From patchwork Tue Sep 10 08:43:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1160089 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="oHpVkJ8G"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46SJWH3DKBz9s7T for ; Tue, 10 Sep 2019 18:44:59 +1000 (AEST) Received: from localhost ([::1]:35554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7blg-0003M4-Po for incoming@patchwork.ozlabs.org; Tue, 10 Sep 2019 04:44:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35767) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7bki-0003KU-L0 for qemu-devel@nongnu.org; Tue, 10 Sep 2019 04:43:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7bkh-0006Hb-FX for qemu-devel@nongnu.org; Tue, 10 Sep 2019 04:43:56 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:44340) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i7bkg-0006GB-15 for qemu-devel@nongnu.org; Tue, 10 Sep 2019 04:43:54 -0400 Received: by mail-wr1-x42a.google.com with SMTP id k6so6224083wrn.11 for ; Tue, 10 Sep 2019 01:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0Lr8Rspy6mGDHTxemrpnhcEpoVqVML2BOuqqGvyKoTM=; b=oHpVkJ8GqujKUnI3zOPCEopU9M4QyGs9+KOQozb2X15VzPZfHfVuSX4Pk4iXddOL3l slD93TBYWvmQT1S/yqMw0c7HSf16XPWZBAUR79GQzerCG+tHWJknRr3Q8C77i8VzIXGZ zvOBaomUWJWBMGhQ0H6uPtT8eirqRln8ouVmVw/MDUlVOS8vKazYp/UL37IxESQbedeF 7Fnas/baBidIL1VdPS8zKd1J2qebFDur1fbLQzu0MsyQ18Bso83tV82yO8xCvqDnmeIY HVve/yCHiB/QBmuuVQl7SYnE2poUkXpBYzBuHdVQXOGMY82wAN5aQ9lDdLfALt6xTCfq y2DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0Lr8Rspy6mGDHTxemrpnhcEpoVqVML2BOuqqGvyKoTM=; b=Idj7aWt5eUNtFVS88L3NUHFTH60+jxPlgrdZwUeByuWYDGxoedc/guFWcnOQzRkog1 WyeN8W5NVC0jdPKFoqKXu105ISwEPdCljF6oBU3d7LtA7L7Ik+w06xtRciBj4yOk+WvA 5hg4DUc0E7aiFkGWfJ2tEE1NRC7Ts3Nt6/MYtxYQdHHvw+ozQsQy8uoCSinh1iIWULre pbbqdVrV1ak8bT9dZyhW7gYWHo/NZr0cgPZ0XPxuW2vsv2WH3E09hrll55jDhGuionbz lmvFJ0XpRQGT6s3ab6CHPxrI1LQRSXELrNfe1PSMmStkclZDokYpryOD177DQUjw30um EIgw== X-Gm-Message-State: APjAAAVE+wCkmezlRF3ZzNiztNO3ajaQcvt+m6M84JDvqXHvhTjd3hyN 1YC94IutRflm2aatXYLVBQWCBQ== X-Google-Smtp-Source: APXvYqxss6LQ31bXri1L1vMxvxM0GR57SU6PPI9rVfuDCBE7x1hhwhQjk6Ea2Ij1cLzL7pl1m+wwAw== X-Received: by 2002:a5d:428c:: with SMTP id k12mr25064614wrq.196.1568105030831; Tue, 10 Sep 2019 01:43:50 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id b144sm2446435wmb.3.2019.09.10.01.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2019 01:43:50 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 9B0B81FF8F; Tue, 10 Sep 2019 09:43:49 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Tue, 10 Sep 2019 09:43:06 +0100 Message-Id: <20190910084349.28817-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190910084349.28817-1-alex.bennee@linaro.org> References: <20190910084349.28817-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42a Subject: [Qemu-devel] [PULL 02/45] configure: clean-up container cross compile detect X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, David Hildenbrand Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The introduction of podman support inadvertently broke configure's detect of the container support as the configure probe didn't specify an engine type. To fix this in docker.py: - only (re)set USE_ENGINE if --engine is specified - enhance the output so docker is no longer just yes In the configure script we can at least start cleaning up the detecting and naming of variables. To avoid too much churn the conversion of the various make DOCKER_foo variables has been left for future clean-ups. Fixes: 9459f754134b Signed-off-by: Alex Bennée Tested-by: David Hildenbrand diff --git a/configure b/configure index 95134c0180b..94845fc5101 100755 --- a/configure +++ b/configure @@ -495,7 +495,7 @@ qed="yes" parallels="yes" sheepdog="yes" libxml2="" -docker="no" +container="no" debug_mutex="no" libpmem="" default_devices="yes" @@ -5894,14 +5894,14 @@ EOF fi ########################################## -# Docker and cross-compiler support +# Container based cross-compiler support # # This is specifically for building test # cases for foreign architectures, not # cross-compiling QEMU itself. -if has "docker"; then - docker=$($python $source_path/tests/docker/docker.py probe) +if has "docker" || has "podman"; then + container=$($python $source_path/tests/docker/docker.py probe) fi ########################################## @@ -6474,7 +6474,7 @@ echo "qed support $qed" echo "parallels support $parallels" echo "sheepdog support $sheepdog" echo "capstone $capstone" -echo "docker $docker" +echo "container support $container" echo "libpmem support $libpmem" echo "libudev $libudev" echo "default devices $default_devices" diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 4bba29e104e..e23209f71ee 100755 --- a/tests/docker/docker.py +++ b/tests/docker/docker.py @@ -536,9 +536,9 @@ class ProbeCommand(SubCommand): try: docker = Docker() if docker._command[0] == "docker": - print("yes") + print("docker") elif docker._command[0] == "sudo": - print("sudo") + print("sudo docker") elif docker._command[0] == "podman": print("podman") except Exception: @@ -651,7 +651,8 @@ def main(): cmd.args(subp) subp.set_defaults(cmdobj=cmd) args, argv = parser.parse_known_args() - USE_ENGINE = args.engine + if args.engine: + USE_ENGINE = args.engine return args.cmdobj.run(args, argv)