From patchwork Mon Aug 26 18:35:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sujay Patwardhan X-Patchwork-Id: 1153397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=eero.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bvMlaAGm"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=eero.com header.i=@eero.com header.b="QaZ8UDU0"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46HLNM6PNFz9s7T for ; Tue, 27 Aug 2019 04:37:55 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Date:Message-Id:Subject:Mime-Version :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=P8qmbS9W31ZdBWAf7Q7NpnaL6TJYll6O/oZpO/faDds=; b=bvMlaAGmBCxfIn nSnbLIUMXO9prH6bfWkeaZcEudo+mldsrScULDnKtodPOoBl+JZA+9TMOa+jqI7dTx7eSUGCngPRy Tk2PjsGGmHrBqE4PhHQjXdd10I/R7EaRIEEeIjCHsSJQDwYVEx03RqO8dq8WPPzvnKbb5oawOSfKa VFiqRyD+Yzwn7XSE/D6fm6CuG3v7DIMvnuWxpeDhFckj92qH7JSWMybUFj8PgRgASKnGynNFp4i6Q B4iHRxPgR3JYb2uxGZ3ZNjwts1kux+8qcvpGG27bNzDqdh+xl4lMm7dVQ29QZ+fBXgAA34RabNTkO tN4T9q6+aP6tw4yj/whg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2JsE-0007IK-I3; Mon, 26 Aug 2019 18:37:50 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2JsA-0007Hv-0m for hostap@lists.infradead.org; Mon, 26 Aug 2019 18:37:47 +0000 Received: by mail-pf1-x441.google.com with SMTP id w16so12340275pfn.7 for ; Mon, 26 Aug 2019 11:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eero.com; s=google; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=o/EINdE+C18uN/ID/CrLzZ/hLFE3RUxuuoahBPXX/gc=; b=QaZ8UDU0g5ir4rzg33tb/0m4CByOZ3KOvtweNQ2jv82m0x1xZtpSH1C0IXXqGryddX WIa2dNWTNUplgBy+hS3S/MjPd3z4hc4eXyREjRJV7VyrPmE6qLl+U2rmSgLT81rUnaIE mSz8SNuMhoOYz0oLMgR2tp42zgAY+gIxXEznA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=o/EINdE+C18uN/ID/CrLzZ/hLFE3RUxuuoahBPXX/gc=; b=rRNjiXoOtyjM/QBASqK0oUXNBKvx1NGY8TYyZrVPFupCInwEeYwVwEqmXhXbD4McI9 qnnql1jTj4V3xDUYcH52azfsCVrjI6Cxp6VLNHsUjDi5nfIR+CHtu6zFhtD3ol42HD4F 9Dh5+6tdyq7vxHf+e4kPZeAapRYxEG+ZJfqr9ccaOqReUVABqU8B9Iu/blSw7G8rtqmW xfAySBBNIKqerv4mKnI1VjB+C9uDMT5R0Pt6jm2JMUQqJeYNtUy+ccLXZ2giOJqOB6Sf eW8aXGSr7tIylX/VupgCsNWnVWDwP3ZTM2iecRIj8i+dKi5HIsYKfNqwvrIy+AxCxlkR EH+Q== X-Gm-Message-State: APjAAAXmu2sQwqS1PsTI8zqTwhsz6mdi2ERkHDtfVqwPO3PsQ2+o3xDJ A+iiWWVbDRewhkYJ0gmmBTMFxT5Ab4M= X-Google-Smtp-Source: APXvYqw3Oyas1a5WPpdtlwxKgEhdrwhNW2Dmtx2RQPWjA2Fqd/zGbAPeMAkMQYcQT3sbTNuXsZULTA== X-Received: by 2002:aa7:8498:: with SMTP id u24mr21977052pfn.61.1566844664613; Mon, 26 Aug 2019 11:37:44 -0700 (PDT) Received: from freeip.amazon.com ([204.246.162.44]) by smtp.gmail.com with ESMTPSA id ev3sm778560pjb.3.2019.08.26.11.37.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Aug 2019 11:37:43 -0700 (PDT) From: Sujay Patwardhan Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [PATCH] wpa_supplicant: Don't return an error when successfully parsing wmm rules Message-Id: <64AA02D3-9F1F-411D-8921-DC99F8D0C393@eero.com> Date: Mon, 26 Aug 2019 11:35:38 -0700 To: hostap@lists.infradead.org X-Mailer: Apple Mail (2.3445.104.11) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190826_113746_066256_7C6D60EB X-CRM114-Status: GOOD ( 10.41 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The config file parser previously would fall through into an error if CONFIG_AP is defined and it hit a wmm_ac_* rule. This commit adds a return to prevent incorrectly printing an error message and returning a non-zero exit code. Signed-off-by: Sujay Patwardhan --- wpa_supplicant/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/wpa_supplicant/config.c b/wpa_supplicant/config.c index 7a62f96..8e94e94 100644 --- a/wpa_supplicant/config.c +++ b/wpa_supplicant/config.c @@ -4987,6 +4987,7 @@ int wpa_config_process_global(struct wpa_config *config, char *pos, int line) "AC item", line); return -1; } + return ret; } #endif /* CONFIG_AP */ if (line < 0)