From patchwork Fri Aug 23 15:18:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vidya Sagar X-Patchwork-Id: 1152265 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.b="Z5hDrRcC"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46FQ5r16ynz9sDQ for ; Sat, 24 Aug 2019 01:18:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405185AbfHWPSj (ORCPT ); Fri, 23 Aug 2019 11:18:39 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:17287 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733205AbfHWPSj (ORCPT ); Fri, 23 Aug 2019 11:18:39 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 23 Aug 2019 08:18:39 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 23 Aug 2019 08:18:37 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 23 Aug 2019 08:18:37 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 23 Aug 2019 15:18:37 +0000 Received: from hqnvemgw02.nvidia.com (172.16.227.111) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 23 Aug 2019 15:18:37 +0000 Received: from vidyas-desktop.nvidia.com (Not Verified[10.24.37.38]) by hqnvemgw02.nvidia.com with Trustwave SEG (v7, 5, 8, 10121) id ; Fri, 23 Aug 2019 08:18:37 -0700 From: Vidya Sagar To: , , , CC: , , , , , , Subject: [PATCH] PCI: tegra: Don't print an error on -EPROBE_DEFER Date: Fri, 23 Aug 2019 20:48:32 +0530 Message-ID: <20190823151832.14427-1-vidyas@nvidia.com> X-Mailer: git-send-email 2.17.1 X-NVConfidentiality: public MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1566573519; bh=klbHIqUG1MOQPk1835oiZcvUqTiR0BpWrtVZRaGnKJE=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=Z5hDrRcC2hLvacpyu+xrgxzOWhU+xST7ZMYONdndHMjtPIKxqWh1EmztmJ1iyrKYs LDQO8swaFCYLBh7wO/tBM91BKLXmMnFPIGXnaTmul10lqwRpSH3KBR6iqQkoVmDBUT s1nlZTjIHUedeoUs3LnU0fnijVfadJaaTvG4ue8rKB00FcOD7pk101nI68/XFkaYC9 vbxXG8UaF0msKy5Rm93+cianCzr0PTtKsmqwoMhRQ8GwUvMw+twgMxzkxEqXPTNkOF rKQUPHOmtgGDYDdG1TNVGotuFGOrgHokzLppQGFQvMwINS0IrIuaM150q8k1WZbfS0 jDmq2xGzLU/CQ== Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org APIs like devm_regulator_get() and devm_phy_get() have the potential to return -EPROBE_DEFER when the respective sub-systems are not ready yet. So avoid printing an error message as .probe() will be tried out again at a later point of time anyway. Signed-off-by: Vidya Sagar --- drivers/pci/controller/dwc/pcie-tegra194.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index fc0dbeb31d78..c730986ed34d 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1368,9 +1368,11 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) pcie->pex_ctl_supply = devm_regulator_get(dev, "vddio-pex-ctl"); if (IS_ERR(pcie->pex_ctl_supply)) { - dev_err(dev, "Failed to get regulator: %ld\n", - PTR_ERR(pcie->pex_ctl_supply)); - return PTR_ERR(pcie->pex_ctl_supply); + ret = PTR_ERR(pcie->pex_ctl_supply); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get regulator: %ld\n", + PTR_ERR(pcie->pex_ctl_supply)); + return ret; } pcie->core_clk = devm_clk_get(dev, "core"); @@ -1412,7 +1414,8 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) kfree(name); if (IS_ERR(phys[i])) { ret = PTR_ERR(phys[i]); - dev_err(dev, "Failed to get PHY: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get PHY: %d\n", ret); return ret; } }