From patchwork Wed Aug 21 15:02:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Hunter X-Patchwork-Id: 1150910 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.b="sLeJloAd"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46D9rc54Tqz9sBF for ; Thu, 22 Aug 2019 01:02:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727464AbfHUPCz (ORCPT ); Wed, 21 Aug 2019 11:02:55 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:18132 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbfHUPCz (ORCPT ); Wed, 21 Aug 2019 11:02:55 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 21 Aug 2019 08:02:54 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 21 Aug 2019 08:02:54 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 21 Aug 2019 08:02:54 -0700 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 21 Aug 2019 15:02:54 +0000 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 21 Aug 2019 15:02:54 +0000 Received: from moonraker.nvidia.com (Not Verified[10.2.160.227]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7, 5, 8, 10121) id ; Wed, 21 Aug 2019 08:02:54 -0700 From: Jon Hunter To: Daniel Lezcano , Thomas Gleixner CC: , , Jon Hunter Subject: [PATCH 1/2] clocksource/drivers/timer-of: Do not warn on deferred probe Date: Wed, 21 Aug 2019 16:02:40 +0100 Message-ID: <20190821150241.31093-1-jonathanh@nvidia.com> X-Mailer: git-send-email 2.17.1 X-NVConfidentiality: public MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1566399774; bh=c+D10e7qyD/v8odq9Z4b64li+E5jzsQQuZpseZjoJdY=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=sLeJloAdyAClgj5ykcwCZWoLQLqSPbEcPcqNvDq1OwNQjyVss1S0cm7SROcWSEjTo Tsi+pPghQVzvD4+nZRBdYVNgcRtTwCiNCEPuyHwQeIH9kg+6/3ruz4bw3GXLQLOkMY /UGmhTXlT6zAR5jBm7cyAo+6UlMSuLLeocMK6zpuXEl2aaCSp2BkIA9t5t2Ydj5iWb 8L3SNk4aBsJJumrHkazf/pWgCyP5iZ+mbHoWGjcGfN53jkMfpvoUVAmBNT2bARtwwv YDfiqJ9xQBIDA37xMfwB5JGqXrZ4oe+8psNtHR1WWWggIv9JEfWmKr62rffo/4jJxg y3If8llHulqDQ== Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Deferred probe is an expected return value for clk_get() on many platforms. The driver deals with it properly, so there's no need to output a warning that may potentially confuse users. Signed-off-by: Jon Hunter --- drivers/clocksource/timer-of.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c index 80542289fae7..d8c2bd4391d0 100644 --- a/drivers/clocksource/timer-of.c +++ b/drivers/clocksource/timer-of.c @@ -113,8 +113,10 @@ static __init int timer_of_clk_init(struct device_node *np, of_clk->clk = of_clk->name ? of_clk_get_by_name(np, of_clk->name) : of_clk_get(np, of_clk->index); if (IS_ERR(of_clk->clk)) { - pr_err("Failed to get clock for %pOF\n", np); - return PTR_ERR(of_clk->clk); + ret = PTR_ERR(of_clk->clk); + if (ret != -EPROBE_DEFER) + pr_err("Failed to get clock for %pOF\n", np); + goto out; } ret = clk_prepare_enable(of_clk->clk); From patchwork Wed Aug 21 15:02:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Hunter X-Patchwork-Id: 1150911 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.b="le8WcKjO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46D9rr46kbz9sBF for ; Thu, 22 Aug 2019 01:03:08 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728804AbfHUPDH (ORCPT ); Wed, 21 Aug 2019 11:03:07 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:16630 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728679AbfHUPDH (ORCPT ); Wed, 21 Aug 2019 11:03:07 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 21 Aug 2019 08:03:07 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 21 Aug 2019 08:03:06 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 21 Aug 2019 08:03:06 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 21 Aug 2019 15:03:06 +0000 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 21 Aug 2019 15:03:06 +0000 Received: from moonraker.nvidia.com (Not Verified[10.2.160.227]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7, 5, 8, 10121) id ; Wed, 21 Aug 2019 08:03:06 -0700 From: Jon Hunter To: Daniel Lezcano , Thomas Gleixner CC: , , Jon Hunter Subject: [PATCH 2/2] clocksource/drivers: Do not warn on probe defer Date: Wed, 21 Aug 2019 16:02:41 +0100 Message-ID: <20190821150241.31093-2-jonathanh@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190821150241.31093-1-jonathanh@nvidia.com> References: <20190821150241.31093-1-jonathanh@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1566399787; bh=p648Wl6F7y32KHJWtTRFzAGWOiC9pGf46QsYBWxiuxs=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:X-NVConfidentiality:MIME-Version: Content-Type; b=le8WcKjOr/xSHdJAiZvm5Jru3NGWJNQwCDULD2ZPRnDQ0Zx0yMPnk5b6uZA3/V5/k u9VN85Z3CFEvS9lyEmcRME3OiY/rkor4HTZHbHh2U2T26Fgxa6z5jr/TgXADQH6S6h MfveZ/qcee960QSQ8u6D8e6+mv88r4CPqH+D8D8/XHofy/LeTHZQ78petCAfkODZv/ rYUJpBbr+aAJ9ygms4zNgs6T85jMV5swpAIIYSD76hhOpbhSNzBsVCzi4FAJ8VQpv5 ZEHqP/Mre5a3F5gNIsKrn0v//tf9ssAyq3rWbx8t/np2Erb37OOWUOhUik2P+c+e6L upgbCw3Mw+bhQ== Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Deferred probe is an expected return value on many platforms and so there's no need to output a warning that may potentially confuse users. Signed-off-by: Jon Hunter --- drivers/clocksource/timer-probe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-probe.c b/drivers/clocksource/timer-probe.c index dda1946e84dd..ee9574da53c0 100644 --- a/drivers/clocksource/timer-probe.c +++ b/drivers/clocksource/timer-probe.c @@ -29,7 +29,9 @@ void __init timer_probe(void) ret = init_func_ret(np); if (ret) { - pr_err("Failed to initialize '%pOF': %d\n", np, ret); + if (ret != -EPROBE_DEFER) + pr_err("Failed to initialize '%pOF': %d\n", np, + ret); continue; }