From patchwork Tue Aug 20 09:51:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1149988 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-507347-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="QXyORo15"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46CR192zXsz9s4Y for ; Tue, 20 Aug 2019 19:52:45 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=aDqyIUhLETmFlQKpsbApyTRBTPePm+Bzzjcd1fXPsKyycaQz/j DVyuhFef1JYhwJ4dCkhitE8HqeTf/bX5dfbYubb1+yT/d+SfYNv5VpBwgVxE/gGg fQAy/onYCIdvfR6DldCoVypCjTrgsop3HsRVpUH2Iy6wZO1GtjGQWfSsY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=/65aPKVcFT0oPymiHijxp8X5bDs=; b=QXyORo1578hKYzVS6+RW Up/uPS1pbUFO0y7n9W2f5pvJUwQ9WGwrXoL5AvgHTbxr7IQeuGgeKmhp6NZYX216 JbceJ2wNoI6eCkpBgihOzmXuR9val5s+YU+/jEi6eQo5VpHDTPt+zVuKtvyvm0zx D1r4BRYSkMKF9LFmgPvMm0E= Received: (qmail 121850 invoked by alias); 20 Aug 2019 09:51:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 121714 invoked by uid 89); 20 Aug 2019 09:51:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=Present X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Aug 2019 09:51:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1B6AF560C3; Tue, 20 Aug 2019 05:51:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ZtwdQVKlxVTn; Tue, 20 Aug 2019 05:51:27 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id 09C0A560BC; Tue, 20 Aug 2019 05:51:27 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4862) id 08E6363E; Tue, 20 Aug 2019 05:51:27 -0400 (EDT) Date: Tue, 20 Aug 2019 05:51:27 -0400 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: Bob Duff Subject: [Ada] Suppress Initialize_Scalars for Persistent_BSS Message-ID: <20190820095126.GA75530@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes If a variable has pragma Persistent_BSS, the compiler now automatically suppresses implicit initializations caused by Initialize_Scalars and Normalize_Scalars. Variables with Persistent_BSS cannot be initialized, and previously a pragma Suppress_Initialization was required before the pragma Persistent_BSS. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-08-20 Bob Duff gcc/ada/ * sem_prag.adb (Persistent_BSS): If an initialization is present because of Initialize_Scalars or Normalize_Scalars, generate an implicit pragma Suppress_Initialization to remove that, because initialization is not allowed for these variables. Other initializations remain illegal. --- gcc/ada/sem_prag.adb +++ gcc/ada/sem_prag.adb @@ -21092,8 +21092,24 @@ package body Sem_Prag is Decl := Parent (Ent); if Present (Expression (Decl)) then - Error_Pragma_Arg - ("object for pragma% cannot have initialization", Arg1); + -- Variables in Persistent_BSS cannot be initialized, so + -- turn off any initialization that might be caused by + -- pragmas Initialize_Scalars or Normalize_Scalars. + + if Kill_Range_Check (Expression (Decl)) then + Prag := + Make_Pragma (Loc, + Name_Suppress_Initialization, + Pragma_Argument_Associations => New_List ( + Make_Pragma_Argument_Association (Loc, + Expression => New_Occurrence_Of (Ent, Loc)))); + Insert_Before (N, Prag); + Analyze (Prag); + + else + Error_Pragma_Arg + ("object for pragma% cannot have initialization", Arg1); + end if; end if; if not Is_Potentially_Persistent_Type (Etype (Ent)) then @@ -21104,7 +21120,7 @@ package body Sem_Prag is Prag := Make_Linker_Section_Pragma - (Ent, Sloc (N), ".persistent.bss"); + (Ent, Loc, ".persistent.bss"); Insert_After (N, Prag); Analyze (Prag);