From patchwork Tue Aug 20 05:38:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amitay Isaacs X-Patchwork-Id: 1149785 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46CKMh3qhwz9sML for ; Tue, 20 Aug 2019 15:38:24 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=ozlabs.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=ozlabs.org header.i=@ozlabs.org header.b="s7hJsNym"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46CKMh2wP7zDqv4 for ; Tue, 20 Aug 2019 15:38:24 +1000 (AEST) X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46CKMc4tmXzDqr5 for ; Tue, 20 Aug 2019 15:38:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=ozlabs.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ozlabs.org header.i=@ozlabs.org header.b="s7hJsNym"; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 46CKMc3J1Wz9sN1; Tue, 20 Aug 2019 15:38:20 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1566279500; bh=Y452deIdX6uMuL8XswSVL565/bw/iOk6j9+getssN7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s7hJsNymeLqjxmm4WEJNGtBB3RzG2IWH207X/mtrx/DaJ4oQUFziZ9RZG+jAHbKkf +YX/OPuhBqePs3cvjSaYx2aImvgSjxXDi47Klp1IMM6WDF0Qi2qyhqVa9psTo3sCUA qIqL7gqHhGWm6htYvJ/tLv01Vtn/C+RUIDz1iMioPKx7mblrpuA4XE5/opOesT+Hj+ OMfWI2ixJ9VVF6b+Z0zcs7BqTpS0CEmUz2aUhXhXqpKy1KhlwoGbrluE1hIo1wmMfM IpoJqe0HGUQOaoBK1wQYqseUQe2L3qnIBTGtvLFgrSwYXJaZBPOKutMgywc7EfPVFK pNEzfExH19DOA== From: Amitay Isaacs To: pdbg@lists.ozlabs.org Date: Tue, 20 Aug 2019 15:38:18 +1000 Message-Id: <20190820053818.18834-2-amitay@ozlabs.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190820053818.18834-1-amitay@ozlabs.org> References: <20190820053818.18834-1-amitay@ozlabs.org> MIME-Version: 1.0 Subject: [Pdbg] [PATCH 1/1] sbefifo: Always use ADU for memory access X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amitay Isaacs Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" Signed-off-by: Amitay Isaacs --- libpdbg/sbefifo.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libpdbg/sbefifo.c b/libpdbg/sbefifo.c index 249f115..a28897f 100644 --- a/libpdbg/sbefifo.c +++ b/libpdbg/sbefifo.c @@ -48,7 +48,7 @@ static int sbefifo_op_getmem(struct sbefifo *sbefifo, uint16_t flags; int rc; - align = ci ? 8 : 128; + align = 8; start_addr = addr & (~(uint64_t)(align-1)); end_addr = (addr + size + (align-1)) & (~(uint64_t)(align-1)); @@ -64,10 +64,9 @@ static int sbefifo_op_getmem(struct sbefifo *sbefifo, PR_NOTICE("sbefifo: getmem addr=0x%016" PRIx64 ", len=%u\n", start_addr, len); + flags = SBEFIFO_MEMORY_FLAG_PROC; if (ci) - flags = SBEFIFO_MEMORY_FLAG_PROC | SBEFIFO_MEMORY_FLAG_CI; - else - flags = SBEFIFO_MEMORY_FLAG_PBA; + flags |= SBEFIFO_MEMORY_FLAG_CI; rc = sbefifo_mem_get(sbefifo->sf_ctx, start_addr, len, flags, &out); @@ -90,7 +89,7 @@ static int sbefifo_op_putmem(struct sbefifo *sbefifo, uint16_t flags; int rc; - align = ci ? 8 : 128; + align = 8; if (addr & (align-1)) { PR_ERROR("sbefifo: Address must be aligned to %d bytes\n", align); @@ -111,10 +110,9 @@ static int sbefifo_op_putmem(struct sbefifo *sbefifo, PR_NOTICE("sbefifo: putmem addr=0x%016"PRIx64", len=%u\n", addr, len); + flags = SBEFIFO_MEMORY_FLAG_PROC; if (ci) - flags = SBEFIFO_MEMORY_FLAG_PROC | SBEFIFO_MEMORY_FLAG_CI; - else - flags = SBEFIFO_MEMORY_FLAG_PBA; + flags |= SBEFIFO_MEMORY_FLAG_CI; rc = sbefifo_mem_put(sbefifo->sf_ctx, addr, data, len, flags);