From patchwork Wed Aug 14 10:29:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos Santos X-Patchwork-Id: 1146934 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pgpvlvzS"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 467m796JLnz9sNC for ; Wed, 14 Aug 2019 20:30:13 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 84FF486432; Wed, 14 Aug 2019 10:30:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zcudGpRwqzNv; Wed, 14 Aug 2019 10:30:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id AD28D863F2; Wed, 14 Aug 2019 10:30:08 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 82A9A1BF30C for ; Wed, 14 Aug 2019 10:30:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 763F721FFB for ; Wed, 14 Aug 2019 10:30:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QQQtnFP8HX0I for ; Wed, 14 Aug 2019 10:30:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by silver.osuosl.org (Postfix) with ESMTPS id 5D8042075B for ; Wed, 14 Aug 2019 10:30:05 +0000 (UTC) Received: by mail-qk1-f179.google.com with SMTP id g17so11387588qkk.8 for ; Wed, 14 Aug 2019 03:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=TxnzY2PNAJCKc2nVVXiRIy4QXu4KWdMBpSH3m9krQZs=; b=pgpvlvzS44AGfRsflZ9tBbRml5UKpl5hKxLyN/F4dPeb+lOefKyboyvuWZm16EkaEe bu6I75T1YKspRTvtgYsxvjSgtc/IN/JFwyQ1xEMQl/KqbF3i2fF6APp5bApaGCc7SDCn +WOpVC52sfEn+1FgWnyjjUD4GoeVGRDEnfT5BW8eCe7W/V0p5HwHsQoEL+lo+kTRAC3V lZx7iTq4FG5ZfVvBJjuEktDiwHJVMn5xJuJKh4GGP6NrK0b1i9Vb+hCRm+XPPOCfzK/k S3yZU54W8zDVJK+g+Ld2qKiGaMDG+srHhtOBwVH0MXWVSYZOMxgUKuVa3YPsz+7gzOgV cbqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TxnzY2PNAJCKc2nVVXiRIy4QXu4KWdMBpSH3m9krQZs=; b=Dc7i1eFYrAKAv6UCgj47PQWgwwcT3qqgmD6Ye0fpPpjNOHe+Bzn3Za+48y+2JQGZT0 +plwPOAD52eoCNQ09xnECqD7jkI2Jp1A8YqWYAFgZfQfRau74NERdJXfNH2FS4k3xmdy R/WTOZy3zKsI4naXAaH/PJ16ypEKETFP5RJ9lNN/YFKILgXJ70wlS2GJaOjBlCEBdu1U 3L/5CF6BbWRpge+HIFyd8D8zxG00gTZSOCj/CL9OB86qKxhJWz6UXlBFIVx2H71vB2J8 NHnlKXMz5xlGaBdyLJODsbU65uempl3Y2un99Cqt3WA1kWhnMgZtJZASBjwn9IfP3Sj+ tjlg== X-Gm-Message-State: APjAAAVT9M8cifOyqmFWqTvnKj+9u8ENMFs/AkixR/CGLOoWPcxydqve iaijQ/y34A7Vshx4tpGU6+YLSQDbyCY= X-Google-Smtp-Source: APXvYqyVMX1ARs6op2ey3L1urqwI9aw2SheyAUBQ8RoRa/mbu20j4bXm7EDftmnAp2jY1yBKswK+Cw== X-Received: by 2002:a37:bcc:: with SMTP id 195mr24502751qkl.115.1565778604030; Wed, 14 Aug 2019 03:30:04 -0700 (PDT) Received: from casantos.remote.csb (177.204.146.241.dynamic.adsl.gvt.net.br. [177.204.146.241]) by smtp.gmail.com with ESMTPSA id 136sm9515317qkg.96.2019.08.14.03.30.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 14 Aug 2019 03:30:03 -0700 (PDT) From: unixmania@gmail.com To: buildroot@buildroot.org Date: Wed, 14 Aug 2019 07:29:57 -0300 Message-Id: <20190814102957.23544-1-unixmania@gmail.com> X-Mailer: git-send-email 2.18.1 Subject: [Buildroot] [PATCH v2] package/devmem2: remove package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Carlos Santos , Ciro Santilli , Thomas Petazzoni MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Carlos Santos It was here just for backwards compatibility and is not used by any package or board after commits 59856480b6 packages/devmem2: remove from all board configurations 2f6e3eae55 package/ti-gfx: do not use devmem2 in script There are address casting issues with 32bit access on a 64bit bus (like on the SoC FPGA ARM processors) with this tool. The Busybox version of devmem is the most up to date and supports quadword access. Fixes: https://bugs.busybox.net/show_bug.cgi?id=10171 Signed-off-by: Carlos Santos --- CC: Ciro Santilli CC: Matt Weber CC: Thomas Petazzoni --- Changes v1->v2: removed spurious "address" from commit message --- Config.in.legacy | 7 +++ .../0001-be-coherent-in-type-usage.patch | 52 ------------------- package/devmem2/Config.in | 7 --- package/devmem2/devmem2.hash | 3 -- package/devmem2/devmem2.mk | 30 ----------- 5 files changed, 7 insertions(+), 92 deletions(-) delete mode 100644 package/devmem2/0001-be-coherent-in-type-usage.patch delete mode 100644 package/devmem2/Config.in delete mode 100644 package/devmem2/devmem2.hash delete mode 100644 package/devmem2/devmem2.mk diff --git a/Config.in.legacy b/Config.in.legacy index 190b98f5a5..741dd35e36 100644 --- a/Config.in.legacy +++ b/Config.in.legacy @@ -146,6 +146,13 @@ endif comment "Legacy options removed in 2019.08" +config BR2_PACKAGE_DEVMEM2 + bool "devmem2 package was removed" + select BR2_LEGACY + help + Use the the Busybox devmem utility, instead, which provides + the same functionality. + config BR2_PACKAGE_LIBAMCODEC bool "liamcodec package was removed" select BR2_LEGACY diff --git a/package/devmem2/0001-be-coherent-in-type-usage.patch b/package/devmem2/0001-be-coherent-in-type-usage.patch deleted file mode 100644 index 1777387734..0000000000 --- a/package/devmem2/0001-be-coherent-in-type-usage.patch +++ /dev/null @@ -1,52 +0,0 @@ -From 6570e7afe1eebd64022b871b9ebd9a76be267f57 Mon Sep 17 00:00:00 2001 -From: Thomas Petazzoni -Date: Sun, 29 Jun 2014 16:27:49 +0200 -Subject: [PATCH] Be coherent in type usage - -- no need to use off_t because it is read from strtoul() -- print unsigned int type correctly - -When built with _FILE_OFFSET_BITS=64, off_t becomes an long long int -and was printed as an unsigned int which lead to a garbled output. - -Signed-off-by: Colin Didier -Signed-off-by: Thomas Petazzoni ---- - devmem2.c | 7 +++---- - 1 file changed, 3 insertions(+), 4 deletions(-) - -diff --git a/devmem2.c b/devmem2.c -index 7732ecb..7aa5c79 100644 ---- a/devmem2.c -+++ b/devmem2.c -@@ -58,8 +58,7 @@ - int main(int argc, char **argv) { - int fd; - void *map_base, *virt_addr; -- unsigned long read_result, writeval; -- off_t target; -+ unsigned long target, read_result, writeval; - int access_type = 'w'; - - if(argc < 2) { -@@ -101,7 +100,7 @@ int main(int argc, char **argv) { - fprintf(stderr, "Illegal data type '%c'.\n", access_type); - exit(2); - } -- printf("Value at address 0x%X (%p): 0x%X\n", target, virt_addr, read_result); -+ printf("Value at address 0x%lX (%p): 0x%X\n", target, virt_addr, read_result); - fflush(stdout); - - if(argc > 3) { -@@ -120,7 +119,7 @@ int main(int argc, char **argv) { - read_result = *((unsigned long *) virt_addr); - break; - } -- printf("Written 0x%X; readback 0x%X\n", writeval, read_result); -+ printf("Written 0x%lX; readback 0x%X\n", writeval, read_result); - fflush(stdout); - } - --- -2.0.0 - diff --git a/package/devmem2/Config.in b/package/devmem2/Config.in deleted file mode 100644 index 1ccb0553b4..0000000000 --- a/package/devmem2/Config.in +++ /dev/null @@ -1,7 +0,0 @@ -config BR2_PACKAGE_DEVMEM2 - bool "devmem2" - depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS - help - Simple program to read/write from/to any location in memory. - - http://bootlin.com/pub/mirror/devmem2.c diff --git a/package/devmem2/devmem2.hash b/package/devmem2/devmem2.hash deleted file mode 100644 index aa638d631d..0000000000 --- a/package/devmem2/devmem2.hash +++ /dev/null @@ -1,3 +0,0 @@ -# Locally calculated -sha256 3b15515693bae1ebd14d914e46d388edfec2175829ea1576a7a0c8606ebbe639 devmem2.c -sha256 560913d09310d446920c16bd0aca1ff21d3b6fedd527195bacfc832ce343e0ae devmem2.c.license diff --git a/package/devmem2/devmem2.mk b/package/devmem2/devmem2.mk deleted file mode 100644 index e1bbee3b78..0000000000 --- a/package/devmem2/devmem2.mk +++ /dev/null @@ -1,30 +0,0 @@ -################################################################################ -# -# devmem2 -# -################################################################################ - -DEVMEM2_SITE = http://bootlin.com/pub/mirror -DEVMEM2_SOURCE = devmem2.c -DEVMEM2_VERSION = 1 -DEVMEM2_LICENSE = GPL-2.0+ -DEVMEM2_LICENSE_FILES = devmem2.c.license - -define DEVMEM2_EXTRACT_CMDS - cp $(DEVMEM2_DL_DIR)/$($(PKG)_SOURCE) $(@D)/ -endef - -define DEVMEM2_EXTRACT_LICENSE - head -n 38 $(@D)/devmem2.c >$(@D)/devmem2.c.license -endef -DEVMEM2_PRE_PATCH_HOOKS += DEVMEM2_EXTRACT_LICENSE - -define DEVMEM2_BUILD_CMDS - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) devmem2 -endef - -define DEVMEM2_INSTALL_TARGET_CMDS - $(INSTALL) -D $(@D)/devmem2 $(TARGET_DIR)/sbin/devmem2 -endef - -$(eval $(generic-package))