From patchwork Tue Nov 7 19:32:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Girish Moodalbail X-Patchwork-Id: 835445 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yWgDK1X4hz9s7C for ; Wed, 8 Nov 2017 06:56:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755044AbdKGT4b (ORCPT ); Tue, 7 Nov 2017 14:56:31 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:36019 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753069AbdKGT4a (ORCPT ); Tue, 7 Nov 2017 14:56:30 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vA7JuOgh026511 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Nov 2017 19:56:25 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vA7JuOLj012390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Nov 2017 19:56:24 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vA7JuOLM021523; Tue, 7 Nov 2017 19:56:24 GMT Received: from openstack-x52-11.us.oracle.com (/10.134.13.80) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 07 Nov 2017 11:56:23 -0800 From: Girish Moodalbail To: netdev@vger.kernel.org, davem@davemloft.net Subject: [PATCH net] net: fix incorrect comment with regard to VLAN packet handling Date: Tue, 7 Nov 2017 11:32:11 -0800 Message-Id: <1510083131-3600-1-git-send-email-girish.moodalbail@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The commit bcc6d4790361 ("net: vlan: make non-hw-accel rx path similar to hw-accel") unified accel and non-accel path for VLAN RX. With that fix we do not register any packet_type handler for VLANs anymore, so fix the incorrect comment. Signed-off-by: Girish Moodalbail --- include/linux/netdevice.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 2eaac7d..7098978 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -4411,15 +4411,7 @@ void netdev_printk(const char *level, const struct net_device *dev, * Why 16. Because with 16 the only overlap we get on a hash of the * low nibble of the protocol value is RARP/SNAP/X.25. * - * NOTE: That is no longer true with the addition of VLAN tags. Not - * sure which should go first, but I bet it won't make much - * difference if we are running VLANs. The good news is that - * this protocol won't be in the list unless compiled in, so - * the average user (w/out VLANs) will not be adversely affected. - * --BLG - * * 0800 IP - * 8100 802.1Q VLAN * 0001 802.3 * 0002 AX.25 * 0004 802.2