From patchwork Mon Aug 5 08:01:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 1142032 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="jUah69i7"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4629Fx6K4Qz9s3Z for ; Mon, 5 Aug 2019 18:01:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726829AbfHEIBk (ORCPT ); Mon, 5 Aug 2019 04:01:40 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:51307 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbfHEIBk (ORCPT ); Mon, 5 Aug 2019 04:01:40 -0400 Received: by mail-wm1-f66.google.com with SMTP id 207so73772337wma.1 for ; Mon, 05 Aug 2019 01:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tLTq55G+8HM5id3F6PTEq7vm1jOe6eDLF+mAtsGbVn8=; b=jUah69i7szH9MKt+wlpPATO2iSXZ8TY9Lni/PdErU9oRBj16CWbb2Hcc8dFA+lsVnm 0vPAzyA+Be5IGDrm4OpHBclDlR63C7kCBHTbJKTRIyczD/fCy6dFghz0Mpy+AWtyqCea NuC2WPuSpWdKr5kBVrhMjaiC2GdIquMK80fTt9RsyFClJKRnMVlW5Ip5u2v6ja+Zr8QA RO1yt4R83HSadVKjgugvYk2ekup3v4AQE8zhYrwZKtLIlFsopzm1BSUXhSek/Njz2Q25 9JkydhRqiXn1bMRwtjwvDZF/f4dBRq7PkzstRsmDoQs9hxENbdJl8sfTq9tNs6kGF3JH AbrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tLTq55G+8HM5id3F6PTEq7vm1jOe6eDLF+mAtsGbVn8=; b=IAtlUQxN3WGQulRBN7nTdZmMww7zKYhQkAMRkbNKiOTmro2olrakKd6rYoINbeYTzK YHDAF7eU8w3qxykPaAfj0dnLzzRiBb+FHY1npU9y9xlvajXobkPYy9UBUqfYFZGERE5M V8zQ+B7IHMPLPlW2A8QTEhCmdcIxxFs6XOyecFWd50KDk3tyG1o2jW6I5jIFwOxHRjPM j2E0WKPg+CuCS5UXEPzIKDEPF2+mPOHGhTEvDa0HUNGXPIIY1S1dNYBwm6rmuCjwE4TF 5HznArU7FYdtNu81YG3OLpFhAe6fIwk3IzzMOz4ivMCpL4+fgjW0EqWTEWDdrOIKfygy 7wFA== X-Gm-Message-State: APjAAAU5dwJamM9s9forAPYsAHPHF745UuUAq5tfKvi2HMcNKdOI8Gi6 1EVMpWGwjeMsSVgpCTcLXN8Hxw== X-Google-Smtp-Source: APXvYqw4mn9gu4bHlXL9JlRLmR/VRheqqFndxlo7p//U5SPq5PS12svDIp3Sp3aF3WqL0pRMF7kSaQ== X-Received: by 2002:a1c:acc8:: with SMTP id v191mr17726531wme.177.1564992098303; Mon, 05 Aug 2019 01:01:38 -0700 (PDT) Received: from localhost.localdomain (amontpellier-652-1-281-69.w109-210.abo.wanadoo.fr. [109.210.96.69]) by smtp.gmail.com with ESMTPSA id o26sm177570979wro.53.2019.08.05.01.01.37 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 05 Aug 2019 01:01:37 -0700 (PDT) From: Bartosz Golaszewski To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, linux-i2c@vger.kernel.org, Jean Delvare , Andrew Lunn , Srinivas Kandagatla , Bartosz Golaszewski , Arnd Bergmann , Bartosz Golaszewski Subject: [PATCH][v4.9.y, v4.14.y] eeprom: at24: make spd world-readable again Date: Mon, 5 Aug 2019 10:01:25 +0200 Message-Id: <20190805080125.20943-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org From: Jean Delvare The integration of the at24 driver into the nvmem framework broke the world-readability of spd EEPROMs. Fix it. Signed-off-by: Jean Delvare Cc: stable@vger.kernel.org Fixes: 57d155506dd5 ("eeprom: at24: extend driver to plug into the NVMEM framework") Cc: Andrew Lunn Cc: Srinivas Kandagatla Cc: Greg Kroah-Hartman Cc: Bartosz Golaszewski Cc: Arnd Bergmann [Bartosz: backported the patch to older branches] Signed-off-by: Bartosz Golaszewski --- drivers/misc/eeprom/at24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index a37b9b6a315a..2eef811764ad 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -777,7 +777,7 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id) at24->nvmem_config.name = dev_name(&client->dev); at24->nvmem_config.dev = &client->dev; at24->nvmem_config.read_only = !writable; - at24->nvmem_config.root_only = true; + at24->nvmem_config.root_only = !(chip.flags & AT24_FLAG_IRUGO); at24->nvmem_config.owner = THIS_MODULE; at24->nvmem_config.compat = true; at24->nvmem_config.base_dev = &client->dev;