From patchwork Tue Jul 30 21:38:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Vorel X-Patchwork-Id: 1139389 X-Patchwork-Delegate: yann.morin.1998@free.fr Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HFfWkXri"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45yqgv0LbDz9s3l for ; Wed, 31 Jul 2019 07:39:06 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7D4C785C95; Tue, 30 Jul 2019 21:39:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D3kZ9Rn2bl4D; Tue, 30 Jul 2019 21:39:02 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id A2FC485BC2; Tue, 30 Jul 2019 21:39:02 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 1AA3C1BF3EE for ; Tue, 30 Jul 2019 21:39:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 15D0085BC2 for ; Tue, 30 Jul 2019 21:39:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WLSrGwPSrgSh for ; Tue, 30 Jul 2019 21:38:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 969BD855BE for ; Tue, 30 Jul 2019 21:38:59 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id k8so63794019edr.11 for ; Tue, 30 Jul 2019 14:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=X4yIBb0DBsVLUSbLskeZo2dK+9cGth5qIEpDKwOiC/o=; b=HFfWkXriOsGan25nqaX/3j9SZVVonzHemU0yWY0JvPPpVCbIrk4fJ4vYChK8j5/M1h QLRdnEkXmm/Z8xwxHtTeTHbxxDkPm1TPmKbHKTag7WlmrGSRHrb9/PEUiM+9oVeq3eqW tbPfSi0HrYJRRBS/JSnJ74jrBoPDYvYs8MXcXLOXEyQumCy6TuipwRiSyuWZXszDYz8s n3b8U8/FJ0FUyDXGbELxqzj+JRO2OSuK9N1HW70dwuoy2/byVgVtkCxVqqiffHsJuNJ1 Mlj5uXWJsivr1aznfFM1H+n4Xc3A8bdeeu6URPvHsmnCLjFuTcMYC1nL5Txx131Nqywo ECkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=X4yIBb0DBsVLUSbLskeZo2dK+9cGth5qIEpDKwOiC/o=; b=EnT2VQJfO84cWZg3zMicUtu48kb12kGnnGLG01Ry9g/R4YcIKO6d311CAzJGvZjF0r PcP5HG05Axr4VX2o/fEEWPuCrDvJBlnNjVvQcrVa9m5djJRt8GRINg2kmJXzhDkLpuel kauCJe5CVOOujRAA33BhLvk1+Rz9CzyFrZUV3MB9cp0ldBiuA6Y7QrS1YyOfP2lzlA1K 2j3aFKwesYubOo+2DSPYFP23M7vkJb/F6NtKxiqWOMeX1+WN3E7+kb07HN46Es8BQqLr enjjVRN8UgZHkrrdYJ7Trvn0kL5LeTNZ9ZjBOgYduq1B8bNKle0CfP+A+6lZkTde9tN5 LP1Q== X-Gm-Message-State: APjAAAUFYbT0N0scVd/YnsCPQxD0FBOwK9mMsr5qmHdPBm1pU+T9RmDU UtbG1d/L746DMpk4s12lip8Wut+J2f0= X-Google-Smtp-Source: APXvYqx6FoOvCDK5bHy7pm/LQvc2VVebZzvuk2uAWUAaXnbzbJbCHRrznn6Wrsp/Qkr1CO9/ZsErYg== X-Received: by 2002:a17:907:2114:: with SMTP id qn20mr91655128ejb.138.1564522737776; Tue, 30 Jul 2019 14:38:57 -0700 (PDT) Received: from dell5510.arch.suse.de ([62.201.25.198]) by smtp.gmail.com with ESMTPSA id f21sm16459527edj.36.2019.07.30.14.38.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 14:38:57 -0700 (PDT) From: Petr Vorel To: buildroot@buildroot.org Date: Tue, 30 Jul 2019 23:38:45 +0200 Message-Id: <20190730213846.7488-1-petr.vorel@gmail.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Subject: [Buildroot] [RFC PATCH v4 1/2] makedevs: only warn when xattr support disabled X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Korsgaard , "Yann E . MORIN" , Thomas Petazzoni Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Previously makedevs failed when xattr configuration defined while disabled BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES. Thus check for this configuration would be required in each use in packages. Changing makedevs to only print warning with number of ignored lines, so package configuration don't have to deal with BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES. No package is using this feature so far (it's used only in tests), thus no need to change any package config. Signed-off-by: Petr Vorel --- Changes v3->v4 (Addressed Yann's issues): * s/discharged/ignored/ * exit with EXIT_SUCCESS (no need to abort fakeroot script just due ignored xattr lines) package/makedevs/makedevs.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/package/makedevs/makedevs.c b/package/makedevs/makedevs.c index c57b964f5c..dbe5b13714 100644 --- a/package/makedevs/makedevs.c +++ b/package/makedevs/makedevs.c @@ -493,6 +493,7 @@ int main(int argc, char **argv) printf("table=\n"); } + unsigned int xattr_warned = 0; while ((line = bb_get_chomped_line_from_file(table))) { char type; unsigned int mode = 0755; @@ -518,9 +519,7 @@ int main(int argc, char **argv) if (bb_set_xattr(full_name, xattr) < 0) bb_error_msg_and_die("can't set cap %s on file %s\n", xattr, full_name); #else - bb_error_msg_and_die("line %d not supported: '%s'\nDid you forget to enable " - "BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES?\n", - linenum, line); + xattr_warned++; #endif /* EXTENDED_ATTRIBUTES */ continue; } @@ -641,6 +640,13 @@ int main(int argc, char **argv) loop: free(line); } + + if (xattr_warned) + bb_error_msg("%u lines with xattr configuration ignored, enable " + "BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES " + "to get xattr support\n", + xattr_warned); + fclose(table); return ret; From patchwork Tue Jul 30 21:38:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Vorel X-Patchwork-Id: 1139390 X-Patchwork-Delegate: yann.morin.1998@free.fr Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZlOiToTt"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45yqgx2MqCz9s3l for ; Wed, 31 Jul 2019 07:39:09 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5D28A85BC2; Tue, 30 Jul 2019 21:39:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XznLwbpPXQdH; Tue, 30 Jul 2019 21:39:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id D522885C1D; Tue, 30 Jul 2019 21:39:06 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 6A0411BF3EE for ; Tue, 30 Jul 2019 21:39:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 64D7785C1D for ; Tue, 30 Jul 2019 21:39:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a4QFXjZg6iRG for ; Tue, 30 Jul 2019 21:39:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by fraxinus.osuosl.org (Postfix) with ESMTPS id B302D85BC2 for ; Tue, 30 Jul 2019 21:39:04 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id e3so63845269edr.10 for ; Tue, 30 Jul 2019 14:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HjWgYm6Z6xzmsK/wBaR1Dv7uaOOzB4zgxTHIE7LSwLg=; b=ZlOiToTtK3A+gDHE4T1+AGLQ0jhPwdsprOYKofi41SVrPFc8b2cudBidgeJW8T0w8t L8A/jN+irBDouuLiizLO0UTFzZ9j+73d1kMuDBbAFayY3TNaPaM+eq30ALxgpwcHEn4O HnqNXNKhXwbsxizuHLdbcd9xpuxxhyR4/j1hSDOhMrKTY7w8HNK8Vj+YLBqXrdcRDszR 6rwp713GtQXtfo2/knTilLVJXrCHE9wHpvQXBgT1wabIag7Z0bNdFLS2NjBvNyA7KQbe JbIAaqj1b3yT4Lrqp1k005XXn/5m8jrW5yHp0zCUCK7gqNH5FDgWq1Ndey8b+lNONHnj j3Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HjWgYm6Z6xzmsK/wBaR1Dv7uaOOzB4zgxTHIE7LSwLg=; b=EPJaorR485wyKiOsdl6Q+izst7g7gZSHy1inaabLPFVHc50dLjlITAX0FM4VAKE++1 7Wq71ZO+16z4YvvFxYYp17oGWMh0tIAoFMYV7AUVacDxSRQUh5dEHIPYFQyLsOCNEHMV PCYbhGzF6NNReMEndIHqi98eL2Mqn5Z8ljDji45Nrqaai84M7qy0ensIrSvIMb8NSgk2 jtNfIJLgcmToflowockiTsOgVA1VTrSSA8fjfyp5j2oTCpmPjtukLcQoSIDzYy2+n/S+ S6juLT5J205AIe4BJmgHeEZZo0yyiJm6NcKMD7SVSc+qaqOKVJyoPWjwB8Zmqnc+ZJsT Ya/g== X-Gm-Message-State: APjAAAV6TWOgyq76xMVbCyQ+fUnbulaJ/SxUCT4NcxQs2tlqJz6spJeK 7TRxMkGxdBJZlpRvTjGMB5b5c52txyE= X-Google-Smtp-Source: APXvYqxwJ97BN5lBm/Tpxdol3wsCQm/Z6YdJ0KXrEyfMq+TsdrVGKwHkTooDm7HCH0CGjqaEuKdIQQ== X-Received: by 2002:a05:6402:6cb:: with SMTP id n11mr103999330edy.101.1564522742928; Tue, 30 Jul 2019 14:39:02 -0700 (PDT) Received: from dell5510.arch.suse.de ([62.201.25.198]) by smtp.gmail.com with ESMTPSA id f21sm16459527edj.36.2019.07.30.14.39.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 14:39:02 -0700 (PDT) From: Petr Vorel To: buildroot@buildroot.org Date: Tue, 30 Jul 2019 23:38:46 +0200 Message-Id: <20190730213846.7488-2-petr.vorel@gmail.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190730213846.7488-1-petr.vorel@gmail.com> References: <20190730213846.7488-1-petr.vorel@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [RFC PATCH v4 2/2] iputils: add capability for clockdiff, ping, traceroute6 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Korsgaard , "Yann E . MORIN" , Thomas Petazzoni Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Not setting for arping as it can be used for ARP Poisoning. Use cap_net_raw+p (drop +e) as upstream sets that via cap_set_flag(), see https://github.com/iputils/iputils/issues/194 Signed-off-by: Petr Vorel --- package/iputils/iputils.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/iputils/iputils.mk b/package/iputils/iputils.mk index 8e6a3e2fc5..f1d3e1fc6a 100644 --- a/package/iputils/iputils.mk +++ b/package/iputils/iputils.mk @@ -76,8 +76,11 @@ IPUTILS_CONF_OPTS += -DNO_SETCAP_OR_SUID=true define IPUTILS_PERMISSIONS /usr/sbin/arping f 4755 0 0 - - - - - /usr/bin/clockdiff f 4755 0 0 - - - - - + |xattr cap_net_raw+p /bin/ping f 4755 0 0 - - - - - + |xattr cap_net_raw+p /usr/bin/traceroute6 f 4755 0 0 - - - - - + |xattr cap_net_raw+p endef $(eval $(meson-package))