From patchwork Tue Jul 30 16:18:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 1139062 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-505856-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="VMaUGTma"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="XQ+4hxZu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="XQ+4hxZu"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45yhZx6X4bz9s8m for ; Wed, 31 Jul 2019 02:19:19 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; q=dns; s=default; b=Gdn /az6jYOQcBCCp82/u47avD8DNNMnMl+Xo1jlGhow+GHhQkAqGHtQRHmBiaEVXO/b Ske8pJAjT+KB9LF7kLk+6M3tKj0LJHlGHOSi7/S9xMB1aLmkdhQHJHPFbAP0WaA7 y6XXeZ2EqFGZfVyYMdLV/pMOIVICU7HT/nhVPsOk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; s=default; bh=ZflU/LTdB Qki4PSpic0fPxS0kxk=; b=VMaUGTmaPBAPINyrK/oasiuOq7zXTVrLZCVHehM37 NDmDhviuxq4cyFh6eum1lDaNtZoU7EJ7+vmQbqpP0+3pq0J04cQJ9f7+b5r0K/Ke BQAvLgGw3saZq/xmHsalUnxlZw+oazPtOfdfUYKXJTmTFVleiv0IjRV+itOSWWzs UI= Received: (qmail 102588 invoked by alias); 30 Jul 2019 16:19:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 102580 invoked by uid 89); 30 Jul 2019 16:19:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40051.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jul 2019 16:19:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LekJACL5VPzwpY8hG+9FdSlgPRv6OIAUvzTijiLRG94=; b=XQ+4hxZulMq471eNtyKTkFdY0bIOOyP6UNK/k+ANkXhamwUv2Ye3NVsw+Fjp9uRp7zkUiWRGrgmdJQqcU6gcq2Yr1Pi5uaxDlkOOwGxrpumB+jAxij8CVP1EfFg/2ygLVhkkpNvBaMNPUkAsaRhpIKNupUD4NwIeg6D1fuUImRs= Received: from DB6PR0802CA0045.eurprd08.prod.outlook.com (2603:10a6:4:a3::31) by VI1PR0801MB1853.eurprd08.prod.outlook.com (2603:10a6:800:5a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Tue, 30 Jul 2019 16:19:03 +0000 Received: from DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::207) by DB6PR0802CA0045.outlook.office365.com (2603:10a6:4:a3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2115.15 via Frontend Transport; Tue, 30 Jul 2019 16:19:03 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; gcc.gnu.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT061.mail.protection.outlook.com (10.152.21.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Tue, 30 Jul 2019 16:19:02 +0000 Received: ("Tessian outbound a1fd2c3cfdb0:v26"); Tue, 30 Jul 2019 16:19:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1af7d69ab6382551 X-CR-MTA-TID: 64aa7808 Received: from 81f1dd930566.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.4.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id D08448A0-4E1C-4AAB-A39B-26CE26854D0D.1; Tue, 30 Jul 2019 16:18:57 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 81f1dd930566.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 30 Jul 2019 16:18:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d2l7WNU+Suivw8tY4iAn8D561CHrZERewdmGJYMYx92wruHtC4bnw+cdVG1O1/7O4J7HicwYPgrhnhGhjeZ3Z2BakguR0zq5KzVcTOg9ZwL1FN5ooeZ72qhEjbh1aiVCrboFI4oil36pq8MQV3H9AeOcjVr5ZfB5AwQLQ3Mg5WockMAKIap1P9fzCz5eZKcKEk5l7XvcEERob7D4ofedMTaeo6IRuOz8Zn80COaQF1kD8o1zK/XwHk5/sQuIC/Jx1KahQprB+V9NwodrczQkNQJ/UinWrtrpSjd/H+PAbcCnZdDNDu3o5CSFqqm8JUWkTXpgmK3imyUbqLGJbLNvnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LekJACL5VPzwpY8hG+9FdSlgPRv6OIAUvzTijiLRG94=; b=nqA9otRKcCJxqVLkncNY/JamyLMNsyPFY++4qDrvghiIuhC+B2dT24bvxiN44nihRZSO0BySo1ax5siaqcwyUZmV3+5kFvFcoVCav+zk4HCL2KEBlm7DaH9i/WsYqioW3LvXc2ge0OORgw3xHeG98BEWisks6/8O4cGwywY1E9J15AzvuBOGMCvbPKX3ip5n4FxrRKkxG0ZpZNB++gMgbbkAnjP/faaY04gv/l75UIGPERNYU8DpRSGJ74y4V1aU5vsWqIGx5WgojNleLJztGNPik/sAJOyjREkFgrcYXEKFtve7rXAsSoFjUQY2U/sjVvzV4MhYD8W0l4458QAHHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LekJACL5VPzwpY8hG+9FdSlgPRv6OIAUvzTijiLRG94=; b=XQ+4hxZulMq471eNtyKTkFdY0bIOOyP6UNK/k+ANkXhamwUv2Ye3NVsw+Fjp9uRp7zkUiWRGrgmdJQqcU6gcq2Yr1Pi5uaxDlkOOwGxrpumB+jAxij8CVP1EfFg/2ygLVhkkpNvBaMNPUkAsaRhpIKNupUD4NwIeg6D1fuUImRs= Received: from VI1PR0801MB2127.eurprd08.prod.outlook.com (10.168.62.22) by VI1PR0801MB1966.eurprd08.prod.outlook.com (10.173.71.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.12; Tue, 30 Jul 2019 16:18:56 +0000 Received: from VI1PR0801MB2127.eurprd08.prod.outlook.com ([fe80::c048:47c4:9d:a454]) by VI1PR0801MB2127.eurprd08.prod.outlook.com ([fe80::c048:47c4:9d:a454%9]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 16:18:56 +0000 From: Wilco Dijkstra To: GCC Patches CC: nd Subject: [COMMITTED][ARM] Adjust literal pool offset in Thumb-2 movsi patterns Date: Tue, 30 Jul 2019 16:18:55 +0000 Message-ID: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR0801MB1966; X-MS-Exchange-PUrlCount: 1 x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(54534003)(199004)(189003)(66556008)(966005)(4326008)(316002)(14454004)(81166006)(8676002)(81156014)(53936002)(256004)(6916009)(2906002)(86362001)(68736007)(305945005)(7736002)(476003)(25786009)(478600001)(64756008)(55016002)(6506007)(71190400001)(66476007)(6436002)(102836004)(8936002)(66066001)(6306002)(9686003)(486006)(71200400001)(74316002)(66946007)(186003)(7696005)(76116006)(52536014)(26005)(3846002)(99286004)(66446008)(33656002)(6116002)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0801MB1966; H:VI1PR0801MB2127.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: aeXV/9+pksZWHRBrbTOrJbnR0ECmbQ/iDHqWSeYs01B3D8oilvTgEH3sOMzqN2WBBUKgpEV+DeiohPoYtBA+CgzQDgSXQbmC9PduyyKFMCWO+7MfnzJejE50MqURuRLodDTJ7bDMLPzCk+A1RKBwRmxoS2MUlNmRVZNUbPLdQr8j6tSI5Ulfp6+Q120SoLlOeCuRXdetkkmzri0N31rNwhBVo4ob4q+vYciLeKfnBK/jmy2/+1IMYjIEU6wcSGmdWpBDlcOmQRa1jHLa6mtpbrH6Y4KDhuryWf/mJwa6ykzmI1gug7asaPcZcXSqiNySrpK+se0klZjAGSnc5HXjyqBajpsjHAcylMmA79UCs4/gmuN5NG1yBeKLJw1h5dV7nGlPq6Ru+ExwMvGpLerV01nCEy+HUpvnxffYl2VkDPc= MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: fe45e082-9422-46ac-92a9-08d715099ef3 My previous change to the Thumb-2 movsi patterns [1] caused a codesize regression with -Os in large functions. Fix this by using the literal pool offset of the 16-bit literal load so that the literal pool is dumped earlier, reducing the number of 32-bit literal loads. Bootstrap & regress OK on arm-none-linux-gnueabihf --with-cpu=cortex-a57, committed as obvious. [1] https://gcc.gnu.org/ml/gcc-patches/2019-07/msg01579.html ChangeLog: 2019-07-30 Wilco Dijkstra * config/arm/thumb2.md (thumb2_movsi_insn): Adjust literal offset. * config/arm/vfp.md (thumb2_movsi_vfp): Likewise. diff --git a/gcc/config/arm/thumb2.md b/gcc/config/arm/thumb2.md index c124838c3a536244909223bd18735427cef7d969..6ccc875e2b4e7b8ce256e52da966dfe220c6f5d6 100644 --- a/gcc/config/arm/thumb2.md +++ b/gcc/config/arm/thumb2.md @@ -274,7 +274,7 @@ (define_insn "*thumb2_movsi_insn" (set_attr "length" "2,4,2,4,4,4,4") (set_attr "predicable" "yes") (set_attr "predicable_short_it" "yes,no,yes,no,no,no,no") - (set_attr "pool_range" "*,*,*,*,*,4094,*") + (set_attr "pool_range" "*,*,*,*,*,1018,*") (set_attr "neg_pool_range" "*,*,*,*,*,0,*")] ) diff --git a/gcc/config/arm/vfp.md b/gcc/config/arm/vfp.md index 9cc5946c79e027c0132d2b5e4fd6b97f13bca72e..661919e2357d352d12ff1020dc061f0c8d052841 100644 --- a/gcc/config/arm/vfp.md +++ b/gcc/config/arm/vfp.md @@ -297,7 +297,7 @@ (define_insn "*thumb2_movsi_vfp" (set_attr "predicable_short_it" "yes,no,yes,no,no,no,no,no,no,no,no,no") (set_attr "type" "mov_reg,mov_reg,mov_reg,mvn_reg,mov_imm,load_4,store_4,f_mcr,f_mrc,fmov,f_loads,f_stores") (set_attr "length" "2,4,2,4,4,4,4,4,4,4,4,4") - (set_attr "pool_range" "*,*,*,*,*,4094,*,*,*,*,1018,*") + (set_attr "pool_range" "*,*,*,*,*,1018,*,*,*,*,1018,*") (set_attr "neg_pool_range" "*,*,*,*,*, 0,*,*,*,*,1008,*")] )