From patchwork Tue Nov 7 03:30:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 835085 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b="aeck3yg5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yWFM62PH1z9s71 for ; Tue, 7 Nov 2017 14:30:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933600AbdKGDa5 (ORCPT ); Mon, 6 Nov 2017 22:30:57 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:52252 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932340AbdKGDa4 (ORCPT ); Mon, 6 Nov 2017 22:30:56 -0500 Received: by mail-pg0-f66.google.com with SMTP id a192so9927247pge.9 for ; Mon, 06 Nov 2017 19:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=y3+OFnExe9h+A7n4epYebiSaSnDQ4qOH/mM7EuFjGO0=; b=aeck3yg55OdFBZJ6u/d45/X7pBpXLuwQojM8xDn3+sbJ+TitC8WYSW7rP+g4WdKKC3 tDkTOtDIvxxMcNcv20OAd46I/l/GYVZrZBl/IYwFZOVcpNciizjCaCiNo1QXqygyBpSn P/oTJTt3E2m+H+SlwQrl1J1wrhg3CJtwYLBbqYZI854B/S34/uL32aVf86N85E7JiCYu 3aejrx8sy74x3/L6UKJ+ydOtfnZNpsgwOEcBIf+0t7dfA6w2VklrH8huOACxbhMUqoJs 8a9zXEFGwqCJhjO62w73j1d75JSNu1ZSiwIExTniQB22BfYTO478R78wHrDZZMU7NQut voWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=y3+OFnExe9h+A7n4epYebiSaSnDQ4qOH/mM7EuFjGO0=; b=AAd67dYsrqD86I4LNqDQjIeV4Y9VVEkD0UAljTYSjdxlCYDrkQ9De+Oa6yySZmzVAf wfYSPDCgZeQhtEkeCHtFhYnrJENL5rvxdsbLkX6ilttZ+L0xEv8nCurYr2Znlvv+9Z7l WmE7DbSGKcp5mrlVnU70XWBOpvNsT/XDfZyDwDR7aC5IbAjXAQ8Ms0Tv+UlqaR+PDVUY OQQRJHEg0G1PgaagfQxhT+su9EUsqVOgiaCjORcc8jh10tXnZ517uXAaMC3LJ/X7V0Uq 7hTNikQF53wP0V3Q4So0UyEBevvqsYC6YO5zmilF0rQHOtFGaLWvN2p5PgVc31FgjqTS moqQ== X-Gm-Message-State: AMCzsaXAAQt2wbh/yVafJc9wKbL1Du8gK0pfcoRlhw6gSMjvgWldLJYr 2fo1IVeBDw7Ofb8JL4PusaH/uopH X-Google-Smtp-Source: ABhQp+QnYyb7aYDl5MIWSjYmFxRU6M2+7+sinD9ZIH/p2x8mkyquNDdZIwcA2R7HWEGS10ImeiTJ1Q== X-Received: by 10.101.82.202 with SMTP id z10mr17191257pgp.404.1510025455645; Mon, 06 Nov 2017 19:30:55 -0800 (PST) Received: from localhost.localdomain (36-239-207-116.dynamic-ip.hinet.net. [36.239.207.116]) by smtp.gmail.com with ESMTPSA id n12sm335934pfb.149.2017.11.06.19.30.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Nov 2017 19:30:54 -0800 (PST) From: Axel Lin To: linux-pwm@vger.kernel.org Cc: Thierry Reding , Fabrice Gasnier , Lee Jones , Axel Lin Subject: [PATCH] pwm: stm32-lp: Remove pwm_is_enabled check before calling pwm_disable Date: Tue, 7 Nov 2017 11:30:41 +0800 Message-Id: <20171107033041.10905-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.11.0 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org The same checking is done by the implementation of pwm_disable(). Signed-off-by: Axel Lin Acked-by: Fabrice Gasnier --- drivers/pwm/pwm-stm32-lp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c index 9793b296108f..1ac9e4384142 100644 --- a/drivers/pwm/pwm-stm32-lp.c +++ b/drivers/pwm/pwm-stm32-lp.c @@ -219,8 +219,7 @@ static int stm32_pwm_lp_remove(struct platform_device *pdev) unsigned int i; for (i = 0; i < priv->chip.npwm; i++) - if (pwm_is_enabled(&priv->chip.pwms[i])) - pwm_disable(&priv->chip.pwms[i]); + pwm_disable(&priv->chip.pwms[i]); return pwmchip_remove(&priv->chip); }