From patchwork Tue Nov 7 01:51:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 835067 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mfdbNW+e"; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3yWC9F6vzJz9s7h; Tue, 7 Nov 2017 12:52:17 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1eBt3k-00089x-UK; Tue, 07 Nov 2017 01:52:12 +0000 Received: from mail-pg0-f68.google.com ([74.125.83.68]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1eBt3j-00089Y-CO for kernel-team@lists.ubuntu.com; Tue, 07 Nov 2017 01:52:11 +0000 Received: by mail-pg0-f68.google.com with SMTP id b192so9754629pga.2 for ; Mon, 06 Nov 2017 17:52:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=vuW0weXrhCfPRNmn4aAvr/2py4G1rHIzgGqIKW+wouY=; b=mfdbNW+eiRElRgMcM9YRHk+9J7wyzQIn0Rb2q1wSXIOy3JpcmTSV9g2WxcRCe97BP3 cbmZDZZJxQrLC6dSgoAA0fmA2yIyyJQxjiIJORiwPGN3lzWJmAgfIPGTi+yu4wAf8SNZ 8qS7OXlHpeFABcKjxZLpfznEQJ42h4T9C+5NWyQ3DVVo1riIOLW11DfHh+ddpKYlkUSO neB+526OYQU+Wo+lz1Ut11QVWHqcHhpiA9vbLm1WUBbXyEUWHM78/Z59JLeuLiVuDJHj 6//y78ODdcldJZThXX69W7ELl3UUjDJ6mnewDSLaZONJGkRgKUkPWChqthuSYp7whx/e IKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=vuW0weXrhCfPRNmn4aAvr/2py4G1rHIzgGqIKW+wouY=; b=uYNuZZDl4B8Lr47E7icKHdroSPXCWY3mY5jp12TIidK3QVZB7MVXAXIcNxapGjy7pM nxWQafdpYb6JVBHLvMJvWL0hjzjHhM5YnSEWM2Yl1zInZPafSxC4x9mpcSaPWl1aj8PQ kUxnyR8V2NXVbchPZYMyulPAEUts8FDkcsODWd5ap8rXx9qzv5eQ+VUX5a3TC8F6B4mc /SSne4/zUU+lGhL1T9gldduEfLM/affU0H/v1fWUx6fbW8neDl+e32ogGD+9wRq34N76 HBXICyvnegbLFfRcyfQfHQnxnmys1jBHmhtMQLoyR5saEfRkLM/OH+YDgxa+FeA5f7rK nfTw== X-Gm-Message-State: AMCzsaW7S04ifdurIVrbicc1KmUAPUeH5iv/0RVEdYqNtz1qQUxcHpRH cj5o1awQjiq7N3OVKmCU8jXml1k8 X-Google-Smtp-Source: ABhQp+St7gZKBtLVfAyUwIlNBtpG0oaee9x26NRtBNSBPqAgkYsNcxDFsz0rtzjPMUeHRhCQlprhxg== X-Received: by 10.84.137.106 with SMTP id 97mr16718699plm.429.1510019529662; Mon, 06 Nov 2017 17:52:09 -0800 (PST) Received: from localhost ([175.41.48.77]) by smtp.gmail.com with ESMTPSA id b6sm111031pgc.2.2017.11.06.17.52.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Nov 2017 17:52:08 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/9] net: aquantia: Bad udp rate on default interrupt coalescing Date: Tue, 7 Nov 2017 09:51:55 +0800 Message-Id: <1510019523-14235-2-git-send-email-acelan.kao@canonical.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510019523-14235-1-git-send-email-acelan.kao@canonical.com> References: <1510019523-14235-1-git-send-email-acelan.kao@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Igor Russkikh BugLink: http://bugs.launchpad.net/bugs/1730544 Default Tx rates cause very long ISR delays on Tx. 0xff is 510us delay, giving only ~ 2000 interrupts per seconds for Tx rings cleanup. With these settings udp tx rate was never higher than ~800Mbps on a single stream. Changing min delay to 0xF makes it way better with ~6Gbps TCP stream performance is almost unaffected by this change, since LSO optimizations play important role. CPU load is affected insignificantly by this change. Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh Signed-off-by: David S. Miller (cherry picked from commit 417a3ae4b14909439bb49790f90201f450399845) Signed-off-by: AceLan Kao --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c index 21784cc..a399203 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c @@ -815,12 +815,12 @@ static int hw_atl_b0_hw_interrupt_moderation_set(struct aq_hw_s *self, PHAL_ATLANTIC_B0->itr_rx |= max_timer << 0x10U; } else { static unsigned int hw_atl_b0_timers_table_tx_[][2] = { - {0xffU, 0xffU}, /* 10Gbit */ - {0xffU, 0x1ffU}, /* 5Gbit */ - {0xffU, 0x1ffU}, /* 5Gbit 5GS */ - {0xffU, 0x1ffU}, /* 2.5Gbit */ - {0xffU, 0x1ffU}, /* 1Gbit */ - {0xffU, 0x1ffU}, /* 100Mbit */ + {0xfU, 0xffU}, /* 10Gbit */ + {0xfU, 0x1ffU}, /* 5Gbit */ + {0xfU, 0x1ffU}, /* 5Gbit 5GS */ + {0xfU, 0x1ffU}, /* 2.5Gbit */ + {0xfU, 0x1ffU}, /* 1Gbit */ + {0xfU, 0x1ffU}, /* 100Mbit */ }; static unsigned int hw_atl_b0_timers_table_rx_[][2] = {