From patchwork Fri Jul 19 21:10:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1134299 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CswfGjPv"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45r3Yj5rjFz9sNC for ; Sat, 20 Jul 2019 07:10:15 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 78ACA22E6E; Fri, 19 Jul 2019 21:10:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DG42+kYSzq4B; Fri, 19 Jul 2019 21:10:01 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id BABA322EE7; Fri, 19 Jul 2019 21:09:57 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 8F5621BF292 for ; Fri, 19 Jul 2019 21:09:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 8C5DC87969 for ; Fri, 19 Jul 2019 21:09:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JAwXExuoeWx7 for ; Fri, 19 Jul 2019 21:09:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id AFE3E84D06 for ; Fri, 19 Jul 2019 21:09:54 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id g67so26078889wme.1 for ; Fri, 19 Jul 2019 14:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bXLBisOLGVI7euAPMVki7zFVlGmHbngLWkXta06igi0=; b=CswfGjPv+Nwy9Fsm9cXunCh9Z68QzUpUK1EpGoFSOl/9MApCrbJojjb7sYOiVdxJ3i J/Lwtu2Zfv9KrZTyEPqul+x2ey6EBaY+sSjgra+2ny4mUgASZHbJTs5KyPZ+iJUSf2jo gfm7LPRCJirstx4Fx2a75jaCWRgp60IynYWaJP1SdpjDe4VXOlZdeHMh3R2bKwZe/L/q p9HidokC+xrbDewKazBH9jjCQl+PGWpaRHzSH0IqDTFKqm28n05wrXKYT1F/0OsOotjN EMwvXVn9Cj8HL1VrUBrmKHyi+LyXZz6PutIpW8j0k3RBx759JY8x5+FJnSQ0BI3IEwEf 4fxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bXLBisOLGVI7euAPMVki7zFVlGmHbngLWkXta06igi0=; b=pqwAvOT7m3UpBTOYZ67ag7oOQwKGz4H/ItCyD1xBOc4JAI4F1HFzPzTqJX9PYYVgi8 N+LXBNmCSnZVm4VhEvdrrf+FqELx7bz0ptC4Qq6b9DNAtizKxwm4H9geTWaqa129jTGe xOGuWc2pCNxiIepTCG/2ubXNjtafHEC0TDBRRRPTfk6Sb53nx4MA4ENn1KK4cKT7XBpJ PlQ6FF1I1yYEWFrz9LXh1kuXLyPy2InxbE7zeE9HFxKzcCVHpuyYnGxi6P26F6DciPMA 1XolkIQrgEOQg4K9y063aPtpcYl/aNKLC0c5v0YknVJOnGIofNd7MfOA3lV9eH/6dDaG 9YpA== X-Gm-Message-State: APjAAAUkV2XQ7zwTeV8oV8hCfxNLegLRGG0sLmjnusDVJ2sNtmwzqrL6 s5URnS5tWkvsi47nydHnCtMUDapF X-Google-Smtp-Source: APXvYqwgiECic6dzBywZe70GVIxS/nBKiIWxL6Nv3o8RfFCCxrgqa/uyqiGPGppnWjlZHkCt3jX7xQ== X-Received: by 2002:a1c:9a53:: with SMTP id c80mr47045312wme.173.1563570592860; Fri, 19 Jul 2019 14:09:52 -0700 (PDT) Received: from kali.home (lfbn-ren-1-605-248.w81-53.abo.wanadoo.fr. [81.53.181.248]) by smtp.gmail.com with ESMTPSA id j9sm32317640wrn.81.2019.07.19.14.09.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 19 Jul 2019 14:09:51 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Fri, 19 Jul 2019 23:10:03 +0200 Message-Id: <20190719211003.3678-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2, 1/1] package/dropwatch: bump to version 1.5.1 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markos Chandras , Tzu-Jung Lee , Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" - Switch site, see http://git.infradead.org/users/nhorman/dropwatch.git/blob/975fd7331d19a32f6d0f20781dfb19f2d14c3c31:/README - Switch to autotools (and so drop second patch on Makefile: if there is some errors raised by -Werror, we'll fix them) - Update first patch by upstream commit - Add hash for license file Signed-off-by: Fabrice Fontaine --- Changes v1 -> v2: - Replace first patch with upstream commit package/dropwatch/0001-binutils-2.23.1.patch | 104 +++++++------------ package/dropwatch/0002-remove-werror.patch | 31 ------ package/dropwatch/Config.in | 2 +- package/dropwatch/dropwatch.hash | 3 +- package/dropwatch/dropwatch.mk | 26 ++--- 5 files changed, 49 insertions(+), 117 deletions(-) delete mode 100644 package/dropwatch/0002-remove-werror.patch diff --git a/package/dropwatch/0001-binutils-2.23.1.patch b/package/dropwatch/0001-binutils-2.23.1.patch index f9f090c055..86b1822bc0 100644 --- a/package/dropwatch/0001-binutils-2.23.1.patch +++ b/package/dropwatch/0001-binutils-2.23.1.patch @@ -1,92 +1,60 @@ -From c89cc908ba7f9f41aba4f61f58103d0fc64fa19f Mon Sep 17 00:00:00 2001 -From: Gustavo Zacarias -Date: Fri, 16 Jun 2017 08:50:03 +0200 +From 0ffad73a59d3c831dfab66d4d06f1ab25fce66f2 Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine +Date: Thu, 18 Jul 2019 22:58:07 +0200 Subject: [PATCH] Fix for binutils 2.23.1 libbfd from binutils 2.23.1+ requires PACKAGE* definitions from autoconf. -Patch from https://fedorahosted.org/dropwatch/ticket/5 -Upstream status: new. +So include config.h now that dropwatch uses autoconf Signed-off-by: Gustavo Zacarias +[Retrieved (and slightly updated) from: +https://git.buildroot.net/buildroot/tree/package/dropwatch/0001-binutils-2.23.1.patch] +Signed-off-by: Fabrice Fontaine +[Retrieved from: +https://github.com/nhorman/dropwatch/commit/0ffad73a59d3c831dfab66d4d06f1ab25fce66f2] --- - src/lookup.c | 2 +- - src/lookup.h | 3 +++ - src/lookup_bfd.c | 2 +- - src/lookup_kas.c | 2 +- - 4 files changed, 6 insertions(+), 3 deletions(-) + src/lookup.c | 3 +++ + src/lookup_bfd.c | 2 ++ + src/lookup_kas.c | 2 ++ + 3 files changed, 7 insertions(+) diff --git a/src/lookup.c b/src/lookup.c -index ba54991..809981b 100644 +index ba54991..521e292 100644 --- a/src/lookup.c +++ b/src/lookup.c -@@ -27,13 +27,13 @@ +@@ -24,6 +24,9 @@ + * 1) /usr/lib/debug/ using libbfd + * 2) /proc/kallsyms + */ ++ ++#include "config.h" ++ #include #include #include --#include - #include - #include - #include - #include - - #include "lookup.h" -+#include - - extern struct lookup_methods bfd_methods; - extern struct lookup_methods kallsym_methods; -diff --git a/src/lookup.h b/src/lookup.h -index e6568d8..47a7b56 100644 ---- a/src/lookup.h -+++ b/src/lookup.h -@@ -28,6 +28,9 @@ - #include - #include - -+// satisfy PR 14072 in bfd.h -+#define PACKAGE 1 -+#define PACKAGE_VERSION 1 - - /* - * Initalization routine diff --git a/src/lookup_bfd.c b/src/lookup_bfd.c -index cc7010b..271d426 100644 +index cc7010b..2c08e5e 100644 --- a/src/lookup_bfd.c +++ b/src/lookup_bfd.c -@@ -25,13 +25,13 @@ +@@ -22,6 +22,8 @@ + * symbollic name using the bfd library + */ + ++#include "config.h" ++ #include #include #include --#include - #include - #include - #include - #include - - #include "lookup.h" -+#include - - - static int lookup_bfd_init(void) diff --git a/src/lookup_kas.c b/src/lookup_kas.c -index 16e639f..556cb62 100644 +index 5e05630..2300220 100644 --- a/src/lookup_kas.c +++ b/src/lookup_kas.c -@@ -25,7 +25,6 @@ +@@ -22,6 +22,8 @@ + * symbolic name using /proc/kallsyms + */ + ++#include "config.h" ++ #include #include - #include --#include - #include - #include - #include -@@ -33,6 +32,7 @@ - #include - - #include "lookup.h" -+#include - - struct symbol_entry { - char *sym_name; --- -2.1.4 - + #include diff --git a/package/dropwatch/0002-remove-werror.patch b/package/dropwatch/0002-remove-werror.patch deleted file mode 100644 index 4b6c989364..0000000000 --- a/package/dropwatch/0002-remove-werror.patch +++ /dev/null @@ -1,31 +0,0 @@ -From 2462baf55939ee53bb28ff5f9474761f2a888add Mon Sep 17 00:00:00 2001 -From: Markos Chandras -Date: Fri, 16 Jun 2017 08:53:31 +0200 -Subject: [PATCH] remove werror - --Werror shouldn't be used in released code since it can -cause random build failures on moderate warnings. It also -depends on the used toolchain since different toolchains may -or may not print the same warnings. - -Signed-off-by: Markos Chandras ---- - src/Makefile | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/src/Makefile b/src/Makefile -index 5bc6aaa..527c1da 100644 ---- a/src/Makefile -+++ b/src/Makefile -@@ -1,7 +1,7 @@ - all: dropwatch - - CPPFLAGS += -D_GNU_SOURCE --CFLAGS += -g -Wall -Werror $(shell pkg-config --cflags libnl-3.0) -+CFLAGS += -g -Wall $(shell pkg-config --cflags libnl-3.0) - LDLIBS += -lbfd -lreadline -lnl-3 -lnl-genl-3 - - OBJFILES := main.o lookup.o\ --- -2.1.4 - diff --git a/package/dropwatch/Config.in b/package/dropwatch/Config.in index f470f1b562..6d021756ee 100644 --- a/package/dropwatch/Config.in +++ b/package/dropwatch/Config.in @@ -10,7 +10,7 @@ config BR2_PACKAGE_DROPWATCH Dropwatch is an interactive utility for monitoring and recording packets that are dropped by the kernel - http://git.infradead.org/users/nhorman/dropwatch.git + https://github.com/nhorman/dropwatch comment "dropwatch needs a toolchain w/ threads, wchar" depends on !BR2_nios2 diff --git a/package/dropwatch/dropwatch.hash b/package/dropwatch/dropwatch.hash index 585b035d0f..e0e03ad883 100644 --- a/package/dropwatch/dropwatch.hash +++ b/package/dropwatch/dropwatch.hash @@ -1,2 +1,3 @@ # Locally calculated -sha256 4937007da3d0071c9a37ee0360cfd1657b342fd2a327d83ba992fbf3e0ea51b5 dropwatch-7c33d8a8ed105b07a46b55d71d93b36ed34c16db.tar.gz +sha256 3a95b7ff0d609f581c120a4072e6a97d044f900824b4f4d3ac83fdcc5f3e96cf dropwatch-1.5.1.tar.gz +sha256 e6d6a009505e345fe949e1310334fcb0747f28dae2856759de102ab66b722cb4 COPYING diff --git a/package/dropwatch/dropwatch.mk b/package/dropwatch/dropwatch.mk index 692a6e8c40..bda25dd326 100644 --- a/package/dropwatch/dropwatch.mk +++ b/package/dropwatch/dropwatch.mk @@ -4,27 +4,21 @@ # ################################################################################ -DROPWATCH_VERSION = 7c33d8a8ed105b07a46b55d71d93b36ed34c16db -DROPWATCH_SITE = git://git.infradead.org/users/nhorman/dropwatch.git +DROPWATCH_VERSION = 1.5.1 +DROPWATCH_SITE = $(call github,nhorman,dropwatch,v$(DROPWATCH_VERSION)) DROPWATCH_DEPENDENCIES = binutils libnl readline host-pkgconf \ $(TARGET_NLS_DEPENDENCIES) DROPWATCH_LICENSE = GPL-2.0 DROPWATCH_LICENSE_FILES = COPYING +# From git +DROPWATCH_AUTORECONF = YES -# libbfd may be linked to libintl -# Ugly... but LDLIBS are hardcoded anyway -DROPWATCH_LDLIBS = \ - -lbfd -lreadline -lnl-3 -lnl-genl-3 -lpthread -lncurses -lm \ - $(TARGET_NLS_LIBS) - -define DROPWATCH_BUILD_CMDS - $(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ - LDLIBS="$(DROPWATCH_LDLIBS)" build +# Autoreconf step fails due to missing m4 directory +define DROPWATCH_CREATE_M4_DIR + mkdir -p $(@D)/m4 endef +DROPWATCH_PRE_CONFIGURE_HOOKS += DROPWATCH_CREATE_M4_DIR -define DROPWATCH_INSTALL_TARGET_CMDS - $(INSTALL) -D -m 0755 $(@D)/src/dropwatch \ - $(TARGET_DIR)/usr/bin/dropwatch -endef +DROPWATCH_MAKE_OPTS = LIBS=$(TARGET_NLS_LIBS) -$(eval $(generic-package)) +$(eval $(autotools-package))