From patchwork Thu Jul 18 07:51:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ding Xiang X-Patchwork-Id: 1133609 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cmss.chinamobile.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45q6610g6jz9s8m for ; Thu, 18 Jul 2019 18:01:29 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726608AbfGRIB1 (ORCPT ); Thu, 18 Jul 2019 04:01:27 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:2578 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfGRIB1 (ORCPT ); Thu, 18 Jul 2019 04:01:27 -0400 X-Greylist: delayed 581 seconds by postgrey-1.27 at vger.kernel.org; Thu, 18 Jul 2019 04:01:18 EDT Received: from spf.mail.chinamobile.com (unknown[172.16.121.1]) by rmmx-syy-dmz-app03-12003 (RichMail) with SMTP id 2ee35d3024f6001-9a38b; Thu, 18 Jul 2019 15:51:19 +0800 (CST) X-RM-TRANSID: 2ee35d3024f6001-9a38b X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.105.0.243]) by rmsmtp-syy-appsvr01-12001 (RichMail) with SMTP id 2ee15d3024f6bc7-f01c1; Thu, 18 Jul 2019 15:51:19 +0800 (CST) X-RM-TRANSID: 2ee15d3024f6bc7-f01c1 From: Ding Xiang To: thierry.reding@gmail.com Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pwm: sifive: remove redundant dev_err message Date: Thu, 18 Jul 2019 15:51:11 +0800 Message-Id: <1563436271-31356-1-git-send-email-dingxiang@cmss.chinamobile.com> X-Mailer: git-send-email 1.9.1 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org devm_ioremap_resource already contains error message, so remove the redundant dev_err message Signed-off-by: Ding Xiang Acked-by: Uwe Kleine-König --- drivers/pwm/pwm-sifive.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index a7c107f..bb4f02c 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -250,10 +250,8 @@ static int pwm_sifive_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); ddata->regs = devm_ioremap_resource(dev, res); - if (IS_ERR(ddata->regs)) { - dev_err(dev, "Unable to map IO resources\n"); + if (IS_ERR(ddata->regs)) return PTR_ERR(ddata->regs); - } ddata->clk = devm_clk_get(dev, NULL); if (IS_ERR(ddata->clk)) {