From patchwork Thu Jul 18 06:51:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133560 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4cY22nCz9s8m for ; Thu, 18 Jul 2019 16:54:21 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4cY0wx2zDqgs for ; Thu, 18 Jul 2019 16:54:21 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YF1rF0zDqMw for ; Thu, 18 Jul 2019 16:51:28 +1000 (AEST) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6mM6a115123 for ; Thu, 18 Jul 2019 02:51:27 -0400 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0b-001b2d01.pphosted.com with ESMTP id 2tthu4525m-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:26 -0400 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jul 2019 07:51:25 +0100 Received: from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 18 Jul 2019 07:51:22 +0100 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pL0f53936612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:21 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6820F6E050 for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 309076E04C for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 4B338478273; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:08 +1000 X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 19071806-0036-0000-0000-00000ADB85DC X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011450; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000286; SDB=6.01233805; UDB=6.00650146; IPR=6.01015132; MB=3.00027773; MTD=3.00000008; XFM=3.00000015; UTC=2019-07-18 06:51:23 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19071806-0037-0000-0000-00004CA5677D Message-Id: <20190718065117.16923-2-stewart@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 01/10] Silence sparse warning for version.c X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" version.c:1:12: warning: symbol 'version' was not declared. Should it be static? Signed-off-by: Stewart Smith --- Makefile.main | 1 + core/init.c | 1 + 2 files changed, 2 insertions(+) diff --git a/Makefile.main b/Makefile.main index fac6e4487460..56fa2bae9e14 100644 --- a/Makefile.main +++ b/Makefile.main @@ -303,6 +303,7 @@ version.c: $(SRC)/make_version.sh $(OBJS_NO_VER) .version @(if [ "a$(VERSION)" = "a" ]; then \ echo "#error You need to set SKIBOOT_VERSION environment variable" > $@ ;\ else \ + echo "extern const char version[];"; \ echo "const char version[] = \"$(VERSION)\";" ;\ fi) > $@ diff --git a/core/init.c b/core/init.c index 271736be8325..c99302c86500 100644 --- a/core/init.c +++ b/core/init.c @@ -57,6 +57,7 @@ enum proc_gen proc_gen; unsigned int pcie_max_link_speed; bool verbose_eeh; +extern const char version[]; static uint64_t kernel_entry; static size_t kernel_size; From patchwork Thu Jul 18 06:51:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133552 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4ZD1tP6z9sBF for ; Thu, 18 Jul 2019 16:52:20 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4ZC5NbKzDqLL for ; Thu, 18 Jul 2019 16:52:19 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YC46sNzDqN1 for ; Thu, 18 Jul 2019 16:51:26 +1000 (AEST) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6nbmk034542 for ; Thu, 18 Jul 2019 02:51:24 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ttjvjjhv4-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:23 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jul 2019 07:51:23 +0100 Received: from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 18 Jul 2019 07:51:22 +0100 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pL5242271064 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:21 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6777BBE04F for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3063EBE051 for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 51D8E478274; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:09 +1000 X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 19071806-0004-0000-0000-0000152B8646 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011450; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000286; SDB=6.01233805; UDB=6.00650146; IPR=6.01015131; MB=3.00027773; MTD=3.00000008; XFM=3.00000015; UTC=2019-07-18 06:51:22 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19071806-0005-0000-0000-00008C826C91 Message-Id: <20190718065117.16923-3-stewart@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 02/10] sparse: Silence "directive in argument list" for version string X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" core/init.c:966:1: error: directive in argument list core/init.c:968:1: error: directive in argument list core/init.c:970:1: error: directive in argument list Signed-off-by: Stewart Smith --- core/init.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/core/init.c b/core/init.c index c99302c86500..e3e0ea380bb2 100644 --- a/core/init.c +++ b/core/init.c @@ -66,6 +66,12 @@ static bool kernel_32bit; /* We backup the previous vectors here before copying our own */ static uint8_t old_vectors[EXCEPTION_VECTORS_END]; +#ifdef DEBUG +#define DEBUG_STR "-debug" +#else +#define DEBUG_STR "" +#endif + #ifdef SKIBOOT_GCOV void skiboot_gcov_done(void); #endif @@ -962,13 +968,8 @@ void __noreturn __nomcount main_cpu_entry(const void *fdt) /* Call library constructors */ do_ctors(); - prlog(PR_NOTICE, "OPAL %s%s starting...\n", version, -#ifdef DEBUG - "-debug" -#else - "" -#endif - ); + prlog(PR_NOTICE, "OPAL %s%s starting...\n", version, DEBUG_STR); + prlog(PR_DEBUG, "initial console log level: memory %d, driver %d\n", (debug_descriptor.console_log_levels >> 4), (debug_descriptor.console_log_levels & 0x0f)); From patchwork Thu Jul 18 06:51:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133549 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4YP1ghgz9s4Y for ; Thu, 18 Jul 2019 16:51:37 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4YN56dRzDqQg for ; Thu, 18 Jul 2019 16:51:36 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YC2GS3zDqLL for ; Thu, 18 Jul 2019 16:51:26 +1000 (AEST) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6nAkd055003 for ; Thu, 18 Jul 2019 02:51:23 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ttjh6uq95-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:23 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x6I6iriG023747 for ; Thu, 18 Jul 2019 06:51:22 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma01dal.us.ibm.com with ESMTP id 2tq6x75j6w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 06:51:22 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pLqF43647294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:21 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9D525AE05C for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 661BFAE05F for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 5B621478275; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:10 +1000 Message-Id: <20190718065117.16923-4-stewart@linux.ibm.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 03/10] sparse: fix (main|secondar)_cpu_entry declaration types X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" core/init.c:923:28: error: symbol 'main_cpu_entry' redeclared with different type (originally declared at core/init.c:921) - different modifiers core/init.c:1314:28: error: symbol 'secondary_cpu_entry' redeclared with different type (originally declared at core/init.c:1312) - different modifiers Signed-off-by: Stewart Smith --- core/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/init.c b/core/init.c index e3e0ea380bb2..7a35da16bd90 100644 --- a/core/init.c +++ b/core/init.c @@ -918,7 +918,7 @@ bool verify_romem(void) } /* Called from head.S, thus no prototype. */ -void main_cpu_entry(const void *fdt); +void __noreturn __nomcount main_cpu_entry(const void *fdt); void __noreturn __nomcount main_cpu_entry(const void *fdt) { @@ -1309,7 +1309,7 @@ void __noreturn __secondary_cpu_entry(void) } /* Called from head.S, thus no prototype. */ -void secondary_cpu_entry(void); +void __noreturn __nomcount secondary_cpu_entry(void); void __noreturn __nomcount secondary_cpu_entry(void) { From patchwork Thu Jul 18 06:51:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133558 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4c342Kmz9s4Y for ; Thu, 18 Jul 2019 16:53:55 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4c32d6mzDqfv for ; Thu, 18 Jul 2019 16:53:55 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YD34DpzDqN1 for ; Thu, 18 Jul 2019 16:51:28 +1000 (AEST) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6n8R6067985 for ; Thu, 18 Jul 2019 02:51:26 -0400 Received: from e12.ny.us.ibm.com (e12.ny.us.ibm.com [129.33.205.202]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ttgk6fafp-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:26 -0400 Received: from localhost by e12.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jul 2019 07:51:25 +0100 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e12.ny.us.ibm.com (146.89.104.199) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 18 Jul 2019 07:51:22 +0100 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pL5746399912 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:21 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9299BAE060 for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 57B31AE063 for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:21 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 63C94478276; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:11 +1000 X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 19071806-0060-0000-0000-00000362A193 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011450; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000286; SDB=6.01233804; UDB=6.00650146; IPR=6.01015132; MB=3.00027773; MTD=3.00000008; XFM=3.00000015; UTC=2019-07-18 06:51:23 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19071806-0061-0000-0000-00004A327EDA Message-Id: <20190718065117.16923-5-stewart@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=873 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 04/10] sparse: fix endian types of struct imc_chip_cb members X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" hw/imc.c:188:46: warning: incorrect type in assignment (different base types) hw/imc.c:188:46: expected unsigned long long [usertype] imc_chip_command hw/imc.c:188:46: got restricted beint64_t hw/imc.c:370:41: warning: incorrect type in argument 1 (different base types) hw/imc.c:370:41: expected restricted beint64_t [usertype] be_val hw/imc.c:370:41: got unsigned long long [usertype] imc_chip_avl_vector hw/imc.c:833:38: warning: incorrect type in assignment (different base types) hw/imc.c:833:38: expected unsigned long long [usertype] imc_chip_command hw/imc.c:833:38: got restricted beint64_t hw/imc.c:894:38: warning: incorrect type in assignment (different base types) hw/imc.c:894:38: expected unsigned long long [usertype] imc_chip_command hw/imc.c:894:38: got restricted beint64_t Signed-off-by: Stewart Smith --- include/imc.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/imc.h b/include/imc.h index 6b04bb36fd1f..9b658241a8dc 100644 --- a/include/imc.h +++ b/include/imc.h @@ -97,12 +97,12 @@ */ struct imc_chip_cb { - u64 imc_chip_run_status; - u64 imc_chip_command; - u64 imc_chip_collection_speed; - u64 imc_chip_avl_vector; - u64 imc_chip_run_mode; -}; + be64 imc_chip_run_status; + be64 imc_chip_command; + be64 imc_chip_collection_speed; + be64 imc_chip_avl_vector; + be64 imc_chip_run_mode; +} __packed; /* Size of IMC dtb LID (256KBytes) */ #define MAX_DECOMPRESSED_IMC_DTB_SIZE 0x40000 From patchwork Thu Jul 18 06:51:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133555 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4bB5n2Mz9s4Y for ; Thu, 18 Jul 2019 16:53:10 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4bB4sZ1zDqbx for ; Thu, 18 Jul 2019 16:53:10 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YC60kszDqPC for ; Thu, 18 Jul 2019 16:51:27 +1000 (AEST) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6mvvR055050 for ; Thu, 18 Jul 2019 02:51:25 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 2tthj1wm4h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:25 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x6I6ivW0018361 for ; Thu, 18 Jul 2019 06:51:24 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma03dal.us.ibm.com with ESMTP id 2tq6x7nk0a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 06:51:24 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pMs151315134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:22 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D16386E050 for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A96B6E04C for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 6B20747829D; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:12 +1000 Message-Id: <20190718065117.16923-6-stewart@linux.ibm.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=976 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 05/10] sparse: various SPIRA structures, declare them. X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" hdata/spira.c:42:49: warning: symbol 'proc_init_data' was not declared. Should it be static? hdata/spira.c:51:49: warning: symbol 'cpu_ctl_spat_area' was not declared. Should it be static? hdata/spira.c:54:49: warning: symbol 'cpu_ctl_hsr_area' was not declared. Should it be static? hdata/spira.c:56:53: warning: symbol 'cpu_ctl_init_data' was not declared. Should it be static? hdata/spira.c:92:48: warning: symbol 'init_mdst_table' was not declared. Should it be static? Signed-off-by: Stewart Smith --- hdata/spira.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hdata/spira.c b/hdata/spira.c index a23fd17c5245..945cc7e8c50f 100644 --- a/hdata/spira.c +++ b/hdata/spira.c @@ -39,6 +39,8 @@ static int cpu_type; +extern struct proc_init_data proc_init_data; + __section(".procin.data") struct proc_init_data proc_init_data = { .hdr = HDIF_SIMPLE_HDR("PROCIN", 1, struct proc_init_data), .regs_ptr = HDIF_IDATA_PTR(offsetof(struct proc_init_data, regs), 0x10), @@ -48,11 +50,14 @@ __section(".procin.data") struct proc_init_data proc_init_data = { }, }; +extern struct sp_addr_table cpu_ctl_spat_area; __section(".cpuctrl.data") struct sp_addr_table cpu_ctl_spat_area; __section(".cpuctrl.data") struct sp_attn_area cpu_ctl_sp_attn_area1; __section(".cpuctrl.data") struct sp_attn_area cpu_ctl_sp_attn_area2; +extern struct hsr_data_area cpu_ctl_hsr_area; __section(".cpuctrl.data") struct hsr_data_area cpu_ctl_hsr_area; +extern struct cpu_ctl_init_data cpu_ctl_init_data; __section(".cpuctrl.data") struct cpu_ctl_init_data cpu_ctl_init_data = { .hdr = HDIF_SIMPLE_HDR(CPU_CTL_HDIF_SIG, 2, struct cpu_ctl_init_data), .cpu_ctl = HDIF_IDATA_PTR(offsetof(struct cpu_ctl_init_data, cpu_ctl_lt), sizeof(struct cpu_ctl_legacy_table)), @@ -89,6 +94,8 @@ __section(".cpuctrl.data") struct cpu_ctl_init_data cpu_ctl_init_data = { * addresses, we set the top bit to 1 on physical addresses */ +extern struct dump_mdst_table init_mdst_table[]; + __section(".mdst.data") struct dump_mdst_table init_mdst_table[2] = { { .addr = CPU_TO_BE64(INMEM_CON_START | HRMOR_BIT), From patchwork Thu Jul 18 06:51:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133557 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4bm725Yz9sBF for ; Thu, 18 Jul 2019 16:53:40 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4bl5xFtzDqfV for ; Thu, 18 Jul 2019 16:53:39 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YD2gBXzDqMw for ; Thu, 18 Jul 2019 16:51:28 +1000 (AEST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6nIll033964 for ; Thu, 18 Jul 2019 02:51:26 -0400 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ttkdhgyf0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:26 -0400 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jul 2019 07:51:24 +0100 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 18 Jul 2019 07:51:23 +0100 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pNtg48693532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:23 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 08875112062 for ; Thu, 18 Jul 2019 06:51:23 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BBF85112061 for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 71CF147656D; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:13 +1000 X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 19071806-0064-0000-0000-00000400A36C X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011450; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000286; SDB=6.01233804; UDB=6.00650146; IPR=6.01015132; MB=3.00027773; MTD=3.00000008; XFM=3.00000015; UTC=2019-07-18 06:51:24 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19071806-0065-0000-0000-00003E528004 Message-Id: <20190718065117.16923-7-stewart@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 06/10] sparse: lpc uart interrupt pointer endianness X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" hw/lpc-uart.c:674:47: warning: incorrect type in argument 1 (different base types) hw/lpc-uart.c:674:47: expected restricted beint32_t [usertype] be_val hw/lpc-uart.c:674:47: got unsigned int const [usertype] Signed-off-by: Stewart Smith --- hw/lpc-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/lpc-uart.c b/hw/lpc-uart.c index bca10e0e98dc..f9643553341c 100644 --- a/hw/lpc-uart.c +++ b/hw/lpc-uart.c @@ -617,7 +617,7 @@ void uart_init(void) const struct dt_property *prop; struct dt_node *n; char *path __unused; - const uint32_t *irqp; + const be32 *irqp; /* Clean up after early_uart_init() */ mmio_uart_base = NULL; From patchwork Thu Jul 18 06:51:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133559 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4cH30jKz9s8m for ; Thu, 18 Jul 2019 16:54:07 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4cH1nHdzDqgs for ; Thu, 18 Jul 2019 16:54:07 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YF12b6zDqLL for ; Thu, 18 Jul 2019 16:51:28 +1000 (AEST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6n9U3047001 for ; Thu, 18 Jul 2019 02:51:25 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ttg4crbhh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:25 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x6I6ivpD023759 for ; Thu, 18 Jul 2019 06:51:24 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma01dal.us.ibm.com with ESMTP id 2tq6x75j72-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 06:51:24 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pNoT43909578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:23 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE51E78063 for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B0E5078066 for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 7969F47656F; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:14 +1000 Message-Id: <20190718065117.16923-8-stewart@linux.ibm.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 07/10] sparse: hdata/fsp: u8 doesn't have endian X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" hdata/fsp.c:271:9: warning: incorrect type in argument 1 (different base types) hdata/fsp.c:271:9: expected restricted beint32_t [usertype] be_val hdata/fsp.c:271:9: got unsigned char const [usertype] uart_int_number hdata/fsp.c:271:9: warning: incorrect type in argument 1 (different base types) hdata/fsp.c:271:9: expected restricted beint32_t [usertype] be_val hdata/fsp.c:271:9: got unsigned char const [usertype] uart_int_number Signed-off-by: Stewart Smith --- hdata/fsp.c | 2 +- hdata/test/op920.wsp.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hdata/fsp.c b/hdata/fsp.c index 2bf691f81446..efa3a487a6a7 100644 --- a/hdata/fsp.c +++ b/hdata/fsp.c @@ -269,7 +269,7 @@ static void add_uart(const struct spss_iopath *iopath, struct dt_node *lpc) dt_add_property_cells(serial, "clock-frequency", be32_to_cpu(iopath->lpc.uart_clk)); dt_add_property_cells(serial, "interrupts", - be32_to_cpu(iopath->lpc.uart_int_number)); + iopath->lpc.uart_int_number); dt_add_property_string(serial, "device_type", "serial"); diff --git a/hdata/test/op920.wsp.dts b/hdata/test/op920.wsp.dts index 4c61b0e7c97d..fbc5a39c8a53 100644 --- a/hdata/test/op920.wsp.dts +++ b/hdata/test/op920.wsp.dts @@ -3254,7 +3254,7 @@ compatible = "ns16550"; current-speed = <0x1c200>; clock-frequency = <0x1c2000>; - interrupts = <0x4000000>; + interrupts = <0x04>; device_type = "serial"; }; }; From patchwork Thu Jul 18 06:51:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133554 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4Zx2ywFz9s8m for ; Thu, 18 Jul 2019 16:52:57 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4Zw6xdMzDqbC for ; Thu, 18 Jul 2019 16:52:56 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YC5CV7zDqP8 for ; Thu, 18 Jul 2019 16:51:27 +1000 (AEST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6nJ69034013 for ; Thu, 18 Jul 2019 02:51:24 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ttkdhgye1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:24 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x6I6isLN004564 for ; Thu, 18 Jul 2019 06:51:23 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma01wdc.us.ibm.com with ESMTP id 2tq6x6dm2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 06:51:23 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pNOQ48693534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:23 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19E4CAC059 for ; Thu, 18 Jul 2019 06:51:23 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CD745AC05E for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 80EE6476570; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:15 +1000 Message-Id: <20190718065117.16923-9-stewart@linux.ibm.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 08/10] sparse: hdata/iohub: correctly convert endianness X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" hdata/iohub.c:723:22: warning: restricted beint16_t degrades to integer Signed-off-by: Stewart Smith --- hdata/iohub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hdata/iohub.c b/hdata/iohub.c index c81dc5e46188..b0ef0c3d721a 100644 --- a/hdata/iohub.c +++ b/hdata/iohub.c @@ -720,7 +720,7 @@ static void io_parse_slots(const struct HDIF_common_hdr *sp_iohubs, int hub_id) const struct slot_map_entry *entry; unsigned int i, count; - if (sp_iohubs->child_count <= CECHUB_CHILD_IOSLOTS) + if (be16_to_cpu(sp_iohubs->child_count) <= CECHUB_CHILD_IOSLOTS) return; ioslot_arr = HDIF_child_arr(sp_iohubs, CECHUB_CHILD_IOSLOTS); From patchwork Thu Jul 18 06:51:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4bT3z1Zz9s8m for ; Thu, 18 Jul 2019 16:53:25 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4bT2LbHzDqZD for ; Thu, 18 Jul 2019 16:53:25 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YD09V0zDqLL for ; Thu, 18 Jul 2019 16:51:27 +1000 (AEST) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6mY8m045157 for ; Thu, 18 Jul 2019 02:51:25 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ttjrbjwf6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:25 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x6I6isD9031596 for ; Thu, 18 Jul 2019 06:51:24 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma04dal.us.ibm.com with ESMTP id 2trtmrdvmf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 06:51:24 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pNjj61538632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:23 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EBC16136055 for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B3C9C136059 for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 87761476572; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:16 +1000 Message-Id: <20190718065117.16923-10-stewart@linux.ibm.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 09/10] sparse: hdata/spira sw_xstop_fir_bitpos is uint8_t, has no endian X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" hdata/spira.c:625:33: warning: incorrect type in argument 1 (different base types) hdata/spira.c:625:33: expected restricted beint32_t [usertype] be_val hdata/spira.c:625:33: got unsigned char [usertype] fir_bit hdata/spira.c:625:33: warning: incorrect type in argument 1 (different base types) hdata/spira.c:625:33: expected restricted beint32_t [usertype] be_val hdata/spira.c:625:33: got unsigned char [usertype] fir_bit Signed-off-by: Stewart Smith --- hdata/spira.c | 4 ++-- hdata/test/op920.wsp.dts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hdata/spira.c b/hdata/spira.c index 945cc7e8c50f..dad779fa223d 100644 --- a/hdata/spira.c +++ b/hdata/spira.c @@ -619,13 +619,13 @@ static bool add_xscom_sppcrd(uint64_t xscom_base) if ((csize >= (offsetof(struct sppcrd_chip_info, sw_xstop_fir_bitpos) + 1)) && cinfo->sw_xstop_fir_scom) { - __be32 fir_bit = cinfo->sw_xstop_fir_bitpos; + uint8_t fir_bit = cinfo->sw_xstop_fir_bitpos; if (!dt_find_property(dt_root, "ibm,sw-checkstop-fir")) dt_add_property_cells(dt_root, "ibm,sw-checkstop-fir", be32_to_cpu(cinfo->sw_xstop_fir_scom), - be32_to_cpu(fir_bit)); + fir_bit); } } diff --git a/hdata/test/op920.wsp.dts b/hdata/test/op920.wsp.dts index fbc5a39c8a53..b9aa0f204b3c 100644 --- a/hdata/test/op920.wsp.dts +++ b/hdata/test/op920.wsp.dts @@ -8,7 +8,7 @@ ibm,io-base-loc-code = "UOPWR.7887E6A-Node0"; nest-frequency = <0x0 0x77359400>; vendor = "IBM"; - ibm,sw-checkstop-fir = <0x5012000 0x1f000000>; + ibm,sw-checkstop-fir = <0x5012000 0x1f>; model = "8335-GTH"; system-id = "7887E6A"; model-name = "ibm,witherspoon"; From patchwork Thu Jul 18 06:51:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133551 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4Yp2zfmz9s4Y for ; Thu, 18 Jul 2019 16:51:58 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4Yp1znqzDqQt for ; Thu, 18 Jul 2019 16:51:58 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YC2bFrzDqMw for ; Thu, 18 Jul 2019 16:51:26 +1000 (AEST) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6mMXi115105 for ; Thu, 18 Jul 2019 02:51:24 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com with ESMTP id 2tthu45248-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:24 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x6I6isLO004564 for ; Thu, 18 Jul 2019 06:51:23 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma01wdc.us.ibm.com with ESMTP id 2tq6x6dm2v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 06:51:23 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pN2760162488 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:23 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F34F3BE04F for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC848BE051 for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 8EB0F476575; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:17 +1000 Message-Id: <20190718065117.16923-11-stewart@linux.ibm.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=873 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 10/10] sparse: libstb/container: fix endian type for magic number X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" libstb/container.c:38:28: warning: incorrect type in argument 1 (different base types) libstb/container.c:38:28: expected restricted beint32_t [usertype] be_val libstb/container.c:38:28: got unsigned int [usertype] Signed-off-by: Stewart Smith --- libstb/container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstb/container.c b/libstb/container.c index a720fbbf1e8b..5287c94dda5f 100644 --- a/libstb/container.c +++ b/libstb/container.c @@ -35,7 +35,7 @@ uint32_t stb_payload_magic(const void *buf, size_t size) if (!stb_is_container(buf, size)) return 0; p = (uint8_t*) buf; - return be32_to_cpu(*(uint32_t*)(p+SECURE_BOOT_HEADERS_SIZE)); + return be32_to_cpu(*(be32*)(p+SECURE_BOOT_HEADERS_SIZE)); } uint64_t stb_sw_payload_size(const void *buf, size_t size)