From patchwork Tue Jul 16 20:13:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guilherme G. Piccoli" X-Patchwork-Id: 1132937 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45pBS829rQz9sNf; Wed, 17 Jul 2019 06:14:00 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hnTpk-0005i8-LO; Tue, 16 Jul 2019 20:13:56 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hnTpi-0005hJ-7z for kernel-team@lists.ubuntu.com; Tue, 16 Jul 2019 20:13:54 +0000 Received: from mail-qk1-f197.google.com ([209.85.222.197]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hnTph-0007OP-Nu for kernel-team@lists.ubuntu.com; Tue, 16 Jul 2019 20:13:53 +0000 Received: by mail-qk1-f197.google.com with SMTP id x17so17988718qkf.14 for ; Tue, 16 Jul 2019 13:13:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KZ6Y18zKhNaHshzvP9DbBPku3Hsgxv6d+voqgOVVmUk=; b=plDE0LRniA2RrNLVHefZuurO+ortKWCoSh73Ih1zKOgVpdSandOW1ZNIz4/VoY5J1O 4ArNrFZEzwcdG5RCiR99kanKIYknjX/TbxQ7iLCz9261WvR8dyTqnkT3DkZfOOap0fBo 9JS29V6Za03OsbncFQD1qbDVmcI2HbG0FD3eLAqetIEqTj7qGlbfcEH0frhVbyGjecgf uJFgHh2peABEWuFda0pdlkXugMtYVsyLHjurLYU0hDmth8JZBw1Mtt/wFFE0s2KVR7Lw gfxP1eukaPxn1l2kjaHPav706pDbk2sD9uUfKisPDZh6PwIprTbhtdk4dGfHEk8KpZia q0ug== X-Gm-Message-State: APjAAAVfzT8gEsxTEEGxaYLRF9S5e9EgdTbEYwOcsysd//G8pm4ksCjT 3STQHu57bEQRLcmWjjBnrDQCMm+zKJAT7AJWUVngo1/gPbXy4pAr99SxUcdjI0AgLb61ayWkMxO Zd8Wmfxymys64rhDb/HI5QhIuWbevJ8svI7PXclrVJQ== X-Received: by 2002:a0c:d0fc:: with SMTP id b57mr25621565qvh.78.1563308032667; Tue, 16 Jul 2019 13:13:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8i3qX0q6dhwcjdVsfhRLEoyIMwkje0mcVFGHTKL+dekhQAxSI3bQawZjgEuVi9xEXxuXGtg== X-Received: by 2002:a0c:d0fc:: with SMTP id b57mr25621555qvh.78.1563308032487; Tue, 16 Jul 2019 13:13:52 -0700 (PDT) Received: from localhost (201-42-108-61.dsl.telesp.net.br. [201.42.108.61]) by smtp.gmail.com with ESMTPSA id g2sm8967082qkm.31.2019.07.16.13.13.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2019 13:13:51 -0700 (PDT) From: "Guilherme G. Piccoli" To: kernel-team@lists.ubuntu.com Subject: [SRU X][PATCH 1/1] ixgbevf: Use cached link state instead of re-reading the value for ethtool Date: Tue, 16 Jul 2019 17:13:43 -0300 Message-Id: <20190716201343.29258-3-gpiccoli@canonical.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190716201343.29258-1-gpiccoli@canonical.com> References: <20190716201343.29258-1-gpiccoli@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gpiccoli@canonical.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Alexander Duyck BugLink: https://bugs.launchpad.net/bugs/1836760 Change the ethtool link settings call to just read the cached state out of the adapter structure instead of trying to recheck the value from the PF. Doing this should prevent excessive reading of the mailbox. Signed-off-by: Alexander Duyck Reviewed-by: "Guilherme G. Piccoli" Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher (backported from commit 1e1b0c658d9bb364b4a2a4b08a760d3e4c239bdc) [gpiccoli: * Context adjustment for v4.4. * Changed the patch to use the old ethtool API for get link settings (get_link_ksettings -> get_settings); the new API was introduced in v4.6 by commit 3f1ac7a700d039.] Signed-off-by: Guilherme G. Piccoli Acked-by: Khalid Elmously --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c index 508e72c5f1c2..be788ba75c95 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c +++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c @@ -95,22 +95,16 @@ static int ixgbevf_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd) { struct ixgbevf_adapter *adapter = netdev_priv(netdev); - struct ixgbe_hw *hw = &adapter->hw; - u32 link_speed = 0; - bool link_up; ecmd->supported = SUPPORTED_10000baseT_Full; ecmd->autoneg = AUTONEG_DISABLE; ecmd->transceiver = XCVR_DUMMY1; ecmd->port = -1; - hw->mac.get_link_status = 1; - hw->mac.ops.check_link(hw, &link_speed, &link_up, false); - - if (link_up) { + if (adapter->link_up) { __u32 speed = SPEED_10000; - switch (link_speed) { + switch (adapter->link_speed) { case IXGBE_LINK_SPEED_10GB_FULL: speed = SPEED_10000; break;