From patchwork Tue Jul 16 07:12:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cameron Esfahani via X-Patchwork-Id: 1132465 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=nongnu.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=vmfacility.fr header.i=@vmfacility.fr header.b="Yc8swd+D"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45ns7C1m4Fz9sNC for ; Tue, 16 Jul 2019 17:13:11 +1000 (AEST) Received: from localhost ([::1]:45792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnHe9-000827-Di for incoming@patchwork.ozlabs.org; Tue, 16 Jul 2019 03:13:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42099) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnHe3-00081p-FC for qemu-devel@nongnu.org; Tue, 16 Jul 2019 03:13:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnHe2-0002a7-BE for qemu-devel@nongnu.org; Tue, 16 Jul 2019 03:13:03 -0400 Received: from db04.iswnet.net ([2001:bc8:3515:300::1]:33696 helo=db04.ivansoftware.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnHe1-0002Y2-LE for qemu-devel@nongnu.org; Tue, 16 Jul 2019 03:13:02 -0400 Received: from [IPv6:2a01:cb19:678:2500:a19f:fa99:4164:d7d5] (unknown [IPv6:2a01:cb19:678:2500:a19f:fa99:4164:d7d5]) by db04.ivansoftware.com (Postfix) with ESMTPSA id BF4F8BE1452 for ; Tue, 16 Jul 2019 09:12:55 +0200 (CEST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.101.2 at db04 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=vmfacility.fr; s=mail; t=1563261175; bh=NXSusU2bqYSrBTf/SepfMAUhtFVV0yrUINAPs1fSnDo=; h=To:From:Subject:Date:From; b=Yc8swd+DzJfzBRb+2vpRnvp9DCbo5mukOxxWFaI6HfHFh1G38QdQQrNRCXC13FKvT xJ9QN0Opk5LSNJO0G7FqLkgNfnfGeCP0fDg6QGgSCC64aYorvNEQBurGpV/kepV779 lf7lnAtfkTX2ewTLSgqVDob6RtUQNyl36sdtVsv7OcimdHa8drMLIRaSBIhVCuZxsM 422Hr7Dv62Bs24BUXRGONyfbA+i8980ziuYXV0TwS9TGSxaQ2t/Jn8j1v3z9zZoPIJ C/IeIG8nvpFReYPp5BHZWuEwIhv/yqzU0cqkklnheWyoASCiK0ziyvFzEBh+6+cjCM UHabmhM3CdhJA== To: qemu-devel@nongnu.org Message-ID: <4791ac27-8a85-7d08-85a6-193a988f60be@vmfacility.fr> Date: Tue, 16 Jul 2019 09:12:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:bc8:3515:300::1 Subject: [Qemu-devel] TCG - Allow bit 15 to 1 for slbmfee and slbmfev X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Ivan Warren via Qemu-devel From: Cameron Esfahani via Reply-To: Ivan Warren Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" All, Submitting proposal : Per Power ISA 3.02B Book III at pages 1029 and 1030, bit 15 of the slbmfee and slbmfev instructions is now assigned to an implementation specific bit and is no longer reserved - meaning it can be set to 1 but can probably be safely ignored. 2.07B still indicates bit 15 is reserved but some non Linux Operating system's debugger DO set this bit to 1 (so it was probably valid yet not documented for Power 7/8). Therefore I propose : PPC_SEGMENT_64B), +GEN_HANDLER2(slbmfev, "slbmfev", 0x1F, 0x13, 0x1A, 0x001E0001, PPC_SEGMENT_64B),  GEN_HANDLER2(slbfee_, "slbfee.", 0x1F, 0x13, 0x1E, 0x001F0000, PPC_SEGMENT_64B),  #endif  GEN_HANDLER(tlbia, 0x1F, 0x12, 0x0B, 0x03FFFC01, PPC_MEM_TLBIA), PS : This patch is not mine, but gleaned from "Zhuowei Zhang" (no known e-mail address). I am just attempting to have it validated. diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 4a5de28036..85f8b147ba 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7064,8 +7064,8 @@ GEN_HANDLER2(mtsr_64b, "mtsr", 0x1F, 0x12, 0x06, 0x0010F801, PPC_SEGMENT_64B),  GEN_HANDLER2(mtsrin_64b, "mtsrin", 0x1F, 0x12, 0x07, 0x001F0001,               PPC_SEGMENT_64B),  GEN_HANDLER2(slbmte, "slbmte", 0x1F, 0x12, 0x0C, 0x001F0001, PPC_SEGMENT_64B), -GEN_HANDLER2(slbmfee, "slbmfee", 0x1F, 0x13, 0x1C, 0x001F0001, PPC_SEGMENT_64B), -GEN_HANDLER2(slbmfev, "slbmfev", 0x1F, 0x13, 0x1A, 0x001F0001, PPC_SEGMENT_64B), +GEN_HANDLER2(slbmfee, "slbmfee", 0x1F, 0x13, 0x1C, 0x001E0001,