From patchwork Thu Jun 27 17:34:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123528 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cY5DlXyQ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZRqV3P7Wz9sCJ for ; Fri, 28 Jun 2019 03:35:02 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbfF0Re7 (ORCPT ); Thu, 27 Jun 2019 13:34:59 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:38544 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbfF0Re6 (ORCPT ); Thu, 27 Jun 2019 13:34:58 -0400 Received: by mail-pf1-f194.google.com with SMTP id y15so1581620pfn.5; Thu, 27 Jun 2019 10:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=5SQb1rM39meuBB6kZ01b1gP2wTIZb8uQPRv3lqA/cvA=; b=cY5DlXyQ+i0vhpdExXlsOUtFFIO16il000fSXYrPn2u0s7GeRJUhWpHvmoUiM3LiX+ dHH/gjqmdWDBW2Qo/dZYgEG4Q+MFV8oU4ZtAItun2i547Hg5I2RRb2juwL5pVjhKQFps 8+M4lIcmQP5yx5oiGC0efgdIb2CZJFzEwY4R7vx1LEBiP8qaKxDRJrVoLF+TLrYYyLQi oVCu5Yzno/5m9E+2IA+g1OGxCrx9P2kd2EycBozkh/G0MC9UPlWBMGg9SR6p9zQ4Ce8I apkzuUJ7rbmF2Smv4k/JhGVpdta2me5N677FpM+wmwOJnkZh3EeRCsawk9uAuy6FqBjj +Exw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5SQb1rM39meuBB6kZ01b1gP2wTIZb8uQPRv3lqA/cvA=; b=A/3Hf0UwCuXXhjEHagkFkGOJ2ZhaHr5xnTBVMYNDUq5SeM2gAmfv3eGGaixZE/kcPe 99g9WXl/dmfqQToWq/A4PZ7RADddbzZyocfoBMhRV0PFvnNeRR2xehWeQ6iyulDmTraP X9+9ZB4QofqwQJQx2lFY0w79Tfow3AWoMXoC0qXzzj16bmYLY77wY5FPg5ga5NHavIi1 kJW6p1trO69SNBjqjchwd+KQXYLYzyYNSnwNm/9v5r+FIcAjWD943Ji+Re5kp7HADYiB DbsBUxBar273HcRBNdkIdFNz9oXGq4zXXuF+N19wRWnpaNRn65I9MuiUxLYM4Obw2QyQ HgvQ== X-Gm-Message-State: APjAAAWoeBLTS+kuwUcJ4EQj4AQQl0WuXUriou19hD4w9KKt4AQnTqEL PdRyTSZToU9VkdMu4ofDEQxiwKt2AzQ= X-Google-Smtp-Source: APXvYqwvrvA6qwgW7DKHNtt68qgVGeHRp0MZ8M5wwwO2Zvvu09444JQq2IIE9hv3tCfJDP2UxVG2rQ== X-Received: by 2002:a63:ed13:: with SMTP id d19mr4845247pgi.100.1561656898277; Thu, 27 Jun 2019 10:34:58 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id y23sm5623700pfo.106.2019.06.27.10.34.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:34:57 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Chas Williams <3chas3@gmail.com>, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/87] atm: idt77252: Remove call to memset after dma_alloc_coherent Date: Fri, 28 Jun 2019 01:34:51 +0800 Message-Id: <20190627173451.2245-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/atm/idt77252.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index 43a14579e80e..df51680e8931 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -1379,7 +1379,6 @@ init_tsq(struct idt77252_dev *card) printk("%s: can't allocate TSQ.\n", card->name); return -1; } - memset(card->tsq.base, 0, TSQSIZE); card->tsq.last = card->tsq.base + TSQ_NUM_ENTRIES - 1; card->tsq.next = card->tsq.last; From patchwork Thu Jun 27 17:39:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123537 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="W/NkPAnc"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZRwY0CF2z9sCJ for ; Fri, 28 Jun 2019 03:39:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbfF0RjW (ORCPT ); Thu, 27 Jun 2019 13:39:22 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:37153 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726508AbfF0RjW (ORCPT ); Thu, 27 Jun 2019 13:39:22 -0400 Received: by mail-pf1-f195.google.com with SMTP id 19so1588586pfa.4; Thu, 27 Jun 2019 10:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=auhF84ioTrGwSpXvPc/29XrrTlTYdcPUHf41o0X+QVA=; b=W/NkPAncjOCMCPyC6MpjNe7fQ/ULUM1JcGoACJN9zrqBIzha/iP+HStc8z8VSrNVnF u64rwkD8FO1iIEEbzKEyWRMiMl0Ia/efR1Dy05vTDnPZq0fN5Cxr4N5cc+Il6Qu/XSrk qJvhBeUS7wHWet+AZr5Bj1epRN7yeLC1EPZ+V2gNn762NErQFQxXJ7XQHDQ6YHHmt1QH gmgkJSw5XoeayLKHutVdvjK9bu7kH8S4rPyskNFEJ1oJj+gJB4sUvPjsiZzKxfZhT1Li DA9GdokDyRYkRlPTZiWLijy9KlqwT76r4A6uvEeDsXpw4ES86vQBk1sLakayP3NRCeqQ UZog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=auhF84ioTrGwSpXvPc/29XrrTlTYdcPUHf41o0X+QVA=; b=sntYSSqvjwboKYSv+AkPAuut2ocbInODUAaFjBSzHl/2TvRWYDsdzevIywHAP02IG3 HuLtykGFO9FZaeus1TJ/TXeBuyx+0YBytB7uqin4nW9S2jxmjOxNnBWAJpiWMqC727Yq pb1hvMj+kGqAlKTjMMJgkHlScdf4ZpXJkUfclmTlSwiAwoHXtd+88omz7kXMOl4VKiuD RVbujhLGvlkO49K1gxWmZcdYzWuX09DInin4SVLxJMgO+OU8egq63PnGBJ+xLzQtBrF+ qFaOlBDQqISo+BLzcQ4iN8ay42jQ1mV8AYp+In7w+TGHmClVIiZrXfWt/O2pJIl3+Cuv 0C1Q== X-Gm-Message-State: APjAAAU7jAZqWDe/dV/V8XoXZ2+rFhY6VQ4PU9vHk8VOAcciwIXpaYOC MZMhZziVHNST5kQpuVfmZy4= X-Google-Smtp-Source: APXvYqxq2x55to6zcMrwiyt0+tQ5rLXtq0cpx2NGlrkySpS86CLSlx7SB6xi/XXqarqsYg7gsTwzcQ== X-Received: by 2002:a63:c006:: with SMTP id h6mr4725873pgg.285.1561657161470; Thu, 27 Jun 2019 10:39:21 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id m20sm5758388pjn.16.2019.06.27.10.39.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:39:21 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 36/87] net: eql.c: replace kmalloc and memset with kzalloc Date: Fri, 28 Jun 2019 01:39:14 +0800 Message-Id: <20190627173916.3729-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org kmalloc + memset(0) -> kzalloc Signed-off-by: Fuqian Huang --- drivers/net/eql.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/eql.c b/drivers/net/eql.c index 74263f8efe1a..2f101a6036e6 100644 --- a/drivers/net/eql.c +++ b/drivers/net/eql.c @@ -419,14 +419,13 @@ static int eql_enslave(struct net_device *master_dev, slaving_request_t __user * if ((master_dev->flags & IFF_UP) == IFF_UP) { /* slave is not a master & not already a slave: */ if (!eql_is_master(slave_dev) && !eql_is_slave(slave_dev)) { - slave_t *s = kmalloc(sizeof(*s), GFP_KERNEL); + slave_t *s = kzalloc(sizeof(*s), GFP_KERNEL); equalizer_t *eql = netdev_priv(master_dev); int ret; if (!s) return -ENOMEM; - memset(s, 0, sizeof(*s)); s->dev = slave_dev; s->priority = srq.priority; s->priority_bps = srq.priority; From patchwork Thu Jun 27 17:39:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123538 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PT45Lu6o"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZRwm4QTWz9sN6 for ; Fri, 28 Jun 2019 03:39:36 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727089AbfF0Rjd (ORCPT ); Thu, 27 Jun 2019 13:39:33 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:42352 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726508AbfF0Rjc (ORCPT ); Thu, 27 Jun 2019 13:39:32 -0400 Received: by mail-pg1-f194.google.com with SMTP id k13so1332951pgq.9; Thu, 27 Jun 2019 10:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=2kq4qqQIO8L6xHtZAgwES+mymmw0wgMAnnlfW7U7BZI=; b=PT45Lu6o796+IjEYC0wtX8I6f0iR+Qa+0pHCRRuz8v4i/XjVTAInbbJZ8oLLP9dHkC n9nT++v6fN5vpsJGfcxv0SLT/8t9rZTrsgDm7q/3XRl/Ia2DbsExiLcp4fZmRDrGNnqo FMYEPLgaaxg4/aRbjD5AziNLJUXcH+c44GETv6S7e4/xc7dCtC2Kq0HKFcIQEIdRPBho +tywostlOW/7MxPdSO2lr3GrbUI35Ln+kVjVIGTt4RpRllGT9mAprtVmLuSnNwc3OFaw jvCr3euxvSCXQIl1KS3+OhDmCv7IDJk+KFUoOnNZlmdtURG7HXJnjbIDf6ewDpRrnxHA x8kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2kq4qqQIO8L6xHtZAgwES+mymmw0wgMAnnlfW7U7BZI=; b=eJ8DpCL8ADGsihKT/Oj2YyB4cdhNl+qGohPi/qEWSJXr3+TC4VgYtNBjuriCAUtWZ7 /uEXD1pKFR0w1PO1OBm4hdherAZir62qyFUEeGiiKdD/xopdluzpOsXKZy2SK/QQmIsl d1WktuAzotb8tDFxzBDgEXBlFeZn8YMUx45FlstxgdP0tik0AN9TfXQPVYdnBs+5fgUf aXsLmPp+qQBwS/a4e0EuweVz1FcWv+MLZUvIjvp4ZKK3U6jNRAPAApW5S/NMti8e7H+s L7VJ2YvqSeQzjDRfpEsaqF0XKAbOD/LodJ7vaz+4m4VqEMS+Grf/qkLOpWejCwT0wqTh DQRw== X-Gm-Message-State: APjAAAWib75echmw9XG1XvvAd7QourRHyv24U+o3TpZ3ewrYRndMaHs6 kEFguIDHxi/Oo04d3Q+kg4U= X-Google-Smtp-Source: APXvYqzNAVJiKS0MlKW3HGoIIbMl366WJhMaLV6VWr78W39LWMhp7Q53vgH0FObrYvZdZTcdN9pa4A== X-Received: by 2002:a63:fc15:: with SMTP id j21mr4830348pgi.217.1561657171752; Thu, 27 Jun 2019 10:39:31 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id w197sm5035790pfd.41.2019.06.27.10.39.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:39:31 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Jay Cliburn , Chris Snook , "David S. Miller" , Michael Ellerman , Allison Randal , YueHaibing , Will Deacon , Thomas Gleixner , zhong jiang , Yang Wei , Colin Ian King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 37/87] ethernet: atlx: remove memset after pci_alloc_consistent in atl1.c Date: Fri, 28 Jun 2019 01:39:22 +0800 Message-Id: <20190627173924.3783-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org pci_alloc_consistent calls dma_alloc_coherent directly. In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/ethernet/atheros/atlx/atl1.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index 7c767ce9aafa..b5c6dc914720 100644 --- a/drivers/net/ethernet/atheros/atlx/atl1.c +++ b/drivers/net/ethernet/atheros/atlx/atl1.c @@ -1060,8 +1060,6 @@ static s32 atl1_setup_ring_resources(struct atl1_adapter *adapter) goto err_nomem; } - memset(ring_header->desc, 0, ring_header->size); - /* init TPD ring */ tpd_ring->dma = ring_header->dma; offset = (tpd_ring->dma & 0x7) ? (8 - (ring_header->dma & 0x7)) : 0; From patchwork Thu Jun 27 17:40:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123541 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Aq1KMHWJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZRyG6p9Qz9sCJ for ; Fri, 28 Jun 2019 03:40:54 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727051AbfF0Rkv (ORCPT ); Thu, 27 Jun 2019 13:40:51 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:37557 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726759AbfF0Rkv (ORCPT ); Thu, 27 Jun 2019 13:40:51 -0400 Received: by mail-pg1-f195.google.com with SMTP id 25so1344197pgy.4; Thu, 27 Jun 2019 10:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=t46mtjbtI3kfKQtCDE30bMwLgnekms1c5N/WXLRHQCM=; b=Aq1KMHWJHzmkqUp/kisIB0tLK4uQnRYkLDW/KonVJWvyc6GcMMAhseSmCIpRdIdAAZ Adfq5lxDw383Bw1yNCSWEaNJu4guwPQN4x1ffx9jAM9I1OfZ/juIr4tUGXPjg+LyRkU6 pzc2C/If59rU3wumJQorRmUk98tOSyYOFtvwn+73oDlrR0F+w24AEvex3rPRj3X+dwB8 isDfw6l7CgH9uO5LKaAdEezQncZKvgXfHpuKjcw+mfxgBefY6SYAWDb34IAxXPk/kDC4 MRtE9YHOuZrhRCYh0yq3WZROprdPUmCmpc3FpQQHLQjFQ9yhpyd9xGhD1OAJbgFrXgFB RyUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=t46mtjbtI3kfKQtCDE30bMwLgnekms1c5N/WXLRHQCM=; b=VsJiXdIdZ3XFvbBQvRVoi0zS1ZzZ8QYw+bpgGc9iauhQmsylp8gIaCu68X+M1n5qYc tvP9S1eXwKtRAOgf1n++Mz2DoruDPtJC26xp96Errmp7S88WCYmMerCA6x3SfQCPva0c 6BhsSGD6FonHdUrZhfydSOcbL+WnBIaj6seZu5x5TKwNoqDy2hZT3yAJL0dY7e/cqr38 LweX97SLd2s9Lgs+y9XR8t1XJ/cOpSLmMGAH9sUqMWLIxNc1z4mXXrGbvuXZkb/6BVFQ EpyLQoD/vM//6YEGVOsQXTpQmF2duGt79sKLO4IAzadR09o/1Qrw9iv3E7LsycvgXvR2 EwHg== X-Gm-Message-State: APjAAAWujcvFJDFJgySK5FuL5+NF7+DTTKQyBZlhv6XxQCFLvMMOXEkQ uAqpJC7A2QNG7ojn0puXDpc= X-Google-Smtp-Source: APXvYqx5uHL095Y9377Xj6V6dq9bqSsdNQRvILwVJLCBicRDa5beyUZ6jc6HAAsA8JExMVhOk0eEwg== X-Received: by 2002:a65:448b:: with SMTP id l11mr4797285pgq.74.1561657250380; Thu, 27 Jun 2019 10:40:50 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id 125sm5862104pfg.23.2019.06.27.10.40.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:40:49 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Jay Cliburn , Chris Snook , "David S. Miller" , Colin Ian King , Yang Wei , Allison Randal , Thomas Gleixner , Will Deacon , Mao Wenan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 38/87] ethernet: atlx: remove memset after pci_alloc_consistent in atl2.c Date: Fri, 28 Jun 2019 01:40:39 +0800 Message-Id: <20190627174040.4180-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org pci_alloc_consitent calls dma_alloc_coherent directly. In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/ethernet/atheros/atlx/atl2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c index 3a3fb5ce0fee..3aba38322717 100644 --- a/drivers/net/ethernet/atheros/atlx/atl2.c +++ b/drivers/net/ethernet/atheros/atlx/atl2.c @@ -291,7 +291,6 @@ static s32 atl2_setup_ring_resources(struct atl2_adapter *adapter) &adapter->ring_dma); if (!adapter->ring_vir_addr) return -ENOMEM; - memset(adapter->ring_vir_addr, 0, adapter->ring_size); /* Init TXD Ring */ adapter->txd_dma = adapter->ring_dma ; From patchwork Thu Jun 27 17:39:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123539 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XC4usCiL"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZRx452HJz9sCJ for ; Fri, 28 Jun 2019 03:39:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726706AbfF0Rjt (ORCPT ); Thu, 27 Jun 2019 13:39:49 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43201 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726508AbfF0Rjt (ORCPT ); Thu, 27 Jun 2019 13:39:49 -0400 Received: by mail-pg1-f196.google.com with SMTP id f25so1331763pgv.10; Thu, 27 Jun 2019 10:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=D32Ks5Fu7pyXBdYyciPpR5394J9zDQfs4fNW75Cd110=; b=XC4usCiLGHHdATHVUaFTzr5JEBLk/yeZisSfEhY1ayH7hLjyksJAjpW3ieT9Oo3iBr d+7/MdVHw1eueGnDmLsz8uJfDltaotexrMweqM7c+vhtYaYB2tmV4ps7R2cLN1Vil9uL yaO3YEVcb1PdWOctqZULRuLnAAM7ozJqo9u2NiqHTqYMFxmEcjGb09P45L30ajwJ2gLK fJ2rwya3nmjU27LHvkDJiJnXj0agM11Ilv2cVUuL56XSRy/edyx56t7P1pQTyVVCbaXu IfJC1Vvj5ZUolzSFLxdbgJQv0/uk7/5z8Dp7yZb6uGSsk22GKAfEYp/OR1NfDgIb4OZr W4oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=D32Ks5Fu7pyXBdYyciPpR5394J9zDQfs4fNW75Cd110=; b=mU1nkSfcksR02k9Fy6vVEQJa2uzC4nwHvIxX3dN0cx4M2BMTEyj/qfN1i8mOY/jEot JXvltnOT3fQflJsFn0W69qPu9o3tx8MJtAFiP4IF8ewRbej+PCJANT+yMDuKivqG6rBc FKBqKol/pKxYC9NQGfsnjImTLHTOeYNH2gi+YxFZ2uZ7S71fBkwrE6+D3528wbe6wAtm LYRbhTMckLtl7zGw3ynxyeVcNawZumD9dCJUKZBHb4E72q30akUVQyXSZsgY5U5iKtjJ 2aXpLIdvL0TaoNW2cJGI7Cg9w+qzuNz1uMZWzodSsjeU8hMCJGFfnio9Fa6W8EKZyhWC ywrg== X-Gm-Message-State: APjAAAUMHJsq6AWAMCjpzLB6WKZ6mIDpF/IHzLS//E2gCdXyBcjDyNpj 7jUgZYLFNh+vi48+ZNniVqE= X-Google-Smtp-Source: APXvYqy0icc/gOqP71bSCfkc1bgCphFNkt0hHXEaL8fKlmRyT9MTAissL3cxIzHMI+v9G5/zx3sgRw== X-Received: by 2002:a17:90a:a008:: with SMTP id q8mr7508898pjp.114.1561657188590; Thu, 27 Jun 2019 10:39:48 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id k14sm7003844pfg.6.2019.06.27.10.39.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:39:48 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Michael Chan , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 39/87] ethernet: bnxt: remove memset after dma_alloc_coherent Date: Fri, 28 Jun 2019 01:39:42 +0800 Message-Id: <20190627173942.3891-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index f758b2e0591f..1a51edb7de37 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -2622,8 +2622,6 @@ static int bnxt_alloc_tx_rings(struct bnxt *bp) mapping = txr->tx_push_mapping + sizeof(struct tx_push_bd); txr->data_mapping = cpu_to_le64(mapping); - - memset(txr->tx_push, 0, sizeof(struct tx_push_bd)); } qidx = bp->tc_to_qidx[j]; ring->queue_id = bp->q_info[qidx].queue_id; From patchwork Thu Jun 27 17:39:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123540 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DFjSpVI+"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZRxL6mmSz9sN6 for ; Fri, 28 Jun 2019 03:40:06 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbfF0RkD (ORCPT ); Thu, 27 Jun 2019 13:40:03 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:33983 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726508AbfF0RkC (ORCPT ); Thu, 27 Jun 2019 13:40:02 -0400 Received: by mail-pf1-f196.google.com with SMTP id c85so1596068pfc.1; Thu, 27 Jun 2019 10:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=sTaNIRgFBqMQPDw0TPcpG7R1iaHcLwdE4qgc0/lS9Dk=; b=DFjSpVI+QyiqRRwnKxUVzTbhIPMReAv5xG9MDT2+gqDowmz/pv9J/9oe/9ATvtWKm2 CFWmBbLxSHh7rUj6QzUdDcYhBXL92prABGBWr0MiwWyx/+SpdnGZCQiMjZQYc9Hw7j7s /L0RBB5JX8rO2YKrg6a736ylnh3i9J4BLG0CR80tAP2vX9KuyXa6fWH6TemWm1B6yaR6 HrK3EftUi2rsPEEe0PLz9p/HLeo34KgGhDGEqXE7VI1YBjTH+4QTc7l2OY1kkFK/Rpc5 R4ewKRt0BsitJzky/9+gdzN+gm+zSZBgdF51GrgUqfs5z3xMpg0/t9fLrynE+WG1k4KZ Ak0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sTaNIRgFBqMQPDw0TPcpG7R1iaHcLwdE4qgc0/lS9Dk=; b=FA61a+PZgqcilzNjLePq/hqQmgHXiuq0Me5wntfy5gFod3lVNYeS2It1XnaNKZCaoD nPJcgY5+g+vAuDFMi5QXTpGfIpabBCbvnXYmG5c2+Gpy6qTVl5USYzfTPBDWWcpEN7ym bUBPEfWKb+VTE3Knd1YK5IFSxA+d9lT/eFXKf4NswMKuiZsYplmpDG1IYNKFyeySNuDE v2Ke7uaLkKigHdU86US1O1Ki8WX9O9Ss0q5GRPg8lHOApqTrn1N1D8tX1vXM/QrA/3kK QNvHWVnjv4TYyFnoqVqwsGrqKg9xwZvErEQKY5cSKG4utLWMucQWgwluqVhNZ7xwA5Ix 3NhA== X-Gm-Message-State: APjAAAWD+xr129v0FPy8NHLM5jN/wxfKMQVdeKU4TIcIcIN04R05iPYD TxupCaZ6E1G3ubbNHFzbc5M= X-Google-Smtp-Source: APXvYqyv44uwLwZ85+ZWtuNVuMXPbhhpAeuFG0N8jYFYoehGCLNQEDxGQjrXZnFlRHg6p3HAlO3XUw== X-Received: by 2002:a63:d0:: with SMTP id 199mr4884238pga.85.1561657201964; Thu, 27 Jun 2019 10:40:01 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id n89sm11449259pjc.0.2019.06.27.10.39.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:40:01 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Derek Chickles , Satanand Burla , Felix Manlunas , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 40/87] ethernet: cavium: replace vmalloc and memset with vzalloc Date: Fri, 28 Jun 2019 01:39:54 +0800 Message-Id: <20190627173954.3943-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org vmalloc + memset(0) -> vzalloc Signed-off-by: Fuqian Huang --- drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c | 4 +--- drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c index 43d11c38b38a..cf3835da32c8 100644 --- a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c +++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c @@ -719,12 +719,10 @@ static int cn23xx_setup_pf_mbox(struct octeon_device *oct) for (i = 0; i < oct->sriov_info.max_vfs; i++) { q_no = i * oct->sriov_info.rings_per_vf; - mbox = vmalloc(sizeof(*mbox)); + mbox = vzalloc(sizeof(*mbox)); if (!mbox) goto free_mbox; - memset(mbox, 0, sizeof(struct octeon_mbox)); - spin_lock_init(&mbox->lock); mbox->oct_dev = oct; diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c index fda49404968c..b3bd2767d3dd 100644 --- a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c +++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c @@ -279,12 +279,10 @@ static int cn23xx_setup_vf_mbox(struct octeon_device *oct) { struct octeon_mbox *mbox = NULL; - mbox = vmalloc(sizeof(*mbox)); + mbox = vzalloc(sizeof(*mbox)); if (!mbox) return 1; - memset(mbox, 0, sizeof(struct octeon_mbox)); - spin_lock_init(&mbox->lock); mbox->oct_dev = oct; From patchwork Thu Jun 27 17:44:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123550 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gUjwxsbO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZS335Ty0z9sNC for ; Fri, 28 Jun 2019 03:45:03 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727281AbfF0Ro7 (ORCPT ); Thu, 27 Jun 2019 13:44:59 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:45901 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbfF0Ro7 (ORCPT ); Thu, 27 Jun 2019 13:44:59 -0400 Received: by mail-pf1-f193.google.com with SMTP id r1so1573884pfq.12; Thu, 27 Jun 2019 10:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tvqfJ6sX8D7AhhMMl5NxvQNNf+P9Cj0Mf8VtEYuVHhQ=; b=gUjwxsbOj9zF11K7N2R6GJLoQRzHvOnguFn3pNwGITkghwiyNN0zIRbAtDW2WkecSf 4pi7X/GVsqF3s0T2puRY04GX1/ywOnu25k0cfbbLfhcS6jSLwTyon94ISWAuY3rabZwP QP+9hYCdAmXMHIhcq1xCOillujpLQTyyRVzqz35ujxm0lGjRuatCLSzGXKfmaRz4JA5U eVT5+yanaDw0RKeFUYNnviOG3j/opfkY0wHcGR1bKSOvNlUwRVwmPJdYc0cNhMlNSDOt Ia6sAvQZi3ysH1oDcxyXeubfV6vQc09Vky4+JWjicAz+QJh4LhsEZj4uo+eE+hfgzgnv azgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tvqfJ6sX8D7AhhMMl5NxvQNNf+P9Cj0Mf8VtEYuVHhQ=; b=UbhI284BNYUevnk6xAYs7CCEx1OEnFOSEnOiSgAx7flTY3S0pNMVjMKyr1UFwK+w+i 7k4rLjgSw0bi3WMpKO55uImc+OSQYbK+G0VZKongmaASkxMJVnWDF3Gicp92aUnQQLjT xAJt/v7MTy7ntEk0/m5MymodWVkqYTMjim6K4ImvrufgvtU0fCP9SzQsdiZbA1SRZa86 Tj4JuI5SFcgxDIf4Sb6o9OY9v7G2qtEMLOx2fBItGEOCM6LD1VAOhMsbob0HpTso6xRD ogv31gKsLsX0vkUWRBXposyy6JUS6PcNmU8pJXTEbJotuF9WFt+r6doWxGlBk2tJ+vU7 J3AQ== X-Gm-Message-State: APjAAAXmJzwxbfCJuWH/mGYHZAjAp06VmgNsdNUsMKs+vOGgVPPYQrha QFfgTB66N7hToNHoF3dzxGE= X-Google-Smtp-Source: APXvYqxd3uhbhjziogjO38CMBomnNt4EgzdyAvQ6S0A9xaoofmauURFi7CpA5qEzERhB5NmWnU2E5w== X-Received: by 2002:a63:fa4e:: with SMTP id g14mr4858876pgk.237.1561657498253; Thu, 27 Jun 2019 10:44:58 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id k4sm5202626pju.14.2019.06.27.10.44.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:44:57 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Jes Sorensen , "David S. Miller" , linux-hippi@sunsite.dk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 80/87] net: hippi: remove memset after pci_alloc_consistent Date: Fri, 28 Jun 2019 01:44:51 +0800 Message-Id: <20190627174452.5677-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org pci_alloc_consistent calls dma_alloc_coherent directly. In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang Acked-by: Jes Sorensen --- drivers/net/hippi/rrunner.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c index 7b9350dbebdd..2a6ec5394966 100644 --- a/drivers/net/hippi/rrunner.c +++ b/drivers/net/hippi/rrunner.c @@ -1196,7 +1196,6 @@ static int rr_open(struct net_device *dev) goto error; } rrpriv->rx_ctrl_dma = dma_addr; - memset(rrpriv->rx_ctrl, 0, 256*sizeof(struct ring_ctrl)); rrpriv->info = pci_alloc_consistent(pdev, sizeof(struct rr_info), &dma_addr); @@ -1205,7 +1204,6 @@ static int rr_open(struct net_device *dev) goto error; } rrpriv->info_dma = dma_addr; - memset(rrpriv->info, 0, sizeof(struct rr_info)); wmb(); spin_lock_irqsave(&rrpriv->lock, flags); From patchwork Thu Jun 27 17:44:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123549 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DlfmlTST"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZS2k6rTQz9sNd for ; Fri, 28 Jun 2019 03:44:46 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727147AbfF0Roi (ORCPT ); Thu, 27 Jun 2019 13:44:38 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35344 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbfF0Roi (ORCPT ); Thu, 27 Jun 2019 13:44:38 -0400 Received: by mail-pg1-f196.google.com with SMTP id s27so1351069pgl.2; Thu, 27 Jun 2019 10:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=PtfqAXXMltfoj6Igz7UOOQYqClcuoNbrMp0Bhkaqno4=; b=DlfmlTST6sqIfIinqRfcF2zB9jfE891HNZPZsvR1ey3QB6Dfk/mdZ8vU5bjIwU+6Ra FM4fXK7lt65CDDvpCWhcXU9vEA4gTopRoYdZSYqtCugcQ+KrCLW6XqVAKSlkwaxFzfrA ie5dz8xBqSEbdXO60IjGBprZSBhSzvQUioQYZ/PXRla47wzhRVBFyPG9F/tu7nM281QY HrCgpvaXgGe+j9355B7PKUEVVzrEEdUrXujVXJbfJEb/0n9I/BBSd490rdRr+N63gQa7 x1dOsUuiVMSwpZWAu0hfEw8s/q3KYQUvUmBZKA4/p+dPzNs85vM7++nrWVqyTJSxmu6v 5dUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PtfqAXXMltfoj6Igz7UOOQYqClcuoNbrMp0Bhkaqno4=; b=DLOthQ9k+F5yUK4IadDZeUSXdt+xQKcJ8ePUSOzo3RTSlnDlKYS/KR4nDbTK5oebGy Nvvqgy93oVzxn6B6xMJrfOmUAxDDrzzWyOSoKOTZRIDiFpxGz9hTBbDvyvNIBgDSRY62 g5NHLauyZAn9cbQGZTd56R4/UaEx5HMHdikXVcpsz7wi/ZlJr7cGZdLDITq/wkrLI3Q5 JSF8dxR47Vv8MLy0IMgAHUkjXdGW3sT0WmvFHRNtxLQGEh4oDXn38P8oklRp07FITONb 4gNIeo5k47Bnjc+0oH+ZUDJiwTjKFHn71MWjBriVpOosPl3aCsaJxqctysHRZDmgEWwI gPLQ== X-Gm-Message-State: APjAAAXwJnCAbVJrLKgbA5ZKEviWJDExbRWXO5LMPZZ6CV8NohCFvkeC Wckx6mG1RcfWoK8KrqVOdSE= X-Google-Smtp-Source: APXvYqx0qZ4ZB+Wax69nqnmA4cYiq4w1swsiezFvMGCG+qooBP6X/PieJQALlCqMiRGtvP/jp4KtBQ== X-Received: by 2002:a17:90a:de02:: with SMTP id m2mr7473343pjv.18.1561657477466; Thu, 27 Jun 2019 10:44:37 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id z22sm2266366pgu.28.2019.06.27.10.44.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:44:37 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Samuel Chessman , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 81/87] ethernet: ti: remove memset after pci_alloc_persistent Date: Fri, 28 Jun 2019 01:44:29 +0800 Message-Id: <20190627174429.5565-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org pci_alloc_persistent calls dma_alloc_coherent directly. In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/ethernet/ti/tlan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index b4ab1a5f6cd0..78f0f2d59e22 100644 --- a/drivers/net/ethernet/ti/tlan.c +++ b/drivers/net/ethernet/ti/tlan.c @@ -855,7 +855,6 @@ static int tlan_init(struct net_device *dev) dev->name); return -ENOMEM; } - memset(priv->dma_storage, 0, dma_size); priv->rx_list = (struct tlan_list *) ALIGN((unsigned long)priv->dma_storage, 8); priv->rx_list_dma = ALIGN(priv->dma_storage_dma, 8); From patchwork Thu Jun 27 17:44:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123548 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GO/fnGWQ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZS2K0k5Vz9sNC for ; Fri, 28 Jun 2019 03:44:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727224AbfF0RoV (ORCPT ); Thu, 27 Jun 2019 13:44:21 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:43548 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726961AbfF0RoU (ORCPT ); Thu, 27 Jun 2019 13:44:20 -0400 Received: by mail-pg1-f194.google.com with SMTP id f25so1336914pgv.10; Thu, 27 Jun 2019 10:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=jTEpnDLcJgOgMeNGqNa8r3yAUVyGipHsMFib578GHIM=; b=GO/fnGWQJZ9eBKz+jiSVxT3PzpO3nUo8WbF7XRHHP15WyaBEQpcR7qPFB2vOMcU3As NnaF5+EuAen9WSupT3Lk2YuPgZEOKP1EtA7C4Z8e2Kq0Zh4pOFuxTs9QWLTggnJJwjBv mYH4Pkcyb4lnBuZynDdti+MgBPMszSahByWOem3dzdjSpLbP4F1FMjjoKozbe9xhs1Xj /V0eCeqfF9dr0VXTyx8ubgKWaP/9dajHbGh8iMLUhEa4T9VZd1G+tVdtkvjqcuEqXku2 saEpotKA4iwR/y3oGHTpZYMEdKGx09Pute+n9JHNot2rjvTYhoG5YvhrYGDJaSRLsPep kLaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jTEpnDLcJgOgMeNGqNa8r3yAUVyGipHsMFib578GHIM=; b=MLHfhh+A0J3vFMxE/yKr0IEFW7b6g/D/0/xeeTpGzC41E4KLefOW3VnuD5yTI46WwP swRJQsbI14IjQjRqhRRaziJyded5BuSYIHcP0kpDrHl4+q1PFWRMy9mgD026fn+meCSO lXyv+lHEKd8LEZVQmh7+YpuSs8UJasl9VVP6UQo688smb8mJdyLAzRsAWbs5mD6uNn6/ vNRc0ipjBXFYhO8Zb2ojvYpZ57E/UjcXEclNnrXnHUVdnU31USOjnLmxAbzOyYyi9tDZ fgu1W7Mf0/lGG3ryOri9frZ3yFGNLkvvPY8jBw+0eSpJWMAgnz1U/5oSIeLDTYMvg+Hl WYow== X-Gm-Message-State: APjAAAX1blcXYQMh4XQfjWI4+XDT06UpKSvrjyIquOAU7K8oJC6en+UL iWLZ0SJNxDYSYpAJK6QSjRsHa3P9wdBiHQ== X-Google-Smtp-Source: APXvYqwZ4n5gMkO5mN+hcC9u5z1H8ijW4j1IVjgz149vY7alsqnjYZjyo3t2zRROvqsKy45x+IZYeg== X-Received: by 2002:a63:1d5:: with SMTP id 204mr5013007pgb.207.1561657459905; Thu, 27 Jun 2019 10:44:19 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id x128sm5280391pfd.17.2019.06.27.10.44.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:44:19 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Manish Chopra , Rahul Verma , GR-Linux-NIC-Dev@marvell.com, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 82/87] ethernet: netxen: remove memset after pci_alloc_persistent Date: Fri, 28 Jun 2019 01:44:13 +0800 Message-Id: <20190627174413.5413-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org pci_alloc_persistent calls dma_alloc_coherent directly. In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c index 433052f734ed..5e9f8ee99800 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c @@ -442,10 +442,8 @@ nx_fw_cmd_create_tx_ctx(struct netxen_adapter *adapter) goto out_free_rq; } - memset(rq_addr, 0, rq_size); prq = rq_addr; - memset(rsp_addr, 0, rsp_size); prsp = rsp_addr; prq->host_rsp_dma_addr = cpu_to_le64(rsp_phys_addr); @@ -755,7 +753,6 @@ int netxen_alloc_hw_resources(struct netxen_adapter *adapter) return -ENOMEM; } - memset(addr, 0, sizeof(struct netxen_ring_ctx)); recv_ctx->hwctx = addr; recv_ctx->hwctx->ctx_id = cpu_to_le32(port); recv_ctx->hwctx->cmd_consumer_offset = From patchwork Thu Jun 27 17:43:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123547 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kZoUqFcy"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZS292bR8z9s8m for ; Fri, 28 Jun 2019 03:44:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727192AbfF0RoK (ORCPT ); Thu, 27 Jun 2019 13:44:10 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:34913 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbfF0RoH (ORCPT ); Thu, 27 Jun 2019 13:44:07 -0400 Received: by mail-pl1-f195.google.com with SMTP id w24so1686746plp.2; Thu, 27 Jun 2019 10:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=l9lSV6b1ipoXEd8WKJZw54y2LcR9Ww5Z/zUwt9y3Dvc=; b=kZoUqFcyjJwLpQIyLIf/9ykIHAeZ0vMBfUW75BfZMqMC+MLZGTDX+2Njm81xFWisUs jA2Ss2K/eoNGiU3M6ZuqJ6CFZJs4derwXXkZm3DkgpQQWI55M0S9IHXbQtaz5Qo6XzU1 yayU4bKIBAGEQHPVpdG76r9awHMxig/lQbKrdbFwIND9Iu4+2JRdqw7QrLGR9QRL9S7M FXCucjtVCGlH7yvkaqkp8fpll5OqqTwY2zo6Tzmn6KGuiSZ5UrfkdF2j3W04rT0szCt9 F8Bwg/iw0SH7/vDWXkc4YCnMg4hfYuk/aZPUzsi/v9moecgC2xzbfGniJeAi3l7JVoPd 27Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=l9lSV6b1ipoXEd8WKJZw54y2LcR9Ww5Z/zUwt9y3Dvc=; b=Kp8G1UJD1vtcXcFk2qtIPp5bsxaaWDPMcI3RYLlco2Z1gNgVrCpdrL95EnNoNAfLIg opSnJ4H4uZKx+RA/nldF9nkwF/wXO+44by4OOb+ORC0CHpV24XRomKH461bPxi7haXnG SP6s5m4S+IhrtuMVEu/ZNZg116szGD2L+o48l9hkuMToQIqYbq/K9Kp3ltPjJn128B2l 2nxSYa5Rk2QjiMc7GR+FY0CDRqgLPrh9Yio/9V2EulFiQn3xOkRNCjpytmO3n2ZD/uoX 5D1I9oRZcDeHS/SaXvKrSnM6QHSRvyR074Zefapw+TtI2P3w79bpM+UTypEiTYCXfx+f 0eRQ== X-Gm-Message-State: APjAAAVr1Zpxh+pJbFJ6s1Jj+tSZZSxu6+0qJ2lYHoKeJ1XvFujyTFuG y9Rc5G/pMtGkxXpe2RJ5f+Evg3eoBzteMg== X-Google-Smtp-Source: APXvYqy141o2pCSFcghigVTcTQcDjL/zFPXsG/bCSBrXgxM8vjcT7tJtWdmX17niHVUMqnfRsf2h0g== X-Received: by 2002:a17:902:121:: with SMTP id 30mr5804893plb.314.1561657446272; Thu, 27 Jun 2019 10:44:06 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id j16sm5096105pjz.31.2019.06.27.10.44.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:44:05 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Jon Mason , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 83/87] ethernet: neterion: remove memset after pci_alloc_persistent Date: Fri, 28 Jun 2019 01:43:59 +0800 Message-Id: <20190627174359.5307-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org pci_alloc_persistent calls dma_alloc_coherent directly. In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/ethernet/neterion/s2io.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index 3b2ae1a21678..e0b2bf327905 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c @@ -747,7 +747,6 @@ static int init_shared_mem(struct s2io_nic *nic) return -ENOMEM; } mem_allocated += size; - memset(tmp_v_addr, 0, size); size = sizeof(struct rxd_info) * rxd_count[nic->rxd_mode]; From patchwork Thu Jun 27 17:43:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123546 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oUZvhBi+"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZS1M3tMYz9sN6 for ; Fri, 28 Jun 2019 03:43:35 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727168AbfF0Rnb (ORCPT ); Thu, 27 Jun 2019 13:43:31 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:40864 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726561AbfF0Rna (ORCPT ); Thu, 27 Jun 2019 13:43:30 -0400 Received: by mail-pl1-f196.google.com with SMTP id a93so1684553pla.7; Thu, 27 Jun 2019 10:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Omg2r+qJLtgq2Odatu+vxMoOAmxY3CNldRSlBn3BzJY=; b=oUZvhBi+q6BwldFmrCI54T7dPoXEbxghwxxzpvavrUkRyVtj+XELXymH1Gt6dl1ViN SNPT/gpluLW5q4VlChwqJJeVvRXu2dKAtlbWEUN5yOP/PqtBHkAS+Jarw/GLxFaztMbR CYW3ICYEmqxkQNzq0N2GQlPlWVlLvoGuHbglVzyHBUX5oupicR1OwrkAu+ymen7ZsDPE XrkiXys0509jPgEesExshUrWq2U4Jda/LObTVKmJr/v/7yE/4xLTO7OItsQnQwT81Pgk cJxD6Fu78I/UcZcoxHkd9tShjFeFtGogT/fMVufKE6ueTLwZIv67k2bHXIh6ZSC7Ifz3 yXwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Omg2r+qJLtgq2Odatu+vxMoOAmxY3CNldRSlBn3BzJY=; b=m3hzMf90kKeu8aquhoNos7YD63gSLETQglriNug4qYED/Ad+id2kWuVOQZRjDGQ736 gtZUNk0uWYSoYA7DROKWlLRGWtz1YcDSOEkdgdaHUv1A//DM+x2HGvnbVFC+5TOfa9XY nq6Fu3I1rTgFo2cU84gCtCXRQdmG5oaUyzJjZ7wqy91wmaDL837AEgutewe/NGJDASIX 5okE2T3V4ZN0iPRzgYf455pxZjNht6DfAlbc4PpbbP++uKGtWUtxUA/FC02RsOoEwD7I X3JuMiIWn6ui2nhxHQn9TStHV/qtzfKEIByc4tsW1WD+ZXsV3qHjiKx0RKivbSWvQkRW 0CQA== X-Gm-Message-State: APjAAAUyD95tuKFvjM0d9/AUyCW6FcubHLfzBXgr4cwi0PDV0zXeIuBA qo+4VLzNLxJH9DHFqq5yL28= X-Google-Smtp-Source: APXvYqzhiTWTM3GiO4gixElLqF05+baJ+GEhtlIAbDBQFJmrYzg7Ok5W/2oU1piuA9dI9B6k/Rb7Rg== X-Received: by 2002:a17:902:7087:: with SMTP id z7mr5982555plk.184.1561657409580; Thu, 27 Jun 2019 10:43:29 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id f10sm2636285pgo.14.2019.06.27.10.43.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:43:29 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Jiri Pirko , Ido Schimmel , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 84/87] ethernet: mellanox: mlxsw: remove memset after pci_alloc_persistent Date: Fri, 28 Jun 2019 01:43:19 +0800 Message-Id: <20190627174319.5095-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org pci_alloc_persistent calls dma_alloc_coherent directly. In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/ethernet/mellanox/mlxsw/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/pci.c b/drivers/net/ethernet/mellanox/mlxsw/pci.c index b40455f8293d..be310ac0883a 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/pci.c +++ b/drivers/net/ethernet/mellanox/mlxsw/pci.c @@ -835,7 +835,6 @@ static int mlxsw_pci_queue_init(struct mlxsw_pci *mlxsw_pci, char *mbox, &mem_item->mapaddr); if (!mem_item->buf) return -ENOMEM; - memset(mem_item->buf, 0, mem_item->size); q->elem_info = kcalloc(q->count, sizeof(*q->elem_info), GFP_KERNEL); if (!q->elem_info) { From patchwork Thu Jun 27 17:43:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123545 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Dm7DjZf+"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZS146XnZz9s8m for ; Fri, 28 Jun 2019 03:43:20 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727131AbfF0RnM (ORCPT ); Thu, 27 Jun 2019 13:43:12 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44635 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726561AbfF0RnL (ORCPT ); Thu, 27 Jun 2019 13:43:11 -0400 Received: by mail-pl1-f193.google.com with SMTP id t7so1670046plr.11; Thu, 27 Jun 2019 10:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XMtbDy7ICVx9sNVDO5hcGRd0P6kv9+a3LFvIsYsOFnw=; b=Dm7DjZf+RwRrSgNYf08NJEWY1VKzGCc3XD4H35gEIFM4doU6DVgCiyjsX6z0YPheLa O2vqEOOrlEC/azUiCg9//zCHoxNq83yybTGLCOiA6jEakmBLhPQMtwAVmSL0ON92hTmy 64J2MHEy2DRRFI+RN+ANhn5y3JLzI0HPXMozKp4BBki6Ij343zd976mGyINBEmr6VMa/ mDryKUpWWVWzY4cUnoO1cMCqLI8E7r1bE5PpKxqtwX5AM9XDBxDkbkvVPijmZ8ljSDx+ TKI9joJueSnCnVl6g/rD6wjWJDiU/QXCJRpWwtp8+KdgUiaDhuxgFXE2rWwsmYLJofiz 1olQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XMtbDy7ICVx9sNVDO5hcGRd0P6kv9+a3LFvIsYsOFnw=; b=nsgkxVfV6z3+BUhBV8TB6TBcWgl86VMu24bKwPuNsEnW8+c8whiPPRKhmY/+uSpju3 5lP5H9AHS9VATasyyf0iOrkUaebp+iJQDEdToT4CpTpjDf9uCX3v5veFYqs7TCAVFYou 7H71ZDyDJR66bPVxjVetT0CGEKoLHQYVJCkrUrCkqNLBpeLjg4+ogOkbH7+z8vfrImMu i6MWPlDtbt64sXOu3BPwEHuddZN7hMXIu+pEjXowCZPpAuY8p0CWkx3smFT355P+zDQZ lJL0BehCRm+S4+P5s4ZkjUpusTzvszl+2uJ/KSB4X7kdDsd55AKTyDcRyw6/gnb/2lCo lnaw== X-Gm-Message-State: APjAAAWQ0D+Rw1PHLzhzObEGjGnTbwQro0/xUFt//SJO04kXjs51CF6N IeBdl+Kctk4wPv0xAddXL7U= X-Google-Smtp-Source: APXvYqzy3Ztt7IQZDJ9RrtSVSX7ny+ia2LX8OvP/XAwNpY7O/YPhbm/2B6k0+I+ofyI6EVTYeA9/Kw== X-Received: by 2002:a17:902:b187:: with SMTP id s7mr5927238plr.309.1561657391050; Thu, 27 Jun 2019 10:43:11 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id j21sm3240723pfh.86.2019.06.27.10.43.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:43:10 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Saeed Mahameed , Leon Romanovsky , "David S. Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 85/87] ethernet: mellanox: mlx5: remove memset after kvzalloc Date: Fri, 28 Jun 2019 01:43:01 +0800 Message-Id: <20190627174301.4983-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org kvzalloc already zeroes the memory. So memset is unneeded. Signed-off-by: Fuqian Huang --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 - drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c index 6a921e24cd5e..587c51fa3985 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c @@ -2391,7 +2391,6 @@ int mlx5_eswitch_get_vport_stats(struct mlx5_eswitch *esw, MLX5_SET(query_vport_counter_in, in, vport_number, vport->vport); MLX5_SET(query_vport_counter_in, in, other_vport, 1); - memset(out, 0, outlen); err = mlx5_cmd_exec(esw->dev, in, sizeof(in), out, outlen); if (err) goto free_out; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index 47b446d30f71..ef5fe3bd95f9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c @@ -993,7 +993,6 @@ static int esw_create_offloads_fdb_tables(struct mlx5_eswitch *esw, int nvports) } /* create send-to-vport group */ - memset(flow_group_in, 0, inlen); MLX5_SET(create_flow_group_in, flow_group_in, match_criteria_enable, MLX5_MATCH_MISC_PARAMETERS); @@ -1151,7 +1150,6 @@ static int esw_create_vport_rx_group(struct mlx5_eswitch *esw, int nvports) return -ENOMEM; /* create vport rx group */ - memset(flow_group_in, 0, inlen); MLX5_SET(create_flow_group_in, flow_group_in, match_criteria_enable, MLX5_MATCH_MISC_PARAMETERS); From patchwork Thu Jun 27 17:42:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123544 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IYMzHCw1"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZS0j3BnNz9sN6 for ; Fri, 28 Jun 2019 03:43:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbfF0Rmy (ORCPT ); Thu, 27 Jun 2019 13:42:54 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:42636 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726561AbfF0Rmx (ORCPT ); Thu, 27 Jun 2019 13:42:53 -0400 Received: by mail-pg1-f194.google.com with SMTP id k13so1336730pgq.9; Thu, 27 Jun 2019 10:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=OWPaAEBhAjk5F4JzNGhatrCNgFqb/Wo92Dms8qeFtZ4=; b=IYMzHCw1NFLgUDiufLBKvDxAuMKCWjFzY1PPyF7YXGfL2wIVK/YF+33yUcpG1u9OSB pXu/MXRjbjlDb2AssyGN37ZUK0PB7+d1SHJxOdiKxDZaAxI/AgYwi565mGSFf2rzZckD nLlQvVwCObFBoX/YaIMBMoXPNAktGrBn4TpXeQQNbQuNCiFM+mD34zhYm6Sm5y2euP9w rZzKkFzDmdX7SR0RC2UeIhu1Zk9iHqcSYAtZX4Cjzlnd9FqrSnJClil8ANWtDv9Pqpxj X9xjbtoAn+uu4T73GZPss/Ko2OELLvI28xtBWUAqi2p9shM2Dn15n6sp3d3mm7LRaqT3 UB4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OWPaAEBhAjk5F4JzNGhatrCNgFqb/Wo92Dms8qeFtZ4=; b=EBhgqyw+9qp9+gEEsSL7kBt6mYjMIBZA5laNy5bVuXftxmUiIBqSE4Cg3zJRXLJyvs VLa9lPm+4cBB6nsMPO5iKsCPFn45rFq1Z+0iVz9Rz2vB7/p+j6VCMnyG58vtNfMbMart LQnd+5xZv8FLntAsBOnVto0m3WQc/7R21qsbn8eHVhUbVfcD3o29zPSvZ0ITZE0f4aEj 3gVtcRmnXLZOZT/Z6gVKxGx7UA02F8m/W7f5R/KXtL9Tw6xC/BoZ/2egd9I+N9Fjdyjs 8ieFrDG6acuLEcIaPnf18hFID0zzikDGH8UplHZ4gxaisGPlRM7xuSTOetkBQ4l/BUIl 8ENQ== X-Gm-Message-State: APjAAAU3wGK11hgiGNoT5fY/JB84AaY7lvjzIU6kRgWJD5j5Bn/0d2nj tasN1l1Hc79MsWQsJn9nmdA= X-Google-Smtp-Source: APXvYqzkEKqRPmNBh7vPqKbxvVFrkNE2c+K+ZaH3WGBd9kBOVasa2XMnJuRw+iBmWP74EoLEOYaNsA== X-Received: by 2002:a65:5202:: with SMTP id o2mr4524485pgp.199.1561657373085; Thu, 27 Jun 2019 10:42:53 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id d4sm5121859pju.19.2019.06.27.10.42.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:42:52 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Tariq Toukan , "David S. Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 86/87] ethernet: mellanox:mlx4: replace kmalloc and memset with kzalloc Date: Fri, 28 Jun 2019 01:42:45 +0800 Message-Id: <20190627174245.4877-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org kmalloc + memset(0) -> kzalloc Signed-off-by: Fuqian Huang --- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c index 6c01314e87b0..f1dff5c47676 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c @@ -1062,7 +1062,7 @@ static int mlx4_en_config_rss_qp(struct mlx4_en_priv *priv, int qpn, struct mlx4_qp_context *context; int err = 0; - context = kmalloc(sizeof(*context), GFP_KERNEL); + context = kzalloc(sizeof(*context), GFP_KERNEL); if (!context) return -ENOMEM; @@ -1073,7 +1073,6 @@ static int mlx4_en_config_rss_qp(struct mlx4_en_priv *priv, int qpn, } qp->event = mlx4_en_sqp_event; - memset(context, 0, sizeof(*context)); mlx4_en_fill_qp_context(priv, ring->actual_size, ring->stride, 0, 0, qpn, ring->cqn, -1, context); context->db_rec_addr = cpu_to_be64(ring->wqres.db.dma); From patchwork Thu Jun 27 17:42:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 1123543 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IyAOo3tM"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45ZS0J46f3z9sCJ for ; Fri, 28 Jun 2019 03:42:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727069AbfF0Rmg (ORCPT ); Thu, 27 Jun 2019 13:42:36 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:44898 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbfF0Rmg (ORCPT ); Thu, 27 Jun 2019 13:42:36 -0400 Received: by mail-pf1-f195.google.com with SMTP id t16so1575797pfe.11; Thu, 27 Jun 2019 10:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=JbWk5FOEtfFARu6jGi76KfhRnQUsmK/80oLXsYAvadE=; b=IyAOo3tM+BIOvpNkzWoKpNQir07XIMk6PecvV/zsNOEoyU14MooOYJPMtrYWwBZBBM yXB7bPm4IG0+Fu9NEZs+NDhEHVrhNNVCHnswR3GQyuBLUi0k+3NZtPOZAq1H5WJMNNoB 5vOcLLH/5uJpVIDeMQKX8YB+04teV/NNItv1SgT3SvE819fKMhM5y6KQFv/Hcryr+4gv jweF/U5erIl/Y+DaIDBDgnEn4KDPT4oIxXYtlTXDEN7uzvxy0YXey/7hCnyhYERZu9Mk u+zQCVk5mxlXRe7/z5gJs6Vk3cr4lCVaRPgecdZmlwSmDmIX6CEl/GyPIuXvkU84Yep6 JBFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JbWk5FOEtfFARu6jGi76KfhRnQUsmK/80oLXsYAvadE=; b=XSb5ZSXu0lp8bZwWoBeuRd50Td+LST0nCl61Bz2byX0QUC7sF/zLoFvrGazl19cMEQ urWxP8CsErc90d7uNjHyBU8YfHEY740WrOhl01rUuQIHJ26Nj5f7EMdhUqFs7/Q3uC/u SFVa8x4Uk4hoPWLX2lWQbWOQW22h27Lxt2sqlRlswG/e3X8xSPl3rqO9viqbSQ85SY87 1Xlx0E+kVoGiVTm5O0Afm2q/LvV9jeOpV3QU33IyhzijAoW4QBvzapveOiY1tS7blEdN pYjvBOAwn5XoT74seNQE2cIkKPGoj5WBGlKPG6KFLdYz4bhHnRcMxVsMHakdBEhzgBOu 39OA== X-Gm-Message-State: APjAAAXJtfDOMtaQcPgSZb7g+f5CMSzoz7m+1j7BPBeSq0ROz+sfZyNo 2kLbQqBZUDGPJU1VQX2BReHU84Y3mMGnag== X-Google-Smtp-Source: APXvYqyIIZEYOJViQfY6zMcYkym9Ys5vOWz6YgmmC/WbfAJS9116enKFi1n2r3fmlqxe2kK1Mg90zQ== X-Received: by 2002:a17:90a:376f:: with SMTP id u102mr7520173pjb.5.1561657355500; Thu, 27 Jun 2019 10:42:35 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id k6sm3489864pfi.12.2019.06.27.10.42.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:42:35 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Tariq Toukan , "David S. Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 87/87] ethernet: mlx4: remove memset after dma_alloc_coherent Date: Fri, 28 Jun 2019 01:42:27 +0800 Message-Id: <20190627174227.4726-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/eq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c index a5be27772b8e..c790a5fcea73 100644 --- a/drivers/net/ethernet/mellanox/mlx4/eq.c +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c @@ -1013,8 +1013,6 @@ static int mlx4_create_eq(struct mlx4_dev *dev, int nent, dma_list[i] = t; eq->page_list[i].map = t; - - memset(eq->page_list[i].buf, 0, PAGE_SIZE); } eq->eqn = mlx4_bitmap_alloc(&priv->eq_table.bitmap);