From patchwork Sat Jun 22 09:31:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Schmutzler X-Patchwork-Id: 1120621 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adrianschmutzler.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n2FCCYJ8"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45W9N70wt2z9s4Y for ; Sat, 22 Jun 2019 19:33:26 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-Id:Date:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7dAGZH3VfksrzhK45IvnM8ASbc0PxDIZ/R5OmIrPrBQ=; b=n2FCCYJ8/8Gx02 IAX0SCCAcpNmif6YqHcG0kq8jk+lrIZzahyXj98TniJex86LzscYfpv3p1dvwubC+9v+q0wXiE5CI FIP/Qp94kK4u80LeU67zmKedZO34LvUdJ+tC6NDj2j0vCk7rDH+a+llxe0CP1/Rvax4FeLb/1MkD/ HuaTe3eGEL1DphQMcP0wvcHSPga51XRreo/+1ZEOCnaArJvLGTZEaVnup534B/QDlO+dP208NP3z+ lkhGm4HaSg2m+GYZpSFZc3n+FppL11juGL77Ma0g5TPVJu7iwPcY1U4MC8Ft4OYHlXgWnbQARz70L sKlFdtO81bVMDfhXH02g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hecOQ-0003Dl-U4; Sat, 22 Jun 2019 09:33:06 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hecOO-0003D5-1E for openwrt-devel@lists.openwrt.org; Sat, 22 Jun 2019 09:33:05 +0000 Received: from localhost.localdomain ([188.194.85.108]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M4bA0-1he4A13yg2-001fMD for ; Sat, 22 Jun 2019 11:33:00 +0200 From: Adrian Schmutzler To: openwrt-devel@lists.openwrt.org Date: Sat, 22 Jun 2019 11:31:56 +0200 Message-Id: <20190622093157.1372-1-freifunk@adrianschmutzler.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:TBe7GPOetWDUPcP3J1eOvPMouUQF1S1ANy0T1JI9CrOFcuVSfg6 NLNGG68ey1gGN7TazGBmVlXuM5L5t0z+xs5zSi4SLdPzIg9v8jZAkBa0HW65eyvfYsh7dWM kNmbDRTuXF82V+OMdG0xoWraQnQg27s5c0ZuBemuw4Jb5S2gTSKmkskJecv4bd7mMtOVM7M pgiqiY7oN9JzNoBpFf+hw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:r4RkSuCDVSQ=:3jwijn9TStY2t5yMfrm2kf Gm6l3iHpVnj5bMx4xEDrx1FOSqScyDqj/7JeeJAYmrUit++10HBMXm3YrVC4LZaJTEg8yu8hf 6fQ4JyCo2+/jDMvsDHO8qF+tETKjD7+XxY2M1qEDwqqTgmoFXqFIjSmvwqVbc01aq8QcIms4Y x9BMn+oiiuTXT8aw4b8IT6pNxh9tevGWas1PeJPB2SgZ+cCzT8yOoDH/j7UrLeuOncpa60kwx /ldSndkM8K2+fbx38Dl5ARLuQBTqom0nLUGYoLZW2Zq3k8dk0E18va7uxM4khcYjxNho1iCDf ea4b0y2c5O0xEXkEw4Nbzj5w0cpKnshZL4fOpP5l6RCo1sIqyT6AwnRifFyDma3VbE6gujQN0 yZyK9j35fdRUugwPFBPUdDq3UtgAk+FGM/XB2KTlPuBbAGUZBqMX/liN+jKfGLxLH/xkPDFQH dmhdswvVhuDo9GQrICOuvRGwzSAHmRu8Xuj2qMcZv8Wm/b7GacVL/B+WpvoPELVtaur4GEqq+ FwOP/R3LInSWu4moLnLYl5J6a5+Ayz4VLod+ZLI9Y5+t4ptJvw+8bN6ugFMCDv0WEirBcEZLD mHMUHHtm2BXWKlIrI9gW+KomtX/m1t8ST/ROp5oRqwXNf1kyfJ2G7IX9ilalcBn3U/vQUIXsq 3VrCpQwCskwtHgo/lwcaxhi5W7twUPKqPShUY0zB+uyAdkeIxodXS9Wdu5NsdZpf0aQ7d66+v g7YY/iAmpL7NcNJz84XK0ao5u40dam0jUJBDIRN8SnDJN1+0NqCLbBKA27c= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190622_023304_372290_B5FF942E X-CRM114-Status: UNSURE ( 8.26 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [212.227.17.24 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record Subject: [OpenWrt-Devel] [PATCH 1/2] openwrt-19.07: ath79: Code style fixes in 10_fix_wifi_mac X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org This fixes one comparison and several useless echos. Signed-off-by: Adrian Schmutzler --- .../base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac b/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac index 2da2e8bfb0..bdb8b71ff7 100644 --- a/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac +++ b/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac @@ -1,6 +1,6 @@ #!/bin/ash -[ "$ACTION" == "add" ] || exit 0 +[ "$ACTION" = "add" ] || exit 0 PHYNBR=${DEVPATH##*/phy} @@ -17,18 +17,18 @@ case "$board" in # There is no eeprom data for 5 GHz wlan in "art" partition # which would allow to patch the macaddress [ "$PHYNBR" -eq 1 ] && \ - echo $(macaddr_add "$(mtd_get_mac_ascii u-boot-env ethaddr)" 1) > /sys${DEVPATH}/macaddress + macaddr_add "$(mtd_get_mac_ascii u-boot-env ethaddr)" 1 > /sys${DEVPATH}/macaddress ;; iodata,wn-ac1600dgr) # There is no eeprom data for 5 GHz wlan in "art" partition # which would allow to patch the macaddress [ "$PHYNBR" -eq 0 ] && \ - echo $(macaddr_add "$(mtd_get_mac_ascii u-boot-env ethaddr)" 1) > /sys${DEVPATH}/macaddress + macaddr_add "$(mtd_get_mac_ascii u-boot-env ethaddr)" 1 > /sys${DEVPATH}/macaddress ;; phicomm,k2t) # The K2T factory firmware does use LAN mac address as the 2.4G wifi mac address [ "$PHYNBR" -eq 1 ] && \ - echo $(k2t_get_mac "lan_mac") > /sys${DEVPATH}/macaddress + k2t_get_mac "lan_mac" > /sys${DEVPATH}/macaddress ;; *) ;; From patchwork Sat Jun 22 09:31:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Schmutzler X-Patchwork-Id: 1120622 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adrianschmutzler.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pf65iVvs"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45W9NC6G7Nz9s4Y for ; Sat, 22 Jun 2019 19:33:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=gnjqL3JycYOQfjKnDl2Sj/XBrhQASXXLmn9itGhZoIw=; b=Pf65iVvsZ1tWLhnHGafh34M67i KWMgXRjPLfiYs7tcFE2vhv7J2UkdIfhStm7Qr+zKzZpF2npdl3CXCIeGwi4K+UsEJiIm8+f/bNlit 7FSEzwZrEd/EFLm0agHO986q3E83QobWPGDDyu4iN7M0557kjEG1e2BYcwuczVzZ3nsWyEfvsTjKX /Vj54vQBaT1fQzpGcGvNrPVkfErO6jqv4tTT1clrFFWoV8Sch6/P3fth3so6qyAe/Cuu1sMP4sFbs rQkwbi4v2yrLxEXqejey1egQ3atz0V+oOyb/Eb4yoUHC6ptX96Dpe9sZcRxbDNHCdOXsRiqfk07TM WBjJ107Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hecOc-0003P5-DG; Sat, 22 Jun 2019 09:33:18 +0000 Received: from mout.kundenserver.de ([212.227.17.13]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hecOO-0003D6-51 for openwrt-devel@lists.openwrt.org; Sat, 22 Jun 2019 09:33:05 +0000 Received: from localhost.localdomain ([188.194.85.108]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MJEAX-1huEUx0L87-00Kh6m for ; Sat, 22 Jun 2019 11:33:00 +0200 From: Adrian Schmutzler To: openwrt-devel@lists.openwrt.org Date: Sat, 22 Jun 2019 11:31:57 +0200 Message-Id: <20190622093157.1372-2-freifunk@adrianschmutzler.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190622093157.1372-1-freifunk@adrianschmutzler.de> References: <20190622093157.1372-1-freifunk@adrianschmutzler.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:oExGv8XozlWLK1B6c/uUlDgsv/HB6TCqx+4dBfbEegqHgpmoeuX A1vKINyzuxfGrrCDhb4gshwgrWyZ9jqPYzTc6GRYt5MvgdAIiaQnXm4+RHab5kVyV40oqpT 3K1tTEFKMUBqclZ4rLmFkwfMobF+DpahvglSgNaOoeBFeITuZQJQX6IEpkmulZkTXqOlBIN x9w54Ng6VkppxFR0JsE9g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:CIqlkgLEM9Y=:OSpFr6e9oXViZrqTTbjxE5 06jk7E8hYKa0rBsVepl1s6hvpJLCypile1TRvOg2Q1nYJAQYBXQkrP0cR8DLwKLA9OOMgBjqi q5F12RntRa7pgQ0tgoipP4h8LaCvYsQolNv+j4Gvmo8rh6qNUr4ptu38t3dsJPXC0lDgz0o8W kZBeP2BNYsZhMQn1ywtGMduLd1+eppsBm2ySSsJMvdnqZpewBkLT8RJrL/HBYWGFQQ4ya4YVA E7IVvt9awV4EiEbjnD684tZfTggdbmHmUKJ2SliM+jrASeV+Vj1aSr1JiBM/22LML4Gv1ZEqg 07cqXIQK3McpKYM349iZ9+72fUsNH6Qagpsh1qRtGaQTyJYeeL4gBNKD+Y3/5r4gb6+RivBb2 ag4zOjRakMNA5d1eRocC6JClaYplZSRFPGDeTCbXiSxhTAOefdbpyRCk17A6rJmY4yAKNg+ov sZcV0k1I/7YB672YXrShDuxs5o6EJdzVEOwtQuh56SAn57qI7wHvd3rxxURLteYK7BStaEpq/ +/3Xkr4PY2Vxy767CD4jYavhndYY4z03EA8SMrUf8AFqtBMibEjqgUHh3A0qpMh6Zmpi/2x+q DBu0twGKLze75D7rY8Z/ik+sFfAUaLYvZsfadWtUT+5RjHcATjxODO6FwSGklYcwxrwjbxW3H 5oUhjiBs8SMdKKtDjHX4hXAYveJas8s4756lZeP8+WYr0vUMe04FGCE7xYKmmP8hUDYTU3hyv jFYlPcNkQCe+VSEDDPEvwJiEd7s+Fsvz+EyQ/F643MkE0L4zao0hp/EKldc= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190622_023304_487373_82250FBF X-CRM114-Status: UNSURE ( 8.16 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [212.227.17.13 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record Subject: [OpenWrt-Devel] [PATCH 2/2] openwrt-19.07: ar71xx: Code style fixes in 10_fix_wifi_mac X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org This fixes one comparison and one useless echo. Signed-off-by: Adrian Schmutzler --- .../ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac b/target/linux/ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac index b58cf9b591..1082ad4ad3 100644 --- a/target/linux/ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac +++ b/target/linux/ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac @@ -1,6 +1,6 @@ #!/bin/ash -[ "$ACTION" == "add" ] || exit 0 +[ "$ACTION" = "add" ] || exit 0 PHYNBR=${DEVPATH##*/phy} @@ -17,7 +17,7 @@ case "$board" in archer-c59-v2|\ archer-c60-v1|\ archer-c60-v2) - echo $(macaddr_add $(mtd_get_mac_binary mac 8) $(($PHYNBR - 1)) ) > /sys${DEVPATH}/macaddress + macaddr_add $(mtd_get_mac_binary mac 8) $(($PHYNBR - 1)) > /sys${DEVPATH}/macaddress ;; *) ;;