From patchwork Thu Jun 20 14:00:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 1119479 X-Patchwork-Delegate: lukma@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="WxSnyjI5"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45V3Nw36pkz9s00 for ; Fri, 21 Jun 2019 00:00:14 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 8CDBAC21E1B; Thu, 20 Jun 2019 14:00:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 3B2C6C21C57; Thu, 20 Jun 2019 14:00:06 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 28A90C21C57; Thu, 20 Jun 2019 14:00:04 +0000 (UTC) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by lists.denx.de (Postfix) with ESMTPS id C8CC4C21BE5 for ; Thu, 20 Jun 2019 14:00:03 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id x25so2828839ljh.2 for ; Thu, 20 Jun 2019 07:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4p+Q0Ek2tylBK4LpPX44XjNqTPxREbcugNC+IoXMeH4=; b=WxSnyjI5LVai3JfIZdR0U6w29xaoFi1/IaVsbTMHw/U8KPBlEZtDCtUj468iWB2fvE CWjX0ihTfJfKDFZO/LhNi/coKK7Ktg46x8pAFzaw7txdSHgv8+NcJJxgvdLlC2qorysC pWF5w4jjfvV0Hl4Wm4DiuTgKnwEho3TFh34RhJW8Ka6vcimCSyMSCIAejk6A5IL6/Td/ WwwtD7pza/rq6DVAfWpugUJpXO+h61e1qp8ih6FL6fIafPEvcd3PN+IxX/v17IynmJz9 sMX6BAo7uXDTt3yz3imX/m4JMUFaWedVOteCyXZBbM9blAkKfME/Xqvk60oR10wFmPjX xSYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4p+Q0Ek2tylBK4LpPX44XjNqTPxREbcugNC+IoXMeH4=; b=P6xrQtWmQcf5C2OCG3NWL8qRMPkKMdpSxs8F0xKIhEogUzO9jOopV8w1YSGa6FJmdx OkrVhj84+yrWExz5JItJ3A0nVQ/iGXbE3MG6VfVdyKZGjpfeQdb6iqdiBBVc4dJc4Ju8 QLkM4ehUM90N/SyzIEwp5TMj7Ecvi5n8qbUjrSFx62MYySO4g/FVGA4vpq3WtaQPtGJ+ 7FG0XqW9sYotIaUC+W1tJySq9W/IEIlCljlmZO4B5alxgwkrnJChKkfb1yckRPfSOuOR FVYhR61wBjHHA87JH/MmS0A37Wd2RSBncN42R0qzjre7oYoPXZcrix6HPbBw0g46wOcD yasA== X-Gm-Message-State: APjAAAVgnY4/hWX7bPtniJlRZ6vxYfm/h6t3+4832Caii34Ij5MAsfOV 8ggFfoGTnJG3hInRBphjKOqey9EfPr4= X-Google-Smtp-Source: APXvYqxbf7qAOC0d/ioH4Vb6d/vKkVHO/Zhf1Q5SFFPx/QrpwgOEzekmFMTOOdhyjWjX9jzNg71ywQ== X-Received: by 2002:a2e:96c3:: with SMTP id d3mr7714299ljj.68.1561039203100; Thu, 20 Jun 2019 07:00:03 -0700 (PDT) Received: from localhost ([195.238.92.132]) by smtp.gmail.com with ESMTPSA id n1sm3104052lfl.77.2019.06.20.07.00.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 20 Jun 2019 07:00:02 -0700 (PDT) From: Sam Protsenko To: u-boot@lists.denx.de Date: Thu, 20 Jun 2019 17:00:01 +0300 Message-Id: <20190620140001.12811-1-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Cc: Tom Rini , Praneeth Bajjuri , Eugeniu Rosca Subject: [U-Boot] [PATCH] fastboot: Remove "bootloader-version" variable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As per [1], there is no such fastboot variable as "bootloader-version". Only "version-bootloader" is supported. Let's reflect this and not confuse users further. [1] https://android.googlesource.com/platform/system/core/+/master/fastboot/README.md#client-variables Signed-off-by: Sam Protsenko Reviewed-by: Igor Opaniuk Reviewed-by: Eugeniu Rosca --- doc/README.android-fastboot | 4 ++-- drivers/fastboot/fb_getvar.c | 9 +++------ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/doc/README.android-fastboot b/doc/README.android-fastboot index 431191c473..ce852a4fd1 100644 --- a/doc/README.android-fastboot +++ b/doc/README.android-fastboot @@ -169,8 +169,8 @@ On the client side you can fetch the bootloader version for instance: :: - $ fastboot getvar bootloader-version - bootloader-version: U-Boot 2014.04-00005-gd24cabc + $ fastboot getvar version-bootloader + version-bootloader: U-Boot 2014.04-00005-gd24cabc finished. total time: 0.000s or initiate a reboot: diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c index fd0823b2bf..ebe5c8a104 100644 --- a/drivers/fastboot/fb_getvar.c +++ b/drivers/fastboot/fb_getvar.c @@ -12,7 +12,7 @@ #include static void getvar_version(char *var_parameter, char *response); -static void getvar_bootloader_version(char *var_parameter, char *response); +static void getvar_version_bootloader(char *var_parameter, char *response); static void getvar_downloadsize(char *var_parameter, char *response); static void getvar_serialno(char *var_parameter, char *response); static void getvar_version_baseband(char *var_parameter, char *response); @@ -37,12 +37,9 @@ static const struct { { .variable = "version", .dispatch = getvar_version - }, { - .variable = "bootloader-version", - .dispatch = getvar_bootloader_version }, { .variable = "version-bootloader", - .dispatch = getvar_bootloader_version + .dispatch = getvar_version_bootloader }, { .variable = "downloadsize", .dispatch = getvar_downloadsize @@ -131,7 +128,7 @@ static void getvar_version(char *var_parameter, char *response) fastboot_okay(FASTBOOT_VERSION, response); } -static void getvar_bootloader_version(char *var_parameter, char *response) +static void getvar_version_bootloader(char *var_parameter, char *response) { fastboot_okay(U_BOOT_VERSION, response); }