From patchwork Sun Jun 16 15:08:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 1116566 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=reject dis=none) header.from=zoho.com.cn Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45Rd5G024lz9s7h for ; Mon, 17 Jun 2019 01:08:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727291AbfFPPIR convert rfc822-to-8bit (ORCPT ); Sun, 16 Jun 2019 11:08:17 -0400 Received: from sender2-pp-o92.zoho.com.cn ([163.53.93.251]:25451 "EHLO sender1.zoho.com.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725879AbfFPPIQ (ORCPT ); Sun, 16 Jun 2019 11:08:16 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1560697690; cv=none; d=zoho.com.cn; s=zohoarc; b=dwYP+DCOLbLdGLQdcGzvXkM6HxK9jzIlcu6Udj7qcK0eFiwqODsk2b2CqaL4oevLPw+Sy8q95+5bVGeussAGxPHABBbsI005kBha4/6NQ94aFce9ZZvFxtx9fmD0sJVioTPDU6cx6qkG/ViwHdFra+BvxsLRnRFLb8Hjek3IyWw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1560697690; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To:ARC-Authentication-Results; bh=Wf53hg+okz/TcqIQqrT1mVPw9mXz0q2TDkW3doCD21s=; b=blAsj0+YVicmkEh/605jELL4v8BMWnXPPtS3Yt5bPcL1hhkXhStK1pPrz8atPiToBOqODbwtnicf5X2zSbfwW7q9xUSpmIngduDqD5GpYgTHjRCZd9E/d3h9eXn8uimWa/1b+usk/EH9CXAo1As9m5AtWh9QCfdeF/2hxhWBGRY= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=zoho.com.cn; spf=pass smtp.mailfrom=cgxu519@zoho.com.cn; dmarc=pass header.from= header.from= Received: from localhost.localdomain.localdomain (113.116.51.202 [113.116.51.202]) by mx.zoho.com.cn with SMTPS id 1560697688293629.3553326145355; Sun, 16 Jun 2019 23:08:08 +0800 (CST) From: Chengguang Xu To: jack@suse.com Cc: linux-ext4@vger.kernel.org, Chengguang Xu Message-ID: <20190616150801.2652-1-cgxu519@zoho.com.cn> Subject: [PATCH] ext2: add missing brelse() in ext2_iget() Date: Sun, 16 Jun 2019 23:08:01 +0800 X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-ZohoCNMailClient: External Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Add missing brelse() on error path of ext2_iget(). Signed-off-by: Chengguang Xu Reviewed-by: Darrick J. Wong --- fs/ext2/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index e474127dd255..fb3611f02051 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -1473,6 +1473,7 @@ struct inode *ext2_iget (struct super_block *sb, unsigned long ino) else ei->i_dir_acl = le32_to_cpu(raw_inode->i_dir_acl); if (i_size_read(inode) < 0) { + brelse(bh); ret = -EFSCORRUPTED; goto bad_inode; }