From patchwork Wed Nov 1 11:10:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 832926 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="1OkJKbzb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yRlrR4Ccsz9t3C for ; Wed, 1 Nov 2017 22:10:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753688AbdKALKq (ORCPT ); Wed, 1 Nov 2017 07:10:46 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:56416 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751482AbdKALKo (ORCPT ); Wed, 1 Nov 2017 07:10:44 -0400 Received: by mail-wm0-f66.google.com with SMTP id z3so4158262wme.5 for ; Wed, 01 Nov 2017 04:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=vNUvyCC8RX/nthdSTRRRlD198YO4Rdsy0FHrVJ1K3zg=; b=1OkJKbzbw601HhNpEKpBOqowWvVMRxXizOwgb7aeybBOqpw91mkjrLPdGf7Wy3I+rq kLeesH33Jz4wJihIi5UmIU2FHesa+AznSK2ZL4esECZJzJ1SA7tdux3/auQktZWGZaLF k2p4L2PN5d18kTidh7t3i+OMELgEzLAyuoxnZwpM71v+UNkm79Hh+Vu5hZO6kqsY/Bz+ XI19bJ2I0dHVnOOQfNmV+cU3sV21EvSWEvNeEc6rltRzQ50UzHZih234jhVqJhoGQ3cn mA+i4Elq4p2DzNci82StKX1E0yZgSZ7aQOIOhIXmqW1BciRuXdRHN17rD0OlmUKS1Sl8 XWLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vNUvyCC8RX/nthdSTRRRlD198YO4Rdsy0FHrVJ1K3zg=; b=Ks27REp6qLqMLd+NunTWT1svyM4TgApA6QYsHbgM/ChDnHpG0mh4ODSmlQVvOzZcVU BAZlwHP8gbYpFm8jLyUX1i37uQeeDNWTgprq/wiVetln9Cb0OxAk4fQubXFRjLuZZJy3 t8+T2z/FGm6dvZC7Up+dtcZgNO2uQL2MSeKey+D0WDVJgxfBaqzKjo4dRMm1CucB29cE 870Cy+3eMK/1SB4lYnjCLj+NHCDgh+wwOp5pk/p0z2ut//QwZVAOoAE3/3uPm+G0qY92 cH+mf2MtoEJ0rq4mdvoPrnzUIEC1kwEUKBM1v6k8OVA9nuo9VJj5nr8gHfE6gjN36JW2 QUdg== X-Gm-Message-State: AMCzsaWt9BA9HdQANjytflFR4i95A6QdB9bkeztu0o6A4ZulUgCFaVns ce/Wihro2gHGKpVZMyDr8QGSChLK X-Google-Smtp-Source: ABhQp+ROezsxcx8xMY3gNKotlX4GAZNrWpcZYY3Avh1/MqyqAiQz4besVBhZfcUGg5p4r7NQ/vjpjA== X-Received: by 10.28.23.129 with SMTP id 123mr4182098wmx.54.1509534642895; Wed, 01 Nov 2017 04:10:42 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id n2sm1979087wmd.39.2017.11.01.04.10.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Nov 2017 04:10:42 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, vadimp@mellanox.com, idosch@mellanox.com, mlxsw@mellanox.com Subject: [patch net] mlxsw: i2c: Fix buffer increment counter for write transaction Date: Wed, 1 Nov 2017 12:10:42 +0100 Message-Id: <20171101111042.8040-1-jiri@resnulli.us> X-Mailer: git-send-email 2.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vadim Pasternak It fixes a problem for the last chunk where 'chunk_size' is smaller than MLXSW_I2C_BLK_MAX and data is copied to the wrong offset, overriding previous data. Fixes: 6882b0aee180 ("mlxsw: Introduce support for I2C bus") Signed-off-by: Vadim Pasternak Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/i2c.c b/drivers/net/ethernet/mellanox/mlxsw/i2c.c index 12c3a44..c0dcfa0 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/i2c.c +++ b/drivers/net/ethernet/mellanox/mlxsw/i2c.c @@ -294,7 +294,7 @@ mlxsw_i2c_write(struct device *dev, size_t in_mbox_size, u8 *in_mbox, int num, write_tran.len = MLXSW_I2C_ADDR_WIDTH + chunk_size; mlxsw_i2c_set_slave_addr(tran_buf, off); memcpy(&tran_buf[MLXSW_I2C_ADDR_BUF_SIZE], in_mbox + - chunk_size * i, chunk_size); + MLXSW_I2C_BLK_MAX * i, chunk_size); j = 0; end = jiffies + timeout;