From patchwork Tue Jun 11 09:09:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 1113600 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45NPMC0c0bz9s4Y; Tue, 11 Jun 2019 19:09:11 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hacmC-0005EB-Dy; Tue, 11 Jun 2019 09:09:08 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hacmB-0005E5-JW for fwts-devel@lists.ubuntu.com; Tue, 11 Jun 2019 09:09:07 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hacmB-00081T-6I; Tue, 11 Jun 2019 09:09:07 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: method: reduce scope of boolean flag matching_levels Date: Tue, 11 Jun 2019 10:09:06 +0100 Message-Id: <20190611090906.21213-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Colin Ian King Clean up a cppcheck style check. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/acpi/method/method.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index d1f20bb2..eeb9c7fa 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -5739,7 +5739,6 @@ static void method_test_BCL_return( uint32_t i; bool failed = false; bool ascending_levels = false; - bool matching_levels; char *str = NULL; FWTS_UNUSED(private); @@ -5812,7 +5811,8 @@ static void method_test_BCL_return( } if (!access("/sys/class/backlight/acpi_video0", R_OK)) { - matching_levels = false; + bool matching_levels = false; + for (i = 2; i < obj->Package.Count; i++) { if (obj->Package.Elements[0].Integer.Value == obj->Package.Elements[i].Integer.Value) {