From patchwork Thu Jun 6 02:07:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?ISO-8859-1?B?eGl1emhp?= <1450335857@qq.com> X-Patchwork-Id: 1110858 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45K8GY0c9Zz9s4Y for ; Thu, 6 Jun 2019 12:08:53 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=qq.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=qq.com header.i=@qq.com header.b="PUQUbBUu"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45K8GX5rS6zDqfV for ; Thu, 6 Jun 2019 12:08:52 +1000 (AEST) X-Original-To: openbmc@lists.ozlabs.org Delivered-To: openbmc@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=qq.com (client-ip=184.105.206.29; helo=smtpbg202.qq.com; envelope-from=1450335857@qq.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=qq.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=qq.com header.i=@qq.com header.b="PUQUbBUu"; dkim-atps=neutral Received: from smtpbg202.qq.com (smtpbg202.qq.com [184.105.206.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45K8Fs4mkszDqRK for ; Thu, 6 Jun 2019 12:08:16 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1559786877; bh=MIC29+XwEVUMHwPEQqcBmNP5s9T3gHAr2oOPr/M8bjA=; h=From:To:Subject:Mime-Version:Date:Message-ID; b=PUQUbBUuoc1MatgLXbkpee/vHJQEKafcaMv2F1BgD3fShGnCW1fQHpBZWw2of4zIU lpifCdY8gfd3gOUrOW+EFYAEluprOc6D+mcStxpcLqYQfrTTa5BmcXzUjuKHsDD5JL yIqtFjAKa3O3Kx1S4SadHCD/yzSIqCLrnrkadzw4= X-QQ-SSF: 00000000000000F000000000000000H X-HAS-ATTACH: no X-QQ-BUSINESS-ORIGIN: 2 X-Originating-IP: 218.247.157.87 X-QQ-STYLE: X-QQ-mid: webenglish1t1559786876t295240 From: "=?ISO-8859-1?B?eGl1emhp?=" <1450335857@qq.com> To: "=?ISO-8859-1?B?amFlLmh5dW4ueW9v?=" , "=?ISO-8859-1?B?b3BlbmJtYw==?=" , "=?ISO-8859-1?B?ZWFqYW1lcw==?=" , "=?ISO-8859-1?B?Sm9lbCBTdGFubGV5?=" , "=?ISO-8859-1?B?QW5kcmV3LkplZmZlcnk=?=" Subject: ikvm gadget usb_ep_queue error when the hostOS reboot Mime-Version: 1.0 Date: Thu, 6 Jun 2019 10:07:56 +0800 X-Priority: 3 Message-ID: X-QQ-MIME: TCMime 1.0 by Tencent X-Mailer: QQMail 2.x X-QQ-Mailer: QQMail 2.x X-QQ-SENDSIZE: 520 Received: from qq.com (unknown [127.0.0.1]) by smtp.qq.com (ESMTP) with SMTP id ; Thu, 06 Jun 2019 10:07:57 +0800 (CST) Feedback-ID: webenglish:qq.com:bgforeign:bgforeign4 X-QQ-Bgrelay: 1 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "openbmc" Hi Jae, The bmc serial port will print an usb_ep_queue errors when reboot the hostOS. I can reproduce it by the following steps: 1, Login the bmc webpage ,open the kvm webpage. 2, reboot the host OS 3, Bmc Serial port will print error messages: [ 680.786134] aspeed-video 1e700000.video: Timed out; first mode detect [ 681.846125] aspeed-video 1e700000.video: Timed out when stopping streaming [ 682.356106] aspeed-video 1e700000.video: Timed out; first mode detect [ 682.377294] configfs-gadget gadget: usb_ep_queue error on int endpoint -108 [ 682.896212] aspeed-video 1e700000.video: Timed out; first mode detect [ 684.917892] configfs-gadget gadget: usb_ep_queue error on int endpoint -108 [ 685.426159] aspeed-video 1e700000.video: Timed out; first mode detect 4, It will stop the error output when the hostOS start to bootup.[ 739.598840] configfs-gadgetgadget: high-speed config #1: c [ 739.629961] aspeed_vhub 1e6a0000.usb-vhub: status direction mismatch Does this output make sense? Best, Xiuzhi ------------------ Original ------------------ From: "jae.hyun.yoo";; Date: Jun 1, 2019 To: "xiuzhi"<1450335857@qq.com>; "openbmc"; "eajames"; "joel"; "andrew"; Subject: Re: [PATCH dev-5.1 4/4] media: aspeed: add a workaround to fix asilicon bug (Jae Hyun Yoo) On 5/31/2019 4:21 AM, xiuzhi wrote: > Hi Jae, > I tested this patch ,it works on 1680*1050,but I found an issue: > > The ikvm webpage will be black screen when you reboot the host after > switching solution between 1680*1050 and 800*600 on chrome browser (my > chrome version is 65). > you can reproduce it: > 1, Set host screen solution to 1680*1050 and save it . ikvm webpage works > 2,Set host screen solution to 800*600 and save it. ikvm webpage works > 3,Reset host screen solution to 1680*1050 and save it, > 4,reboot the host, > 5, the ikvm webpage is black screen when boot to Centos GUI Hi Xiuzhi, Checked that the issue isn't related this patch. Actually, that is caused by the first patch of this patch series. Since the patch removes source buffer allocation before mode detection, remaining allocation logic should be changed accordingly, otherwise it can't allocate buffers and eventually causes the issue. I'll fix the first patch in the next spin. In the meantime, you can apply below quick fix on top of what you tested the issue. Thanks, Jae diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c index c2d4a2e6f20f..034f2f436d76 100644 --- a/drivers/media/platform/aspeed-video.c +++ b/drivers/media/platform/aspeed-video.c @@ -865,20 +865,14 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) size *= 4; - if (size == video->srcs[0].size / 2) { - aspeed_video_write(video, VE_SRC1_ADDR, - video->srcs[0].dma + size); - } else if (size == video->srcs[0].size) { - if (!aspeed_video_alloc_buf(video, &video->srcs[1], size)) - goto err_mem; - - aspeed_video_write(video, VE_SRC1_ADDR, video->srcs[1].dma); - } else { - aspeed_video_free_buf(video, &video->srcs[0]); + if (size != video->srcs[0].size) { + if (video->srcs[0].size) + aspeed_video_free_buf(video, &video->srcs[0]); + if (video->srcs[1].size) + aspeed_video_free_buf(video, &video->srcs[1]); if (!aspeed_video_alloc_buf(video, &video->srcs[0], size)) goto err_mem; - if (!aspeed_video_alloc_buf(video, &video->srcs[1], size)) goto err_mem;