From patchwork Tue May 28 12:35:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giulio Benetti X-Patchwork-Id: 1106303 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=micronovasrl.com Authentication-Results: ozlabs.org; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=micronovasrl.com header.i=@micronovasrl.com header.b="TARw8P2b"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45Ctc85zcfz9s00 for ; Tue, 28 May 2019 22:35:52 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3A44285317; Tue, 28 May 2019 12:35:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OlkpoMe1qCwg; Tue, 28 May 2019 12:35:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 1853285230; Tue, 28 May 2019 12:35:50 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 86F9B1BF3DC for ; Tue, 28 May 2019 12:35:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 83D1784EDB for ; Tue, 28 May 2019 12:35:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eaXCEY5k5889 for ; Tue, 28 May 2019 12:35:47 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.micronovasrl.com (mail.micronovasrl.com [212.103.203.10]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8879384E60 for ; Tue, 28 May 2019 12:35:47 +0000 (UTC) Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id 1349CB01328 for ; Tue, 28 May 2019 14:35:46 +0200 (CEST) Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=micronovasrl.com; h=x-mailer:message-id:date:date:subject:subject:to:from:from; s=dkim; t=1559046944; x=1559910945; bh=TwtNy8mpfOO/FUU7lU4gHffg IeoXlTqjeDGfa9gJkPU=; b=TARw8P2bNES70tv2ianS3xmRhyG05N8k1ukGqb3z gYD9lOgjy6dDKw5FYQ4/NcNaK0sSriBu9uy5YTAO4ZveyRMBAeYknRbxS48mPFfr 0X+q+rd3bLRSuKsQwFZ4s9ykC4SV1g6rPoZvJkaLdocoE/9QL0Pe9VA+O4XW5igh xiQ= X-Virus-Scanned: Debian amavisd-new at mail.micronovasrl.com Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ecZceGW3pUKP for ; Tue, 28 May 2019 14:35:44 +0200 (CEST) Received: from ubuntu.localdomain (88-149-228-83.v4.ngi.it [88.149.228.83]) by mail.micronovasrl.com (Postfix) with ESMTPSA id B8D59B01364; Tue, 28 May 2019 14:35:44 +0200 (CEST) From: Giulio Benetti To: buildroot@buildroot.org Date: Tue, 28 May 2019 14:35:43 +0200 Message-Id: <20190528123543.43882-1-giulio.benetti@micronovasrl.com> X-Mailer: git-send-email 2.17.1 Subject: [Buildroot] [PATCH] package/bullet: re-enable package when gcc bug 85180 is present X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Romain Naour MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" With Microblaze Gcc version < 8.x the build hangs to gcc bug 85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. This package has been excluded from building if the toolchain is affected by gcc bug 85180. To be consistent with how we deal with this issue in other packages, we re-enable the package and instead work around the issue by building with -O0, since gcc bug 85180 manifests itself only when optimization is enabled. To achieve this pass -O0 to CMAKE_CXX_FLAGS in CONF_OPT and remove 'depends on !BR2_microblaze' and its comment if not available from Config.in. Signed-off-by: Giulio Benetti --- package/bullet/Config.in | 4 ---- package/bullet/bullet.mk | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package/bullet/Config.in b/package/bullet/Config.in index d4d69d2c9e..fc285ab33a 100644 --- a/package/bullet/Config.in +++ b/package/bullet/Config.in @@ -1,9 +1,6 @@ config BR2_PACKAGE_BULLET bool "bullet" depends on BR2_INSTALL_LIBSTDCPP - # Affected by - # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68476 - depends on !BR2_microblaze help Bullet is a Collision Detection and Rigid Body Dynamics Library. @@ -12,4 +9,3 @@ config BR2_PACKAGE_BULLET comment "bullet needs a toolchain w/ C++" depends on !BR2_INSTALL_LIBSTDCPP - depends on !BR2_microblaze diff --git a/package/bullet/bullet.mk b/package/bullet/bullet.mk index 36aaa157e1..7cde20ee58 100644 --- a/package/bullet/bullet.mk +++ b/package/bullet/bullet.mk @@ -23,4 +23,8 @@ else BULLET_CONF_OPTS += -DBUILD_EXTRAS=OFF endif +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) +BULLET_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -O0" +endif + $(eval $(cmake-package))