From patchwork Sun May 26 09:13:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 1105533 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-501677-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="A1wyxcFO"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45BZDs0cJ8z9s9T for ; Sun, 26 May 2019 19:14:27 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; q=dns; s= default; b=miH2IO1t5AK+NY8CrA8OWNV5MoAgICVcDd9+AwSejgHaNjYqYohR8 4VMD6AKK41Q2NmyH6jAJFST87YzlfCz0coDjk+O0Y1REi6oHqMfRr3G6PJp5tism eezP7zJB+lVnFTzbZeWoRTkkJvJRCru2A/o/gFK5PKfmQAH8XQ+mcU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; s= default; bh=PMZpw9+eperb4iWLz1eu2d7wg8Q=; b=A1wyxcFOL25EGiM6haIJ 9vXbbc0P0KiqvWKRu642rcH/W9Vmo/uuYn/5ujBdi8nNu0vwmKP6N9KXeXQXwQm0 DrQlNAjpL0OZkdq5BDvp8Z+XPgdhUFNtRyOZ6d31zSZMif2JwTfKq8+iaRRLsI9b Tv0Ta606Exwz6ReOb5bSST8= Received: (qmail 99278 invoked by alias); 26 May 2019 09:14:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 99221 invoked by uid 89); 26 May 2019 09:14:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT autolearn=ham version=3.3.1 spammy=i386.c, i386c, UD:i386.c, bother X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 26 May 2019 09:14:06 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 9C15BE68 for ; Sun, 26 May 2019 11:14:02 +0200 (CEST) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id A9D+iPb8FFgA for ; Sun, 26 May 2019 11:13:57 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p54ACF8DB.dip0.t-ipconnect.de [84.172.248.219]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 4CD48E67 for ; Sun, 26 May 2019 11:13:57 +0200 (CEST) From: Rainer Orth To: gcc-patches@gcc.gnu.org Subject: Remove obsolete comment about use_thunk Date: Sun, 26 May 2019 11:13:56 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes When reviewing how this patch [PATCH] gcc: move assemble_start_function / assemble_end_function to output_mi_thunk https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00722.html might affect Solaris, I noticed an obsolete comment Note that use_thunk calls assemble_start_function et al. */ that in one form or another is present in several targets, but has been wrong for almost 10 years when r154736 ripped out those calls to assemble_*_function in use_thunk. The following patch corrects this. Bootstrapped on i386-pc-solaris2.11 and sparc-sun-solaris2.11; I didn't bother to try and build cc1 on all other affected targets, though. Ok for mainline? I guess this is obvious. Rainer # HG changeset patch # Parent 74a1aea7c39d71273fd4f28d937e03f593e92778 Remove obsolete comment about use_thunk diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c --- a/gcc/config/alpha/alpha.c +++ b/gcc/config/alpha/alpha.c @@ -8514,8 +8514,7 @@ alpha_output_mi_thunk_osf (FILE *file, t /* Run just enough of rest_of_compilation to get the insns emitted. There's not really enough bulk here to make other passes such as - instruction scheduling worth while. Note that use_thunk calls - assemble_start_function and assemble_end_function. */ + instruction scheduling worth while. */ insn = get_insns (); shorten_branches (insn); assemble_start_function (thunk_fndecl, fnname); diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -19983,8 +19983,7 @@ x86_output_mi_thunk (FILE *file, tree th } emit_barrier (); - /* Emit just enough of rest_of_compilation to get the insns emitted. - Note that use_thunk calls assemble_start_function et al. */ + /* Emit just enough of rest_of_compilation to get the insns emitted. */ insn = get_insns (); shorten_branches (insn); assemble_start_function (thunk_fndecl, fnname); diff --git a/gcc/config/ia64/ia64.c b/gcc/config/ia64/ia64.c --- a/gcc/config/ia64/ia64.c +++ b/gcc/config/ia64/ia64.c @@ -11033,8 +11033,7 @@ ia64_output_mi_thunk (FILE *file, tree t /* Run just enough of rest_of_compilation to get the insns emitted. There's not really enough bulk here to make other passes such as - instruction scheduling worth while. Note that use_thunk calls - assemble_start_function and assemble_end_function. */ + instruction scheduling worth while. */ emit_all_insn_group_barriers (NULL); insn = get_insns (); diff --git a/gcc/config/nios2/nios2.c b/gcc/config/nios2/nios2.c --- a/gcc/config/nios2/nios2.c +++ b/gcc/config/nios2/nios2.c @@ -4519,8 +4519,7 @@ nios2_asm_output_mi_thunk (FILE *file, t /* Run just enough of rest_of_compilation to get the insns emitted. There's not really enough bulk here to make other passes such as - instruction scheduling worth while. Note that use_thunk calls - assemble_start_function and assemble_end_function. */ + instruction scheduling worth while. */ insn = get_insns (); shorten_branches (insn); assemble_start_function (thunk_fndecl, fnname); diff --git a/gcc/config/or1k/or1k.c b/gcc/config/or1k/or1k.c --- a/gcc/config/or1k/or1k.c +++ b/gcc/config/or1k/or1k.c @@ -2112,8 +2112,7 @@ or1k_output_mi_thunk (FILE *file, tree t /* Run just enough of rest_of_compilation to get the insns emitted. There's not really enough bulk here to make other passes such as - instruction scheduling worth while. Note that use_thunk calls - assemble_start_function and assemble_end_function. */ + instruction scheduling worth while. */ insn = get_insns (); shorten_branches (insn); assemble_start_function (thunk_fndecl, fnname); diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -29296,8 +29296,7 @@ rs6000_output_mi_thunk (FILE *file, tree /* Run just enough of rest_of_compilation to get the insns emitted. There's not really enough bulk here to make other passes such as - instruction scheduling worth while. Note that use_thunk calls - assemble_start_function and assemble_end_function. */ + instruction scheduling worth while. */ insn = get_insns (); shorten_branches (insn); assemble_start_function (thunk_fndecl, fnname); diff --git a/gcc/config/sh/sh.c b/gcc/config/sh/sh.c --- a/gcc/config/sh/sh.c +++ b/gcc/config/sh/sh.c @@ -10940,8 +10940,7 @@ sh_output_mi_thunk (FILE *file, tree thu emit_barrier (); /* Run just enough of rest_of_compilation to do scheduling and get - the insns emitted. Note that use_thunk calls - assemble_start_function and assemble_end_function. */ + the insns emitted. */ insns = get_insns (); diff --git a/gcc/config/sparc/sparc.c b/gcc/config/sparc/sparc.c --- a/gcc/config/sparc/sparc.c +++ b/gcc/config/sparc/sparc.c @@ -12482,8 +12482,7 @@ sparc_output_mi_thunk (FILE *file, tree /* Run just enough of rest_of_compilation to get the insns emitted. There's not really enough bulk here to make other passes such as - instruction scheduling worth while. Note that use_thunk calls - assemble_start_function and assemble_end_function. */ + instruction scheduling worth while. */ insn = get_insns (); shorten_branches (insn); assemble_start_function (thunk_fndecl, fnname); diff --git a/gcc/config/tilegx/tilegx.c b/gcc/config/tilegx/tilegx.c --- a/gcc/config/tilegx/tilegx.c +++ b/gcc/config/tilegx/tilegx.c @@ -4993,8 +4993,7 @@ tilegx_output_mi_thunk (FILE *file, tree /* Run just enough of rest_of_compilation to get the insns emitted. There's not really enough bulk here to make other passes such as - instruction scheduling worth while. Note that use_thunk calls - assemble_start_function and assemble_end_function. + instruction scheduling worth while. We don't currently bundle, but the instruciton sequence is all serial except for the tail call, so we're only wasting one cycle. diff --git a/gcc/config/tilepro/tilepro.c b/gcc/config/tilepro/tilepro.c --- a/gcc/config/tilepro/tilepro.c +++ b/gcc/config/tilepro/tilepro.c @@ -4416,8 +4416,7 @@ tilepro_asm_output_mi_thunk (FILE *file, /* Run just enough of rest_of_compilation to get the insns emitted. There's not really enough bulk here to make other passes such as - instruction scheduling worth while. Note that use_thunk calls - assemble_start_function and assemble_end_function. + instruction scheduling worth while. We don't currently bundle, but the instruciton sequence is all serial except for the tail call, so we're only wasting one cycle.