From patchwork Sat May 25 22:22:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1105428 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="d6PuE/1c"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45BHmN4dRNz9s9N for ; Sun, 26 May 2019 08:22:26 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C3ED6227EC; Sat, 25 May 2019 22:22:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1cmH1EPYwvTr; Sat, 25 May 2019 22:22:19 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id B4067230E6; Sat, 25 May 2019 22:22:19 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id E275F1BF5A7 for ; Sat, 25 May 2019 22:22:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id DF943230E6 for ; Sat, 25 May 2019 22:22:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VvqNjvxwlrM0 for ; Sat, 25 May 2019 22:22:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by silver.osuosl.org (Postfix) with ESMTPS id AD27A227EC for ; Sat, 25 May 2019 22:22:16 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id u16so9348963wrn.8 for ; Sat, 25 May 2019 15:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IFLRuj5pKB/eIIErgXjxSdmArr4oySDHx8KNQQgUEBg=; b=d6PuE/1czCS0Jzor9N0nOtuEEQtBGrZAi0pO+MoNbO891zex6d9W0moC8So2tBMSqx dWmo2C0tiv5uk50ngWTCooigD2cwrNzsoEVqK5JjUnomfcRDoNQlojnORxSONrctosoB ToGzt7flCg+1VoQWK9h8xN8zvbvdwZQfTMpRTPmeUXwA+DfmsZDctYKtCf1zc1l+Og1Q dS1XSSUuG6AkPcSkx2HETGpfxjWWm6rQW/IKDyRypJdgH/KROtHwwdBQc8TbMf5EVeN6 WjOcdro9EwPBQMOO23KQZP00rUAETEFaCD/BgG2eXu5lU7jhh9/1T7Y59tiTuCNyArj0 5uWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IFLRuj5pKB/eIIErgXjxSdmArr4oySDHx8KNQQgUEBg=; b=IqzZMPx2HvNwQS0kPl4c3nBd+dVrn7Rasrr68xROTIHCviNGPbZfJv6Zlm1aDTPZcF mNEo9dJphpCx7O7fyvMWwmxvI3kQL5LGgwXycbw6QhvBiygRf1GyBFcZNMIvrlWl+IfX EBLEtcdHNp1G+maQ6pxaGIoJcN2nkBhN2JQjB9wpW+BQHfvssgdtQ6yqdsTq1yAqmuQy 139k4pGK67eJ16lzEQrDnkkEvG623UG2CnAB1JeeXccb3YGXmkEVJ5SQu3lFowQd8z1s 1khJBUAyZzJTbzlg2FtQPO8dfNqXO9yFZelv5mba34K7BxaCMEgwYaymGjsYM00/Y7S+ feSw== X-Gm-Message-State: APjAAAXJOvlaLHYQg0pYdq3Oflk73hTI39qm2MJkBCVXurXx4xRg+Y45 LPUPYWQDtF2eRTtIDLF0p+XxjhCHaxM= X-Google-Smtp-Source: APXvYqziFGJASzwSPZeTsfh6SrH5QetpHkc8lh9VwP3SfkoqFcH66c/PGCQgI0cldM6JzK7ikeZAYQ== X-Received: by 2002:adf:dfd0:: with SMTP id q16mr13611643wrn.235.1558822934868; Sat, 25 May 2019 15:22:14 -0700 (PDT) Received: from kali.home (lfbn-ren-1-314-196.w2-10.abo.wanadoo.fr. [2.10.15.196]) by smtp.gmail.com with ESMTPSA id h14sm3201306wro.3.2019.05.25.15.22.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 May 2019 15:22:13 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Sun, 26 May 2019 00:22:09 +0200 Message-Id: <20190525222209.14372-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2, 1/1] package/kvm-unit-tests: fix build without ssp on x86_64 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cyril Bur , Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Makefile tries to detect stack-protector which will result in build failure on x86_64 if ssp is not available on host compiler so disable stack protector through EXTRA_CFLAGS Fixes: - http://autobuild.buildroot.org/results/e6f767755ffdb5ecc014eb5ad7519814f075a60e Signed-off-by: Fabrice Fontaine --- Changes v1 -> v2 (after review of Peter Korsgaard): - Always disable stack-protector on x86_64 as we're using host compiler package/kvm-unit-tests/kvm-unit-tests.mk | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/package/kvm-unit-tests/kvm-unit-tests.mk b/package/kvm-unit-tests/kvm-unit-tests.mk index 92d67fb34b..72762d21f2 100644 --- a/package/kvm-unit-tests/kvm-unit-tests.mk +++ b/package/kvm-unit-tests/kvm-unit-tests.mk @@ -37,6 +37,8 @@ KVM_UNIT_TESTS_CONF_OPTS =\ # x86-64 cannot do. ifneq ($(BR2_x86_64),y) KVM_UNIT_TESTS_CONF_OPTS += --cross-prefix="$(TARGET_CROSS)" +# Don't force -fstack-protector as we don't know if host compiler supports ssp +KVM_UNIT_TESTS_MAKE_OPTS += EXTRA_CFLAGS=-fno-stack-protector endif define KVM_UNIT_TESTS_CONFIGURE_CMDS @@ -44,11 +46,12 @@ define KVM_UNIT_TESTS_CONFIGURE_CMDS endef define KVM_UNIT_TESTS_BUILD_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) standalone + $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ + standalone endef define KVM_UNIT_TESTS_INSTALL_TARGET_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ + $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ DESTDIR=$(TARGET_DIR)/usr/share/kvm-unit-tests/ \ install endef