From patchwork Wed May 22 07:08:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 1103212 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="B5eIQBaT"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 4583d06F7sz9s6w for ; Wed, 22 May 2019 17:08:20 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 7C32DC21E0B; Wed, 22 May 2019 07:08:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id C1A50C21C2F; Wed, 22 May 2019 07:08:13 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id A7EA8C21C2C; Wed, 22 May 2019 07:08:11 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150081.outbound.protection.outlook.com [40.107.15.81]) by lists.denx.de (Postfix) with ESMTPS id 50450C21BE5 for ; Wed, 22 May 2019 07:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mg4nXdryUNUpzUb1ieh4QbExetJrR8kjfk/5DRAtS5E=; b=B5eIQBaTK0l5wUdWc5zs18LpB66KqP/nmGY4TSN2Nca91+jk1+F35QCn6Ou+RD45K92FkK6KjZcepW4jtu2S/b3zPciKiIg0carCvgw9lcqrqRjrCIIQsK4J5H+NCqUTYYK1M3Mf8KMa7WYCpcyC8GdKs8p56A62E/oCvkVUpP4= Received: from AM0PR04MB4481.eurprd04.prod.outlook.com (52.135.147.15) by AM0PR04MB6356.eurprd04.prod.outlook.com (10.255.182.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.17; Wed, 22 May 2019 07:08:10 +0000 Received: from AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::3173:24:d401:2378]) by AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::3173:24:d401:2378%6]) with mapi id 15.20.1900.020; Wed, 22 May 2019 07:08:10 +0000 From: Peng Fan To: "sjg@chromium.org" Thread-Topic: [PATCH V2 1/3] test: dm: adc: use the real device name Thread-Index: AQHVEG0cus5Q7qcnDEK8sJd2SxW0Rw== Date: Wed, 22 May 2019 07:08:09 +0000 Message-ID: <20190522072201.5130-1-peng.fan@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.16.4 x-clientproxiedby: HK2PR02CA0157.apcprd02.prod.outlook.com (2603:1096:201:1f::17) To AM0PR04MB4481.eurprd04.prod.outlook.com (2603:10a6:208:70::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d7834d99-493d-48d2-2fd0-08d6de843f2f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR04MB6356; x-ms-traffictypediagnostic: AM0PR04MB6356: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-forefront-prvs: 0045236D47 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(199004)(189003)(2501003)(6116002)(3846002)(1076003)(5640700003)(6512007)(68736007)(6436002)(498600001)(6486002)(66556008)(64756008)(66946007)(2906002)(66476007)(71190400001)(71200400001)(53936002)(256004)(14454004)(73956011)(5660300002)(66446008)(4326008)(7736002)(54906003)(36756003)(25786009)(52116002)(6506007)(102836004)(66066001)(50226002)(44832011)(81156014)(8676002)(386003)(81166006)(8936002)(1730700003)(86362001)(6916009)(305945005)(2351001)(2616005)(26005)(476003)(486006)(99286004)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB6356; H:AM0PR04MB4481.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: GWBrQJB3OP1qJk60Mfq5Ir4lcwU4Y38bLuA7XVY2sqLQVVNBcKMD81bdCADb6gkA0emGElcgrukE8t9JTDQBRREg1xtSt7pns+cbO53XvueKhXuID7NXyDwESmWJAHWqDqpLvZWrn/ROmpsr47p/8VrJzVXrcVz/GnvfpffLR6NZBWRv4P+9+rspTFg0m/nh57ESUG/lVO103qx/ygRw/kunZT2Rr7hR8eBsKn/A+9cHJwPjzRg7gwSg9bfpkZItsA4OICYC86u0EhuViobyPxkB5Zj9g2h7Fo5AtBpseVOYoy7G8pr0134h1Z0DX0C5coSVx2d/EOOdvYJ2iFq7XuYP60S9e8m8kCGvr0o9+jElXSqIeLcUH/a58KTUwgWdFzhvAHrj6E5zUFSz4T4MKWhWyi96xu7umUieNl5rcJo= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7834d99-493d-48d2-2fd0-08d6de843f2f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2019 07:08:10.0288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6356 Cc: "u-boot@lists.denx.de" , dl-uboot-imx Subject: [U-Boot] [PATCH V2 1/3] test: dm: adc: use the real device name X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" "adc" is not the real device name, "adc@0" is. Signed-off-by: Peng Fan Reviewed-by: Bin Meng --- V2: new test/dm/adc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test/dm/adc.c b/test/dm/adc.c index 1f82304f41..da7bd4bf1f 100644 --- a/test/dm/adc.c +++ b/test/dm/adc.c @@ -24,7 +24,7 @@ static int dm_test_adc_bind(struct unit_test_state *uts) struct udevice *dev; unsigned int channel_mask; - ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev)); + ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc@0", &dev)); ut_asserteq_str(SANDBOX_ADC_DEVNAME, dev->name); ut_assertok(adc_channel_mask(dev, &channel_mask)); @@ -38,7 +38,7 @@ static int dm_test_adc_wrong_channel_selection(struct unit_test_state *uts) { struct udevice *dev; - ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev)); + ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc@0", &dev)); ut_asserteq(-EINVAL, adc_start_channel(dev, SANDBOX_ADC_CHANNELS)); return 0; @@ -51,7 +51,7 @@ static int dm_test_adc_supply(struct unit_test_state *uts) struct udevice *dev; int uV; - ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev)); + ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc@0", &dev)); /* Test Vss value - predefined 0 uV */ ut_assertok(adc_vss_value(dev, &uV)); @@ -94,7 +94,7 @@ static int dm_test_adc_single_channel_conversion(struct unit_test_state *uts) unsigned int i, data; struct udevice *dev; - ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev)); + ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc@0", &dev)); /* Test each ADC channel's value */ for (i = 0; i < SANDBOX_ADC_CHANNELS; i++, tdata++) { ut_assertok(adc_start_channel(dev, tdata->id)); @@ -117,7 +117,7 @@ static int dm_test_adc_multi_channel_conversion(struct unit_test_state *uts) ADC_CHANNEL(2) | ADC_CHANNEL(3); /* Start multi channel conversion */ - ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev)); + ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc@0", &dev)); ut_assertok(adc_start_channels(dev, channel_mask)); ut_assertok(adc_channels_data(dev, channel_mask, channels)); @@ -136,7 +136,7 @@ static int dm_test_adc_single_channel_shot(struct unit_test_state *uts) for (i = 0; i < SANDBOX_ADC_CHANNELS; i++, tdata++) { /* Start single channel conversion */ - ut_assertok(adc_channel_single_shot("adc", tdata->id, &data)); + ut_assertok(adc_channel_single_shot("adc@0", tdata->id, &data)); /* Compare the expected and returned conversion data. */ ut_asserteq(tdata->data, data); } @@ -155,7 +155,7 @@ static int dm_test_adc_multi_channel_shot(struct unit_test_state *uts) ADC_CHANNEL(2) | ADC_CHANNEL(3); /* Start single call and multi channel conversion */ - ut_assertok(adc_channels_single_shot("adc", channel_mask, channels)); + ut_assertok(adc_channels_single_shot("adc@0", channel_mask, channels)); /* Compare the expected and returned conversion data. */ for (i = 0; i < SANDBOX_ADC_CHANNELS; i++, tdata++) @@ -183,7 +183,7 @@ static int dm_test_adc_raw_to_uV(struct unit_test_state *uts) struct udevice *dev; int uV; - ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc", &dev)); + ut_assertok(uclass_get_device_by_name(UCLASS_ADC, "adc@0", &dev)); /* Test each ADC channel's value in microvolts */ for (i = 0; i < SANDBOX_ADC_CHANNELS; i++, tdata++) { ut_assertok(adc_start_channel(dev, tdata->id)); From patchwork Wed May 22 07:08:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 1103213 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Sib0q+aQ"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 4583dD2ltRz9s55 for ; Wed, 22 May 2019 17:08:32 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 15C6FC21DEC; Wed, 22 May 2019 07:08:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 55BDFC21BE5; Wed, 22 May 2019 07:08:16 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id D9C99C21C8B; Wed, 22 May 2019 07:08:13 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150048.outbound.protection.outlook.com [40.107.15.48]) by lists.denx.de (Postfix) with ESMTPS id 81CC3C21BE5 for ; Wed, 22 May 2019 07:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wDsDtS8Jy/7zhxm2nPJhUENTwBqumxbqMzwvwHtIhyU=; b=Sib0q+aQygW4XeaKlhbbOWw9IhQrObE3+ory6+eUAbM6KM6dC1Fe2B17XuhioWXawc+DAle/2DjtccO+Y/t6IYfHu4d4bYgNqXxHMM1Ew06EJH6PKEJXmusHJGsmognFlvixS8XI65VzQLh3swzLZR62QL78X570TlgwRF6a7T4= Received: from AM0PR04MB4481.eurprd04.prod.outlook.com (52.135.147.15) by AM0PR04MB6356.eurprd04.prod.outlook.com (10.255.182.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.17; Wed, 22 May 2019 07:08:12 +0000 Received: from AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::3173:24:d401:2378]) by AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::3173:24:d401:2378%6]) with mapi id 15.20.1900.020; Wed, 22 May 2019 07:08:12 +0000 From: Peng Fan To: "sjg@chromium.org" Thread-Topic: [PATCH V2 2/3] test: dm: usb: use the real device name Thread-Index: AQHVEG0eAbsilN7uK02GWlziiKaV2g== Date: Wed, 22 May 2019 07:08:12 +0000 Message-ID: <20190522072201.5130-2-peng.fan@nxp.com> References: <20190522072201.5130-1-peng.fan@nxp.com> In-Reply-To: <20190522072201.5130-1-peng.fan@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.16.4 x-clientproxiedby: HK2PR02CA0157.apcprd02.prod.outlook.com (2603:1096:201:1f::17) To AM0PR04MB4481.eurprd04.prod.outlook.com (2603:10a6:208:70::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b449187e-44b8-45f9-5d56-08d6de844077 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR04MB6356; x-ms-traffictypediagnostic: AM0PR04MB6356: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-forefront-prvs: 0045236D47 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(199004)(189003)(2501003)(6116002)(3846002)(1076003)(5640700003)(6512007)(68736007)(6436002)(498600001)(6486002)(66556008)(64756008)(66946007)(2906002)(66476007)(71190400001)(71200400001)(53936002)(256004)(14444005)(14454004)(73956011)(5660300002)(66446008)(4326008)(11346002)(4744005)(7736002)(54906003)(36756003)(25786009)(52116002)(6506007)(102836004)(66066001)(50226002)(44832011)(81156014)(8676002)(386003)(81166006)(8936002)(1730700003)(86362001)(446003)(6916009)(305945005)(2351001)(2616005)(76176011)(26005)(476003)(486006)(99286004)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB6356; H:AM0PR04MB4481.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BDxXYPYVfwLekMiHWSeXKumA48SRelctVQeD+7CxUl/VAV9gAGvzMyinp6W1jvaPWY9r2SP2n5x/LkRZHmcBbsBgR/ypnWscbXgkyJhFE4P4ml20eNX4b+u2IU+rxx+8rNG9jM5UTzl1T2LRIpsSkiXBOY9F+gBcWOB9hHq3iIm33TtHb0NjIbnb9KT7PXhGVnlaoaAs2v7ac8iNI32N2GJlGbNu+jGAellLTZJJxDT+MBsancuKk7srbCUbWxe+/U2yPOh9E7IRLPadKRwzb5HVhySSl9YBxWzAN+2N6MX6VxhyBxs9pCeuCo8wOtvcbQ2sbUEz8nYA8zP97bum7mzYZeh4nMsfSzJPybhQZChDAX+DLCaex69BGc1Il/F57UN7G67RaSvy8qZuoE1z+y6TBO8ClZgCSUEDZcsL/Uc= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b449187e-44b8-45f9-5d56-08d6de844077 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2019 07:08:12.2844 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6356 Cc: "u-boot@lists.denx.de" , dl-uboot-imx Subject: [U-Boot] [PATCH V2 2/3] test: dm: usb: use the real device name X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" "keyb" is not the real device name, "keyb@3" is. Signed-off-by: Peng Fan Reviewed-by: Bin Meng --- V2: New test/dm/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/dm/usb.c b/test/dm/usb.c index 3493617544..ef454b0ae5 100644 --- a/test/dm/usb.c +++ b/test/dm/usb.c @@ -125,7 +125,7 @@ static int dm_test_usb_keyb(struct unit_test_state *uts) /* Initially there should be no characters */ ut_asserteq(0, tstc()); - ut_assertok(uclass_get_device_by_name(UCLASS_USB_EMUL, "keyb", + ut_assertok(uclass_get_device_by_name(UCLASS_USB_EMUL, "keyb@3", &dev)); /* From patchwork Wed May 22 07:08:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 1103214 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="GtN5dIs9"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 4583f12PsZz9s7h for ; Wed, 22 May 2019 17:09:13 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 0A517C21DD3; Wed, 22 May 2019 07:08:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D33EDC21C93; Wed, 22 May 2019 07:08:31 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id DC1EAC21BE5; Wed, 22 May 2019 07:08:19 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150058.outbound.protection.outlook.com [40.107.15.58]) by lists.denx.de (Postfix) with ESMTPS id AF75CC21DD4 for ; Wed, 22 May 2019 07:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uJ0VRPhr240EXiedd2ZrXhSq5JMC3u1hARzpkADAPU0=; b=GtN5dIs9QeKqCdmRi1q+byZDixVELE8cASb3953Opv3Tmg1rsstImQJ1RD2cNJzZT7K70tXpYMPhmhwnt648PAZXGcQ5V/YvdE3vKvsB775NmI0uDd/aXC2tswdebpchmrAgbI1bG5fAN5Pw0XQ5w+mmLx+jx0wRcuRn1q7nUKc= Received: from AM0PR04MB4481.eurprd04.prod.outlook.com (52.135.147.15) by AM0PR04MB6356.eurprd04.prod.outlook.com (10.255.182.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.17; Wed, 22 May 2019 07:08:14 +0000 Received: from AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::3173:24:d401:2378]) by AM0PR04MB4481.eurprd04.prod.outlook.com ([fe80::3173:24:d401:2378%6]) with mapi id 15.20.1900.020; Wed, 22 May 2019 07:08:14 +0000 From: Peng Fan To: "sjg@chromium.org" Thread-Topic: [PATCH V2 3/3] drivers: core: use strcmp when find device by name Thread-Index: AQHVEG0fv8ljaCn560q4G8hM62SlJQ== Date: Wed, 22 May 2019 07:08:14 +0000 Message-ID: <20190522072201.5130-3-peng.fan@nxp.com> References: <20190522072201.5130-1-peng.fan@nxp.com> In-Reply-To: <20190522072201.5130-1-peng.fan@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.16.4 x-clientproxiedby: HK2PR02CA0157.apcprd02.prod.outlook.com (2603:1096:201:1f::17) To AM0PR04MB4481.eurprd04.prod.outlook.com (2603:10a6:208:70::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16f66f4b-0884-4ee7-6285-08d6de8441d1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR04MB6356; x-ms-traffictypediagnostic: AM0PR04MB6356: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1051; x-forefront-prvs: 0045236D47 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(199004)(189003)(2501003)(6116002)(3846002)(1076003)(5640700003)(6512007)(68736007)(6436002)(498600001)(6486002)(66556008)(64756008)(66946007)(2906002)(66476007)(71190400001)(71200400001)(53936002)(256004)(14444005)(14454004)(73956011)(5660300002)(66446008)(4326008)(11346002)(4744005)(7736002)(54906003)(36756003)(25786009)(52116002)(6506007)(102836004)(66066001)(50226002)(44832011)(81156014)(8676002)(386003)(81166006)(8936002)(1730700003)(86362001)(446003)(6916009)(305945005)(2351001)(2616005)(76176011)(26005)(476003)(486006)(99286004)(186003)(40753002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB6356; H:AM0PR04MB4481.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: yYSviyU63njGeg6PBHnFF9l0wfyYO5qdD4ixQL1sCVE0gbpcX2rZodI+ortblkRuV1tF40P64mCQNUCbiDQVjOMH6OEY4g6IVE2uQxda08Iq35lgdNldzIa3xIqQY2bXXyHATMrgyjdgIGrPRbU2FsMUbaUjGGSHyrYB1bCskaMur7bVRZrqm26Zn0db00Sa/cnFUxFCbg+DuItmwunixt3K3fTqqPRcLyCJ7miOgmo8y28z74gSikcoZc//Vl+ahbEV4mPLVRkcv6jBqyatruOGdzxYONANcqGP/EOwqZHuMndbDfGhMWhIEnFQt/MHHxV3aS/v+kL8wBS0F8/KYNljz/gNjGjhdy/yo9hYOnerJG7VtCj/vJXqsstPyOn0i4tBte3PyJQ82EVLZmO0pCywD+5MV4TM6YyBGtR+e2w= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16f66f4b-0884-4ee7-6285-08d6de8441d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2019 07:08:14.5841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6356 Cc: "u-boot@lists.denx.de" , dl-uboot-imx Subject: [U-Boot] [PATCH V2 3/3] drivers: core: use strcmp when find device by name X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" `if (!strncmp(dev->name, name, strlen(name)))` might find out the wrong device, it might find out `dram_pll_ref_sel`, when name is `dram_pll`. So use strcmp to avoid such issue. Signed-off-by: Peng Fan Reviewed-by: Simon Glass Reviewed-by: Bin Meng --- V2: None drivers/core/uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index fc3157de39..e2f35393a9 100644 --- a/drivers/core/uclass.c +++ b/drivers/core/uclass.c @@ -260,7 +260,7 @@ int uclass_find_device_by_name(enum uclass_id id, const char *name, return ret; uclass_foreach_dev(dev, uc) { - if (!strncmp(dev->name, name, strlen(name))) { + if (!strcmp(dev->name, name)) { *devp = dev; return 0; }