From patchwork Fri May 17 11:45:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1100996 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-501012-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="aeNGn6Hf"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45561T4Yn5z9s3l for ; Fri, 17 May 2019 21:45:47 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:mime-version :content-type; q=dns; s=default; b=ufqVmy1YL9z3KAIq7ibxqgXi8mEA7 Q2IzGvuJMBDVzM8tyaD/n2ss6MwEHQhis1GS41aICGTV2wWG14pWijxo6dXG10BA FR2dE0mGT52DIrxka56E+NfsKVDoKQBKNJP6AHCA+bw2cpJZnaXB3Dr6zOk0sRtU k41RTuShuMMoqk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:mime-version :content-type; s=default; bh=RKz+nIRTqNey0osNo84y1oHn9ug=; b=aeN Gn6Hf7o421455fbUwNhCkaccsXOZcOJXgdCU2raIBP59wZ8BM5cpoRyTse60+aXd wdi1OYSqv71wPCVdhxGekhi7lWL6QnzoUu+/BRx7WZzOLhfN7BrLHXWGUG/iPYqt iFkQBl21rfe1KuQZCQq+MvhMBZAHOC30WnulpEQ0= Received: (qmail 117899 invoked by alias); 17 May 2019 11:45:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 117714 invoked by uid 89); 17 May 2019 11:45:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=forgotten, ms X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 May 2019 11:45:35 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2DCB9C057E3C; Fri, 17 May 2019 11:45:29 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-52.ams2.redhat.com [10.36.116.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C70D75B096; Fri, 17 May 2019 11:45:28 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id x4HBjQRr016603; Fri, 17 May 2019 13:45:26 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id x4HBjPX5016602; Fri, 17 May 2019 13:45:25 +0200 Date: Fri, 17 May 2019 13:45:25 +0200 From: Jakub Jelinek To: Thomas Koenig Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH] Export forgotten _gfortran_{, m, s}findloc0_i2 (PR fortran/54613) Message-ID: <20190517114525.GI19695@tucnak> Reply-To: Jakub Jelinek MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.11.3 (2019-02-01) X-IsSubscribed: yes Hi! I've found that gfortran.map doesn't export these 3 symbols (while it does export other variants, with i1, i4, i8, i16, etc.). Do we want to export them from both GCC 9.2 and 10 the following way, or just on the trunk using GFORTRAN_10? Tested on x86_64-linux. Another thing is, but that one isn't just about exported symbols, but also about not even generating such files and listing them in Makefile.am, there are no findloc r10 entrypoints. Is that intentional? BTW, this shows that there is no testsuite coverage for findloc (but apparently not for minloc, maxloc etc.) that would actually try all the supported kinds and have at least one test for each supported kind, that is something that would have caught this. 2019-05-17 Jakub Jelinek PR fortran/54613 * gfortran.map (GFORTRAN_9.2): New symbol version, export _gfortran_{,m,s}findloc0_i2 in it. Jakub --- libgfortran/gfortran.map.jj 2019-01-14 22:13:47.503717103 +0100 +++ libgfortran/gfortran.map 2019-05-17 12:53:34.614042579 +0200 @@ -1590,3 +1590,9 @@ GFORTRAN_9 { __ieee_arithmetic_MOD_ieee_support_subnormal_8; __ieee_arithmetic_MOD_ieee_support_subnormal_noarg; } GFORTRAN_8; + +GFORTRAN_9.2 { + _gfortran_findloc0_i2; + _gfortran_mfindloc0_i2; + _gfortran_sfindloc0_i2; +} GFORTRAN_9;