From patchwork Thu May 16 20:01:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1100707 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fwhFzIr+"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 454j4f2nTKz9sBp for ; Fri, 17 May 2019 06:02:09 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id B4297C21DD4; Thu, 16 May 2019 20:02:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2E6C5C21C3F; Thu, 16 May 2019 20:02:03 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 60819C21C3F; Thu, 16 May 2019 20:02:02 +0000 (UTC) Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by lists.denx.de (Postfix) with ESMTPS id DA786C21C29 for ; Thu, 16 May 2019 20:02:01 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id z128so3093133qkb.6 for ; Thu, 16 May 2019 13:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=pyoSv71IOf5OOOmX7BQZEkve7DU2HTBaMwvqCJzrQdc=; b=fwhFzIr+lAbe8AiJrlSc+6/Sb5B3jfcBCrwOtCnzoBJOk/Ly2gK7ujjxnXwlPrids3 OM7mL9JJKFTKihuTHDWj9WKM3sOdLZ/HNBOUl3CWcgbZ/ea7i1pGb40izCRcppXlsmZO ND282PVrQ1xR935+bfp4JcQYO8h6ALwuum82DhkNKDv4jcFwGyy7sClJ2iNd0gqUTH0R RACX/95TPYj4IMtbpr3xL55UJMaqrP+NJDYqWxE2OKiGlA/zRoDqaKJEC13abuSVrVHy ojMCpDTvof0L/V1mL3wqtO8hdaW46yxKN9w2jCTYbx5n9oNNJQ65o6w47JzTwxobXc+O xMMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pyoSv71IOf5OOOmX7BQZEkve7DU2HTBaMwvqCJzrQdc=; b=W427dfKuZvAv/WXDjWGwLfrNOGow/B5G3cR8X1vG8IszKwVCE2BnPcfgGHpRLbdEak CLQ1CS5vUyyajWpD5gEdqEuGmk5y6AKuAaw+SZFp6HyAhUaofDChoDeOiBSyZShbisv2 7sz/nQJlg+NLolWkjH0/vkMVLm38yW9vsU+qRBmm63u3QxA/XAfb0NWqIvSEmECpScjD wLDrZLHxgfcbDCzYaTmOWaUTIqHpgFgUYlNyjykCT8RQnCpa9milAF2Ll1OFwwj/6TUP +9Sw9qrGgPMJpgA9N//j4NJmqUJgiIYd0fdsPoOoFPWeVWwPEwskUzO5iObYfNCz1rgp vQFw== X-Gm-Message-State: APjAAAWO3jqPLjPUuZI1RqbrQ2OPchc+IdtrPnIwpyHotUBe5cyH7PMV ffKJlRPFh25DtTJwCt6BzDE= X-Google-Smtp-Source: APXvYqwKR4Jwp2qmPhvvF+tccwwtebDygt71oBGxTVlmnDHkEXgRT6CHmRvIFO/UEuCh95KW7IqJWA== X-Received: by 2002:a37:6117:: with SMTP id v23mr40223695qkb.309.1558036918673; Thu, 16 May 2019 13:01:58 -0700 (PDT) Received: from fabio-Latitude-E5450.am.freescale.net ([2804:14c:482:3c8:56cb:1049:60d2:137b]) by smtp.gmail.com with ESMTPSA id l3sm933886qkd.49.2019.05.16.13.01.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2019 13:01:57 -0700 (PDT) From: Fabio Estevam To: sbabic@denx.de Date: Thu, 16 May 2019 17:01:46 -0300 Message-Id: <20190516200148.5468-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 Cc: otavio@ossystems.com.br, u-boot@lists.denx.de, uboot-imx@nxp.com Subject: [U-Boot] [PATCH 1/3] mx6sabresd: Do not use DM with SPL X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" With CONFIG_SPL_DM enabled the board does not boot: U-Boot SPL 2019.07-rc2 (May 16 2019 - 14:28:55 -0300) Trying to boot from MMC1 spl: could not find mmc device 0. error: -19 SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### Remove such option, so that we can boot the board. Signed-off-by: Fabio Estevam --- Hi, If someone wants to fix the boot issue with CONFIG_SPL_DM=y, please submit a patch, as I don't know what is the proper fix here. Also, there is also the need for applying Peng's fix for the framebuffer hang: https://lists.denx.de/pipermail/u-boot/2019-April/366424.html Thanks configs/mx6sabresd_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig index d3ed3c4543..5c2d055561 100644 --- a/configs/mx6sabresd_defconfig +++ b/configs/mx6sabresd_defconfig @@ -65,7 +65,6 @@ CONFIG_SPL_MULTI_DTB_FIT=y CONFIG_SPL_OF_LIST="imx6dl-sabresd imx6q-sabresd imx6qp-sabresd" CONFIG_ENV_IS_IN_MMC=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y -CONFIG_SPL_DM=y CONFIG_USB_FUNCTION_FASTBOOT=y CONFIG_FASTBOOT_BUF_ADDR=0x12000000 CONFIG_FASTBOOT_BUF_SIZE=0x10000000 From patchwork Thu May 16 20:01:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1100708 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Vu/V7jzI"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 454j4s4Rz3z9sBp for ; Fri, 17 May 2019 06:02:21 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 4CFDDC21DF8; Thu, 16 May 2019 20:02:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 847BBC21DD3; Thu, 16 May 2019 20:02:11 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 03284C21DD3; Thu, 16 May 2019 20:02:08 +0000 (UTC) Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by lists.denx.de (Postfix) with ESMTPS id 8DBAEC21DA6 for ; Thu, 16 May 2019 20:02:04 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id z128so3093238qkb.6 for ; Thu, 16 May 2019 13:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=L9addfbtIS/2Wm830X2FLodW3z2/+m4fyM0W4MYvnew=; b=Vu/V7jzIKFuyC+m8oEA96bBx61/ooyIayoF5a9Wljop+vMrbRuowSqWRJKpMiL0gvQ TXT76/4aajifSh3lwiT2C7mGErX/wWaRDkZAsNLJVsNbL5qNGaXnlcAcNC9qfYX5BQ3d +K9s1NSQdUdhCceBUZBXVwzuwoojhTyBgfWm1R5UKfFp6fVi5AqFTOskaVf05OC5jTD3 y9hIiMgGnShgEtGvxPVa4VtSf2/h4H3sqwYC3sg8ZJzPH770qIDSinqy7zAsxDLCyAmA ttUtfcD3ArJ+eTcaR+T31781jhbWEClXiWax9fG5T1leZjdY1jPp7mmzYer4XlMV4yp9 XHPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=L9addfbtIS/2Wm830X2FLodW3z2/+m4fyM0W4MYvnew=; b=eMHoNiI1Kjkykcx7TyX/ZzwArTUoQk31p/bQBhjUMga7pRHHk38UYoOtQJxFG4r8eW nAyRJF6iWt+/f7x3x52tMYnSI9c7DZa+C+JYH4EbWKHfigHIvUIuUgTIPl8ftTQPbQuY yAoCFTyIosqK2oakIEJO37NA9FJncdEivANTF4Dmbo6t7XQDpsmWp0y1JGMcMJtS62UZ KQ8ES2Y42GZqudzw7djx/4WhY8BVa3TuSeoUb+e+b8QopCGCOsHUb4z7067x8Ax5+2J3 KMyLPa8+UzWC2dAEcTnW4B1ErCtufVhxCTNAQmWOVz/lx8ipqmCI5URxMzmd2kzVZo5V j7eg== X-Gm-Message-State: APjAAAWrwRo9KzhR7vJhDUjCWLi6yvEICKEkImWl8wraql4CsANNHEau RXAO7pMayynK9lah7fOjHAk= X-Google-Smtp-Source: APXvYqx+gfoM1JyrPGXxohR84sD3APdWo7kxs2yWZPGdtKyzPSYBiSrqidrgvDskxyTPX5LtFeFvHQ== X-Received: by 2002:a37:8ca:: with SMTP id 193mr38559399qki.50.1558036923529; Thu, 16 May 2019 13:02:03 -0700 (PDT) Received: from fabio-Latitude-E5450.am.freescale.net ([2804:14c:482:3c8:56cb:1049:60d2:137b]) by smtp.gmail.com with ESMTPSA id l3sm933886qkd.49.2019.05.16.13.01.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2019 13:02:02 -0700 (PDT) From: Fabio Estevam To: sbabic@denx.de Date: Thu, 16 May 2019 17:01:47 -0300 Message-Id: <20190516200148.5468-2-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190516200148.5468-1-festevam@gmail.com> References: <20190516200148.5468-1-festevam@gmail.com> Cc: otavio@ossystems.com.br, u-boot@lists.denx.de, uboot-imx@nxp.com Subject: [U-Boot] [PATCH 2/3] mx6sabresd: Select pinctrl driver X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" With the conversion to DM we should select the pinctrl driver. Signed-off-by: Fabio Estevam --- configs/mx6sabresd_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig index 5c2d055561..f7ba632b2a 100644 --- a/configs/mx6sabresd_defconfig +++ b/configs/mx6sabresd_defconfig @@ -81,6 +81,8 @@ CONFIG_SF_DEFAULT_SPEED=20000000 CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHYLIB=y CONFIG_MII=y +CONFIG_PINCTRL=y +CONFIG_PINCTRL_IMX6=y CONFIG_PCI=y CONFIG_DM_REGULATOR=y CONFIG_SPI=y From patchwork Thu May 16 20:01:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1100709 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mMhUT5Jh"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 454j5T18h5z9sBp for ; Fri, 17 May 2019 06:02:53 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id C05A2C21DA6; Thu, 16 May 2019 20:02:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 0E57CC21DD3; Thu, 16 May 2019 20:02:28 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6AFECC21DF9; Thu, 16 May 2019 20:02:12 +0000 (UTC) Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by lists.denx.de (Postfix) with ESMTPS id 95ECCC21D4A for ; Thu, 16 May 2019 20:02:08 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id t1so5405965qtc.12 for ; Thu, 16 May 2019 13:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oY6Kh+LJtH6ZfOvu4Aa6fd4JbimNwLWhw6ecvXwXj6M=; b=mMhUT5Jh3DpaUaYbYbZdOU0scpiCVIfSM9/U2GTMriXrnf09rxy++fVvZU2mZvBZ+n 0jN5XVXzrJXkwcP3Ti/wmouA9GJ0ORah1oBEB2oyCgsFVO7YjYKV8mKl+VCVFi9eo6+V g9fzQSU0R2taQUcPVpScw2Yxd+nKXAvi21ppfU8GLMyOwqcRPOt/oZKdCkyYLLwxNiSo L5sS34ttB2VZgfb88fPBvPWLVoC28OlGM1AQWizOStuat5wO/hIeJvf5SxzVYLW2r8Vm g2k+H9+Ic9EKfDDgmrpglaKGYGG2UIOHGdbVymeXdkLmfml1Nf560f+GBUi7m5rPqMpm 1TzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oY6Kh+LJtH6ZfOvu4Aa6fd4JbimNwLWhw6ecvXwXj6M=; b=iN4g1/iKGd2T7uHwXYq2i6NslA06M8mQ9fquJX6bvCiWxZCVyVCCWuoqxKvEp95mRZ Ty/UZxeXahRJiKOGSv/CUJ4H6qJZBpwYqbWeKDVaDRc58J3rXYJryT5QRe3zHgT022vQ 3sqnNi5NSWaF+V6FPTvTfbbpNIz1qpOcq9h8i/9RnrN1bA6sFTc16J4VRuCVgxoXh/XR PKpvEIM9LvX3XNEeBQe7OvGgBqR7C/SUOxuKIr4DGKxq4zU84mlHWfZqzfeLJwbadUvi s4FbXhhULhS5Mzk+not2nJepIVuqJ/DWiaX243dIDyWA9VZWwhYHAii9eTK06lMiZfeE FxTg== X-Gm-Message-State: APjAAAXsWlmoZaQiWa5WvGbK9uxoyJ2H5Lox+o6bbqBxXCKvQ2Fj8Ldl IN+rt79QVX81Pfqijl4ONSI= X-Google-Smtp-Source: APXvYqxbxmE47A4HVrA0eJAzn+hfv/K7wdq92upWjZRJs6CzICUhvLWdRVrnb+k4/faXmoRpA9YBRA== X-Received: by 2002:a0c:8a6c:: with SMTP id 41mr39502466qvu.236.1558036927485; Thu, 16 May 2019 13:02:07 -0700 (PDT) Received: from fabio-Latitude-E5450.am.freescale.net ([2804:14c:482:3c8:56cb:1049:60d2:137b]) by smtp.gmail.com with ESMTPSA id l3sm933886qkd.49.2019.05.16.13.02.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2019 13:02:06 -0700 (PDT) From: Fabio Estevam To: sbabic@denx.de Date: Thu, 16 May 2019 17:01:48 -0300 Message-Id: <20190516200148.5468-3-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190516200148.5468-1-festevam@gmail.com> References: <20190516200148.5468-1-festevam@gmail.com> Cc: otavio@ossystems.com.br, u-boot@lists.denx.de, uboot-imx@nxp.com Subject: [U-Boot] [PATCH 3/3] mx6sabresd: Remove U-Boot proper mmc initialization X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" After the conversion to DM there is no need to have mmc initialization code inside U-Boot proper. Remove the unneeded code. Signed-off-by: Fabio Estevam --- board/freescale/mx6sabresd/mx6sabresd.c | 44 ------------------------- 1 file changed, 44 deletions(-) diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c index 385a18e923..cdfc5ff77f 100644 --- a/board/freescale/mx6sabresd/mx6sabresd.c +++ b/board/freescale/mx6sabresd/mx6sabresd.c @@ -287,49 +287,6 @@ int board_mmc_getcd(struct mmc *mmc) int board_mmc_init(bd_t *bis) { -#ifndef CONFIG_SPL_BUILD - int ret; - int i; - - /* - * According to the board_mmc_init() the following map is done: - * (U-Boot device node) (Physical Port) - * mmc0 SD2 - * mmc1 SD3 - * mmc2 eMMC - */ - for (i = 0; i < CONFIG_SYS_FSL_USDHC_NUM; i++) { - switch (i) { - case 0: - SETUP_IOMUX_PADS(usdhc2_pads); - gpio_request(USDHC2_CD_GPIO, "USDHC2 CD"); - gpio_direction_input(USDHC2_CD_GPIO); - usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC2_CLK); - break; - case 1: - SETUP_IOMUX_PADS(usdhc3_pads); - gpio_request(USDHC3_CD_GPIO, "USDHC3 CD"); - gpio_direction_input(USDHC3_CD_GPIO); - usdhc_cfg[1].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK); - break; - case 2: - SETUP_IOMUX_PADS(usdhc4_pads); - usdhc_cfg[2].sdhc_clk = mxc_get_clock(MXC_ESDHC4_CLK); - break; - default: - printf("Warning: you configured more USDHC controllers" - "(%d) then supported by the board (%d)\n", - i + 1, CONFIG_SYS_FSL_USDHC_NUM); - return -EINVAL; - } - - ret = fsl_esdhc_initialize(bis, &usdhc_cfg[i]); - if (ret) - return ret; - } - - return 0; -#else struct src *psrc = (struct src *)SRC_BASE_ADDR; unsigned reg = readl(&psrc->sbmr1) >> 11; /* @@ -363,7 +320,6 @@ int board_mmc_init(bd_t *bis) } return fsl_esdhc_initialize(bis, &usdhc_cfg[0]); -#endif } #endif