From patchwork Fri May 3 19:52:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dylan Howey X-Patchwork-Id: 1095028 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=tennantco.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=tennantco.onmicrosoft.com header.i=@tennantco.onmicrosoft.com header.b="aASkUipO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44wjdP4TXBz9s9N for ; Sat, 4 May 2019 05:59:21 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726721AbfECT7U (ORCPT ); Fri, 3 May 2019 15:59:20 -0400 Received: from esa3.tennantco.iphmx.com ([68.232.154.86]:12822 "EHLO esa3.tennantco.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbfECT7U (ORCPT ); Fri, 3 May 2019 15:59:20 -0400 X-Greylist: delayed 426 seconds by postgrey-1.27 at vger.kernel.org; Fri, 03 May 2019 15:59:20 EDT IronPort-PHdr: 9a23:7G+o+hOKKVdt/nm7tOsl6mtUPXoX/o7sNwtQ0KIMzox0K/zyosbcNUDSrc9gkEXOFd2Cra4d0qyJ6uu5BTFIyK3CmUhKSIZLWR4BhJdetC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+KPjrFY7OlcS30P2594HObwlSizexfK5+IA+0oAnMucUanIRvJ6YswRbVv3VEfPhby3l1LlyJhRb84cmw/J9n8ytOvv8q6tBNX6bncakmVLJUFDspPXw7683trhnDUBCA5mAAXWUMkxpHGBbK4RfnVZrsqCT6t+592C6HPc3qSL0/RDqv47t3RBLulSwKMSMy/mPKhcxqlK9VoAyvqQFjw4DaY4+bM/t+cb/Sc9wVXmdBQt1eWjZdDo6mc4cCDewMNvtYoYnnoFsOqAOzCwesBePr0DBIgGL906890+UvDw7H3BErEtUAvnXUqNX6LqESXfq3wqnPwzTMcfNX1Czh6IfWdBAhp+uDXbRsccXNzkkjDR/KjlKVqYH8OT6ey+oDs2+e7+V6VOKvjXYqpBttojiz3McgkI/JiZgQyl/a8yhy3YU7JcWgRUJmfdKpH4Fcui6YOodsTM4vQHtktSY6x7EepJK2eCsHxI45yxLDZPGLaYaF7xz5WOqPPTt0mGppeLyhiBux7UStz+jxW8ip31lWqidIl8TDuW4T2BHd78WIVOZy8Vu91TuKzQ/e6PpLLl4ymKHGMZAu2KQwmYAWsUnbGy/2n1j5g7GOe0U//+io9/znYrL7pp+AL4N0ih/xMqApmsGnGeo1Lg8AU3SF9eilybDt+1P1TKxNjvItjKbVqpfaJdkHpqGiBA9Vz4Aj5AulAze+ytQYmmUHI0xZdxKbjojpPFfOLOr/Dfein1SslDBrx/fFPrH7HprNKX3DnK/gfbZ79UFc1BI+wc1D659bEL0ML/D+VlX/udHbFBM0Mwy5z/7iCNpn14MeXWyPArWeMKPXqVKG6OIuI+2Wa48TojrzKf8l5vDwgn45glIdYbem3Z0RaH+iGPRmP1mWYX32jtgdFmcKuxIyTPb2h12aTT5Te3GyUrom6TE/Fo2nAp3MRoawj7ybwii3BIZZaX5CClCIFnfocYSEVuwXZyKVJc9hjjgEVbmnS4M7yR6uswr6waJ9LuXI4i0YqY7j1N9t6uLJjx0z9CF0D8GY02GKVGx0gmQIRjEo06BlvUxy1EuM0ahij/xZCdxZ/+lJXRsiNZ7A0+x6DMj/WgbAftePVVanTcyqASstTt0t2NIOfUl9FMu4jhzZ3CqlHaUVl7qVC5ww6K7c2GLxJ8kug0rBgeMoi1Q2S81DL2DgjKN78w/VBqbDlEKFk6esM68b2WSFoG6HwHqHuk1CXUh6XKHBWnYeTkHRqsj950WERLirX+cJKAxEnOKTLqJMIv3uklhXDKPPKdDXZSSRnHi9FD6Uy7WKZYz2cGJb1yLYXhtX2zsP9GqLYFBtThyqpHjTWWQ0TwDmfl/s/O9iqXiyUk4zyUSQYlZ806aupE5HnuSSHvUU2L9M+DwsrTl5Bh6c55rXEJLBwmgpZ6BAeZU46VZD23jesllRL5ipKeZCgUETYixrskXo3hNrAYIGms8v/zsn X-IPAS-Result: A2GdDmbjmsxc/zcmL2hlg1VQWxF1BAsoCoQGg0cDhTGJT5Fbhn8Zg1oDGDwPARsSAoQ+GVEBgUE4EwEDAQEBBAEBAQECAQECaRwBC4IuDCJcDTkFAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEVAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQUCMwUhGhYRBA0MAQERJgERASICJgIEMBUSBA4FIoMAAYFqAx0BoR89AmICC4EBKYhfcXwzgnkBAQV1hAkYUoE8CYELJ4Z4hi0/gRGDUIRDGCOCUIJYixuCOoRslHUHAoILVoVCjCEngm+SWYwbkRqDTwIEAgQFAg4BAQWBZiKBVjMaI4M8CYV1hFGCQINCQAExgSmOdQGBIAEB X-IronPort-AV: E=Sophos;i="5.60,426,1549951200"; d="scan'208";a="13731131" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from mail-bl2nam02lp2055.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) ([104.47.38.55]) by ob1.tennantco.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 May 2019 14:52:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tennantco.onmicrosoft.com; s=selector1-tennantco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=87cmkqj2gVWObjudDV5Lp+2731KGXpTbseUS3Vf1APU=; b=aASkUipOf00dbcvV9BTMjQDMRS6aREmNtHRWZjrc/szj+o8AxOetJ7NlDm692qeTuH87rs/0N50K90ALM7KaFCMckTtgpT6rAKAvorGNea3zacoVDDonWSgXAcJyb90u1F8YFydCR3SOK5pBDwtRWMeowZosEqJIXOAqlqJuXH4= Received: from CY4PR20MB1381.namprd20.prod.outlook.com (10.173.111.8) by CY4PR20MB1624.namprd20.prod.outlook.com (10.171.167.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Fri, 3 May 2019 19:52:09 +0000 Received: from CY4PR20MB1381.namprd20.prod.outlook.com ([fe80::6dc9:dee3:edc0:a7be]) by CY4PR20MB1381.namprd20.prod.outlook.com ([fe80::6dc9:dee3:edc0:a7be%4]) with mapi id 15.20.1856.008; Fri, 3 May 2019 19:52:09 +0000 From: Dylan Howey To: "alexandre.belloni@bootlin.com" CC: "a.zummo@towertech.it" , "linux-rtc@vger.kernel.org" , Dylan Howey Subject: [PATCH v2 1/4] rtc: pcf2123: remove sysfs register view Thread-Topic: [PATCH v2 1/4] rtc: pcf2123: remove sysfs register view Thread-Index: AQHVAemx0KfSEvpbCEmONoHwczY0PQ== Date: Fri, 3 May 2019 19:52:08 +0000 Message-ID: <20190503195149.31297-1-Dylan.Howey@tennantco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MN2PR13CA0004.namprd13.prod.outlook.com (2603:10b6:208:160::17) To CY4PR20MB1381.namprd20.prod.outlook.com (2603:10b6:903:8d::8) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dylan.Howey@tennantco.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [198.204.33.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9b42aed-73e1-44b9-d41c-08d6d000d33f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR20MB1624; x-ms-traffictypediagnostic: CY4PR20MB1624: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:530; x-forefront-prvs: 0026334A56 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(396003)(346002)(39860400002)(366004)(189003)(199004)(186003)(386003)(26005)(486006)(71200400001)(7736002)(86362001)(6506007)(14454004)(6436002)(305945005)(71190400001)(1076003)(4326008)(72206003)(102836004)(50226002)(2501003)(52116002)(256004)(6916009)(5660300002)(6512007)(81166006)(99286004)(478600001)(2351001)(68736007)(6486002)(53936002)(6116002)(107886003)(5640700003)(8676002)(2906002)(316002)(3846002)(36756003)(66066001)(81156014)(64756008)(73956011)(66446008)(66946007)(8936002)(66476007)(66556008)(2616005)(25786009)(54906003)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR20MB1624; H:CY4PR20MB1381.namprd20.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: tennantco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: VINeyociJczKvw9pd6evVdhPNDKvmSGdpJktOolKaLMTFtAirtQGvIJuJ7Wl6DN8HcpKiHpqVK7JhZt33LAbadUwFqmfey7RUX3xXAQKHKqVzZWFBBhw3sNuNyaHSDjrePP1FDVzhmQsQKeXXpUchgIp4dJbV+rE7nNBCV4cQGYG71Xsol2w6rgu4TTJbQjcKV7yb76a3dGxRe3tLtQ1rLaNS7OMBoshS038rfFQtytFhWyQuEHOpT4JZht6ZR2s+gP9G1wf/YiDrq9/NjCh7jSrJZwnAgoXTSBMO9fKgd/43edRrl3D92EMyIDY2jKoJLQEW56agv8BkyD1FxFowV2PzqfFMnoVhTmqlrAdIgG8VsYT0CdZUr2PRZEtSqv0EUCdb8olGRjcfM23JRAt5c3Ndsq9krnUAsLzQCvsnvk= MIME-Version: 1.0 X-OriginatorOrg: tennantco.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9b42aed-73e1-44b9-d41c-08d6d000d33f X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2019 19:52:08.9122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 854ee4fb-bf50-420c-8a26-5b96d626ac37 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR20MB1624 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Use regmap debugfs register view instead. Signed-off-by: Dylan Howey --- drivers/rtc/rtc-pcf2123.c | 90 +-------------------------------------- 1 file changed, 1 insertion(+), 89 deletions(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index 39da8b214275..fb5cb81f2161 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -44,7 +44,6 @@ #include #include #include -#include /* REGISTERS */ #define PCF2123_REG_CTRL1 (0x00) /* Control Register 1 */ @@ -107,14 +106,8 @@ static struct spi_driver pcf2123_driver; -struct pcf2123_sysfs_reg { - struct device_attribute attr; - char name[2]; -}; - struct pcf2123_plat_data { struct rtc_device *rtc; - struct pcf2123_sysfs_reg regs[16]; }; /* @@ -160,52 +153,6 @@ static int pcf2123_write_reg(struct device *dev, u8 reg, u8 val) return pcf2123_write(dev, txbuf, sizeof(txbuf)); } -static ssize_t pcf2123_show(struct device *dev, struct device_attribute *attr, - char *buffer) -{ - struct pcf2123_sysfs_reg *r; - u8 rxbuf[1]; - unsigned long reg; - int ret; - - r = container_of(attr, struct pcf2123_sysfs_reg, attr); - - ret = kstrtoul(r->name, 16, ®); - if (ret) - return ret; - - ret = pcf2123_read(dev, reg, rxbuf, 1); - if (ret < 0) - return -EIO; - - return sprintf(buffer, "0x%x\n", rxbuf[0]); -} - -static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr, - const char *buffer, size_t count) -{ - struct pcf2123_sysfs_reg *r; - unsigned long reg; - unsigned long val; - - int ret; - - r = container_of(attr, struct pcf2123_sysfs_reg, attr); - - ret = kstrtoul(r->name, 16, ®); - if (ret) - return ret; - - ret = kstrtoul(buffer, 10, &val); - if (ret) - return ret; - - ret = pcf2123_write_reg(dev, reg, val); - if (ret < 0) - return -EIO; - return count; -} - static int pcf2123_read_offset(struct device *dev, long *offset) { int ret; @@ -377,7 +324,7 @@ static int pcf2123_probe(struct spi_device *spi) struct rtc_device *rtc; struct rtc_time tm; struct pcf2123_plat_data *pdata; - int ret, i; + int ret; pdata = devm_kzalloc(&spi->dev, sizeof(struct pcf2123_plat_data), GFP_KERNEL); @@ -409,47 +356,13 @@ static int pcf2123_probe(struct spi_device *spi) pdata->rtc = rtc; - for (i = 0; i < 16; i++) { - sysfs_attr_init(&pdata->regs[i].attr.attr); - sprintf(pdata->regs[i].name, "%1x", i); - pdata->regs[i].attr.attr.mode = S_IRUGO | S_IWUSR; - pdata->regs[i].attr.attr.name = pdata->regs[i].name; - pdata->regs[i].attr.show = pcf2123_show; - pdata->regs[i].attr.store = pcf2123_store; - ret = device_create_file(&spi->dev, &pdata->regs[i].attr); - if (ret) { - dev_err(&spi->dev, "Unable to create sysfs %s\n", - pdata->regs[i].name); - goto sysfs_exit; - } - } - return 0; -sysfs_exit: - for (i--; i >= 0; i--) - device_remove_file(&spi->dev, &pdata->regs[i].attr); - kfree_exit: spi->dev.platform_data = NULL; return ret; } -static int pcf2123_remove(struct spi_device *spi) -{ - struct pcf2123_plat_data *pdata = dev_get_platdata(&spi->dev); - int i; - - if (pdata) { - for (i = 0; i < 16; i++) - if (pdata->regs[i].name[0]) - device_remove_file(&spi->dev, - &pdata->regs[i].attr); - } - - return 0; -} - #ifdef CONFIG_OF static const struct of_device_id pcf2123_dt_ids[] = { { .compatible = "nxp,rtc-pcf2123", }, @@ -465,7 +378,6 @@ static struct spi_driver pcf2123_driver = { .of_match_table = of_match_ptr(pcf2123_dt_ids), }, .probe = pcf2123_probe, - .remove = pcf2123_remove, }; module_spi_driver(pcf2123_driver); From patchwork Fri May 3 19:52:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dylan Howey X-Patchwork-Id: 1095029 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=tennantco.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=tennantco.onmicrosoft.com header.i=@tennantco.onmicrosoft.com header.b="MwVtsFo6"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44wjdR3yGNz9sCJ for ; Sat, 4 May 2019 05:59:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbfECT7V (ORCPT ); Fri, 3 May 2019 15:59:21 -0400 Received: from esa3.tennantco.iphmx.com ([68.232.154.86]:12822 "EHLO esa3.tennantco.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbfECT7V (ORCPT ); Fri, 3 May 2019 15:59:21 -0400 X-Greylist: delayed 426 seconds by postgrey-1.27 at vger.kernel.org; Fri, 03 May 2019 15:59:20 EDT IronPort-PHdr: 9a23:HubgqxNuUO4agvL5yTEl6mtUPXoX/o7sNwtQ0KIMzox0K/z9pMbcNUDSrc9gkEXOFd2Cra4d0qyJ6uu5BTFIyK3CmUhKSIZLWR4BhJdetC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+KPjrFY7OlcS30P2594HObwlSizexfK5+IA+0oAnMucUanIRvJ6YswRbVv3VEfPhby3l1LlyJhRb84cmw/J9n8ytOvv8q6tBNX6bncakmVLJUFDspPXw7683trhnDUBCA5mAAXWUMkxpHGBbK4RfnVZrsqCT6t+592C6HPc3qSL0/RDqv47t3RBLulSwKMSMy/mPKhcxqlK9VoAyvqQFjw4DaY4+VOvhxcKTcfdwGSmROUd1cVzBaDY6mc4cCFfYNMOReooLgp1UOtxy+BQy0Ce3hyj5IgmX53asn2OojFgHH0hIvHtITu3nTotv0NKMSXvqzzKXSzzvDaP1X1in96YXTbhAuv/eMXbRqfsrX1UkgCwTFgk+MpoziOjOYz+IAuHWY4ep4Te+jlnIrpg5rrjWgxMogkIfEi4EPxl3E9Sh12Js5KNm7RUJhf9KoDJRduzuUOoZ4WM8uXX1ktDoixr0Ip5G2fzQGxZEiyhPedvOIb4yF7xf+W+mPPzh1indod6yiiBmu7UStz/fzW8uv31lUqCdOj8PCuWoX1xPJ78iKUv59/kC81jmRzw3T8eREIVwslarcNp4h3qY8lpoNvkTHGS/7gF34gbOReEk45OSk8vnqbLP4qpOFMI97kR/xPr4pmsyiHeQ3KQ8OX3Wd+euhzrHj5Vf5QLJWjvIojqbZrJHaJcMdpqKjBA9Vz5oj6xK4Dzeh09QUh2UILFVAeB6fjojpPU/BIOzgAPuin1ihny1nyv/EM7H7DJjALWLPnbfhcLpl7k5T0gszzdRR55JODbEBJer+VEHxtdzcFBA5NRa4zeTgCNRzyIwfWXmCArOHP6PUt1+H/OQvI/WQa48SojryN/8l5/v2gX8jhVAdZbWp3YcQaH2gBPtmJ1uWYHX2jdcHDGgKpBQxQPbxh1KcVT5TY3GyX6Q95jwgE42mCoDDRpypgLyA2ie3BIFZZmdDClqUC3fna52EW+sQaCKVOsJuiCYIVLm8S48k0BGusxT3y6ZgLuva5CIYr47j28Zp6O3Tjx0y9CB0BdyH026RV2F0gn8IRzgu0aB7oEx9zEqD0Kdhj/xCCdxc++hEUhk1NZHC1ex2EdPyVRzbftePVlmmRs+qATYrTtI+kJcyZBM3EtGvnhnF0zCnRbUYk7iMAp0c+KXbw3zwIYB2zHOMnP0oi1Q2S81DL2DgjKN78w/VBqbDlEKFk6esM68b2Xie2n2EyD+irUVRVkZQVrrITDhLSlrSpNK/xkTdQq6GFbkhNAJH1cWFbKBNb4u63h19WP7/NYGGMCqKkGCqCEPQnOneZZf2e2gbwCTWAVQFlAZW53udKAwiHXnx8XnGAmloElTiKwP3/O9ypWnzb3d8zhrCLigDn6Gw5gZTgPWdT/0J2bdRlDYlojMyPFGi0sP+F9eGoQNnYK5bJ9g65QQP2A== X-IPAS-Result: A2F1CgDjmsxc/zcmL2hlg1VQW4EGBAsoCoQGg0cDhTGJT5xNAxg8DwEtAoQ+AheCEzgTAQMBAQEEAQEBAQIBAQJpHAELgjoiaTkyAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBBQI4OQIBAxIRBA0MAQERJgEPAgEiAiYCAgIwFRACBA4FIoMAgWsDHQGhHz0CYgILgQEpiF9xfDOCeQEBBYR+GFKBPAmBCyeGeIYtP4RhhEMYI4JQgliLEQqCOoZckwUHAoILVpFjJ4IOiiuJD4wblGkCBAIEBQIOAQEFgWYigVYzGiODPIEYgQMXg0yKU0ABMYEpjnUBgSABAQ X-IronPort-AV: E=Sophos;i="5.60,426,1549951200"; d="scan'208";a="13731132" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from mail-bl2nam02lp2055.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) ([104.47.38.55]) by ob1.tennantco.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 May 2019 14:52:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tennantco.onmicrosoft.com; s=selector1-tennantco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wL5xCmU1qLakNFMD5QbqLNr+8TSz20IqVRa0xB59cPA=; b=MwVtsFo6QGyZ2V7uwFdtyWOWmieSBWzo0v3oCgUWyzD06DNFpoYjc6bPVtEJOAHq7zAS/npQm/nMnmCj2gxiI1B+5roBCioVR34PrWZQUOH/guiwKyJiin3OOiEvhigSOMX+6ijb3eA2uegiWnhy5QHzrZtV+d2nbgVhB287uMM= Received: from CY4PR20MB1381.namprd20.prod.outlook.com (10.173.111.8) by CY4PR20MB1624.namprd20.prod.outlook.com (10.171.167.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Fri, 3 May 2019 19:52:11 +0000 Received: from CY4PR20MB1381.namprd20.prod.outlook.com ([fe80::6dc9:dee3:edc0:a7be]) by CY4PR20MB1381.namprd20.prod.outlook.com ([fe80::6dc9:dee3:edc0:a7be%4]) with mapi id 15.20.1856.008; Fri, 3 May 2019 19:52:10 +0000 From: Dylan Howey To: "alexandre.belloni@bootlin.com" CC: "a.zummo@towertech.it" , "linux-rtc@vger.kernel.org" , Dylan Howey Subject: [PATCH v2 2/4] rtc: pcf2123: port to regmap Thread-Topic: [PATCH v2 2/4] rtc: pcf2123: port to regmap Thread-Index: AQHVAemyAdN/LMDpz0WQQihDx54ckA== Date: Fri, 3 May 2019 19:52:10 +0000 Message-ID: <20190503195149.31297-2-Dylan.Howey@tennantco.com> References: <20190503195149.31297-1-Dylan.Howey@tennantco.com> In-Reply-To: <20190503195149.31297-1-Dylan.Howey@tennantco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BL0PR05CA0012.namprd05.prod.outlook.com (2603:10b6:208:91::22) To CY4PR20MB1381.namprd20.prod.outlook.com (2603:10b6:903:8d::8) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dylan.Howey@tennantco.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [198.204.33.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 279c7d2d-c17a-4dc8-69f5-08d6d000d490 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR20MB1624; x-ms-traffictypediagnostic: CY4PR20MB1624: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0026334A56 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(396003)(346002)(39860400002)(366004)(189003)(199004)(186003)(386003)(26005)(486006)(71200400001)(7736002)(11346002)(86362001)(6506007)(14454004)(6436002)(305945005)(71190400001)(1076003)(4326008)(72206003)(102836004)(50226002)(2501003)(52116002)(76176011)(256004)(6916009)(5660300002)(6512007)(81166006)(99286004)(478600001)(446003)(2351001)(68736007)(6486002)(53936002)(6116002)(107886003)(5640700003)(8676002)(2906002)(316002)(3846002)(36756003)(66066001)(81156014)(64756008)(73956011)(66446008)(66946007)(8936002)(66476007)(66556008)(2616005)(25786009)(54906003)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR20MB1624; H:CY4PR20MB1381.namprd20.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: tennantco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cV+wqq4gC0nfTcn8SEYsmFa6Yf61h9aVEr7sUKES+L+Assv8tFoOP81USJEMJq1R01ZCD4geRDvlHnHypVgASh3QwGncYKeT8P7lvNnuwjH18L2ixIUoPLvzeWIFuCsQuwxmtWp+HHi+fTDZdnCmpXhMIhqkjWOfvKIKYWfSr0osjdynVj0epzjA2b7xH+5KywQuJHQmx+RdKvuyLtvdBeDWsFEn3HKskB+DfiBvw+XkaUSDt6XmOUySZ6wz62N4zrOnGY8ydzWHm80ZwGD6zaXFOEQqxOJScThKne//K5e+Zotz5rJAl0JK5pLYxCNKSayll9E8I56+LFsgz+YY5Ys2e/XrqghtOZgAmDtz5F8xd2vciOHIi3TYUhLAMC2GQ5y8ItkLpliu+o2i8LCwvtE8hpsSf+Bs6fwplLEaEOc= MIME-Version: 1.0 X-OriginatorOrg: tennantco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 279c7d2d-c17a-4dc8-69f5-08d6d000d490 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2019 19:52:10.8128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 854ee4fb-bf50-420c-8a26-5b96d626ac37 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR20MB1624 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Also remove pcf2123_delay_trec. This claimed to add a 30ns delay to SPI writes, but I could not see any reference to this requirement in the datasheet. Closest thing I could find to a requirement are timings for the SPI chip enable line, which cannot be controlled by this driver (the ndelay came after the call to spi_write_then_read, which means it would sleep after CE has already gone inactive). Things seem to work fine without it. Signed-off-by: Dylan Howey --- drivers/rtc/rtc-pcf2123.c | 142 ++++++++++++++++---------------------- 1 file changed, 61 insertions(+), 81 deletions(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index fb5cb81f2161..32bfed7eefd4 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -44,6 +44,7 @@ #include #include #include +#include /* REGISTERS */ #define PCF2123_REG_CTRL1 (0x00) /* Control Register 1 */ @@ -98,6 +99,7 @@ #define OFFSET_SIGN_BIT 6 /* 2's complement sign bit */ #define OFFSET_COARSE BIT(7) /* Coarse mode offset */ #define OFFSET_STEP (2170) /* Offset step in parts per billion */ +#define OFFSET_MASK GENMASK(6, 0) /* Offset value */ /* READ/WRITE ADDRESS BITS */ #define PCF2123_WRITE BIT(4) @@ -108,66 +110,33 @@ static struct spi_driver pcf2123_driver; struct pcf2123_plat_data { struct rtc_device *rtc; + struct regmap *map; }; -/* - * Causes a 30 nanosecond delay to ensure that the PCF2123 chip select - * is released properly after an SPI write. This function should be - * called after EVERY read/write call over SPI. - */ -static inline void pcf2123_delay_trec(void) -{ - ndelay(30); -} - -static int pcf2123_read(struct device *dev, u8 reg, u8 *rxbuf, size_t size) -{ - struct spi_device *spi = to_spi_device(dev); - int ret; - - reg |= PCF2123_READ; - ret = spi_write_then_read(spi, ®, 1, rxbuf, size); - pcf2123_delay_trec(); - - return ret; -} - -static int pcf2123_write(struct device *dev, u8 *txbuf, size_t size) -{ - struct spi_device *spi = to_spi_device(dev); - int ret; - - txbuf[0] |= PCF2123_WRITE; - ret = spi_write(spi, txbuf, size); - pcf2123_delay_trec(); - - return ret; -} - -static int pcf2123_write_reg(struct device *dev, u8 reg, u8 val) -{ - u8 txbuf[2]; - - txbuf[0] = reg; - txbuf[1] = val; - return pcf2123_write(dev, txbuf, sizeof(txbuf)); -} +static const struct regmap_config pcf2123_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .read_flag_mask = PCF2123_READ, + .write_flag_mask = PCF2123_WRITE, + .max_register = PCF2123_REG_CTDWN_TMR, +}; static int pcf2123_read_offset(struct device *dev, long *offset) { - int ret; - s8 reg; + struct pcf2123_plat_data *pdata = dev_get_platdata(dev); + int ret, val; + unsigned int reg; - ret = pcf2123_read(dev, PCF2123_REG_OFFSET, ®, 1); - if (ret < 0) + ret = regmap_read(pdata->map, PCF2123_REG_OFFSET, ®); + if (ret) return ret; + val = sign_extend32((reg & OFFSET_MASK), OFFSET_SIGN_BIT); + if (reg & OFFSET_COARSE) - reg <<= 1; /* multiply by 2 and sign extend */ - else - reg = sign_extend32(reg, OFFSET_SIGN_BIT); + val *= 2; - *offset = ((long)reg) * OFFSET_STEP; + *offset = ((long)val) * OFFSET_STEP; return 0; } @@ -184,6 +153,7 @@ static int pcf2123_read_offset(struct device *dev, long *offset) */ static int pcf2123_set_offset(struct device *dev, long offset) { + struct pcf2123_plat_data *pdata = dev_get_platdata(dev); s8 reg; if (offset > OFFSET_STEP * 127) @@ -203,16 +173,18 @@ static int pcf2123_set_offset(struct device *dev, long offset) reg |= OFFSET_COARSE; } - return pcf2123_write_reg(dev, PCF2123_REG_OFFSET, reg); + return regmap_write(pdata->map, PCF2123_REG_OFFSET, (unsigned int)reg); } static int pcf2123_rtc_read_time(struct device *dev, struct rtc_time *tm) { + struct pcf2123_plat_data *pdata = dev_get_platdata(dev); u8 rxbuf[7]; int ret; - ret = pcf2123_read(dev, PCF2123_REG_SC, rxbuf, sizeof(rxbuf)); - if (ret < 0) + ret = regmap_bulk_read(pdata->map, PCF2123_REG_SC, rxbuf, + sizeof(rxbuf)); + if (ret) return ret; if (rxbuf[0] & OSC_HAS_STOPPED) { @@ -241,7 +213,8 @@ static int pcf2123_rtc_read_time(struct device *dev, struct rtc_time *tm) static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm) { - u8 txbuf[8]; + struct pcf2123_plat_data *pdata = dev_get_platdata(dev); + u8 txbuf[7]; int ret; dev_dbg(dev, "%s: tm is secs=%d, mins=%d, hours=%d, " @@ -251,27 +224,27 @@ static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm) tm->tm_mday, tm->tm_mon, tm->tm_year, tm->tm_wday); /* Stop the counter first */ - ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, CTRL1_STOP); - if (ret < 0) + ret = regmap_write(pdata->map, PCF2123_REG_CTRL1, CTRL1_STOP); + if (ret) return ret; /* Set the new time */ - txbuf[0] = PCF2123_REG_SC; - txbuf[1] = bin2bcd(tm->tm_sec & 0x7F); - txbuf[2] = bin2bcd(tm->tm_min & 0x7F); - txbuf[3] = bin2bcd(tm->tm_hour & 0x3F); - txbuf[4] = bin2bcd(tm->tm_mday & 0x3F); - txbuf[5] = tm->tm_wday & 0x07; - txbuf[6] = bin2bcd((tm->tm_mon + 1) & 0x1F); /* rtc mn 1-12 */ - txbuf[7] = bin2bcd(tm->tm_year < 100 ? tm->tm_year : tm->tm_year - 100); - - ret = pcf2123_write(dev, txbuf, sizeof(txbuf)); - if (ret < 0) + txbuf[0] = bin2bcd(tm->tm_sec & 0x7F); + txbuf[1] = bin2bcd(tm->tm_min & 0x7F); + txbuf[2] = bin2bcd(tm->tm_hour & 0x3F); + txbuf[3] = bin2bcd(tm->tm_mday & 0x3F); + txbuf[4] = tm->tm_wday & 0x07; + txbuf[5] = bin2bcd((tm->tm_mon + 1) & 0x1F); /* rtc mn 1-12 */ + txbuf[6] = bin2bcd(tm->tm_year < 100 ? tm->tm_year : tm->tm_year - 100); + + ret = regmap_bulk_write(pdata->map, PCF2123_REG_SC, txbuf, + sizeof(txbuf)); + if (ret) return ret; /* Start the counter */ - ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, CTRL1_CLEAR); - if (ret < 0) + ret = regmap_write(pdata->map, PCF2123_REG_CTRL1, CTRL1_CLEAR); + if (ret) return ret; return 0; @@ -279,33 +252,33 @@ static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm) static int pcf2123_reset(struct device *dev) { + struct pcf2123_plat_data *pdata = dev_get_platdata(dev); int ret; - u8 rxbuf[2]; + unsigned int val = 0; - ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, CTRL1_SW_RESET); - if (ret < 0) + ret = regmap_write(pdata->map, PCF2123_REG_CTRL1, CTRL1_SW_RESET); + if (ret) return ret; /* Stop the counter */ dev_dbg(dev, "stopping RTC\n"); - ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, CTRL1_STOP); - if (ret < 0) + ret = regmap_write(pdata->map, PCF2123_REG_CTRL1, CTRL1_STOP); + if (ret) return ret; /* See if the counter was actually stopped */ dev_dbg(dev, "checking for presence of RTC\n"); - ret = pcf2123_read(dev, PCF2123_REG_CTRL1, rxbuf, sizeof(rxbuf)); - if (ret < 0) + ret = regmap_read(pdata->map, PCF2123_REG_CTRL1, &val); + if (ret) return ret; - dev_dbg(dev, "received data from RTC (0x%02X 0x%02X)\n", - rxbuf[0], rxbuf[1]); - if (!(rxbuf[0] & CTRL1_STOP)) + dev_dbg(dev, "received data from RTC (0x%08X)\n", val); + if (!(val & CTRL1_STOP)) return -ENODEV; /* Start the counter */ - ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, CTRL1_CLEAR); - if (ret < 0) + ret = regmap_write(pdata->map, PCF2123_REG_CTRL1, CTRL1_CLEAR); + if (ret) return ret; return 0; @@ -332,6 +305,13 @@ static int pcf2123_probe(struct spi_device *spi) return -ENOMEM; spi->dev.platform_data = pdata; + pdata->map = devm_regmap_init_spi(spi, &pcf2123_regmap_config); + + if (IS_ERR(pdata->map)) { + dev_err(&spi->dev, "regmap init failed.\n"); + goto kfree_exit; + } + ret = pcf2123_rtc_read_time(&spi->dev, &tm); if (ret < 0) { ret = pcf2123_reset(&spi->dev); From patchwork Fri May 3 19:52:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dylan Howey X-Patchwork-Id: 1095030 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=tennantco.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=tennantco.onmicrosoft.com header.i=@tennantco.onmicrosoft.com header.b="HozWWzgw"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44wjdS30b3z9sDQ for ; Sat, 4 May 2019 05:59:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726404AbfECT7W (ORCPT ); Fri, 3 May 2019 15:59:22 -0400 Received: from esa3.tennantco.iphmx.com ([68.232.154.86]:12822 "EHLO esa3.tennantco.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbfECT7V (ORCPT ); Fri, 3 May 2019 15:59:21 -0400 X-Greylist: delayed 426 seconds by postgrey-1.27 at vger.kernel.org; Fri, 03 May 2019 15:59:20 EDT IronPort-PHdr: 9a23:y2bZkhKI5wozJLK9g9mcpTZWNBhigK39O0sv0rFitYgXK/z4rarrMEGX3/hxlliBBdydt6sdzbWP+Pm8BCQp2tWoiDg6aptCVhsI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFRrhKAF7Ovr6GpLIj8Swyuu+54Dfbx9HiTagfL9+Nhe7oRjeusULjoZvKrs6xwfUrHdPZ+lY335jK0iJnxb76Mew/Zpj/DpVtvk86cNOUrj0crohQ7BAAzsoL2465MvwtRneVgSP/WcTUn8XkhVTHQfI6gzxU4rrvSv7sup93zSaPdHzQLspVzmu87tnRRn1gyoBKjU38nzYitZogaxbvhyvugB/zYDXboGbNvVweaLdcs8VS2VORctRSzdOD5mgY4YVE+YMP+BVpJT9qVsUqhu+ABGhCu3vyz9MnHD227Ax3eYmEQDIwgMhH88FvXPaotT1MKcdS+a1wLPKwzXEYfJZxzf85ZPUch8/p/GMW6h/cczNyUYzEAPJlEmfqYvgPz6M0OkGrmaV7+1lVe21im4nrRl8rSW1xsctlInGmJgVxkrC9SpjxYY6O9u1Q1N4b968CJZcqj2WOoRsTs4tQWxkoig3x74ctZO7YSQG0IkryhrcZvCdbYSE/h3uWPyfLDp2nn5pZq6ziwqq/Uiu1OLxVdW43VNPoydEj9bDqnQA2hnO5ceZVPRw8EKs1iiS2A/P9u1JJFo7mKjAJJE/xLM7i4Advl7ZHiDsnUX7lKqWdkI59ee28+nnebDmpoOEN49zlwH+LrwimsyhDuQ8NQgDR3CV9Pi72rH/40H1WahHgPsonqXAt5DVPtoUqrS+Aw9IzoYs8BG/Dyqg0NsFh3UHNEhFeBWbj4f3J17OPPH4DfC5g1i2lzdr2uzGPrnmApXKLXjPiqvufbF460JEyQozy85Q545MB70cPP7+VVX9udPaAxMjPQG5wPzrBdVg2o8GXGKAGK6ZMKfcsV+S4eIvJvGBaoEVuTb5Mfcl4eTig30+mV4TY6ao3YAaaGymEfRgJUWWe3zsgssdHmcNpAYxUOvqiFiaXT5Je3myR7485i08CI++F4jDQp6igbOb0ye9A5JWfH5JBkqXHnj2c4WEX/AMaCSTIsJ6iTMEUr+hS5Ml1RGvsg/20aZoLu3R+icAr5LsyMB15/HPlRE17TF7Fd6R0mCQT2Fxm2MIQCQ73Lx4oU1z1FiDy7R4jOJEGtxT/f9JUxs6P4bGz+NmE9DyRh7BftCRRVaiQ9WmBywxT90oz98Uf0ZyB86vjg7M3yW0Gb8Zjb+LC4Iu8qLawXfxI9xxy3Hc1Kku3BEaRZ4FPGmrlqd5+xLeQYTEl0GekaeCf6MbwCrM8iGIym/E9BVRVANgWKPJR31ZbEbSqdP/52vISLiyDbUhdABGzJjRBLFNb4jFnFFPQr/DP8vTcirlt3a0DBDO5rSTYZvCZ2gb2izbFEMD1QsU+CDVZkAFGi69rjeGX3RVHlX1bha0q7MsoW6nTkIy0wCBZlFg0Lzw4BMOmPiAUK1DjKkctnInrDN5VBam0tTaBsDIhjIpfb4UILZfqExCyXqfsgV8OpK6KKU3qk8aegIxn0Tx2gRfFohGl8EssHgtigF1LPHQ3Q== X-IPAS-Result: A2F1CgDjmsxc/zMmL2hlg1VQW4EGBAsoCoQGg0cDhTGJT5xNAxg8DwEtAoQ+AheCEzgTAQMBAQEEAQEBAQIBAQJpHAELgjoiaTkyAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBBQI4OQIBAxIRBA0MAQERJgEPAgEiAiYCAgIwFRACBA4FIoMAgWsDHQGhHz0CYgILgQEpiF9xfDOCeQEBBYR+GFKBPAmBCyeGeIYtP4ERg1CEQzuCUIJYjVWEbJR1BwKCC1aRYyeVSIwblGkCBAIEBQIOAQEFgWYigVYzGiODPIIbF4NMilNAATGBKY51AYEgAQE X-IronPort-AV: E=Sophos;i="5.60,426,1549951200"; d="scan'208";a="13731133" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from mail-bl2nam02lp2051.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) ([104.47.38.51]) by ob1.tennantco.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 May 2019 14:52:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tennantco.onmicrosoft.com; s=selector1-tennantco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M5bQNQmXQ+O6fNkPSncAUuA2Ze8SV6zTzI5HNudcXB4=; b=HozWWzgwEpZyANl3rp7uKPCooSxf4hP+QgThD4hRkXAFQOHzmh7xWqvlcwzMxgrPEZFMJ+xlPZuoI+AIHAogAHCQNbRIgfZ/7AN1IUA1V2V+glMefcmca8VX04UvUgcTzdpG3XVrPVX9ALFOXyjrXXeykhsjo7jlWoj2o+PAZYs= Received: from CY4PR20MB1381.namprd20.prod.outlook.com (10.173.111.8) by CY4PR20MB1624.namprd20.prod.outlook.com (10.171.167.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Fri, 3 May 2019 19:52:12 +0000 Received: from CY4PR20MB1381.namprd20.prod.outlook.com ([fe80::6dc9:dee3:edc0:a7be]) by CY4PR20MB1381.namprd20.prod.outlook.com ([fe80::6dc9:dee3:edc0:a7be%4]) with mapi id 15.20.1856.008; Fri, 3 May 2019 19:52:12 +0000 From: Dylan Howey To: "alexandre.belloni@bootlin.com" CC: "a.zummo@towertech.it" , "linux-rtc@vger.kernel.org" , Dylan Howey Subject: [PATCH v2 3/4] rtc: pcf2123: add alarm support Thread-Topic: [PATCH v2 3/4] rtc: pcf2123: add alarm support Thread-Index: AQHVAemz+aQKVMtb00W1ZVuDbdgjCA== Date: Fri, 3 May 2019 19:52:12 +0000 Message-ID: <20190503195149.31297-3-Dylan.Howey@tennantco.com> References: <20190503195149.31297-1-Dylan.Howey@tennantco.com> In-Reply-To: <20190503195149.31297-1-Dylan.Howey@tennantco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MN2PR13CA0027.namprd13.prod.outlook.com (2603:10b6:208:160::40) To CY4PR20MB1381.namprd20.prod.outlook.com (2603:10b6:903:8d::8) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dylan.Howey@tennantco.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [198.204.33.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 12157744-f556-46a3-c480-08d6d000d54f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR20MB1624; x-ms-traffictypediagnostic: CY4PR20MB1624: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:363; x-forefront-prvs: 0026334A56 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(396003)(346002)(39860400002)(366004)(189003)(199004)(186003)(386003)(26005)(486006)(71200400001)(7736002)(11346002)(86362001)(6506007)(14454004)(6436002)(305945005)(71190400001)(1076003)(4326008)(72206003)(14444005)(102836004)(50226002)(2501003)(52116002)(76176011)(256004)(6916009)(5660300002)(6512007)(81166006)(99286004)(478600001)(446003)(2351001)(68736007)(6486002)(53936002)(6116002)(107886003)(5640700003)(8676002)(2906002)(316002)(3846002)(36756003)(66066001)(81156014)(64756008)(73956011)(66446008)(66946007)(8936002)(66476007)(66556008)(2616005)(25786009)(54906003)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR20MB1624; H:CY4PR20MB1381.namprd20.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: tennantco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: C8t9j0xGjkpSCP+5/XKPJpDDNRmJgCDHlU7a8cGhaeQWMboL3lUQ8sMZYLsLgvC5zWLrldkSaFFRrV32TDlux8/jLTtvahuWNj3DEq6tKsWx6n+hYOi0DPsHVeuNIHCGpzyw+Fos2GEMrIXh87wKaXtsKELhR79kcxifRgGFA/9FfztpkupP4fZtLCYrVyshJ06bapI0SNsq9dRhccdi0uBK39wxWleOuqdhIp36pqkyimf0nDIA53wDJNgY1KE657rKP2NSdTRoDrBIrnIEntFJg9f4/9va6DpKQnJYY7/Wx4FfHlK1VIjuoUeWM32EdmseVCS5M5C/trSw2p7Azb+K64PdKimPm9hRGZNkCvTp65+zdSrKgISXWpITIkCbY40BfQXRrMANeCGBjAMqgLx54Kgu9IolNx6Ta8hwUkI= MIME-Version: 1.0 X-OriginatorOrg: tennantco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12157744-f556-46a3-c480-08d6d000d54f X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2019 19:52:12.1489 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 854ee4fb-bf50-420c-8a26-5b96d626ac37 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR20MB1624 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Allows alarm to be controlled using, e.g., the RTC_WKALM_SET ioctl. Signed-off-by: Dylan Howey --- drivers/rtc/rtc-pcf2123.c | 116 +++++++++++++++++++++++++++++++++++++- 1 file changed, 114 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index 32bfed7eefd4..8610bf690de6 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -250,6 +250,99 @@ static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm) return 0; } +static int pcf2123_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alm) +{ + struct pcf2123_plat_data *pdata = dev_get_platdata(dev); + u8 rxbuf[4]; + int ret; + unsigned int val = 0; + + ret = regmap_bulk_read(pdata->map, PCF2123_REG_ALRM_MN, rxbuf, + sizeof(rxbuf)); + if (ret) + return ret; + + alm->time.tm_min = bcd2bin(rxbuf[0] & 0x7F); + alm->time.tm_hour = bcd2bin(rxbuf[1] & 0x3F); + alm->time.tm_mday = bcd2bin(rxbuf[2] & 0x3F); + alm->time.tm_wday = bcd2bin(rxbuf[3] & 0x07); + + dev_dbg(dev, "%s: alm is %ptR\n", __func__, &alm->time); + + ret = regmap_read(pdata->map, PCF2123_REG_CTRL2, &val); + if (ret) + return ret; + + alm->enabled = !!(val & CTRL2_AIE); + + return 0; +} + +static int pcf2123_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) +{ + struct pcf2123_plat_data *pdata = dev_get_platdata(dev); + u8 txbuf[4]; + int ret; + + dev_dbg(dev, "%s: alm is %ptR\n", __func__, &alm->time); + + /* Ensure alarm flag is clear */ + ret = regmap_update_bits(pdata->map, PCF2123_REG_CTRL2, CTRL2_AF, 0); + if (ret) + return ret; + + /* Disable alarm interrupt */ + ret = regmap_update_bits(pdata->map, PCF2123_REG_CTRL2, CTRL2_AIE, 0); + if (ret) + return ret; + + /* Set new alarm */ + txbuf[0] = bin2bcd(alm->time.tm_min & 0x7F); + txbuf[1] = bin2bcd(alm->time.tm_hour & 0x3F); + txbuf[2] = bin2bcd(alm->time.tm_mday & 0x3F); + txbuf[3] = bin2bcd(alm->time.tm_wday & 0x07); + + ret = regmap_bulk_write(pdata->map, PCF2123_REG_ALRM_MN, txbuf, + sizeof(txbuf)); + if (ret) + return ret; + + /* Enable alarm interrupt */ + if (alm->enabled) { + ret = regmap_update_bits(pdata->map, PCF2123_REG_CTRL2, + CTRL2_AIE, CTRL2_AIE); + if (ret) + return ret; + } + + return 0; +} + +static irqreturn_t pcf2123_rtc_irq(int irq, void *dev) +{ + struct pcf2123_plat_data *pdata = dev_get_platdata(dev); + struct mutex *lock = &pdata->rtc->ops_lock; + unsigned int val = 0; + int ret = IRQ_NONE; + + mutex_lock(lock); + regmap_read(pdata->map, PCF2123_REG_CTRL2, &val); + + /* Alarm? */ + if (val & CTRL2_AF) { + ret = IRQ_HANDLED; + + /* Clear alarm flag */ + regmap_update_bits(pdata->map, PCF2123_REG_CTRL2, CTRL2_AF, 0); + + rtc_update_irq(pdata->rtc, 1, RTC_IRQF | RTC_AF); + } + + mutex_unlock(lock); + + return ret; +} + static int pcf2123_reset(struct device *dev) { struct pcf2123_plat_data *pdata = dev_get_platdata(dev); @@ -289,7 +382,8 @@ static const struct rtc_class_ops pcf2123_rtc_ops = { .set_time = pcf2123_rtc_set_time, .read_offset = pcf2123_read_offset, .set_offset = pcf2123_set_offset, - + .read_alarm = pcf2123_rtc_read_alarm, + .set_alarm = pcf2123_rtc_set_alarm, }; static int pcf2123_probe(struct spi_device *spi) @@ -297,7 +391,7 @@ static int pcf2123_probe(struct spi_device *spi) struct rtc_device *rtc; struct rtc_time tm; struct pcf2123_plat_data *pdata; - int ret; + int ret = 0; pdata = devm_kzalloc(&spi->dev, sizeof(struct pcf2123_plat_data), GFP_KERNEL); @@ -336,6 +430,24 @@ static int pcf2123_probe(struct spi_device *spi) pdata->rtc = rtc; + /* Register alarm irq */ + if (spi->irq > 0) { + ret = devm_request_threaded_irq(&spi->dev, spi->irq, NULL, + pcf2123_rtc_irq, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, + pcf2123_driver.driver.name, &spi->dev); + if (!ret) + device_init_wakeup(&spi->dev, true); + else + dev_err(&spi->dev, "could not request irq.\n"); + } + + /* The PCF2123's alarm only has minute accuracy. Must add timer + * support to this driver to generate interrupts more than once + * per minute. + */ + pdata->rtc->uie_unsupported = 1; + return 0; kfree_exit: From patchwork Fri May 3 19:52:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dylan Howey X-Patchwork-Id: 1095031 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=tennantco.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=tennantco.onmicrosoft.com header.i=@tennantco.onmicrosoft.com header.b="EntLlfCa"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44wjdT1Pmdz9s9N for ; Sat, 4 May 2019 05:59:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725793AbfECT7W (ORCPT ); Fri, 3 May 2019 15:59:22 -0400 Received: from esa3.tennantco.iphmx.com ([68.232.154.86]:3394 "EHLO esa3.tennantco.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726790AbfECT7W (ORCPT ); Fri, 3 May 2019 15:59:22 -0400 IronPort-PHdr: 9a23:woGE/BPYhIea3amnVsAl6mtUPXoX/o7sNwtQ0KIMzox0K/z9pMbcNUDSrc9gkEXOFd2Cra4d0qyJ6uu5BTFIyK3CmUhKSIZLWR4BhJdetC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+KPjrFY7OlcS30P2594HObwlSizexfK5+IA+0oAnMucUanIRvJ6YswRbVv3VEfPhby3l1LlyJhRb84cmw/J9n8ytOvv8q6tBNX6bncakmVLJUFDspPXw7683trhnDUBCA5mAAXWUMkxpHGBbK4RfnVZrsqCT6t+592C6HPc3qSL0/RDqv47t3RBLulSwKMSMy/mPKhcxqlK9VoAyvqQFjw4DaY4+VOvhxcKTcfdwGSmROUd1cVzBaDY6mc4cCFfYNMOReooLgp1UOtxy+BQy0Ce3hyj5IgmX53asn2OojFgHH0hIvHtITu3nTotv0NKMSXvqzzKXSzzvDaP1X1in96YXTbhAuv/eMXbRqfsrX1UkgCwTFgk+MpoziOjOYz+IAuHWY4ep4Te+jlnIrpg5rrjWgxMogkIfEi4EPxl3E6Cl12Js5KNm7RUJhf9KoDJRduzuUOoZ4WM8uXX1ktDoixr0Ip5G2fzQGxZEiyhPedvOIb4yF7xf+W+mPPzh1indod6yiiBmu7UStz/fzW8uv31lUqCdOj8PCuWoX1xPJ78iKUv59/kC81jmRzw3T8eREIVwslarcNp4h3qY8lpoNvkTHGS/7gF34gbOReEk45OSk8vnqbLP4qpOFMI97kR/xPr4pmsyiHeQ3KQ8OX3Wd+euhzrHj5Vf5QLJWjvIojqbZrJHaJcMdpqKjBA9Vz5oj6xK4Dzeh09QUh2UILFVAeB6fjojpPU/BIOzgAPuin1ihny1nyv/EM7H7DJjALWLPnbf8cbpl7k5T0gszzdRR55JODbEBJer+VEHxtdzcFBA5NRa4zeTgCNRzyIwfWXmCArOHP6PUt1+H/OQvI/WQa48SojryN/8l5/v2gX8jhVAdZbWp3YcQaH2gBPtmJ1uWYHX2jdcHDGgKpBQxQPbxh1KcVT5TY3GyX6Q95jwgE42mCoDDRpypgLyA2ie3BIFZZmdDClqUC3fna52EW+sQaCKVOsJuiCYIVLm8S48k0BGusxT3y6ZgLuva5CIYr47j28Zp6O3Tjx0y9CB0BdyH026RV2F0gn8IRzgu0aB7oEx9zEqD0Kdhj/xCCdxc++hEUhk1NZHC1ex2EdPyVRzbftePVlmmRs+qATYrTtI+kJcyZBM3EtGvnhnF0zCnRbUYk7iMAp0c+KXbw3zwIYB2zHOMnP0oi1Q2S81DL2DgjKN78w/VBqbDlEKFk6esM68b2Xie2n2EyD+irUVRVkZQVrrITDhLSlrSpNK/xkTdQq6GFbkhNAJH1cWFbKBNb4u63h19WP7/NYGGMCqKkGCqCEPQnOneZZf2e2gbwCTWAVQFlAZW53udKAwiHXnx8XnGAmloElTiKwP3/O9ypWnzb3d8zhrCLigDn6Gw5gZTgPWdT/0J2bdRlDYlojMyPFGi0sP+F9eGoQNnYK5bJ9g65QQP2A== X-IPAS-Result: A2F1CgDjmsxc/zMmL2hlg1VQW4EGBAsoCoQGg0cDhTGJT5xNAxg8DwEtAoQ+AheCEzgTAQMBAQEEAQEBAQIBAQJpHAELgjoiaTkyAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBBQI4OQIBAxIRBA0MAQERJgEPAgEiAiYCAgIwFRACBA4FIoMAgWsDHQGhHz0CYgILgQEpiF9xfDOCeQEBBYR+GFKBPAmBCyeGeIYtP4RhhEM7glCCWIsbgjqZYQcCggtWkWMnlUiMG5RpAgQCBAUCDgEBBYFmIoFWMxojgzyBGIRmilNAATGBKY51AYEgAQE X-IronPort-AV: E=Sophos;i="5.60,426,1549951200"; d="scan'208";a="13731134" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from mail-bl2nam02lp2051.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) ([104.47.38.51]) by ob1.tennantco.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 May 2019 14:52:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tennantco.onmicrosoft.com; s=selector1-tennantco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R/CT1WCcXx5ZYsldQSVjzEwMHeb/eeV0W66vv4pp0yE=; b=EntLlfCa7feY38qpX9Tz5diTonZiZuFi5YWcTL8XK+3flZn9L7Sp6wRONw15bf1ZP49aea347L7agYqdanxMTp2xYrw9HZ4eP2Jm2xFmtI5CeAt+KEw2iylZ2vvaGvHJT1o9qEDmoSRuoKaOvonD+sttyhzIRfLBTQ1dYEEDPvE= Received: from CY4PR20MB1381.namprd20.prod.outlook.com (10.173.111.8) by CY4PR20MB1624.namprd20.prod.outlook.com (10.171.167.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Fri, 3 May 2019 19:52:13 +0000 Received: from CY4PR20MB1381.namprd20.prod.outlook.com ([fe80::6dc9:dee3:edc0:a7be]) by CY4PR20MB1381.namprd20.prod.outlook.com ([fe80::6dc9:dee3:edc0:a7be%4]) with mapi id 15.20.1856.008; Fri, 3 May 2019 19:52:13 +0000 From: Dylan Howey To: "alexandre.belloni@bootlin.com" CC: "a.zummo@towertech.it" , "linux-rtc@vger.kernel.org" , Dylan Howey Subject: [PATCH v2 4/4] rtc: pcf2123: use %ptR Thread-Topic: [PATCH v2 4/4] rtc: pcf2123: use %ptR Thread-Index: AQHVAemzlzvgTfa2QkWK6KkkgoESLg== Date: Fri, 3 May 2019 19:52:12 +0000 Message-ID: <20190503195149.31297-4-Dylan.Howey@tennantco.com> References: <20190503195149.31297-1-Dylan.Howey@tennantco.com> In-Reply-To: <20190503195149.31297-1-Dylan.Howey@tennantco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BL0PR03CA0010.namprd03.prod.outlook.com (2603:10b6:208:2d::23) To CY4PR20MB1381.namprd20.prod.outlook.com (2603:10b6:903:8d::8) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dylan.Howey@tennantco.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [198.204.33.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a221061-f9a3-4533-8944-08d6d000d5cc x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR20MB1624; x-ms-traffictypediagnostic: CY4PR20MB1624: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:172; x-forefront-prvs: 0026334A56 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(396003)(346002)(39860400002)(366004)(189003)(199004)(186003)(386003)(26005)(486006)(71200400001)(7736002)(11346002)(86362001)(6506007)(14454004)(6436002)(305945005)(71190400001)(1076003)(4326008)(72206003)(102836004)(50226002)(2501003)(52116002)(76176011)(256004)(6916009)(5660300002)(6512007)(81166006)(99286004)(478600001)(446003)(2351001)(68736007)(6486002)(53936002)(6116002)(107886003)(5640700003)(8676002)(2906002)(316002)(3846002)(36756003)(66066001)(81156014)(64756008)(73956011)(66446008)(66946007)(8936002)(66476007)(66556008)(2616005)(25786009)(54906003)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR20MB1624; H:CY4PR20MB1381.namprd20.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: tennantco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AFPhHF4yutQ4CJsaY2KXNYiYZTT5vywpYtld2NaO1Y6dgnRmWG/zNfNB9Qwv+6wNGxDTrVlMEWUijZE4OJmNPhPUeBLHf9+b1QU7qWPI+nFUClR7U0FxNrphE5h1df1XDbQT8BpnwHJfLdN6YuNXAsZipS19YBGETdMWk5z2JFuNVJmEkThLm62b0brnA+x+iOxVXcWMcIMjyg4sZ/FyFCicuqVa5fdBYo6L0HpMrZ6KTVoCyqdj4hgQ4cFzSrNhhz0FTmRjb6AKt6+V7n/nLdEkEGOIpt0L75NyOEeuFOipJL7C8hJEMSp/vJeasBipo1ZXRwChX5vRIwUvuL6qjmTjANGq8XeNtnxFsKFApYRYHc/XuGF/5VeaU9qamTW6+X63J6ryGmd0O4DiKomSCyt9xnd70t8IZ8nwFLo0+Ho= MIME-Version: 1.0 X-OriginatorOrg: tennantco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a221061-f9a3-4533-8944-08d6d000d5cc X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2019 19:52:12.8185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 854ee4fb-bf50-420c-8a26-5b96d626ac37 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR20MB1624 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Use %ptR to print date in human readable format. Signed-off-by: Dylan Howey --- drivers/rtc/rtc-pcf2123.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index 8610bf690de6..3b314ce991e5 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -202,11 +202,7 @@ static int pcf2123_rtc_read_time(struct device *dev, struct rtc_time *tm) if (tm->tm_year < 70) tm->tm_year += 100; /* assume we are in 1970...2069 */ - dev_dbg(dev, "%s: tm is secs=%d, mins=%d, hours=%d, " - "mday=%d, mon=%d, year=%d, wday=%d\n", - __func__, - tm->tm_sec, tm->tm_min, tm->tm_hour, - tm->tm_mday, tm->tm_mon, tm->tm_year, tm->tm_wday); + dev_dbg(dev, "%s: tm is %ptR\n", __func__, tm); return 0; } @@ -217,11 +213,7 @@ static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm) u8 txbuf[7]; int ret; - dev_dbg(dev, "%s: tm is secs=%d, mins=%d, hours=%d, " - "mday=%d, mon=%d, year=%d, wday=%d\n", - __func__, - tm->tm_sec, tm->tm_min, tm->tm_hour, - tm->tm_mday, tm->tm_mon, tm->tm_year, tm->tm_wday); + dev_dbg(dev, "%s: tm is %ptR\n", __func__, tm); /* Stop the counter first */ ret = regmap_write(pdata->map, PCF2123_REG_CTRL1, CTRL1_STOP);