From patchwork Tue Apr 30 13:38:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyril Hrubis X-Patchwork-Id: 1093287 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44tjKp0lryz9s7T for ; Tue, 30 Apr 2019 23:38:53 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id C6A7C3EAC98 for ; Tue, 30 Apr 2019 15:38:49 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) by picard.linux.it (Postfix) with ESMTP id 19F2B3EA05E for ; Tue, 30 Apr 2019 15:38:48 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id E2978200B17 for ; Tue, 30 Apr 2019 15:38:46 +0200 (CEST) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1A6FFAD7B; Tue, 30 Apr 2019 13:38:46 +0000 (UTC) From: Cyril Hrubis To: ltp@lists.linux.it Date: Tue, 30 Apr 2019 15:38:35 +0200 Message-Id: <20190430133836.28400-1-chrubis@suse.cz> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.99.2 at in-7.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.0 required=7.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-7.smtp.seeweb.it Subject: [LTP] [PATCH 1/2] testcases.mk: Fix libs/ path for out-of-tree build X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" The path to the Makefile was not correct for the out-of-tree build because it was pointing to the build directory rather than to the source directory. Apparently this also caused random failures for out-of-tree build. For some reason when building syscalls/set_mempolicy/ testcases the rebuild of the libltpnuma.a library is triggered for out-of-tree build for about 10% of the cases on massively parallel build. Which as far as I can tell shouldn't happen since we build everything in the libs/ directory as a prerequisite of the testcases/ directory. So there is likely some strange race condition happening and while this does not fix the actual race it makes it quite harmless since the target was already build and the make in the libs/libltpnuma/ directory will be no-op. Signed-off-by: Cyril Hrubis CC: Petr Vorel CC: Jan Stancek Acked-by: Jan Stancek Tested-by: Petr Vorel --- include/mk/testcases.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/mk/testcases.mk b/include/mk/testcases.mk index 131854ec7..684655fbf 100644 --- a/include/mk/testcases.mk +++ b/include/mk/testcases.mk @@ -49,7 +49,7 @@ LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/, $(foreach MAKE_DEPS += $(LTPLIBS_FILES) $(LTPLIBS_FILES): $(LTPLIBS_DIRS) - $(MAKE) -C "$^" -f "$^/Makefile" all + $(MAKE) -C "$^" -f "$(subst $(abs_top_builddir),$(abs_top_srcdir),$^)/Makefile" all LDFLAGS += $(addprefix -L$(top_builddir)/libs/lib, $(LTPLIBS)) From patchwork Tue Apr 30 13:38:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyril Hrubis X-Patchwork-Id: 1093288 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44tjKr6M2tz9sB3 for ; Tue, 30 Apr 2019 23:38:56 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 0A96B3EACFD for ; Tue, 30 Apr 2019 15:38:54 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) by picard.linux.it (Postfix) with ESMTP id B33CC3EACA0 for ; Tue, 30 Apr 2019 15:38:50 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 644611A01478 for ; Tue, 30 Apr 2019 15:38:49 +0200 (CEST) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9C8F8AD85; Tue, 30 Apr 2019 13:38:49 +0000 (UTC) From: Cyril Hrubis To: ltp@lists.linux.it Date: Tue, 30 Apr 2019 15:38:36 +0200 Message-Id: <20190430133836.28400-2-chrubis@suse.cz> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190430133836.28400-1-chrubis@suse.cz> References: <20190430133836.28400-1-chrubis@suse.cz> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.99.2 at in-3.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.0 required=7.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-3.smtp.seeweb.it Subject: [LTP] [PATCH 2/2] Makefile: Fix target redefinition X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" There is no need to add a rule for the libs directory because there is a generic rule for directory creation already. All we need to do is to make the libs-all target depend on the directory path, which we do already so that the directory is created before we attempt to execute make there. Fixes: 17a5b0fb63bf65eff433bdee3bf5f73826a50e0f Signed-off-by: Cyril Hrubis CC: Petr Vorel CC: Jan Stancek Tested-by: Petr Vorel --- Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/Makefile b/Makefile index c46d050ce..768ca4606 100644 --- a/Makefile +++ b/Makefile @@ -102,9 +102,6 @@ $(sort $(addprefix $(abs_top_builddir)/,$(BOOTSTRAP_TARGETS)) $(INSTALL_DIR) $(D ## Pattern based subtarget rules. lib-install: lib-all -$(abs_top_builddir)/libs: - mkdir -m 00755 -p "$@" - libs-all: $(abs_top_builddir)/libs $(MAKE_TARGETS) include-all lib-all libs-all: