From patchwork Fri Apr 26 16:42:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 1091636 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D2kYgFmr"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mYJw+fEp"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44rKbr4lTSz9s9N for ; Sat, 27 Apr 2019 02:42:48 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JKn09frZM+WG//vJXjRUlhgKNOGXK3NNUo0POCbtGhE=; b=D2kYgFmrU3BUlL FCOfYYK8381RGaZyOaePiwtUfn0R8e17l0l8WljnQUpkEnJQMMVQxS7gA3g/b2P0OCu6q6SJOF4x/ mNThyxYrPuj2hAXIu0F9ffSfm6H/ZLXZe7tJZR3Et2j8kys/yCUWmpMZWYyxkklBCj4SHy2tuXcIW xkyCAc66ZiFMyhKwoMibmaW7b2bWKmL8VdeAX3Zx1yRlJ0/rptMEitAOMMHATM/18FfzrF2+/etQe piGpSMcBe/biJ4oT4HGXPWpQmZzlgBRVBiPmwBVMHfB3BDSe8WSr5b7yn24ZYR6Bv3F6z+e8BSXQA 6N6D+3qCK7e7j9+W0qjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3vv-0003Z3-P5; Fri, 26 Apr 2019 16:42:43 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3vm-0003OG-Dy for linux-mtd@lists.infradead.org; Fri, 26 Apr 2019 16:42:35 +0000 Received: by mail-lj1-x242.google.com with SMTP id f23so3557847ljc.0 for ; Fri, 26 Apr 2019 09:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qzP0AR+ti/bqIxQypEOph2XNCqymISMdCKVOmHoTAW0=; b=mYJw+fEpKwfGv3W9+yz4OQZOogyQvXG4iChudvGNTNRdh94xryShu29kHDsNZzfeVV Zms7PPfIpkesYBp5DxHHdhVfm8KgKK+oM/cPOH+gb+hAwSjnlE0LIhftW1fqmtVI1QYb OujX/HNvH96Ir4xXi4UhqmEPy5oIhXf7/v3oOtOVVda+lIRtfAyEzbVc/2r80w+yend7 ECUgfPKvtJx35ZcnGyQZzitt6BrdtlVJI4BjtIp6FigIchdJLisJJqZQVBMoXdcwXUzV LJlIrwuC+q9ryu8M3pBgMlSgdLCxQ8WuFsXks0lW/9zA3uwkKp5vrvn6pG/McsjlLSxe fzlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qzP0AR+ti/bqIxQypEOph2XNCqymISMdCKVOmHoTAW0=; b=o3vxZbbLR56NPwVDeNU3lKf8La9/szwRg9VgV2xJig1oTr6/9RxXqYkOey8SspLGo+ E2wZklNaW/RV2VjF70ZhHF2dth4y1VmHD1JktoQzvvtKaB3jGp0m8H5ZylvbIfT+yRQj TGqOxSoDB1MyZsxmqpgAMJyb7F2LXQ5WIwJHzpsjlEfKYUXHjfo27DRQOXHtjtcW90pL dfTFNAGYtZ7/GrAzSHxmzN2uGiJvnviMT158DaQRHfNC9bboi0WXMx8xbtxRnoYeYaN/ JH0mTrgR6o77tU3slUzPuGKitXeiJA/T/vr2ZWWJAGgsROmWqaRfn6Yjyt9nGga3tZtp U7lA== X-Gm-Message-State: APjAAAXZtFZSJ3/qnolZpH900sv/J9tAsgxOTD1zZFMQ/4U7eVWTFswi o05ZJ1bVBPSjTUngbe5bE7k= X-Google-Smtp-Source: APXvYqzs7CP5V5+FUsRKnlBS83N6ImFLqrYYzWE+m/MWQdzJUonXvYNwdAqr5NLnWOwcqxJ7X+YLDg== X-Received: by 2002:a2e:9687:: with SMTP id q7mr2908573lji.113.1556296952878; Fri, 26 Apr 2019 09:42:32 -0700 (PDT) Received: from localhost.localdomain ([2a02:a315:5445:5300:2492:ad61:69f1:23cc]) by smtp.googlemail.com with ESMTPSA id q11sm5637807lfc.51.2019.04.26.09.42.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 09:42:32 -0700 (PDT) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: kyungmin.park@samsung.com Subject: [PATCH 1/5] mtd: onenand/samsung: Unify resource order for controller variants Date: Fri, 26 Apr 2019 18:42:20 +0200 Message-Id: <20190426164224.11327-2-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> References: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_094234_488522_990F90C5 X-CRM114-Status: GOOD ( 16.32 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:242 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pawel.mikolaj.chmiel[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, bbrezillon@kernel.org, richard@nod.at, linux-kernel@vger.kernel.org, Tomasz Figa , marek.vasut@gmail.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com, dwmw2@infradead.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tomasz Figa Before this patch, the order of memory resources requested by the driver was controller base as first and OneNAND chip base as second for S3C64xx/S5PC100 variant and the opposite for S5PC110/S5PV210 variant. To make this more consistent, this patch swaps the order of resources for the latter and updates platform code accordingly. As a nice side effect there is a slight reduction in line count of probe function. Signed-off-by: Tomasz Figa Signed-off-by: Paweł Chmiel --- drivers/mtd/nand/onenand/samsung.c | 48 ++++++++++++++---------------- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/drivers/mtd/nand/onenand/samsung.c b/drivers/mtd/nand/onenand/samsung.c index e64d0fdf7eb5..a425f19a3876 100644 --- a/drivers/mtd/nand/onenand/samsung.c +++ b/drivers/mtd/nand/onenand/samsung.c @@ -126,14 +126,13 @@ struct s3c_onenand { struct mtd_info *mtd; struct platform_device *pdev; enum soc_type type; - void __iomem *base; - void __iomem *ahb_addr; + void __iomem *ctrl_base; + void __iomem *chip_base; int bootram_command; void *page_buf; void *oob_buf; unsigned int (*mem_addr)(int fba, int fpa, int fsa); unsigned int (*cmd_map)(unsigned int type, unsigned int val); - void __iomem *dma_addr; unsigned long phys_base; struct completion complete; }; @@ -147,22 +146,22 @@ static struct s3c_onenand *onenand; static inline int s3c_read_reg(int offset) { - return readl(onenand->base + offset); + return readl(onenand->ctrl_base + offset); } static inline void s3c_write_reg(int value, int offset) { - writel(value, onenand->base + offset); + writel(value, onenand->ctrl_base + offset); } static inline int s3c_read_cmd(unsigned int cmd) { - return readl(onenand->ahb_addr + cmd); + return readl(onenand->chip_base + cmd); } static inline void s3c_write_cmd(int value, unsigned int cmd) { - writel(value, onenand->ahb_addr + cmd); + writel(value, onenand->chip_base + cmd); } #ifdef SAMSUNG_DEBUG @@ -519,7 +518,7 @@ static int (*s5pc110_dma_ops)(dma_addr_t dst, dma_addr_t src, size_t count, int static int s5pc110_dma_poll(dma_addr_t dst, dma_addr_t src, size_t count, int direction) { - void __iomem *base = onenand->dma_addr; + void __iomem *base = onenand->ctrl_base; int status; unsigned long timeout; @@ -563,7 +562,7 @@ static int s5pc110_dma_poll(dma_addr_t dst, dma_addr_t src, size_t count, int di static irqreturn_t s5pc110_onenand_irq(int irq, void *data) { - void __iomem *base = onenand->dma_addr; + void __iomem *base = onenand->ctrl_base; int status, cmd = 0; status = readl(base + S5PC110_INTC_DMA_STATUS); @@ -585,7 +584,7 @@ static irqreturn_t s5pc110_onenand_irq(int irq, void *data) static int s5pc110_dma_irq(dma_addr_t dst, dma_addr_t src, size_t count, int direction) { - void __iomem *base = onenand->dma_addr; + void __iomem *base = onenand->ctrl_base; int status; status = readl(base + S5PC110_INTC_DMA_MASK); @@ -634,7 +633,7 @@ static int s5pc110_read_bufferram(struct mtd_info *mtd, int area, } if (offset & 3 || (size_t) buf & 3 || - !onenand->dma_addr || count != mtd->writesize) + !onenand->ctrl_base || count != mtd->writesize) goto normal; /* Handle vmalloc address */ @@ -864,23 +863,22 @@ static int s3c_onenand_probe(struct platform_device *pdev) s3c_onenand_setup(mtd); r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - onenand->base = devm_ioremap_resource(&pdev->dev, r); - if (IS_ERR(onenand->base)) - return PTR_ERR(onenand->base); - + onenand->ctrl_base = devm_ioremap_resource(&pdev->dev, r); + if (IS_ERR(onenand->ctrl_base)) + return PTR_ERR(onenand->ctrl_base); + + r = platform_get_resource(pdev, IORESOURCE_MEM, 1); + onenand->chip_base = devm_ioremap_resource(&pdev->dev, r); + if (IS_ERR(onenand->chip_base)) + return PTR_ERR(onenand->chip_base); onenand->phys_base = r->start; - /* Set onenand_chip also */ - this->base = onenand->base; - /* Use runtime badblock check */ this->options |= ONENAND_SKIP_UNLOCK_CHECK; if (onenand->type != TYPE_S5PC110) { - r = platform_get_resource(pdev, IORESOURCE_MEM, 1); - onenand->ahb_addr = devm_ioremap_resource(&pdev->dev, r); - if (IS_ERR(onenand->ahb_addr)) - return PTR_ERR(onenand->ahb_addr); + /* Set onenand_chip also */ + this->base = onenand->ctrl_base; /* Allocate 4KiB BufferRAM */ onenand->page_buf = devm_kzalloc(&pdev->dev, SZ_4K, @@ -898,10 +896,8 @@ static int s3c_onenand_probe(struct platform_device *pdev) this->subpagesize = mtd->writesize; } else { /* S5PC110 */ - r = platform_get_resource(pdev, IORESOURCE_MEM, 1); - onenand->dma_addr = devm_ioremap_resource(&pdev->dev, r); - if (IS_ERR(onenand->dma_addr)) - return PTR_ERR(onenand->dma_addr); + /* Set onenand_chip also */ + this->base = onenand->chip_base; s5pc110_dma_ops = s5pc110_dma_poll; /* Interrupt support */ From patchwork Fri Apr 26 16:42:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 1091637 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X3Pvb/uG"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WkHXdRvo"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44rKc43bHyz9s70 for ; Sat, 27 Apr 2019 02:43:00 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nYXH1dFNYjYYeWKg5zkPSzmUH7a3BOnrntpZFfRqAbo=; b=X3Pvb/uGbR6gM0 ggHIU6Eu58ed/5j+zj5zn8p7li5x5ewxBbfnVMc9UugfdK+8pfV08Ej0g9JC+qD+/K/cn444BRFak VoOMQ3zK5lN+nPZ28IZJGyZFHCu6Ag4oQBSN7MMNvbJpdQtPnWV2lg/2nYQ1p+bdXG+ljZVxgFeZB 1nzwL85azNmZY5Owk+p0Dv1UuYxdbyPerYdaHU3iHXIYqB4F0ZD183eJuskuVJ5Eu2+bx51i+zq4m wphgSCCKlc7WwwnKz3FCihYzrmsUJo/EQLoa/n3ftBBcoLPoTcJJ8Hsb6LmrKHl6HGRqcag9Oc5MP yg/xxx8LoxsMg3BIgLCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3w7-0003qg-U5; Fri, 26 Apr 2019 16:42:55 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3vo-0003Om-Cl for linux-mtd@lists.infradead.org; Fri, 26 Apr 2019 16:42:38 +0000 Received: by mail-lf1-x144.google.com with SMTP id j20so2982388lfh.2 for ; Fri, 26 Apr 2019 09:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eWVEhVXV6Szyd9/44KMWrRQaDEl4L0ZWJnDi1/l1OvU=; b=WkHXdRvo7xgf4zAkZ1FgFwoafjH+HccU9KLH1nV9eSay+kL9EbIhE6HkomyibxW1e4 lNHutCqEG+L35Mk8D6utdJQ97nVWRuksU1keF0ALEwIfHvmOpLMVogA/Wi5dsdXkj6ZH heoVg3WDdIQwDg0auIn9YOkFfd1EjsS6W3Xm8S1MFOVqip9GQ5Q8M9dxn0u6389PMpTr C5SXY+nN5SKa4QMyjEZQ6vNGwTxE0MxU2JzTkAD7zuNxehhx3MBHRh6z7wxd/gSBScS2 n+JZfX5Ahg5EbO2YYTuPLFt/ibIXN/yzINXn0rCyOrI7VZ5g7YpEmZD6TmN+KgxMm4bV 3/hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eWVEhVXV6Szyd9/44KMWrRQaDEl4L0ZWJnDi1/l1OvU=; b=V1YafGj2xUpvqm98T6JW9xguVo78YsJgUVQbFNUxiCcaknZTIGFWjcCYsVegNlz5z2 HMIuI4Go4Nq9jR7iSrym4ny1M8by9IUpdxW7kwugCRrZaOydvkaDDf9RfVRdBmQ90mNH KPEsc77DF+jn6o7nKDoRJOenJ+GZ2j1wmtNtrMLgyFbrba90M+qwFBuNk8aBxJOYt+y6 XzAPkX6ZDw/vaiUS8wwFWu+xEj6s4skoHQD6sJCTkK1sfAkk1cC1ToDkdeKItZUFxrMv bQRlcg+KancejN+Zyv01WEWF2/LqaFCBLOq3FW2K7d/toPksYOi+I8KlRkQBmBXv4bVJ 5p1g== X-Gm-Message-State: APjAAAXFcGRmf7iufY4UsUddfkeJb7E8zSFEOwkRcVufnQt02Lr6U5GX qsa1ljYCX29BERDdmMN5UxM= X-Google-Smtp-Source: APXvYqxhhrqH1igbuxLqu6Jv09PPhxp/Yw5Ugs/uQ7FpqteK7/kO4wqb+fOJ0yS80vA0LZ6oBCvrzQ== X-Received: by 2002:a19:7702:: with SMTP id s2mr26244975lfc.102.1556296954524; Fri, 26 Apr 2019 09:42:34 -0700 (PDT) Received: from localhost.localdomain ([2a02:a315:5445:5300:2492:ad61:69f1:23cc]) by smtp.googlemail.com with ESMTPSA id q11sm5637807lfc.51.2019.04.26.09.42.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 09:42:33 -0700 (PDT) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: kyungmin.park@samsung.com Subject: [PATCH 2/5] mtd: onenand/samsung: Make sure that bus clock is enabled Date: Fri, 26 Apr 2019 18:42:21 +0200 Message-Id: <20190426164224.11327-3-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> References: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_094236_544695_92FC0F25 X-CRM114-Status: GOOD ( 12.92 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:144 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pawel.mikolaj.chmiel[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, bbrezillon@kernel.org, richard@nod.at, linux-kernel@vger.kernel.org, Tomasz Figa , marek.vasut@gmail.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com, dwmw2@infradead.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tomasz Figa This patch adds basic handling of controller bus clock to make sure that in device probe it is enabled and device can operate correctly. The clock is optional and driver behavior is identical as before this patch if not provided. Signed-off-by: Tomasz Figa Signed-off-by: Paweł Chmiel Reviewed-by: Miquel Raynal --- drivers/mtd/nand/onenand/samsung.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/mtd/nand/onenand/samsung.c b/drivers/mtd/nand/onenand/samsung.c index a425f19a3876..9628bf5bc397 100644 --- a/drivers/mtd/nand/onenand/samsung.c +++ b/drivers/mtd/nand/onenand/samsung.c @@ -14,6 +14,7 @@ * S5PC110: use DMA */ +#include #include #include #include @@ -125,6 +126,7 @@ enum soc_type { struct s3c_onenand { struct mtd_info *mtd; struct platform_device *pdev; + struct clk *clk_bus; enum soc_type type; void __iomem *ctrl_base; void __iomem *chip_base; @@ -916,6 +918,10 @@ static int s3c_onenand_probe(struct platform_device *pdev) } } + onenand->clk_bus = devm_clk_get(&pdev->dev, "bus"); + if (!IS_ERR(onenand->clk_bus)) + clk_prepare_enable(onenand->clk_bus); + err = onenand_scan(mtd, 1); if (err) return err; @@ -947,6 +953,8 @@ static int s3c_onenand_remove(struct platform_device *pdev) struct mtd_info *mtd = platform_get_drvdata(pdev); onenand_release(mtd); + if (!IS_ERR(onenand->clk_bus)) + clk_disable_unprepare(onenand->clk_bus); return 0; } From patchwork Fri Apr 26 16:42:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 1091639 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qzyQ10bh"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GLdiWg0Z"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44rKcK2cNdz9s3Z for ; Sat, 27 Apr 2019 02:43:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m9YNgbGDyqBzeh5edQqQ9U6VqQRjNxgsWSoBmVB8GD4=; b=qzyQ10bht6ew7V Xy1pB28qj80YfEbFqGhoolLyndYqmvTh2jzuCLVgFiLOvM0pxtPyT+ZXuaQTCRq5dU6msaHFV6BEF 8Dgk7IOVgUEDueRv2CKLKPWvv+CrPzBTnp+55OCreF5hbV18bn2xDRKq1/b+ENfOLGozs2HeAODzA 6HUhmK9f9YLLYMur8y9NSSW2VLfJaT1B9u580QA92ZeJU2rb5TiKPofDsrmXLaW8TvHd5KtX3SMco 6yF4pNxEzUiIeraDGF4PP28v39lCVbVX45AEDM4TKPDBsTh9di+ocsieZ716yz8YZUpXEeu9GtysJ K5ehSv2ihr2ZEHP6sgSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3wJ-00045n-Jl; Fri, 26 Apr 2019 16:43:07 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3vq-0003PM-0S for linux-mtd@lists.infradead.org; Fri, 26 Apr 2019 16:42:41 +0000 Received: by mail-lj1-x241.google.com with SMTP id s7so795420ljh.1 for ; Fri, 26 Apr 2019 09:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6Y+4Tl47IG+lz0BxKQcbzY1Eso3ZPi0a0zQy/pwXSWM=; b=GLdiWg0ZkD2A76urU8+cUmH7vu4+Xj4Xr0HWH0tPBVd1h13p5zIa8oOwLyU0z31n4W MC/IGXOLu4gAz/z2SgQOTsMvWc//eQlHtxh7QQ895Dyj4rjwrrSDzB4avpPAy8vcJYUR NnWAbeJg+tgKVEwd+UuNO1nYtnqxXrJTAis4G+Ei1fFPmj52MCw1g3nm3PjxmlZYvW3e 9l+vTSCFBvGlDKsuTcxo7Ux/oNuOWDfDp1h8gM3ybn2Uin0weXZgm9n//Np9tEYB18JX /OtPusi+ULOTnp/yl+VIAeyDbA6Xf5M2hyVFqEGXMOJNR0qjQWXJhHWxFkkrsAgoeYe8 uF1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6Y+4Tl47IG+lz0BxKQcbzY1Eso3ZPi0a0zQy/pwXSWM=; b=nfewZp+1FV3WtXttx6XBtFU8Krh30MtVaASbTIWj+YNNMg8IxJIiLrnYPLbX76CESv 3E/6gSQW1OaPJ4EOPGvP6XEC8/PyaOkqZDwy3xQ38L7YAhbUpEAF/b9WX33M7xizrsi8 gPUWleksjQIUBsOoUJSla2lLL1NyWcJuD6u5eXNm4X3Cu+nfJmHFsfbwKU2C40JPTJMo 0iYuF7xQK1syWadeG1MTqwaYgSAB/ke1W2wrF5VS+++hW6aE456N6B63QEnyRVyYbBC6 Sa32IyQ4HUqjvDknNjib5jhhranpmZdxpnSFW8lTBLykSgErbAr4Jy/JzWOShU5A0HJK U28Q== X-Gm-Message-State: APjAAAVF4gsd3RRV/1r0gdPdswaOiixBZGZGByfukE0kk+fWl6jNhRnJ 1FMrm9aOWS0IOakEbyICKgs= X-Google-Smtp-Source: APXvYqyk/POYUvdk35I2whPVIAg8/WSc3NUy2eGeHn6j2RSTLnpZi2BPXJt0JWUcnlepCVr6LY1PQQ== X-Received: by 2002:a2e:4a09:: with SMTP id x9mr5053589lja.19.1556296956179; Fri, 26 Apr 2019 09:42:36 -0700 (PDT) Received: from localhost.localdomain ([2a02:a315:5445:5300:2492:ad61:69f1:23cc]) by smtp.googlemail.com with ESMTPSA id q11sm5637807lfc.51.2019.04.26.09.42.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 09:42:35 -0700 (PDT) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: kyungmin.park@samsung.com Subject: [PATCH 3/5] mtd: onenand/samsung: Add device tree support Date: Fri, 26 Apr 2019 18:42:22 +0200 Message-Id: <20190426164224.11327-4-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> References: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_094238_411017_CDA44961 X-CRM114-Status: GOOD ( 14.99 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:241 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pawel.mikolaj.chmiel[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, bbrezillon@kernel.org, richard@nod.at, linux-kernel@vger.kernel.org, Tomasz Figa , marek.vasut@gmail.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com, dwmw2@infradead.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tomasz Figa This patch adds support for instantation using Device Tree. Signed-off-by: Tomasz Figa Signed-off-by: Paweł Chmiel Reviewed-by: Miquel Raynal --- drivers/mtd/nand/onenand/samsung.c | 37 +++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/onenand/samsung.c b/drivers/mtd/nand/onenand/samsung.c index 9628bf5bc397..0f450604412f 100644 --- a/drivers/mtd/nand/onenand/samsung.c +++ b/drivers/mtd/nand/onenand/samsung.c @@ -25,6 +25,7 @@ #include #include #include +#include #include "samsung.h" @@ -835,8 +836,36 @@ static void s3c_onenand_setup(struct mtd_info *mtd) this->write_bufferram = onenand_write_bufferram; } +#ifdef CONFIG_OF +static const struct of_device_id s3c_onenand_of_match[] = { + { .compatible = "samsung,s3c6400-onenand", + .data = (void *)TYPE_S3C6400 }, + { .compatible = "samsung,s3c6410-onenand", + .data = (void *)TYPE_S3C6410 }, + { .compatible = "samsung,s5pv210-onenand", + .data = (void *)TYPE_S5PC110 }, + {}, +}; +MODULE_DEVICE_TABLE(of, onenand_s3c_dt_match); +#endif + +static enum soc_type s3c_onenand_get_device_id(struct platform_device *pdev) +{ + struct device_node *np = pdev->dev.of_node; + + if (IS_ENABLED(CONFIG_OF) && np) { + const struct of_device_id *match; + + match = of_match_node(s3c_onenand_of_match, np); + return (enum soc_type)match->data; + } + + return platform_get_device_id(pdev)->driver_data; +} + static int s3c_onenand_probe(struct platform_device *pdev) { + struct device_node *np = pdev->dev.of_node; struct onenand_platform_data *pdata; struct onenand_chip *this; struct mtd_info *mtd; @@ -858,9 +887,10 @@ static int s3c_onenand_probe(struct platform_device *pdev) this = (struct onenand_chip *) &mtd[1]; mtd->priv = this; + mtd->dev.of_node = np; mtd->dev.parent = &pdev->dev; onenand->pdev = pdev; - onenand->type = platform_get_device_id(pdev)->driver_data; + onenand->type = s3c_onenand_get_device_id(pdev); s3c_onenand_setup(mtd); @@ -919,6 +949,10 @@ static int s3c_onenand_probe(struct platform_device *pdev) } onenand->clk_bus = devm_clk_get(&pdev->dev, "bus"); + if (np && IS_ERR(onenand->clk_bus)) { + dev_err(&pdev->dev, "failed to get bus clock\n"); + return PTR_ERR(onenand->clk_bus); + } if (!IS_ERR(onenand->clk_bus)) clk_prepare_enable(onenand->clk_bus); @@ -1000,6 +1034,7 @@ static struct platform_driver s3c_onenand_driver = { .driver = { .name = "samsung-onenand", .pm = &s3c_pm_ops, + .of_match_table = of_match_ptr(s3c_onenand_of_match), }, .id_table = s3c_onenand_driver_ids, .probe = s3c_onenand_probe, From patchwork Fri Apr 26 16:42:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 1091640 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nSEmF0le"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nJyPCLZ3"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44rKcW4Xyqz9s5c for ; Sat, 27 Apr 2019 02:43:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VF955NClf3l85ZUAZTIK/s5bWPReQe0JknrOLlyRf+w=; b=nSEmF0leuYgHCu zD5ZhTJBSI4qNb0TSk6x+0yVaxBeHA6/x6GAp5s327PRBbTvijb4t0lfnh1vTm3xqM/nLuudgqe+v 9gcuXBJ9OT/BxMzcfWgOvUqJPbty2VudJOlXhSTd5IhUfPtqt35cdSLWoF/oHJQAqJB3izH7Xq7Iu ecKCqpln5ylYptqO3HUp4OAFiH76ig6kW/HyMxbN5gkM7bYJ4Ym1XPw31VXfHDsoSpjeDpHBrJzJU 6+sHQkGyaDY5g4A59aB+DeXm6N1JS1YdfntGMuvQ+3FLj5pIx0InvlRmJOALw/z0HD1SAlgreT5aP bpcN+y/A3+nacGr4NUUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3wU-0004Kn-89; Fri, 26 Apr 2019 16:43:18 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3vr-0003Rm-Uc for linux-mtd@lists.infradead.org; Fri, 26 Apr 2019 16:42:43 +0000 Received: by mail-lf1-x141.google.com with SMTP id j20so2982495lfh.2 for ; Fri, 26 Apr 2019 09:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xuIU2BQoWzCiQ5FUAaKlSoiV2sVXtdwFfbdEhHMztTg=; b=nJyPCLZ3ErXNfXIjsfl5woXrqnWv2QZqmaztLmTuDHbc8Pm6jl+xN4GyYqWz4/+atE x/Krc5kqtqsgPSBxsx1kCTKIAyD7rMdQFUSpi3TwwZU7cAXHOKm+urN6HAoUiG3+pDde Z/7ar+DwOLS6ABUfEDthSB2ccA/Dwv1pCDbwYT3RpwBeJs8z1Qy0+DflkKU/IQmRwAKG 105vW23kC0BwCHqVpmnxGRUYIPUJLEvLuVAN+xRAtxsBj1qoJPsvOci6zjmjDxqQ0faF 7hCO88ooXCOZJNlba4guRggFXBcI4aixK6to8I9yrtAiU7M/X4+tausPBMSy0IFgwgZJ 9eGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xuIU2BQoWzCiQ5FUAaKlSoiV2sVXtdwFfbdEhHMztTg=; b=c+g76hluJFjIHiqrfJdpKQGKbA4sZzE5bOMrTQvwH7stQQtfLhs/gpQmp51WI5I38P dudcUDXRh0p8w1AYbYpmhj52eZbAtv9S41dXeetCPDn5GGG/D7MU10HAGk+KHEB23pye 6XLwV5Zraz3VJ4Vlqesrx6wMPiyjGBP8AV1IbQi5p+rRWScFXMv2qlCr/CWjtQZawimo jNaNm4WWXmk00b9+O2jrNZ+N4XHWo0BmMgqT1E0uBrqJ8MpPAHx6K72QNvEkFTRV0uxu bDbBZRwTSJ3Lg1gjF+IOGrNVoRGspSrT2iY/f0AVbj48jaMc/GdbSDwsO6RCKj9UA+86 ERdQ== X-Gm-Message-State: APjAAAU2kO9YY6hucZlALzGHwLXiYgZvBp49+pcq6PzJrR6luB9DKphA Vquog5YJ97UM41Yp/uzyi2o= X-Google-Smtp-Source: APXvYqxIhxB+pq7CSTz418WnS4sJZ3rJXeFB7fOmACoTnFhM5FbWtx1wP6RXgY3VH+fDux3BIpC9Ew== X-Received: by 2002:ac2:5495:: with SMTP id t21mr24993782lfk.3.1556296958026; Fri, 26 Apr 2019 09:42:38 -0700 (PDT) Received: from localhost.localdomain ([2a02:a315:5445:5300:2492:ad61:69f1:23cc]) by smtp.googlemail.com with ESMTPSA id q11sm5637807lfc.51.2019.04.26.09.42.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 09:42:37 -0700 (PDT) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: kyungmin.park@samsung.com Subject: [PATCH 4/5] dt-binding: mtd: onenand/samsung: Add device tree support Date: Fri, 26 Apr 2019 18:42:23 +0200 Message-Id: <20190426164224.11327-5-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> References: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_094240_382112_F8B82FA6 X-CRM114-Status: GOOD ( 14.58 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:141 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pawel.mikolaj.chmiel[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, bbrezillon@kernel.org, richard@nod.at, linux-kernel@vger.kernel.org, Tomasz Figa , marek.vasut@gmail.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com, dwmw2@infradead.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tomasz Figa This patch adds dt-bindings for Samsung OneNAND driver. Signed-off-by: Tomasz Figa Signed-off-by: Paweł Chmiel --- .../bindings/mtd/samsung-onenand.txt | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/samsung-onenand.txt diff --git a/Documentation/devicetree/bindings/mtd/samsung-onenand.txt b/Documentation/devicetree/bindings/mtd/samsung-onenand.txt new file mode 100644 index 000000000000..341d97cc1513 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/samsung-onenand.txt @@ -0,0 +1,46 @@ +Device tree bindings for Samsung SoC OneNAND controller + +Required properties: + - compatible : value should be either of the following. + (a) "samsung,s3c6400-onenand" - for onenand controller compatible with + S3C6400 SoC, + (b) "samsung,s3c6410-onenand" - for onenand controller compatible with + S3C6410 SoC, + (c) "samsung,s5pc100-onenand" - for onenand controller compatible with + S5PC100 SoC, + (d) "samsung,s5pv210-onenand" - for onenand controller compatible with + S5PC110/S5PV210 SoCs. + + - reg : two memory mapped register regions: + - first entry: control registers. + - second and next entries: memory windows of particular OneNAND chips; + for variants a), b) and c) only one is allowed, in case of d) up to + two chips can be supported. + + - interrupt-parent : phandle of interrupt controller to which the OneNAND + controller is wired, + - interrupts : specifier of interrupt signal to which the OneNAND controller + is wired; should contain just one entry. + - clock-names : should contain two entries: + - "bus" - bus clock of the controller, + - "onenand" - clock supplied to OneNAND memory. + - clock: should contain list of phandles and specifiers for all clocks listed + in clock-names property. + - #address-cells : must be 1, + - #size-cells : must be 1. + +For partition table parsing (optional) please refer to: + [1] Documentation/devicetree/bindings/mtd/partition.txt + +Example for an s5pv210 board: + + onenand@b0600000 { + compatible = "samsung,s5pv210-onenand"; + reg = <0xb0600000 0x2000>, <0xb0000000 0x20000>; + interrupt-parent = <&vic1>; + interrupts = <31>; + clock-names = "bus", "onenand"; + clocks = <&clocks NANDXL>, <&clocks DOUT_FLASH>; + #address-cells = <1>; + #size-cells = <1>; + }; From patchwork Fri Apr 26 16:42:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 1091642 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fr3E01Oq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o+ofXdAw"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44rKck0cLcz9s5c for ; Sat, 27 Apr 2019 02:43:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PFEATE3KM3j865fvpSUlumqXCEj72HLE285uGKIfwl0=; b=fr3E01OqcCdDJ0 q8+8KCzr3ACxzvCgOdULgVgM1G05ZWgTRlU5p4j+bp9fE1m27qAgU05HXYLRI/WRQpFGIpnSqwVbn e6JznjJiw0Y+XElmT/L7w2sgnRJAj+ciyamsIARjN9Et3EZ3FVy+9U01WwS5PP00ilkWDrChAsAG3 bq56W/aiu+nlaA0K0Bkq6axKViCislqqWtP+WG1hUZ8wtU/qYKHFmNwttK1OpW5+AHAiQ4GcabiZA z6+twRrJkZ0qTgHPwtJQbnUqZSbLFftj/m2/NZbg/7LibKxEoeUW9SIrWOqRIXwK4XLoTq6R7DAe0 blKlZA5B+5P+IMZ1Zxdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3wf-0004a1-F8; Fri, 26 Apr 2019 16:43:29 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK3vt-0003U1-77 for linux-mtd@lists.infradead.org; Fri, 26 Apr 2019 16:42:44 +0000 Received: by mail-lj1-x242.google.com with SMTP id b12so2326462lji.4 for ; Fri, 26 Apr 2019 09:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GmiljxR0tDKc7rqpSkSKqbQb6AAiPA5Nk+pPD2f3A2k=; b=o+ofXdAw4bIKSWuAYjDkmrfetZ07r0OreqSlGTEMAMWBtEpVMIrW6Cie1qcLcZruuw KSY0p3WWaDhq+GF63/PLKUB0osQ8ArtEtdlOARK/7w1Ik1DD00Y1YbzAyHbn6nAw1Nzo iS4ftTuer8CLtOu8l+2J819dnOJ7TF4yvUOIpACmiBCasZ7opq1/SL5vOxBVXak//40L bR/w7Dvm+/wXRHOWa5t3B3yKXeZO8IQdfB85Xl4cO37nqg+9PXKnKrvIGOEDsrgRJmVt krUl2k26Q8Cq4qXyZegCCSH4UZji6rVCbCoKlCHnaPSqVEw6Y3gdRe5JVqHOa+e4wQEG 1oRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GmiljxR0tDKc7rqpSkSKqbQb6AAiPA5Nk+pPD2f3A2k=; b=eT3SmTnfmyr4viyKFEtDsXB/e+Or0fnzwTXK9dPnmjbETP9Ti8lPAga6OceHcjb1NJ FiN0y/t63ZKyPGqJsb6O/J1vCxwqHnextYzCCKY2i/WrC2nni7ADKYF2w1IrRWK9aUy4 e0eheZRD43gB2h20SUoqfrfxL2uKQbVksNfE6uft0jvCst8umJKK6ngC1/wqETeB+rvS TBeG33ngqpuoGEPj0xLQ+T4cMxJvYjSKE9jxQL1csnX90mrHiGJpAcevtaGavKSEEIVS b+TMgOFOXet9UnF4ZBHRXJWY7pK+BhhCwvL6rc+6nV/S61bsOarNGQ44/VRJxZW50Nlw bK8w== X-Gm-Message-State: APjAAAVw07DYJcYbzjH/rmHitU8meJH/u/k7xaeJe4kvV4JV++ORKhVa j8WXq7+s5g6FFdzh9irGff2CgDxp9cM= X-Google-Smtp-Source: APXvYqyXGvtR+Aq5jipLArRTQrWAcOARjHVWJn/3Jnmr11sInDW/lKSKycYh6xsZ2phrW6D1l94JCA== X-Received: by 2002:a2e:9151:: with SMTP id q17mr24865433ljg.87.1556296959733; Fri, 26 Apr 2019 09:42:39 -0700 (PDT) Received: from localhost.localdomain ([2a02:a315:5445:5300:2492:ad61:69f1:23cc]) by smtp.googlemail.com with ESMTPSA id q11sm5637807lfc.51.2019.04.26.09.42.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 09:42:39 -0700 (PDT) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: kyungmin.park@samsung.com Subject: [PATCH 5/5] mtd: onenand/samsung: Set name field of mtd_info struct Date: Fri, 26 Apr 2019 18:42:24 +0200 Message-Id: <20190426164224.11327-6-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> References: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_094241_862222_8A6AE4ED X-CRM114-Status: GOOD ( 11.04 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:242 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pawel.mikolaj.chmiel[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, bbrezillon@kernel.org, richard@nod.at, linux-kernel@vger.kernel.org, Tomasz Figa , marek.vasut@gmail.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com, dwmw2@infradead.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tomasz Figa This patch adds initialization of .name field of mtd_info struct to avoid printing "(null)" in kernel log messages, such as: [ 1.942519] 1 ofpart partitions found on MTD device (null) [ 1.949708] Creating 1 MTD partitions on "(null)": Signed-off-by: Tomasz Figa Signed-off-by: Paweł Chmiel Reviewed-by: Miquel Raynal --- drivers/mtd/nand/onenand/samsung.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/onenand/samsung.c b/drivers/mtd/nand/onenand/samsung.c index 0f450604412f..1fda1f324cc6 100644 --- a/drivers/mtd/nand/onenand/samsung.c +++ b/drivers/mtd/nand/onenand/samsung.c @@ -886,6 +886,7 @@ static int s3c_onenand_probe(struct platform_device *pdev) return -ENOMEM; this = (struct onenand_chip *) &mtd[1]; + mtd->name = dev_name(&pdev->dev); mtd->priv = this; mtd->dev.of_node = np; mtd->dev.parent = &pdev->dev;