From patchwork Wed Apr 24 19:49:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 1090433 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NVAK7QT4"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44q9rQ2vd7z9s55 for ; Thu, 25 Apr 2019 05:49:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730619AbfDXTtk (ORCPT ); Wed, 24 Apr 2019 15:49:40 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:47039 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbfDXTtk (ORCPT ); Wed, 24 Apr 2019 15:49:40 -0400 Received: by mail-wr1-f68.google.com with SMTP id t17so26754639wrw.13 for ; Wed, 24 Apr 2019 12:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=6a7ktGJAxpNroV3BfbqK1VolyrZJDvdCv+ILkjw5rxc=; b=NVAK7QT4oNb54zj6PRO2knlrxkrXQxvhTMFmQWVvpwm78Fa4LEaXPIlFSNmOMcnkzd LtNhPfNNCPIYm4p9NwETCcCDb6dSPiaWK/9kSSBRD3C7rNiDW2SidwELYeM5mBZ+ds87 ZEXskstS0p0p7zS+dTJ1GeuitXChyNfs/f8+q6jhsHWKNZEDII3H4fZP6NvIddBphDNW JHILtKBWGWmVYdXUv3DUtkuVgYvD7rC0UCd54BTsfMblT3fy9pNVhk7tEYtektaY5bwQ 5k+akDn/aXsuvM+SHSZTKznuARUYJY6uG9MLHcvRO86b1aXFHgsZVRUAPNzzFv8fOv/g hZ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=6a7ktGJAxpNroV3BfbqK1VolyrZJDvdCv+ILkjw5rxc=; b=lgMiq6tPakqr8y5bneuOUzFBuZ0DGHvk3JNdD3gBqLRS1Qn3afWqyB+61ea3OmAzqi 7IbEg+1tNUB/XnfPjpF+7Kp9Lpd+YrL70jb5CG7KQh8f5UKHfghDPEcbdE04EXj0T6Er lNPbXe+XMNnA6OdyIOY+AqLGx+GXhof1nEr8TK361prNrLkf76R20q/vyuBAJeV3Un6S YHPxjwEilgFBwF/dKf2CvWm1DkjakSEdEQ7c+NkH4/kyOExu+Y8rKqtqVDxwWgfwxG81 wTV4SAQT44m9WR2al9K4741cZYmecz92T3mAQQ9mW3zFv1UCmW377AWDYRIagAB5QNHS UbDA== X-Gm-Message-State: APjAAAUax14qDKXRp8tIwbB6qQHxaQGkyLCeA0Qn83agZdeBtaQMKk0d A33WVYtXtIMgdwWV3IR5blVAwXwB/rw= X-Google-Smtp-Source: APXvYqzE/08IrilYtn6cVkGP10dVGnXGIz7vlTTKyK7V5d5bDHq8C16k4nJ1gR6ENUJHBuyBVnAg2w== X-Received: by 2002:adf:9e86:: with SMTP id a6mr12951330wrf.178.1556135378397; Wed, 24 Apr 2019 12:49:38 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:5700:c498:ee8f:ff0a:13e5? (p200300EA8BD45700C498EE8FFF0A13E5.dip0.t-ipconnect.de. [2003:ea:8bd4:5700:c498:ee8f:ff0a:13e5]) by smtp.googlemail.com with ESMTPSA id d187sm4076101wmd.42.2019.04.24.12.49.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 12:49:37 -0700 (PDT) To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net-next] net: phy: avoid unneeded MDIO reads in genphy_read_status Message-ID: <92a0d681-33ea-feb7-bdf5-ff6fd9911ce1@gmail.com> Date: Wed, 24 Apr 2019 21:49:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Considering that in polling mode each link drop will be latched, settings can't have changed if link was up and is up. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy_device.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index f794ff3a1..2a2aaa5f3 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1739,13 +1739,17 @@ EXPORT_SYMBOL(genphy_update_link); */ int genphy_read_status(struct phy_device *phydev) { - int adv, lpa, lpagb, err; + int adv, lpa, lpagb, err, old_link = phydev->link; /* Update the link, but return if there was an error */ err = genphy_update_link(phydev); if (err) return err; + /* why bother the PHY if nothing can have changed */ + if (phydev->autoneg == AUTONEG_ENABLE && old_link && phydev->link) + return 0; + phydev->speed = SPEED_UNKNOWN; phydev->duplex = DUPLEX_UNKNOWN; phydev->pause = 0;