From patchwork Tue Apr 9 15:22:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 1082376 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 44drdL0gZ7z9sND for ; Wed, 10 Apr 2019 01:22:45 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 68234C21E08; Tue, 9 Apr 2019 15:22:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 92279C21D74; Tue, 9 Apr 2019 15:22:40 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3EA8FC21DEC; Tue, 9 Apr 2019 15:22:27 +0000 (UTC) Received: from mout.perfora.net (mout.perfora.net [74.208.4.197]) by lists.denx.de (Postfix) with ESMTPS id 9EA9EC21E1D for ; Tue, 9 Apr 2019 15:22:26 +0000 (UTC) Received: from marcel-nb-toradex-int.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus003 [74.208.5.2]) with ESMTPSA (Nemesis) id 0MKsGU-1hDsZm0dtI-0006ti; Tue, 09 Apr 2019 17:22:18 +0200 From: Marcel Ziswiler To: u-boot@lists.denx.de Date: Tue, 9 Apr 2019 17:22:13 +0200 Message-Id: <20190409152213.10969-1-marcel@ziswiler.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:BmEjQVfVF3fA9OnJMCtT4fLaeBCJy5SCQT08BKM7r0mWBofTjsd sQNMlHTZdsR3fPoX4KDBtFBEnc85/lBBrAS//N4sDTUvmIxzL+1QA5B0NNeb0EGF4zuM2vd 10Q4WHdlXGGelQCA6UuleJnXY72QAJ4km72MfCXJNYQLqXcWN95ILY5qS7y/kJ4ct7XAhoz RSYwVwok1KVu2l6Fo1KVQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:xGcrBcmOfQk=:F+x+BQE8vSyERrUuGkL0+o MlY8zzaXM5+x6CV2CVh0xSsTN0FfG1AEGbW9vl6ILY16NhRJ04KoDymmpsYVT1Pd34r2xmkLL Mmehcox/W7jzMYPPyN2s62iOz7srUVV+8NRRvHwErlSkSq1ZlPqiLXZKGRWgwcFX1uIYZBNzs kW3/TeREHFXfC434U5MTM4rvhUuXmsgYJSTkTJN6pEVp5s2SzIHq6yx3ARoWmvWFja9n81eyB 2RD6GVs9fsTlsV1oiqDa2PvuxTrZOmL9OlAwA8udZCn8bqX3IYiyWaUV5KmhO/UXKMZ2DUEb1 5LC5gehloIBJZKsUdBl9bK+WYb8pMGlzD3nt5fGLPlxGUlbTTVXrSWQxCFiv89IxtqRdu/xxr Xa6mF9SFdAd/EdR8D7dlhKcyavzJ+sY+o7utNQ8rR+zttD6KwMJ7PFtqZy1Wf/QNzepC4iJff n7WUvh36EsLZCoAafRDfFc0anVH3ss5wv7Ba6A384AIAkUKBYafwXinXgLzOZWPsFYiV6Gnl4 NBLaHmzQ1ZBv/KVOtpd+qieeisolh3ipwh/Mll2/f1QtPzmRAcTvtOv7wRuxNPmazf3+tW2dL 1qvC5HDH+d03Suf18YpJNREdIycVyuZR/FYYVp6hJJ8kkIFgMCPvDCJn1rT4E+ekVd9jAEvXq VY1rybgsxNV0fQY/GcJwU/rxi5aWG9wQFw5qBb//061kUg3NQDNytJ0zalrP4ybRmla9V8XjH DaF5jgeqxdckt02X9KQ8AH1at4C6CK2hpP5HKw== Cc: Marcel Ziswiler , Igor Opaniuk , Stefan Agner Subject: [U-Boot] [PATCH v2] colibri_vf: fix ethernet by adding explicit phy node X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Marcel Ziswiler The implicit fallback mechanism for searching the whole MDIO bus for at least one PHY has been gone with the following commit b882005a18de ("drivers/net/fec: phy_init: remove redundant logic"). This lead to the Ethernet driver erroring out as follows: Net: Could not get PHY for FEC0: addr -19 eth-1: fec@400d1000 Colibri VFxx # dhcp Could not get PHY for FEC0: addr -19 Could not get PHY for FEC0: addr -19 Could not get PHY for FEC0: addr -19 Could not get PHY for FEC0: addr -19 No ethernet found. Could not get PHY for FEC0: addr -19 Colibri VFxx # This commit adds an explicit PHY node which makes it work again. Signed-off-by: Marcel Ziswiler Reviewed-by: Hannes Schmelzer Reviewed-by: Igor Opaniuk --- Changes in v2: - Added Hannes and Igor's reviewed-by. arch/arm/dts/vf-colibri.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm/dts/vf-colibri.dtsi b/arch/arm/dts/vf-colibri.dtsi index 5ce17076e9..91ca4e4ddd 100644 --- a/arch/arm/dts/vf-colibri.dtsi +++ b/arch/arm/dts/vf-colibri.dtsi @@ -60,11 +60,24 @@ status = "okay"; }; +/* Ethernet */ &fec1 { phy-mode = "rmii"; + phy-handle = <ðphy1>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_fec1>; status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy1: ethernet-phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + max-speed = <100>; + reg = <1>; + }; + }; }; &i2c0 {