From patchwork Mon Apr 8 15:21:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyril Hrubis X-Patchwork-Id: 1081158 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44dDfv2CD6z9sRY for ; Tue, 9 Apr 2019 01:21:56 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 78D28294A85 for ; Mon, 8 Apr 2019 17:21:51 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) by picard.linux.it (Postfix) with ESMTP id 860D03EA5C6 for ; Mon, 8 Apr 2019 17:21:49 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 28E01600A60 for ; Mon, 8 Apr 2019 17:21:49 +0200 (CEST) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B1266B027 for ; Mon, 8 Apr 2019 15:21:46 +0000 (UTC) From: Cyril Hrubis To: ltp@lists.linux.it Date: Mon, 8 Apr 2019 17:21:45 +0200 Message-Id: <20190408152145.29005-1-chrubis@suse.cz> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.99.2 at in-5.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.0 required=7.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-5.smtp.seeweb.it Subject: [LTP] [PATCH] Makefile: Remove IDcheck.sh X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" There is no point in running the IDcheck on 'make install' as it's completely pointless to print ignored errors on installation which is only confusing users. Also the same script is even executed as a part of runltp script which is more appropriate place for it. Signed-off-by: Cyril Hrubis Reviewed-by: Enji Cooper --- Makefile | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/Makefile b/Makefile index 170c2da20..c46d050ce 100644 --- a/Makefile +++ b/Makefile @@ -21,11 +21,6 @@ # Ngie Cooper, July 2009 # -# Force IDcheck.sh to fix any issues found with $(DESTDIR)/etc/group and -# $(DESTDIR)/etc/passwd automatically when after running the top-level -# install target. -CREATE_ENTRIES ?= 0 - top_srcdir ?= $(CURDIR) include $(top_srcdir)/include/mk/env_pre.mk @@ -42,9 +37,6 @@ vpath %.in $(top_srcdir)/include vpath %.m4 $(top_srcdir)/m4 vpath %.mk $(top_srcdir)/mk:$(top_srcdir)/mk/include -# Skip running IDcheck.sh at the end of install? -SKIP_IDCHECK ?= 0 - # User wants uclinux binaries? UCLINUX ?= 0 export UCLINUX @@ -202,17 +194,6 @@ $(INSTALL_TARGETS): $(INSTALL_DIR) $(DESTDIR)/$(bindir) ## Install install: $(INSTALL_TARGETS) -ifeq ($(SKIP_IDCHECK),0) - -@CREATE_ENTRIES=$(CREATE_ENTRIES) \ - DESTDIR="$(DESTDIR)" \ - "$(top_srcdir)/IDcheck.sh" -else - @echo "*******************************************************" - @echo "** Will not run IDcheck.sh (SKIP_IDCHECK set to 1). **" - @echo "*******************************************************" -endif - -## Misc targets. ## Help .PHONY: help