From patchwork Fri Apr 5 20:14:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1078719 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UKHm4+bO"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44bWKd0JLXz9s9y for ; Sat, 6 Apr 2019 07:16:04 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3888A87E1B; Fri, 5 Apr 2019 20:16:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ham6ru0lFEDD; Fri, 5 Apr 2019 20:15:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 4A1A987D5D; Fri, 5 Apr 2019 20:15:58 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 6FA881BF370 for ; Fri, 5 Apr 2019 20:15:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6A47222686 for ; Fri, 5 Apr 2019 20:15:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OkIjwb0T7il0 for ; Fri, 5 Apr 2019 20:15:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by silver.osuosl.org (Postfix) with ESMTPS id D6D1221F5A for ; Fri, 5 Apr 2019 20:15:53 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id a184so7956589wma.2 for ; Fri, 05 Apr 2019 13:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vDYrdUb5j/zEs9lAGsjcAWmj2lWXPGXEkqC8+KrZOp8=; b=UKHm4+bOR5NlLHhEomm1dbl97qFozYCDW3fehqxSohuwP/tj1E4h6yUG2YOzjKyeJk lWxd9MwvQGXVexDH5aoMW8sBpvzj1/zkcFjDpK/muf+E88PI0Zpp6Ux7ujslT+SSJd/V jMOm0xD0M2XveZ92Oz3Kv3il2JzSL2w8RkHaBYtHzjP4IpcUTf020/DI5wiVyiQ9C6r7 sndaPO4wglSslJJHFBTdpIfQay8eE/DMWZCyABgt9d3Mn7Qgy3tRdydx1UuIpGkMMTYs jPtVWpfRQQD6zJPl+n5t9/B7KFp9cy+lBpaTsjk0qASVC+bYI64rHMNGE+dG2oO/o0kj 0EeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vDYrdUb5j/zEs9lAGsjcAWmj2lWXPGXEkqC8+KrZOp8=; b=D+zkOv6VevGtuNGc9bWaC1+5/eqgDAZAT3SejahmJPgFuFetp2xMl0EJBSuYLLuNNb C/h4ztovkS5R+tAFnBziawpVsAJ5hnqNxKKAWo5WWJYjmL6zEnosdSd+YaBc6WKoKB6N OYxyAdOCDa72uzEJR6D9POHMiy1EP6U0kX8M6oqrrJAebsz0HHrj1OKnsxrthYL/wO1m mJf/5Sd5km406BR3YyLLOYEvW2Zmkm/Wr6Z4cs6l+yNhu+MnrBFperNQ+CZKEfonj+ac pQJC2prJeCYNqH80r2v6ltIgvOTh2aNetfBCVEIQ7zA/h/QEwOtpaJ4CdYT2eW4zE7pZ DOPA== X-Gm-Message-State: APjAAAWe8GEAqNOSjfgDCuZiFg0BH12aEMgvCwRcG2+g4zjVKq/AUCmi PQYyvHumdj9K5fKw864IBvs1kiHy X-Google-Smtp-Source: APXvYqyFG/Q8VFbSCICqlpLQ9s9xN8gPzG27HkWsUqxo+xtRF3AwI6pHm8UUUjbOl3R74iaTU7FldQ== X-Received: by 2002:a05:600c:28b:: with SMTP id 11mr8996819wmk.129.1554495351730; Fri, 05 Apr 2019 13:15:51 -0700 (PDT) Received: from kali.home (lfbn-ren-1-314-196.w2-10.abo.wanadoo.fr. [2.10.15.196]) by smtp.gmail.com with ESMTPSA id h9sm2114297wmb.5.2019.04.05.13.15.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 13:15:50 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Fri, 5 Apr 2019 22:14:45 +0200 Message-Id: <20190405201445.24773-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 7/7] package/sysklogd: bump to version 1.6 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , Fabrice Fontaine , Ryan Coe Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" - Switch site to github - Drop all patches (already in version or not needed anymore) - Switch to autotools infrastructure - Add hash for license file Signed-off-by: Fabrice Fontaine --- ...place-deprecated-union-wait-with-int.patch | 28 ------- .../0002-Fix-improper-header-includes.patch | 78 ------------------- .../0003-Remove-include-of-linux-time.h.patch | 50 ------------ ...d-written-klogctl-syscall-implementa.patch | 38 --------- ...5-Add-missing-headers-for-open-flags.patch | 46 ----------- ...yslogd.c-rename-dprintf-to-mydprintf.patch | 39 ---------- package/sysklogd/Config.in | 2 +- package/sysklogd/sysklogd.hash | 5 +- package/sysklogd/sysklogd.mk | 20 ++--- 9 files changed, 12 insertions(+), 294 deletions(-) delete mode 100644 package/sysklogd/0001-Replace-deprecated-union-wait-with-int.patch delete mode 100644 package/sysklogd/0002-Fix-improper-header-includes.patch delete mode 100644 package/sysklogd/0003-Remove-include-of-linux-time.h.patch delete mode 100644 package/sysklogd/0004-Remove-bogus-hand-written-klogctl-syscall-implementa.patch delete mode 100644 package/sysklogd/0005-Add-missing-headers-for-open-flags.patch delete mode 100644 package/sysklogd/0006-syslogd.c-rename-dprintf-to-mydprintf.patch diff --git a/package/sysklogd/0001-Replace-deprecated-union-wait-with-int.patch b/package/sysklogd/0001-Replace-deprecated-union-wait-with-int.patch deleted file mode 100644 index d3fc0dc188..0000000000 --- a/package/sysklogd/0001-Replace-deprecated-union-wait-with-int.patch +++ /dev/null @@ -1,28 +0,0 @@ -From 76685540a7882926c54bc0d1a8945b7a6abffe40 Mon Sep 17 00:00:00 2001 -From: Ryan Coe -Date: Fri, 7 Oct 2016 19:42:40 -0700 -Subject: [PATCH] Replace deprecated union wait with int - -This is needed for compatibility with glibc >= 2.24. - -Signed-off-by: Ryan Coe ---- - syslogd.c | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/syslogd.c b/syslogd.c -index ea73ea5..ace96c8 100644 ---- a/syslogd.c -+++ b/syslogd.c -@@ -2094,7 +2094,7 @@ void reapchild() - (void) signal(SIGCHLD, reapchild); /* reset signal handler -ASP */ - wait ((int *)0); - #else -- union wait status; -+ int status; - - while (wait3(&status, WNOHANG, (struct rusage *) NULL) > 0) - ; --- -2.7.4 - diff --git a/package/sysklogd/0002-Fix-improper-header-includes.patch b/package/sysklogd/0002-Fix-improper-header-includes.patch deleted file mode 100644 index 3518ef0270..0000000000 --- a/package/sysklogd/0002-Fix-improper-header-includes.patch +++ /dev/null @@ -1,78 +0,0 @@ -From 7a043f619a91fbb998863c08e3e5e94a4747b11d Mon Sep 17 00:00:00 2001 -From: Thomas Petazzoni -Date: Mon, 28 Nov 2016 23:07:36 +0100 -Subject: [PATCH] Fix improper header includes - -When building with the musl C library, a number of warnings indicate -that sysklogd is directly including headers that are considered internal -to the C library: - - - Instead of including , should be included. - - - Instead of including , should be included. - - - Instead of includeing , should be included. - -Signed-off-by: Thomas Petazzoni ---- - klogd.c | 2 +- - ksym_mod.c | 2 +- - syslog.c | 2 +- - syslogd.c | 2 +- - 4 files changed, 4 insertions(+), 4 deletions(-) - -diff --git a/klogd.c b/klogd.c -index 6cc80ed..a173353 100644 ---- a/klogd.c -+++ b/klogd.c -@@ -260,7 +260,7 @@ - #include - #include - #include --#include -+#include - #include - #if !defined(__GLIBC__) - #include -diff --git a/ksym_mod.c b/ksym_mod.c -index 68cd6b6..2e69d65 100644 ---- a/ksym_mod.c -+++ b/ksym_mod.c -@@ -113,7 +113,7 @@ - #include - #include - #include --#include -+#include - #include - #include "module.h" - #if !defined(__GLIBC__) -diff --git a/syslog.c b/syslog.c -index bdb3ff2..f96b43c 100644 ---- a/syslog.c -+++ b/syslog.c -@@ -55,7 +55,7 @@ static char sccsid[] = "@(#)syslog.c 5.28 (Berkeley) 6/27/90"; - #include - #include - #include --#include -+#include - #include - #if 0 - #include "syslog.h" -diff --git a/syslogd.c b/syslogd.c -index ace96c8..b5e8054 100644 ---- a/syslogd.c -+++ b/syslogd.c -@@ -521,7 +521,7 @@ static char sccsid[] = "@(#)syslogd.c 5.27 (Berkeley) 10/10/88"; - #define SYSLOG_NAMES - #include - #include --#include -+#include - #include - #include - #include --- -2.7.4 - diff --git a/package/sysklogd/0003-Remove-include-of-linux-time.h.patch b/package/sysklogd/0003-Remove-include-of-linux-time.h.patch deleted file mode 100644 index 374d89bd05..0000000000 --- a/package/sysklogd/0003-Remove-include-of-linux-time.h.patch +++ /dev/null @@ -1,50 +0,0 @@ -From f4926a61ba2d3766255dd996bf0315bc8fa0c528 Mon Sep 17 00:00:00 2001 -From: Thomas Petazzoni -Date: Mon, 28 Nov 2016 23:09:03 +0100 -Subject: [PATCH] Remove include of - -klogd.c and ksym_mod.c currently include if GLIBC is not -defined. Unfortunately, this breaks badly with the musl C library: this -C library is not glibc so it doesn't define GLIBC, but it does have a -definition of "struct timespec" in its header file, which conflict with -the one provided by the Linux kernel headers. - -So, this commit simply gets rid of this header inclusion. - -Signed-off-by: Thomas Petazzoni ---- - klogd.c | 3 --- - ksym_mod.c | 3 --- - 2 files changed, 6 deletions(-) - -diff --git a/klogd.c b/klogd.c -index a173353..6505d96 100644 ---- a/klogd.c -+++ b/klogd.c -@@ -262,9 +262,6 @@ - #include - #include - #include --#if !defined(__GLIBC__) --#include --#endif /* __GLIBC__ */ - #include - #include - #include -diff --git a/ksym_mod.c b/ksym_mod.c -index 2e69d65..6e26da1 100644 ---- a/ksym_mod.c -+++ b/ksym_mod.c -@@ -116,9 +116,6 @@ - #include - #include - #include "module.h" --#if !defined(__GLIBC__) --#include --#endif /* __GLIBC__ */ - #include - #include - #include --- -2.7.4 - diff --git a/package/sysklogd/0004-Remove-bogus-hand-written-klogctl-syscall-implementa.patch b/package/sysklogd/0004-Remove-bogus-hand-written-klogctl-syscall-implementa.patch deleted file mode 100644 index 548f160718..0000000000 --- a/package/sysklogd/0004-Remove-bogus-hand-written-klogctl-syscall-implementa.patch +++ /dev/null @@ -1,38 +0,0 @@ -From fe92a7a8197241f7d6b28ea3c8214bb6d2c7fda4 Mon Sep 17 00:00:00 2001 -From: Thomas Petazzoni -Date: Mon, 28 Nov 2016 23:10:55 +0100 -Subject: [PATCH] Remove bogus hand-written klogctl() syscall implementation - -The way the hand-written klogctl() syscall is written cannot compile, as -_syscall3() is just a function provided by the C library, so calling it -outside of a function doesn't build. - -Since the musl C library provides a klogctl() function, we don't need -this hand-written system call anyway. - -Signed-off-by: Thomas Petazzoni ---- - klogd.c | 5 ----- - 1 file changed, 5 deletions(-) - -diff --git a/klogd.c b/klogd.c -index 6505d96..9219671 100644 ---- a/klogd.c -+++ b/klogd.c -@@ -274,13 +274,8 @@ - - #define __LIBRARY__ - #include --#if !defined(__GLIBC__) --# define __NR_ksyslog __NR_syslog --_syscall3(int,ksyslog,int, type, char *, buf, int, len); --#else - #include - #define ksyslog klogctl --#endif - - #define LOG_BUFFER_SIZE 4096 - #define LOG_LINE_LENGTH 1000 --- -2.7.4 - diff --git a/package/sysklogd/0005-Add-missing-headers-for-open-flags.patch b/package/sysklogd/0005-Add-missing-headers-for-open-flags.patch deleted file mode 100644 index 1a7ad84868..0000000000 --- a/package/sysklogd/0005-Add-missing-headers-for-open-flags.patch +++ /dev/null @@ -1,46 +0,0 @@ -From 0dff338a704f4ad11a2b78871e1f2a0b8030b4d2 Mon Sep 17 00:00:00 2001 -From: Thomas Petazzoni -Date: Mon, 28 Nov 2016 23:12:37 +0100 -Subject: [PATCH] Add missing headers for open() flags - -Both pidfile.c and syslog.c use open() and its flags, but forgets to -include all relevant headers, causing build failures with the musl C -library. - -Signed-off-by: Thomas Petazzoni ---- - pidfile.c | 2 ++ - syslog.c | 2 ++ - 2 files changed, 4 insertions(+) - -diff --git a/pidfile.c b/pidfile.c -index e0959a0..14de56f 100644 ---- a/pidfile.c -+++ b/pidfile.c -@@ -26,8 +26,10 @@ - - #include - #include -+#include - #include - #include -+#include - #include - #include - #include -diff --git a/syslog.c b/syslog.c -index f96b43c..d09e7aa 100644 ---- a/syslog.c -+++ b/syslog.c -@@ -57,6 +57,8 @@ static char sccsid[] = "@(#)syslog.c 5.28 (Berkeley) 6/27/90"; - #include - #include - #include -+#include -+#include - #if 0 - #include "syslog.h" - #include "pathnames.h" --- -2.7.4 - diff --git a/package/sysklogd/0006-syslogd.c-rename-dprintf-to-mydprintf.patch b/package/sysklogd/0006-syslogd.c-rename-dprintf-to-mydprintf.patch deleted file mode 100644 index a1fb5331e4..0000000000 --- a/package/sysklogd/0006-syslogd.c-rename-dprintf-to-mydprintf.patch +++ /dev/null @@ -1,39 +0,0 @@ -From 68213f6902d291d2ba1626fd950fd7d4a1329d33 Mon Sep 17 00:00:00 2001 -From: Thomas Petazzoni -Date: Mon, 28 Nov 2016 23:13:08 +0100 -Subject: [PATCH] syslogd.c: rename dprintf() to mydprintf() - -There is an existing kludge in syslogd.c to rename all dprintf() -function calls and its definition to mydprintf(). This kludge is only -applied when the glibc C library is used (i.e when GLIBC is defined), -because glibc also provides a dprintf() function, with a different -signature and behavior. - -However, the musl C library also provides the dprintf() function (with -the same signature as the one in glibc, obviously), but does not define -the GLIBC macro, causing a conflicting definition of dprintf. - -This commit fixes that by having the rename kludge used unconditionally. - -Signed-off-by: Thomas Petazzoni ---- - syslogd.c | 2 -- - 1 file changed, 2 deletions(-) - -diff --git a/syslogd.c b/syslogd.c -index b5e8054..22a9ed5 100644 ---- a/syslogd.c -+++ b/syslogd.c -@@ -818,9 +818,7 @@ void doexit(int sig); - void init(); - void cfline(char *line, register struct filed *f); - int decode(char *name, struct code *codetab); --#if defined(__GLIBC__) - #define dprintf mydprintf --#endif /* __GLIBC__ */ - static void dprintf(char *, ...); - static void allocate_log(void); - void sighup_handler(); --- -2.7.4 - diff --git a/package/sysklogd/Config.in b/package/sysklogd/Config.in index 4188fb8274..fda58e020e 100644 --- a/package/sysklogd/Config.in +++ b/package/sysklogd/Config.in @@ -5,4 +5,4 @@ config BR2_PACKAGE_SYSKLOGD help System log daemons syslogd and klogd. - http://www.infodrom.org/projects/sysklogd/ + https://github.com/troglobit/sysklogd/ diff --git a/package/sysklogd/sysklogd.hash b/package/sysklogd/sysklogd.hash index dd5b89a884..6f7ab6ece8 100644 --- a/package/sysklogd/sysklogd.hash +++ b/package/sysklogd/sysklogd.hash @@ -1,2 +1,3 @@ -# Locally calculated from download (no sig, hash) -sha256 5166c185ae23c92e8b9feee66a6e3d0bc944bf673112f53e3ecf62e08ce7c201 sysklogd-1.5.1.tar.gz +# Locally calculated +sha256 1e9e18564c5bba474954d55ea6e2a0e3dc1bc145d8973c5fd098b088a9be9ceb sysklogd-1.6.tar.gz +sha256 91df39d1816bfb17a4dda2d3d2c83b1f6f2d38d53e53e41e8f97ad5ac46a0cad COPYING diff --git a/package/sysklogd/sysklogd.mk b/package/sysklogd/sysklogd.mk index 976438c110..8cd7f9573c 100644 --- a/package/sysklogd/sysklogd.mk +++ b/package/sysklogd/sysklogd.mk @@ -4,24 +4,20 @@ # ################################################################################ -SYSKLOGD_VERSION = 1.5.1 -SYSKLOGD_SITE = http://www.infodrom.org/projects/sysklogd/download +SYSKLOGD_VERSION = 1.6 +SYSKLOGD_SITE = $(call github,troglobit,sysklogd,v$(SYSKLOGD_VERSION)) SYSKLOGD_LICENSE = GPL-2.0+ SYSKLOGD_LICENSE_FILES = COPYING +# From git +SYSKLOGD_AUTORECONF = YES -# Override SKFLAGS which is used as CFLAGS. -define SYSKLOGD_BUILD_CMDS - $(MAKE) $(TARGET_CONFIGURE_OPTS) SKFLAGS="$(TARGET_CFLAGS) -DSYSV" \ - -C $(@D) -endef - -define SYSKLOGD_INSTALL_TARGET_CMDS - $(INSTALL) -D -m 0500 $(@D)/syslogd $(TARGET_DIR)/sbin/syslogd - $(INSTALL) -D -m 0500 $(@D)/klogd $(TARGET_DIR)/sbin/klogd +define SYSKLOGD_INSTALL_SAMPLE_CONFIG $(INSTALL) -D -m 0644 package/sysklogd/syslog.conf \ $(TARGET_DIR)/etc/syslog.conf endef +SYSKLOGD_POST_INSTALL_TARGET_HOOKS += SYSKLOGD_INSTALL_SAMPLE_CONFIG + define SYSKLOGD_INSTALL_INIT_SYSV $(INSTALL) -m 755 -D package/sysklogd/S01syslogd \ $(TARGET_DIR)/etc/init.d/S01syslogd @@ -41,4 +37,4 @@ define SYSKLOGD_INSTALL_INIT_SYSTEMD $(TARGET_DIR)/etc/systemd/system/syslog.service endef -$(eval $(generic-package)) +$(eval $(autotools-package))