diff mbox

[Buildroot] uClibc build verbosity control

Message ID CAC1BbcSrg=NYqv4p_mgw8Njv3nfVOxZTa=EO=1iN+Z5cA1ix4A@mail.gmail.com
State Superseded
Headers show

Commit Message

Bernhard Reutner-Fischer April 29, 2015, 8:37 a.m. UTC 
On 28 April 2015 at 08:38, Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> On Tuesday 28 April 2015 01:46 AM, Bernhard Reutner-Fischer wrote:
>
> On April 27, 2015 11:21:10 AM GMT+02:00, Waldemar Brodkorb <wbx@openadk.org><mailto:wbx@openadk.org> wrote:
>
>
>>Hi Vineet,
>>Vineet Gupta wrote,
>>
>
>
>>> Hi,
>>>
>>> uClibc verbosity control V=xx is different from other mainstream
>
>
>>projects: namely Busybox and Linux kernel.

These are kbuild-based, fwiw.
>
>
>>> To print full cmdlines (when debugging obscure toolchain issues) we
>
>
>>need to pass V=2 whereas kernel/busybox take V=1.
>
>
>>>
>>> Can this be changed (I can provide a patch) assuming this doesn't
>
>
>>break existing scripts upsetting some people.
>
>
>>>
>>> My issue is specifically when using likes of Buildroot, there's no
>
>
>>obvious way to get the cmdlines of uClibc and/or other projects (unless
>>there's some obvious way I'm missing).
>
>
> Just add V=2 to make flags used for uclibc?
>
> Still requires manually hacking some Makefile etc, since V=xx is tyoically given at cmdline once for entire build.



but anyway.
>
>
>
>>
>>Good idea. Send a patch. I am pro.
>
>
> I found the terse output with just defines rather neat.
> If there is consensus that the current V=1 has no benefit then we can drop it in favour of just silent 0 and fully verbose 1.
>
>
> No, the idea is to keep both V=1 and V=2, but make them like other projects.
> e.g. in kernel build, V=2 prints the single liners, while V=1 prints the verbose cmdline,
> While in uClibc it's the other way around. Same with Busybox AFAIKR.
>
> Simple patch below addresses that, please consider applying.

Patch did not include help-text adjustment nor locale generation verbosity.
Fixed thus, please try current master.

thanks,
diff mbox

Patch

diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
index ce9b2b4..402966c 100644
--- a/package/uclibc/uclibc.mk
+++ b/package/uclibc/uclibc.mk
@@ -359,6 +359,13 @@  UCLIBC_MAKE_FLAGS = \
  UCLIBC_EXTRA_CFLAGS="$(UCLIBC_EXTRA_CFLAGS) $(TARGET_ABI)" \
  HOSTCC="$(HOSTCC)"

+ifeq ($(KBUILD_VERBOSE),0)
+ UCLIBC_MAKE_FLAGS += "V=0" # default anyway
+endif
+ifeq ($(KBUILD_VERBOSE),1)
+ UCLIBC_MAKE_FLAGS += "V=2"
+endif
+
 define UCLIBC_KCONFIG_FIXUP_CMDS
  $(call KCONFIG_SET_OPT,CROSS_COMPILER_PREFIX,"$(TARGET_CROSS)",$(@D)/.config)
  $(call KCONFIG_ENABLE_OPT,TARGET_$(UCLIBC_TARGET_ARCH),$(@D)/.config)