From patchwork Tue Jun 21 05:17:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shravan Kumar Ramani X-Patchwork-Id: 1645829 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LRvsY0B0Kz9sGp for ; Tue, 21 Jun 2022 15:17:35 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1o3WGU-0002Yo-Jj; Tue, 21 Jun 2022 05:17:26 +0000 Received: from mail-il-dmz.mellanox.com ([193.47.165.129] helo=mellanox.co.il) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1o3WGQ-0002Y0-3a for kernel-team@lists.ubuntu.com; Tue, 21 Jun 2022 05:17:22 +0000 Received: from Internal Mail-Server by MTLPINE1 (envelope-from shravankr@mellanox.com) with SMTP; 21 Jun 2022 08:17:18 +0300 Received: from bu-vnc02.mtbu.labs.mlnx (bu-vnc02.mtbu.labs.mlnx [10.15.2.65]) by mtbu-labmailer.labs.mlnx (8.14.4/8.14.4) with ESMTP id 25L5HGGj003371; Tue, 21 Jun 2022 01:17:16 -0400 Received: (from shravankr@localhost) by bu-vnc02.mtbu.labs.mlnx (8.14.7/8.13.8/Submit) id 25L5HG94030095; Tue, 21 Jun 2022 01:17:16 -0400 From: Shravan Kumar Ramani To: kernel-team@lists.ubuntu.com Subject: [PATCH v2 1/2] UBUNTU: SAUCE: mlx-trio: Use pr_debug for TRIO IRQ prints Date: Tue, 21 Jun 2022 01:17:10 -0400 Message-Id: X-Mailer: git-send-email 2.30.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shravan Kumar Ramani Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1979045 TRIO IRQs are triggered during mlxfwreset and the prints from the handler are misleading in such instances. So replace the dev_err calls with pr_debug. Signed-off-by: Shravan Kumar Ramani --- drivers/platform/mellanox/mlx-trio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/mellanox/mlx-trio.c b/drivers/platform/mellanox/mlx-trio.c index 1fd1b7a35bc1..b040606505ac 100644 --- a/drivers/platform/mellanox/mlx-trio.c +++ b/drivers/platform/mellanox/mlx-trio.c @@ -302,8 +302,7 @@ static irqreturn_t trio_irq_handler(int irq, void *arg) struct event_context *ctx = (struct event_context *)arg; struct trio_context *trio = ctx->trio; - dev_err_ratelimited(&trio->pdev->dev, - "mlx_trio: TRIO %d received IRQ %d event %d (%s)\n", + pr_debug("mlx_trio: TRIO %d received IRQ %d event %d (%s)\n", trio->trio_index, irq, ctx->event_num, trio_events[ctx->event_num].name); @@ -312,8 +311,7 @@ static irqreturn_t trio_irq_handler(int irq, void *arg) trio_readq(trio, trio->mmio_base + trio_events[ctx->event_num].additional_info, &info); - dev_err_ratelimited(&trio->pdev->dev, - "mlx_trio: Addition IRQ info: %llx\n", info); + pr_debug("mlx_trio: Addition IRQ info: %llx\n", info); } return IRQ_HANDLED;