From patchwork Thu Aug 30 09:23:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Bader X-Patchwork-Id: 963807 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 421H946wR1z9ryt; Thu, 30 Aug 2018 19:23:20 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1fvJAY-0002bN-5c; Thu, 30 Aug 2018 09:23:14 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1fvJAW-0002bH-FN for kernel-team@lists.ubuntu.com; Thu, 30 Aug 2018 09:23:12 +0000 Received: from 1.general.smb.uk.vpn ([10.172.193.28]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1fvJAW-00061Q-7O; Thu, 30 Aug 2018 09:23:12 +0000 Subject: ACK/Cmnt: [SRU] [Bionic/Unstable] [PATCH v2 0/4] Enable AMD PCIe MP2 for AMDI0011 To: Kai-Heng Feng , kernel-team@lists.ubuntu.com References: <20180719101932.23954-1-kai.heng.feng@canonical.com> From: Stefan Bader Openpgp: preference=signencrypt Autocrypt: addr=stefan.bader@canonical.com; prefer-encrypt=mutual; keydata= xsFNBE5mmXEBEADoM0yd6ERIuH2sQjbCGtrt0SFCbpAuOgNy7LSDJw2vZHkZ1bLPtpojdQId 258o/4V+qLWaWLjbQdadzodnVUsvb+LUKJhFRB1kmzVYNxiu7AtxOnNmUn9dl1oS90IACo1B BpaMIunnKu1pp7s3sfzWapsNMwHbYVHXyJeaPFtMqOxd1V7bNEAC9uNjqJ3IG15f5/50+N+w LGkd5QJmp6Hs9RgCXQMDn989+qFnJga390C9JPWYye0sLjQeZTuUgdhebP0nvciOlKwaOC8v K3UwEIbjt+eL18kBq4VBgrqQiMupmTP9oQNYEgk2FiW3iAQ9BXE8VGiglUOF8KIe/2okVjdO nl3VgOHumV+emrE8XFOB2pgVmoklYNvOjaIV7UBesO5/16jbhGVDXskpZkrP/Ip+n9XD/EJM ismF8UcvcL4aPwZf9J03fZT4HARXuig/GXdK7nMgCRChKwsAARjw5f8lUx5iR1wZwSa7HhHP rAclUzjFNK2819/Ke5kM1UuT1X9aqL+uLYQEDB3QfJmdzVv5vHON3O7GOfaxBICo4Z5OdXSQ SRetiJ8YeUhKpWSqP59PSsbJg+nCKvWfkl/XUu5cFO4V/+NfivTttnoFwNhi/4lrBKZDhGVm 6Oo/VytPpGHXt29npHb8x0NsQOsfZeam9Z5ysmePwH/53Np8NQARAQABzTVTdGVmYW4gQmFk ZXIgKENhbm9uaWNhbCkgPHN0ZWZhbi5iYWRlckBjYW5vbmljYWwuY29tPsLBgAQTAQoAKgIb AwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAIZAQUCWfsxzwUJDf6wvwAKCRDoZ13uy+7Oo8kH D/48NJMchyKB0Iu7kyAgctvPl6LlnJN7Ln2hWKQtMqZDhxGGQTsY3glF9anJ9u3X2J6hOsXR 3n/j56QAVFM1w1w+rLJWIibI6xqR1GOqrW3LQi+gS6LFLLPPZrlW2gCeP/WVoZvGEDHGou8I rnFkjMbKXicdzg4OMXU5ha+uoavO30IfFouiDnzQFdDtAMhqquWIQcPbFNlplu82CeMvSd+J wWUegRySiINLSsMnyrv/DZr/ayo20Hyi5WuHCKFymHIpghUfb0O/0oyVMdwFEu5/Pg9uZvgd X9UV+HPWD8K0+/BX/5TsNSmcUk1zWATcfhG5FcKtiV/AO8i28h3Ht4HmnB7QixY1wN+b3+tc H9wVe8DvPg7XVNPno80G4wzvSjW06EWa+rYWnbDyqgfyeI4jGb06Ak/jJKo7bHFY3Keq2ljj nutnYcuqVTNCs/uDV2ikEQsWUUCT7VZtHSEeBqMtzEQ3mxJcoVBJ98vYwSJ/cB/zeIqDT53s jwHeMQScu4T2EFCjYsuAiUNrDaN5Z89mcQgXjL9qhU+eVzENq1FvPeyaDvfr/B7tn588VAs+ Dw68j5Yqx1oEiY7VtxufcYlutJTqhikfuict6yjC4vh7t5ldTqGiiJ3g4HtC3cC4BeEW/uPw IGH41XIwvBDJoybmC1FFyDJM8n8PR19su8snIc7BTQROZplxARAAwpEX7ktXAMdNsk7JPYMg GqXEJ6W+hAWsuNAofyD6zBdohuBdAl+qbirm441W6i+oxCspLKj2+e1bvVgLn8uEZb9zsM2s pplpNNAkTglUrhFft24pAU5xf5flVQr3HDZaR7AAzC53GgE70jo9Ygl3opMTQJNiwN4PR/Ls +5UFIY54tOYsQWRgxm2sQejnZoefKvJP4qKERB8qn5XkoNc6bgcWBilboNnWly0r0CO8OfXm Dvy9WKS7btbDM6kcmHUlMgojXFwzvyqNttaNjX3akPShE9Ws/EE7AZ2Xk7I7JOFZ2MI3PWRG DeywE1q4c/L4CNnj/NJV8V5vZMfNTbm5zj8Z2ub4PQ4cWRI6PAPsxOHOW0Lkgidxk5zmpV7A M9C8JNR9ZxcIs1Kr5jyPHgKmRnmaCeNPbg3DYtga0fluzI18TzOZODNszIjXyLzQY3JQSxP5 u563MTSzpNc/ykIhVWUIbR16Dk1FpiDWfhNxiCU9g06BcVKGhFthnV9K46hHq21GqKOkgV+x 8ZowM7HjQ/SGrRk8YDfhISVIiFiuFDh9+N3qwex4GvfFnhM2U6u1tjb8J6jlQKthJZz4R6w/ fJ1iAWTzhLusYIsr1RX1yRpkQTEQUfvIQY319OuN5y6t8GDq2WzXz/HSVUGeBsSOji03MGDY In6qf0iCcxNbYJMAEQEAAcLBZQQYAQoADwIbDAUCWfsxtgUJDcNdPwAKCRDoZ13uy+7OoxwI D/9qrdQpoh+4FykI2CMnI3ad2BYy6xuo4gK2pWIcdgQzDAnj3DueMR2TTGNva+4GFRDEAyIO UX24DPtmsFUcuH2ughUEZtp9kY818Jm/R+nnHBXZ6iiYUaO5jDRbn0izKOmbLcUqv1yiY2xH 9R/MYFvYMju5CtuAavqYx8uKE2bjOV9+ypMYdlo63wU0mUlg5KSeynVpyiQIJeA6EzBz3Wmf W0v8jFz7ydnFSJsL02JOzSSK1wYa5l6BdhotkCmzzXbPovCLxD4/Y014K84epSKGPfdt5QT0 7T1itPDS3CnTrvAeWVQLhhaZ5WvFweOL2XSqNJVorQvdu//hTVwmX+nyhAZ7jJRiUya5+EYe 1v5x8APto0G8QSvwFVeOwuHwOv9ribia0BXinSoEUb5jcWP0xG82u/oKNBtCSS8t/CxApmb0 +jqA/4I+BEmNj9ZkoIbYofCjPRPxXqPQoOVG4wmrU/TIKQav+G2gccVjKrSPDwRGYhy2cASg FaizWurk1ikDL0abYS6cOjd+2559i2oZkxCi7LJnFOkkNo6Fv/1C4SwTUNx+0R+Y72N20wO2 5R47/A54JJH5BqndNfpkwYGvHFW9z4dEjohTBlhOcfZtDL63sM3n0KMPRgdX2phCzdyjTQ40 Dti/p8JIn8NSXV45VmPHnPB444ly1ZCBlDUoZQ== Message-ID: Date: Thu, 30 Aug 2018 11:23:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180719101932.23954-1-kai.heng.feng@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" On 19.07.2018 12:19, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1773940 > > [Impact] > Touchpad doesn't work on Latitude 5495. > > [Test] > I can confirm the driver from AMD works. > With patch 2/3, no issues found so far. > > [Fix] > The touchpad connects to AMDI0011, which doesn't have any driver until > now. > > The original plan is to use an upstream version for this driver, but the > review process took longer than anticipated, and the driver is really in > need as the Latitude 5495 is about to hit the market. I'll replace this > patch set with upstream version once it's in mainline. > > v2: Fix build for architectures don't support ACPI. > > [Regression Potential] > Low. It's a new driver, shouldn't affect any other device. > > Kai-Heng Feng (3): > UBUNTU: SAUCE: i2c:amd move out pointer in union i2c_event_base > UBUNTU: SAUCE: i2c:amd Depends on ACPI > UBUNTU: [Config] i2c: CONFIG_I2C_AMD_MP2=y > > Nehal-bakulchandra Shah (1): > UBUNTU: SAUCE: i2c:amd I2C Driver based on PCI Interface for upcoming > platform > > debian.master/config/config.common.ubuntu | 1 + > drivers/i2c/busses/Kconfig | 10 + > drivers/i2c/busses/Makefile | 2 + > drivers/i2c/busses/i2c-amd-pci-mp2.c | 625 ++++++++++++++++++++++ > drivers/i2c/busses/i2c-amd-pci-mp2.h | 253 +++++++++ > drivers/i2c/busses/i2c-amd-platdrv.c | 335 ++++++++++++ > 6 files changed, 1226 insertions(+) > create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.c > create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.h > create mode 100644 drivers/i2c/busses/i2c-amd-platdrv.c > Ok, there is probably no choice but to build the driver into the kernel. But at least I would suggest to limit this to x86 kernels. So replacing patch 4/4 with the attached version. How does that sound (I am also adding the update to the annotations file)? -Stefan Acked-by: Stefan Bader Acked-by: Colin Ian King From fe6885022f95065fe1393a7cd69e78e243450d0a Mon Sep 17 00:00:00 2001 From: Kai-Heng Feng Date: Thu, 19 Jul 2018 12:19:00 +0200 Subject: [PATCH] UBUNTU: [Config] i2c: CONFIG_I2C_AMD_MP2=y on x86 Build the new driver into x86 based kernels. BugLink: https://bugs.launchpad.net/bugs/1773940 Signed-off-by: Kai-Heng Feng --- debian.master/config/amd64/config.common.amd64 | 1 + debian.master/config/annotations | 1 + debian.master/config/arm64/config.common.arm64 | 1 + debian.master/config/i386/config.common.i386 | 1 + 4 files changed, 4 insertions(+) diff --git a/debian.master/config/amd64/config.common.amd64 b/debian.master/config/amd64/config.common.amd64 index c380997..06bd75a 100644 --- a/debian.master/config/amd64/config.common.amd64 +++ b/debian.master/config/amd64/config.common.amd64 @@ -159,6 +159,7 @@ CONFIG_HYPERV_TSCPAGE=y # CONFIG_HZ_100 is not set CONFIG_I2C=y CONFIG_I2C_ALGOBIT=m +CONFIG_I2C_AMD_MP2=y # CONFIG_I2C_EMEV2 is not set # CONFIG_I2C_SLAVE is not set CONFIG_I6300ESB_WDT=m diff --git a/debian.master/config/annotations b/debian.master/config/annotations index 5d8144b..4e24cfa 100644 --- a/debian.master/config/annotations +++ b/debian.master/config/annotations @@ -2455,6 +2455,7 @@ CONFIG_I2C_CHARDEV note # Menu: Device Drivers >> I2C support >> I2C support >> I2C Algorithms CONFIG_I2C_ALGOBIT policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm'}> +CONFIG_I2C_AMD_MP2 policy<{'amd64': 'y', 'arm64': 'n', 'armhf': 'n', 'i386': 'y', 'ppc64el': 'n'}> CONFIG_I2C_ALGOPCA policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm'}> # Menu: Device Drivers >> I2C support >> I2C support >> I2C Hardware Bus support diff --git a/debian.master/config/arm64/config.common.arm64 b/debian.master/config/arm64/config.common.arm64 index df2eb44..67f8bae 100644 --- a/debian.master/config/arm64/config.common.arm64 +++ b/debian.master/config/arm64/config.common.arm64 @@ -165,6 +165,7 @@ CONFIG_HZ=250 # CONFIG_HZ_1000 is not set CONFIG_HZ_250=y CONFIG_I2C=y +# CONFIG_I2C_AMD_MP2 is not set # CONFIG_I2C_EMEV2 is not set CONFIG_I2C_IMX=m CONFIG_I2C_SLAVE=y diff --git a/debian.master/config/i386/config.common.i386 b/debian.master/config/i386/config.common.i386 index 85d45bd..1a87045 100644 --- a/debian.master/config/i386/config.common.i386 +++ b/debian.master/config/i386/config.common.i386 @@ -155,6 +155,7 @@ CONFIG_HW_RANDOM_TIMERIOMEM=m # CONFIG_HZ_100 is not set CONFIG_I2C=y CONFIG_I2C_ALGOBIT=m +CONFIG_I2C_AMD_MP2=y # CONFIG_I2C_EMEV2 is not set # CONFIG_I2C_SLAVE is not set CONFIG_I6300ESB_WDT=m -- 2.7.4