| Message ID | CAOA0tznko-_=YiuWP=Dh67j_O65ey73f0sa3CyFjyMbGCKx_mQ@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Jun 08, 2016 at 03:40:30PM +0800, Phidias Chiang wrote: > BugLink: http://bugs.launchpad.net/bugs/1484159 > > The driver is ready for v4.4+ kernel and is included in Xenial > release, but lacking of firmware to make it work. This pull > request add the firmware from upstream, and has been tested. > > For Yakkety, the daily build release has already included the > firmware, and releases before Xenial doesn't support the > device so only Xenial need this. This looks fine, but you missed a couple of details. First, the bug link should be added to the commit message. Second, you should be using the -x argument for 'git cherry-pick' to add the "(cherry picked from ...)" line before your sign-off. I'll fix up the commit message when apply it, but please try to remember both of these in the future. Thanks, Seth
On Wed, Jun 08, 2016 at 03:40:30PM +0800, Phidias Chiang wrote: > BugLink: http://bugs.launchpad.net/bugs/1484159 > > The driver is ready for v4.4+ kernel and is included in Xenial > release, but lacking of firmware to make it work. This pull > request add the firmware from upstream, and has been tested. > > For Yakkety, the daily build release has already included the > firmware, and releases before Xenial doesn't support the > device so only Xenial need this. Applied with buglink and upstream commit id added to the commit message.
On Thu, Jun 9, 2016 at 11:00 PM, Seth Forshee <seth.forshee@canonical.com> wrote: > > This looks fine, but you missed a couple of details. > > First, the bug link should be added to the commit message. > > Second, you should be using the -x argument for 'git cherry-pick' to add > the "(cherry picked from ...)" line before your sign-off. > > I'll fix up the commit message when apply it, but please try to remember > both of these in the future. > > Thanks, > Seth Sorry for missing the spots, and thanks for the hints!
BugLink: http://bugs.launchpad.net/bugs/1484159 The driver is ready for v4.4+ kernel and is included in Xenial release, but lacking of firmware to make it work. This pull request add the firmware from upstream, and has been tested. For Yakkety, the daily build release has already included the firmware, and releases before Xenial doesn't support the device so only Xenial need this. ================================================================ The following changes since commit 9fee61eb4be9d7a143519db473dcdd17c5856497: UBUNTU: Ubuntu-1.157 (2016-03-17 14:07:53 -0500) are available in the git repository at: https://git.launchpad.net/~phidias-chiang/+git/linux-firmware xenial-qca9377 for you to fetch changes up to 8a26cef93fbe4e3710f8f811412c7c7241fec824: ath10k: QCA9377 hw1.0: add firmware and board files (2016-06-08 14:05:38 +0800) ---------------------------------------------------------------- Kalle Valo (1): ath10k: QCA9377 hw1.0: add firmware and board files WHENCE | 5 + ath10k/QCA9377/hw1.0/board-2.bin | Bin 0 -> 427668 bytes ath10k/QCA9377/hw1.0/board.bin | Bin 0 -> 8124 bytes ath10k/QCA9377/hw1.0/firmware-5.bin | Bin 0 -> 605908 bytes ath10k/QCA9377/hw1.0/notice_ath10k_firmware-5.txt | 1128 +++++++++++++++++++++ 5 files changed, 1133 insertions(+) create mode 100644 ath10k/QCA9377/hw1.0/board-2.bin create mode 100644 ath10k/QCA9377/hw1.0/board.bin create mode 100644 ath10k/QCA9377/hw1.0/firmware-5.bin create mode 100644 ath10k/QCA9377/hw1.0/notice_ath10k_firmware-5.txt