mbox

SRU LP 1400349 new arm64 optimized copy_to_user and copy_from_user assembly code

Message ID CAKp6GAv4+99CwSKmuoMEPtx-cFOYO3+zCFgCRn4+=qgbKrWGPA@mail.gmail.com
State New
Headers show

Pull-request

git://kernel.ubuntu.com/cmagina/vivid-xgene.git lp1400349

Message

Craig Magina Dec. 10, 2014, 8:24 p.m. UTC
This contains a new optimization patch that has been tested and
verified not to have the same memory corruption issue as the previous.
The logs for the bug reproduction and testing done with this new patch
can be found attached to the bug [1].

[1] BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1400349


Trusty

The following changes since commit f943c19de5a4af319761aa30f79c7ba8f5aa36ed:

  When ring buffer returns an error indicating retry, storvsc may not
return a proper error code to SCSI when bounce buffer is not used.
This has introduced I/O freeze on RAID running atop storvsc devices.
This patch fixes it by always returning a proper error code.
(2014-12-10 08:56:25 -0800)

are available in the git repository at:

  git://kernel.ubuntu.com/cmagina/trusty-xgene.git lp1400349

for you to fetch changes up to e4ca122ed833316245489f947cab61e7d531169e:

  arm64: optimized copy_to_user and copy_from_user assembly code
(2014-12-10 14:44:43 -0500)

----------------------------------------------------------------
Feng Kan (1):
      arm64: optimized copy_to_user and copy_from_user assembly code

 arch/arm64/lib/copy_from_user.S |  87 ++++++++++++++++----------
 arch/arm64/lib/copy_template.S  | 212
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm64/lib/copy_to_user.S   |  57 +++++++++--------
 3 files changed, 297 insertions(+), 59 deletions(-)
 create mode 100644 arch/arm64/lib/copy_template.S


Utopic

The following changes since commit 6a61c55d0fa1cb7c854fb4307bbdcffffe82b797:

  sched/x86: Fix up typo in topology detection (2014-12-10 11:35:05 -0800)

are available in the git repository at:

  git://kernel.ubuntu.com/cmagina/utopic-xgene.git lp1400349

for you to fetch changes up to 15b90f5363eeb088d014b59155f848bfcdc4dc1f:

  arm64: optimized copy_to_user and copy_from_user assembly code
(2014-12-10 14:55:10 -0500)

----------------------------------------------------------------
Feng Kan (1):
      arm64: optimized copy_to_user and copy_from_user assembly code

 arch/arm64/lib/copy_from_user.S |  87 ++++++++++++++++----------
 arch/arm64/lib/copy_template.S  | 212
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm64/lib/copy_to_user.S   |  57 +++++++++--------
 3 files changed, 297 insertions(+), 59 deletions(-)
 create mode 100644 arch/arm64/lib/copy_template.S


Vivid

The following changes since commit cf7e9f183f6f7e96cc0eb4ee9ddcd2f525613190:

  UBUNTU: [Config] CONFIG_FW_LOADER_USER_HELPER_FALLBACK=n (2014-12-10
11:50:01 -0800)

are available in the git repository at:

  git://kernel.ubuntu.com/cmagina/vivid-xgene.git lp1400349

for you to fetch changes up to db1847d8c6eba863a38ef9027efce52801f5f456:

  arm64: optimized copy_to_user and copy_from_user assembly code
(2014-12-10 15:11:49 -0500)

----------------------------------------------------------------
Feng Kan (1):
      arm64: optimized copy_to_user and copy_from_user assembly code

 arch/arm64/lib/copy_from_user.S |  87 ++++++++++++++++----------
 arch/arm64/lib/copy_template.S  | 212
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm64/lib/copy_to_user.S   |  57 +++++++++--------
 3 files changed, 297 insertions(+), 59 deletions(-)
 create mode 100644 arch/arm64/lib/copy_template.S

Thanks,

Comments

Paolo Pisati Dec. 11, 2014, 2:29 p.m. UTC | #1
On Wed, Dec 10, 2014 at 03:24:56PM -0500, Craig Magina wrote:
> This contains a new optimization patch that has been tested and
> verified not to have the same memory corruption issue as the previous.
> The logs for the bug reproduction and testing done with this new patch
> can be found attached to the bug [1].
> 
> [1] BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1400349

was the patch posted upstream anywhere? can't find it.
Craig Magina Dec. 11, 2014, 3:29 p.m. UTC | #2
On Thu, Dec 11, 2014 at 9:29 AM, Paolo Pisati
<paolo.pisati@canonical.com> wrote:
> On Wed, Dec 10, 2014 at 03:24:56PM -0500, Craig Magina wrote:
>> This contains a new optimization patch that has been tested and
>> verified not to have the same memory corruption issue as the previous.
>> The logs for the bug reproduction and testing done with this new patch
>> can be found attached to the bug [1].
>>
>> [1] BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1400349
>
> was the patch posted upstream anywhere? can't find it.
> --
> bye,
> p.

I apologize, I forgot to add the Reference link. The patch can be found here:
http://www.spinics.net/lists/arm-kernel/msg384539.html
Brad Figg Dec. 11, 2014, 5:42 p.m. UTC | #3
On Wed, Dec 10, 2014 at 03:24:56PM -0500, Craig Magina wrote:
> This contains a new optimization patch that has been tested and
> verified not to have the same memory corruption issue as the previous.
> The logs for the bug reproduction and testing done with this new patch
> can be found attached to the bug [1].
> 
> [1] BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1400349
> 
> 
> Trusty
> 
> The following changes since commit f943c19de5a4af319761aa30f79c7ba8f5aa36ed:
> 
>   When ring buffer returns an error indicating retry, storvsc may not
> return a proper error code to SCSI when bounce buffer is not used.
> This has introduced I/O freeze on RAID running atop storvsc devices.
> This patch fixes it by always returning a proper error code.
> (2014-12-10 08:56:25 -0800)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/cmagina/trusty-xgene.git lp1400349
> 
> for you to fetch changes up to e4ca122ed833316245489f947cab61e7d531169e:
> 
>   arm64: optimized copy_to_user and copy_from_user assembly code
> (2014-12-10 14:44:43 -0500)
> 
> ----------------------------------------------------------------
> Feng Kan (1):
>       arm64: optimized copy_to_user and copy_from_user assembly code
> 
>  arch/arm64/lib/copy_from_user.S |  87 ++++++++++++++++----------
>  arch/arm64/lib/copy_template.S  | 212
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  arch/arm64/lib/copy_to_user.S   |  57 +++++++++--------
>  3 files changed, 297 insertions(+), 59 deletions(-)
>  create mode 100644 arch/arm64/lib/copy_template.S
> 
> 
> Utopic
> 
> The following changes since commit 6a61c55d0fa1cb7c854fb4307bbdcffffe82b797:
> 
>   sched/x86: Fix up typo in topology detection (2014-12-10 11:35:05 -0800)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/cmagina/utopic-xgene.git lp1400349
> 
> for you to fetch changes up to 15b90f5363eeb088d014b59155f848bfcdc4dc1f:
> 
>   arm64: optimized copy_to_user and copy_from_user assembly code
> (2014-12-10 14:55:10 -0500)
> 
> ----------------------------------------------------------------
> Feng Kan (1):
>       arm64: optimized copy_to_user and copy_from_user assembly code
> 
>  arch/arm64/lib/copy_from_user.S |  87 ++++++++++++++++----------
>  arch/arm64/lib/copy_template.S  | 212
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  arch/arm64/lib/copy_to_user.S   |  57 +++++++++--------
>  3 files changed, 297 insertions(+), 59 deletions(-)
>  create mode 100644 arch/arm64/lib/copy_template.S
> 
> 
> Vivid
> 
> The following changes since commit cf7e9f183f6f7e96cc0eb4ee9ddcd2f525613190:
> 
>   UBUNTU: [Config] CONFIG_FW_LOADER_USER_HELPER_FALLBACK=n (2014-12-10
> 11:50:01 -0800)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/cmagina/vivid-xgene.git lp1400349
> 
> for you to fetch changes up to db1847d8c6eba863a38ef9027efce52801f5f456:
> 
>   arm64: optimized copy_to_user and copy_from_user assembly code
> (2014-12-10 15:11:49 -0500)
> 
> ----------------------------------------------------------------
> Feng Kan (1):
>       arm64: optimized copy_to_user and copy_from_user assembly code
> 
>  arch/arm64/lib/copy_from_user.S |  87 ++++++++++++++++----------
>  arch/arm64/lib/copy_template.S  | 212
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  arch/arm64/lib/copy_to_user.S   |  57 +++++++++--------
>  3 files changed, 297 insertions(+), 59 deletions(-)
>  create mode 100644 arch/arm64/lib/copy_template.S
> 
> Thanks,
> -- 
> Craig Magina
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Applied to Trusty master-next
Applied to Utopic master-next