From patchwork Fri Apr 13 13:07:59 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 152301 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id D5E0EB70D5 for ; Fri, 13 Apr 2012 23:08:58 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SIgF2-0006uX-2S; Fri, 13 Apr 2012 13:08:44 +0000 Received: from mail.tpi.com ([70.99.223.143]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SIgEz-0006u8-3Q for kernel-team@lists.ubuntu.com; Fri, 13 Apr 2012 13:08:41 +0000 Received: from [10.0.2.6] (host-174-45-43-11.hln-mt.client.bresnan.net [174.45.43.11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail.tpi.com (Postfix) with ESMTP id D1FAA312B61; Fri, 13 Apr 2012 06:08:39 -0700 (PDT) Message-ID: <4F88252F.9090307@canonical.com> Date: Fri, 13 Apr 2012 07:07:59 -0600 From: Tim Gardner User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Chase Douglas Subject: Re: APPLIED: [Precise PATCH 0/6] Support for new Sentelic touchpad (LP #969334) References: <1334239099-3502-1-git-send-email-eric.miao@canonical.com> <1334249903.24765.17.camel@adamo> <4F870AAA.9020805@canonical.com> <4F881FB1.5010102@canonical.com> In-Reply-To: <4F881FB1.5010102@canonical.com> X-Enigmail-Version: 1.4 Cc: kernel-team@lists.ubuntu.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list Reply-To: tim.gardner@canonical.com List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com On 04/13/2012 06:44 AM, Tim Gardner wrote: > What impact will the lack of this patch have (as noted by Chase) ? > Aha! Chase - I took the liberty of applying your ACK. From 4a4d71a277c26464bc6c844a3d3eae9d8e12904a Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa Date: Tue, 3 Apr 2012 09:46:32 -0700 Subject: [PATCH] Input: sentelic - filter taps in absolute mode BugLink: http://bugs.launchpad.net/bugs/969334 Taps in absolute positioning single-finger mode are currently reported as physical clicks by the driver. This should be handled by userspace, not the kernel. When a tap occurs, the FSP_PB0_LBTN bit is set, but the FSP_PB0_PHY_BTN is not. We use this to filter out physical clicks from taps. Signed-off-by: Oskari Saarenmaa Reviewed-by: Tai-hwa Liang Reviewed-by: Chase Douglas Signed-off-by: Dmitry Torokhov (cherry picked from commit d626dad58f02e13730ded6ac84d6a9e53123f0e8) Signed-off-by: Tim Gardner Acked-by: Chase Douglas --- drivers/input/mouse/sentelic.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/input/mouse/sentelic.c b/drivers/input/mouse/sentelic.c index 869efb3..19097f4 100644 --- a/drivers/input/mouse/sentelic.c +++ b/drivers/input/mouse/sentelic.c @@ -720,6 +720,14 @@ static psmouse_ret_t fsp_process_byte(struct psmouse *psmouse) } } else { /* SFAC packet */ + if ((packet[0] & (FSP_PB0_LBTN|FSP_PB0_PHY_BTN)) == + FSP_PB0_LBTN) { + /* On-pad click in SFAC mode should be handled + * by userspace. On-pad clicks in MFMC mode + * are real clickpad clicks, and not ignored. + */ + packet[0] &= ~FSP_PB0_LBTN; + } /* no multi-finger information */ ad->last_mt_fgr = 0; -- 1.7.9.5