diff mbox

[Maverick,SRU] (pre-stable) Fix mic for Dell Vostro 320

Message ID 4D203E68.5010101@canonical.com
State Accepted
Headers show

Commit Message

David Henningsson Jan. 2, 2011, 8:59 a.m. UTC
On 2010-12-10 21:54, Tim Gardner wrote:
> On 12/10/2010 08:38 AM, Brad Figg wrote:
>> On 12/10/2010 06:19 AM, Stefan Bader wrote:
>>> On 12/10/2010 12:57 PM, David Henningsson wrote:
>>>> SRU Justification:
>>>>
>>>> Impact: Non-working mic
>>>> Fix: Quirk into model "ideapad", tested by cert lab
>>>> Testcase: Try recording from mic
>>>>
>>>> Upstream status: Not yet reached Linus's tree, commit id in Takashi's
>>>> tree is 8a96b1e02029aa512199b1b6d281dcede9ed81f1.
>>>>
>>>> Hope I did everything right this time :-)
>>>>
>>> I am afraid, no. :-P The BugLink is invalid and should be:
>>>
>>> http://bugs.launchpad.net/bugs/497546
>>>
>>> Patch looks reasonable. Arguable whether we should wait to apply it
>>> until it has
>>> at least made it into Linus tree. It is not a critical issue. On the
>>> other hand
>>> it is simple enough and very limited in scope.

It has now reached Linus's tree.

>>>
>>> Acked-by: Stefan Bader<stefan.bader@canonical.com>
>>>
>>
>> It's early so I might have missed it but the SRU text is missing from the
>> bug. Just adding it as a comment is acceptable, some folks modify the
>> bug description and add it there.

Added as 
https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/497546/comments/58 
(although my personal opinion is that this is just extra bureaucracy).

>>
>> The patch looks fine however.
>>
>> Acked-by: Brad Figg<brad.figg@canonical.com>
>>
>> Brad
>
> And while you're fixing the commit log, reformat the patch so that it
> applies to Maverick.
>
> rtg

Attaching modified patch. Checked that buglink is correct and that it 
applies to ubuntu-maverick.

Comments

Tim Gardner Jan. 3, 2011, 6 p.m. UTC | #1
On 01/02/2011 01:59 AM, David Henningsson wrote:
> On 2010-12-10 21:54, Tim Gardner wrote:
>> On 12/10/2010 08:38 AM, Brad Figg wrote:
>>> On 12/10/2010 06:19 AM, Stefan Bader wrote:
>>>> On 12/10/2010 12:57 PM, David Henningsson wrote:
>>>>> SRU Justification:
>>>>>
>>>>> Impact: Non-working mic
>>>>> Fix: Quirk into model "ideapad", tested by cert lab
>>>>> Testcase: Try recording from mic
>>>>>
>>>>> Upstream status: Not yet reached Linus's tree, commit id in Takashi's
>>>>> tree is 8a96b1e02029aa512199b1b6d281dcede9ed81f1.
>>>>>
>>>>> Hope I did everything right this time :-)
>>>>>
>>>> I am afraid, no. :-P The BugLink is invalid and should be:
>>>>
>>>> http://bugs.launchpad.net/bugs/497546
>>>>
>>>> Patch looks reasonable. Arguable whether we should wait to apply it
>>>> until it has
>>>> at least made it into Linus tree. It is not a critical issue. On the
>>>> other hand
>>>> it is simple enough and very limited in scope.
>
> It has now reached Linus's tree.
>
>>>>
>>>> Acked-by: Stefan Bader<stefan.bader@canonical.com>
>>>>
>>>
>>> It's early so I might have missed it but the SRU text is missing from
>>> the
>>> bug. Just adding it as a comment is acceptable, some folks modify the
>>> bug description and add it there.
>
> Added as
> https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/497546/comments/58
> (although my personal opinion is that this is just extra bureaucracy).
>
>>>
>>> The patch looks fine however.
>>>
>>> Acked-by: Brad Figg<brad.figg@canonical.com>
>>>
>>> Brad
>>
>> And while you're fixing the commit log, reformat the patch so that it
>> applies to Maverick.
>>
>> rtg
>
> Attaching modified patch. Checked that buglink is correct and that it
> applies to ubuntu-maverick.
>

applied, pushed
diff mbox

Patch

From d67cc609fafcb6d748cbe2d06d45aaebcd183bf7 Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Sun, 2 Jan 2011 09:42:56 +0100
Subject: [PATCH] ALSA: HDA: Quirk for Dell Vostro 320 to make microphone work

Backport of commit 8a96b1e02029aa512199b1b6d281dcede9ed81f1 upstream.

BugLink: http://bugs.launchpad.net/bugs/497546

Confirmed that the ideapad model works better than the current
quirk for Dell Vostro 320.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/patch_conexant.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 301d51f..f31843f 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -3026,8 +3026,7 @@  static const char *cxt5066_models[CXT5066_MODELS] = {
 static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x14f1, 0x0101, "Conexant Reference board",
 		      CXT5066_LAPTOP),
-	SND_PCI_QUIRK(0x1028, 0x02f5, "Dell",
-		      CXT5066_DELL_LAPTOP),
+	SND_PCI_QUIRK(0x1028, 0x02f5, "Dell Vostro 320", CXT5066_IDEAPAD),
 	SND_PCI_QUIRK(0x152d, 0x0833, "OLPC XO-1.5", CXT5066_OLPC_XO_1_5),
 	SND_PCI_QUIRK(0x1028, 0x02d8, "Dell Vostro", CXT5066_DELL_VOSTO),
 	SND_PCI_QUIRK(0x1028, 0x0402, "Dell Vostro", CXT5066_DELL_VOSTO),
-- 
1.7.1