From patchwork Wed Jul 19 18:29:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1809989 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=tdW/p4kM; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R5krd1rGlz1yY9 for ; Thu, 20 Jul 2023 04:30:09 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1qMBw3-0003LU-5l; Wed, 19 Jul 2023 18:30:03 +0000 Received: from mail-bn7nam10on2065.outbound.protection.outlook.com ([40.107.92.65] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1qMBw0-0003Is-2X for kernel-team@lists.ubuntu.com; Wed, 19 Jul 2023 18:30:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i82cZdp7xALCTbhvppfh5JbI5ViTdZXWUxAvxbQKc3VN7t3H0ilKIujFGkAvNh4cOOF49UulSebKl+Ft8qt6rAs/693d3/+RgBDfwO4jixQOF87Zdi813gzjsaXXmYN9JhNLoqQxqk3bu+4br5pxXrnvomBUmSWASt/dHJ6b8voRacolxMB0i4f3CYgDTBNUbO+DGYbIHFKoFKlSR0e2PLMd90QCaJ9XDfzAL9dtT+tT5HmZtSMQ4+QeYm4pkhAy3qWFVqNvxUlqzYUhGaZzwN/I+t0va1JywcaiVBXy+ZrPrOpJCpfCFySKxkdHq0MJY6IaqlfRILWq5A4wLs9jhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hD24ZHKxw3xcjGbq4ANGz18Jg9Jyy7OvO66zEBXAut0=; b=nlckW9Ee3xVn9UfO4y00Pk59B7t2OjDmvnli+ux1tkLzgYg/fl3ZEjX2BESW9o19TFhj1GTul4UhG4cbeHMqSIQgmAEn0pYS5YFGoyRcZmukLs1o6dxU8jfBl5UMfdXg6s2hzyQ5oHiHTjNqJqmccvNA++ye5Zf0cd3Tflgig2tWbXLSbuwGNMRYsDAgfGhKpKYcfbwbUkqnuZuyqObC1jaE9LCzdRPvZHUC4dkBtAbPlgbRCvhwlZsQPnf1ku02tjTBS/Kv8hgPvEt7/mldbUMadrFec7AxUR/QkSTNcEPZ2EBR1FHoFDOh95oRMRN00QG4aV0IHG47RXX6ORTeYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hD24ZHKxw3xcjGbq4ANGz18Jg9Jyy7OvO66zEBXAut0=; b=tdW/p4kMWocRYZh2QaJXly5RFzTwLu3Sq98itQ6ADxJRKaMSNb3wSXfNddWFQ8A5KRQwMEUIiPAJuLusjKSA+KviY2TxtdfG1uAE5amBFXwJ3X+nx2xA5gGtNTh00tj6CVzOFEOy9hRUxMYfNGM/PdpfAbWqg3HX7PXRjq4dnVP8IdD06TrTsQWv5HGtluIoxIZiA2ILxPb6YLDly9x2FkY4e3XHp4OAHKWuOYeNRiRDx/E39U9giC4q28OWSapcndtfUI3EMN66AmQxHrtnEMiHQXf/0j/kP73tqfF3/zbPBPZqXDtPHbrtdSBImy48YYEuNwUQptn5PrLUiqkaOA== Received: from BN9PR03CA0847.namprd03.prod.outlook.com (2603:10b6:408:13d::12) by SJ0PR12MB6853.namprd12.prod.outlook.com (2603:10b6:a03:47b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Wed, 19 Jul 2023 18:29:55 +0000 Received: from BN8NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13d:cafe::ec) by BN9PR03CA0847.outlook.office365.com (2603:10b6:408:13d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33 via Frontend Transport; Wed, 19 Jul 2023 18:29:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT067.mail.protection.outlook.com (10.13.177.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.34 via Frontend Transport; Wed, 19 Jul 2023 18:29:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 19 Jul 2023 11:29:43 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 19 Jul 2023 11:29:42 -0700 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Wed, 19 Jul 2023 11:29:42 -0700 Received: from c-237-147-20-023.vagrant-libvirt (c-237-147-20-023.mtl.labs.mlnx [10.237.147.23]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 36JITeKJ028835; Wed, 19 Jul 2023 21:29:40 +0300 From: William Tu To: Subject: [SRU][J:linux-bluefield][PATCH 1/1] UBUNTU: SAUCE: net/sched: fix ct offload action Date: Wed, 19 Jul 2023 21:29:40 +0300 Message-ID: <20230719182940.873851-2-witu@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230719182940.873851-1-witu@nvidia.com> References: <20230719182940.873851-1-witu@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT067:EE_|SJ0PR12MB6853:EE_ X-MS-Office365-Filtering-Correlation-Id: aac60f13-d125-4a65-b37d-08db8886266a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3aFYEQpaAALgSGWpbl8Ty7HCigLlcJN/gIUeX3fhkeIWbwILtK672hrN1kpMk7SVZJP2936F4dAs15dehYgLbTAzzlw3ooA1UvdZeKQYFuZSqFbGEjrQpPQfSR7Dfi3FAUHKi1lHVhU1t0Kaaky/ON2uwQZoMisOh1vZJfr+r9tFmzcOEwgfcYT9qsS9Rngi9rinu8QXRRU729EE0DmHM/3z8fHHJCwiZeYFHBcex1+MVtJss4vat7sKW3kco0R3e5fQmZne0mk1iQpxjRAOWgJJ0c1AJFgBedsXRwCsVnCjRAsB/iqy6jF5AtkAyEJjTGdkDrl+tmrqzKQnq58lUjFy6SVgM+I6L6k5X6wvTY+lHWpf1WgeAJ/JGJnfQWeIFUcSXkxtDC/gQvPKRA0wXjjgHUGP0PJntZnZeG7/+LXiEmbd0Yx0KgTz2HEkG0byVEZCGRd7IMNx87OSQcGZSfu+tB50X2im+VJ2pySmgbyp6rbf22SSsB91o+sK6pLeJH3kAZ4u5hMB5m5ykfcgLdiUFDo14BOIImI620Tyg5lk5QOnsNuY7rRgddg5Y+cl/hFxtmU6TEbBp9VdFBoVkMOM0tFmQn7ovJ7OQW+W2IFjBQeI2j1YGBgz3AgncgJcplUYvstFGmJ7rW3lomzGuk13qZXzE0lkf7K/v5bTLR8TtXN808L5hMjoi2st47Fxp6FC9F09Jno410cUZmd5soCvQINHmlK0WWDC6ZE6GX84kUOrlyTFEibcJurBsNzMkfnPKfUa0XRuiCufjVYUZQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199021)(82310400008)(36840700001)(46966006)(40470700004)(40480700001)(40460700003)(2616005)(47076005)(336012)(1076003)(26005)(186003)(107886003)(36860700001)(83380400001)(5660300002)(8936002)(8676002)(70586007)(41300700001)(4326008)(6916009)(70206006)(54906003)(316002)(966005)(478600001)(2906002)(45080400002)(356005)(36756003)(7636003)(82740400003)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 18:29:55.2548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aac60f13-d125-4a65-b37d-08db8886266a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6853 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dann.frazier@canonical.com, paulb@nvidia.com, vlad@nvidia.com, yifeid@nvidia.com, bodong@nvidia.com, cmi@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Paul Blakey BugLink: https://bugs.launchpad.net/bugs/2028190 The patch fixes the kernel panic due to getting tc flower stats, when testing conntrack offload with pedit. [ 226.156222] Unable to handle kernel access to user memory outside uaccess routines at [ 226.177783] Mem abort info: [ 226.183408] ESR = 0x0000000096000004 [ 226.190953] EC = 0x25: DABT (current EL), IL = 32 bits [ 226.201641] SET = 0, FnV = 0 [ 226.207786] EA = 0, S1PTW = 0 [ 226.214095] FSC = 0x04: level 0 translation fault [ 226.223906] Data abort info: [ 226.229695] ISV = 0, ISS = 0x00000004 [ 226.237410] CM = 0, WnR = 0 [ 226.243372] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000123f25000 [ 226.256328] [0000000000000090] pgd=0000000000000000, p4d=0000000000000000 [ 226.269984] Internal error: Oops: 96000004 [#1] SMP [ 226.279779] Modules linked in: act_pedit act_ct nf_flow_table iptable_raw xt_CT xt_tcpudp bpfilter xt_comment xt_mark [ 226.279938] async_raid6_recov async_memcpy async_pq async_xor async_tx xor xor_neon raid6_pq raid1 raid0 multipath [ 226.544260] CPU: 2 PID: 4293 Comm: handler3 Tainted: G [ 226.565581] Hardware name: https://www.mellanox.com BlueField SoC/BlueField SoC, BIOS 4.2.0.12795 Jun 30 2023 [ 226.585497] pstate: a0400005 (NzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 226.599481] pc : tcf_action_update_stats+0x8/0xc4 [ 226.608933] lr : mlx5e_tc_act_stats_fill_stats+0xf8/0x19c [mlx5_core] [ 226.622089] sp : ffff80000e073130 [ 226.628735] x29: ffff80000e073130 x28: 0000000000000008 x27: 0000000000000020 [ 226.643067] x26: ffffffffffffffe0 x25: ffff5913c62dfe71 x24: ffff5913c62dfe00 [ 226.657398] x23: 0000000000000000 x22: 0000000000000000 x21: ffff5913c62dfe70 [ 226.671730] x20: ffff5913c2fc3b00 x19: ffff5913f0058000 x18: 0000000000000014 [ 226.686059] x17: 00000000b96d1a87 x16: ffffc6320acb93e0 x15: 0000000000000000 [ 226.700390] x14: 0000000000000001 x13: 0000000000000000 x12: 0000000000000002 [ 226.714720] x11: 7f7f7f7f7f7f7f7f x10: 0000000000000000 x9 : ffffc631ce0b66ac [ 226.729052] x8 : ffff80000e073130 x7 : 0000000000000000 x6 : 000000000000000d [ 226.743384] x5 : 0000000000000c62 x4 : 0000000000000001 x3 : 0000000000000000 [ 226.757715] x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000 [ 226.772047] Call trace: [ 226.776947] tcf_action_update_stats+0x8/0xc4 [ 226.785695] mlx5e_tc_act_stats_fill_stats_flow+0x78/0xc0 [mlx5_core] [ 226.798833] mlx5e_stats_flower+0x394/0x3c0 [mlx5_core] [ 226.809502] mlx5e_rep_setup_tc_cls_flower+0x8c/0xa0 [mlx5_core] [ 226.821732] mlx5e_rep_setup_tc_cb+0x74/0xb0 [mlx5_core] [ 226.832549] tc_setup_cb_call+0xa4/0x160 [ 226.840426] fl_hw_update_stats+0x98/0x164 [cls_flower] [ 226.850927] fl_dump.part.0+0x224/0x260 [cls_flower] [ 226.860891] fl_dump+0x20/0x34 [cls_flower] [ 226.869284] tcf_fill_node+0x164/0x244 [ 226.876803] tfilter_notify+0xc0/0x140 [ 226.884323] tc_new_tfilter+0x454/0x8bc [ 226.892018] rtnetlink_rcv_msg+0x2e8/0x3cc [ 226.900245] netlink_rcv_skb+0x64/0x130 [ 226.907942] rtnetlink_rcv+0x20/0x30 [ 226.915110] netlink_unicast+0x2ec/0x360 Fixes: e334c2b80bea ("SAUCE: net/sched: Provide act to offload action") Signed-off-by: Paul Blakey Signed-off-by: William Tu --- net/sched/cls_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 1637529a6cbf..2ccd66e34dc0 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -3844,6 +3844,7 @@ int tc_setup_flow_action(struct flow_action *flow_action, entry->hw_stats = tc_act_hw_stats(act->hw_stats); entry->miss_cookie = tcf_exts_miss_cookie_get(miss_cookie_base, i); + entry->act = act; entry = &flow_action->entries[++j]; }