Message ID | 20230619174942.1195846-5-witu@nvidia.com |
---|---|
State | New |
Headers | show
Return-Path: <kernel-team-bounces@lists.ubuntu.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=Qj1dRLGp; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QlHNf1K5vz20Wk for <incoming@patchwork.ozlabs.org>; Tue, 20 Jun 2023 03:50:26 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from <kernel-team-bounces@lists.ubuntu.com>) id 1qBJ17-0007pC-P9; Mon, 19 Jun 2023 17:50:17 +0000 Received: from mail-dm6nam10on2065.outbound.protection.outlook.com ([40.107.93.65] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <witu@nvidia.com>) id 1qBJ12-0007il-K6 for kernel-team@lists.ubuntu.com; Mon, 19 Jun 2023 17:50:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VaTHJ5lYkF6o238A0WnZQ9XSm7iSxeDLxI/Oq/S1nfH2mFrdJk6PLmSBwgCSdcpiPFjsZntLyLFJ7ryNiJ7uFZ1dtU+iFqim8uaOFvLp7RUZxcEC154sn9/8u4LkXFWHRoE/DnPLdH1zXYRFdfO5dKJrEBv/0ZSDED6CLCVktjheGb4Lf3tC3BERmkVJpR+G+TCcs5dgo1Q0zFy+JWvMTGVLsyW8KkQGWn64whV+Ta57lZ00j0QmYeYFK7BsFbUnFeTCie6hqb+P5PHpnR3VSIrYuLOiv2kDQGbKye0KHVN03eV2nXbc+AEd+sVJT/kqBGviOXKjU19adPJSxITfSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZQPAJRCdARJRZqzKgsxahGLj+Ub2pd36KEeAwj4HnHc=; b=NXOyKEpsp9Mv8i0ISqKhNFFHSDf6Kt16vsp83O4QZEqL/les+1UWiAYMqGOPIfy8KSBCffiHSQeqc9thm36fpWfZJ1GzDazm6nCzlJcNyZq39ub+QFe+75/zblAVwcR/fNx0Cw0GaV51pjlOdkwWvCQjiRB32PpEAGkxvVm5DMPZI1x9t+V9rfnxSk3lKCyJDgOxGx1TCm6xHHbnmP4eM/4TtRLQXEE2ssn4CqQ0t+WJesd1/QEk50CMR+8LHEsdK4LSZs8PiQlssrYJ8cDrtgb7OGW1xscB/HqsNslCk1fifshv6n2AY4FNT+U0X/UBY+TXE2SxGA2CM8s9Kqg25A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZQPAJRCdARJRZqzKgsxahGLj+Ub2pd36KEeAwj4HnHc=; b=Qj1dRLGpUwvELp/TuQAbITionSNpJd06P2x/0b0EnYQXZtfY0T6OYLECu8BnglLQZyRURAzGH2aksT5xW/EeN5j7XPSKsSN2n6xji/hOSAn0JQO3EvvzZpt57zkOxEZtgO0QnUjgSMTlCLMdRutWrdrQuL4tOMygiNwEE393USgxZTrG7lV+dDmwvOmxFZhvg+BICW0g6E5juLEBB34hwx0KIvWCh4oIcmfWdlFr9fiYgfm1Xb8m3jLckNkrXtrJhQsaRSugY8Ivu9EJQJg6MvGx0d/6+NExemn5/eDuoTzSmb+rz43n1yTEBWRpX5nu/wq4dqIuFPabbQnp451OWA== Received: from BN0PR04CA0059.namprd04.prod.outlook.com (2603:10b6:408:e8::34) by LV8PR12MB9081.namprd12.prod.outlook.com (2603:10b6:408:188::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Mon, 19 Jun 2023 17:50:09 +0000 Received: from BN8NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e8:cafe::42) by BN0PR04CA0059.outlook.office365.com (2603:10b6:408:e8::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37 via Frontend Transport; Mon, 19 Jun 2023 17:50:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BN8NAM11FT024.mail.protection.outlook.com (10.13.177.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36 via Frontend Transport; Mon, 19 Jun 2023 17:50:09 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 19 Jun 2023 10:50:03 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 19 Jun 2023 10:50:02 -0700 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Mon, 19 Jun 2023 10:50:02 -0700 Received: from sw-mtx-002.mtx.labs.mlnx (sw-mtx-002.mtx.labs.mlnx [10.9.151.106]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 35JHnnvJ030853; Mon, 19 Jun 2023 20:49:58 +0300 From: William Tu <witu@nvidia.com> To: <kernel-team@lists.ubuntu.com> Subject: [SRU][J:linux-bluefield][PATCH v4 04/10] net/sched: flower: fix fl_change() error recovery path Date: Mon, 19 Jun 2023 20:49:35 +0300 Message-ID: <20230619174942.1195846-5-witu@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230619174942.1195846-1-witu@nvidia.com> References: <20230619174942.1195846-1-witu@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT024:EE_|LV8PR12MB9081:EE_ X-MS-Office365-Filtering-Correlation-Id: a1e0604e-3f4b-4d40-32ee-08db70eda015 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +JZuHhY7B5Rni3VYW3q4+DFzRvXPdNAxtAs8EvDzgVn+TwuhgGydKtOikKplZI9OK+8igWt2ky67bSgM2CsYrh2tyZZqotWNNwpCuCE/thD4GABHj8XozZeVixieOSFBYZ0PzmEjPK5Ni+Oid9sPOAwQ4q0q6JLhm0RtSwsHXJhU5H2NpljUtYL5WbDeDOxp1uacD0/hopAO5OEN4PjASMcX+RKpVHjNHpzAe6tYAV7z6DCVFTPZl5wbD4pg18HQeXL8U5WjyCQgzibJr0M3IckrGwsdvM+HihsF7bFUiNMjHDUBzh28sHptF3e/mqYFc4V1i3kII0F7kAmu9QGBSySdKvq6l1ZluyAixXSOO1Qe0EInoaCHrrh5p/DzZeWs8WQor2sTn2Zu8Oc2klysdJ7xNbEpD8FPRpPBOfQJDZ2QgmsC1nX9udSRdbziQJ3PC7vjICWIp1YjEKWhaqGB+8I37GS5YPxZ/V6Z2QmsiK7ifprCedQgRAHl8fsIwBQKJRvXdj8b2qEMYFT5QAruY7G/7dxUg0V1eU6wJmNOcMbw+I3l301WlsHazHIXJ64mnLgOJ0F+AweobxBzznmG2W9yhArA9nxgh2EDYnFn35Wdo0C1Rg0pbOHE6PngGLiP7mCi8/+0PrnBMZj/XONDb0ptX9W3HAbLY9PrpENuUPgJ2Ih/fU8bGlBHOsZbhsu8BJNhAYTS6SxpY8A1jfnnMILRkgcnyZ0+fOmP5plW8BtOYzpFN7j7WVKRkkH8hdcl4SwRKRoD1BZchLcQ+AiaCuxT3VCmMnXrltLEnR+Nk4w= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199021)(46966006)(40470700004)(36840700001)(47076005)(83380400001)(54906003)(6666004)(316002)(8676002)(8936002)(2616005)(36756003)(86362001)(1076003)(26005)(4326008)(186003)(336012)(41300700001)(5660300002)(82310400005)(6916009)(70586007)(70206006)(40460700003)(82740400003)(356005)(966005)(107886003)(7636003)(40480700001)(478600001)(36860700001)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 17:50:09.6486 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a1e0604e-3f4b-4d40-32ee-08db70eda015 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9081 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions <kernel-team.lists.ubuntu.com> List-Unsubscribe: <https://lists.ubuntu.com/mailman/options/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe> List-Archive: <https://lists.ubuntu.com/archives/kernel-team> List-Post: <mailto:kernel-team@lists.ubuntu.com> List-Help: <mailto:kernel-team-request@lists.ubuntu.com?subject=help> List-Subscribe: <https://lists.ubuntu.com/mailman/listinfo/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe> Cc: dann.frazier@canonical.com, paulb@nvidia.com, vlad@nvidia.com, yifeid@nvidia.com, bodong@nvidia.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" <kernel-team-bounces@lists.ubuntu.com> |
Series |
Support hardware miss to tc action
|
expand
|
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 54228e684f86..83a55b00e800 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -2036,8 +2036,9 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, fnew->flags = nla_get_u32(tb[TCA_FLOWER_FLAGS]); if (!tc_flags_valid(fnew->flags)) { + kfree(fnew); err = -EINVAL; - goto errout; + goto errout_tb; } } @@ -2062,8 +2063,10 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, } spin_unlock(&tp->lock); - if (err) - goto errout; + if (err) { + kfree(fnew); + goto errout_tb; + } } fnew->handle = handle; @@ -2171,7 +2174,6 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, fl_mask_put(head, fnew->mask); errout_idr: idr_remove(&head->handle_idr, fnew->handle); -errout: __fl_put(fnew); errout_tb: kfree(tb);