Message ID | 20230524171328.397718-2-witu@nvidia.com |
---|---|
State | New |
Headers | show
Return-Path: <kernel-team-bounces@lists.ubuntu.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=YiqrDy97; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QRHpk4jZdz20PY for <incoming@patchwork.ozlabs.org>; Thu, 25 May 2023 03:14:06 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from <kernel-team-bounces@lists.ubuntu.com>) id 1q1s3h-0002KH-S1; Wed, 24 May 2023 17:13:57 +0000 Received: from mail-co1nam11on2084.outbound.protection.outlook.com ([40.107.220.84] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <witu@nvidia.com>) id 1q1s3f-0002JZ-7O for kernel-team@lists.ubuntu.com; Wed, 24 May 2023 17:13:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V5rE/0IWv6tFWjruQrUpgGHF5SRsAzh/AeOW6QHFqVEx+2Bnv22vZZXeRTaNbxj3MDAN5CHYvrpLT0CKcb7mtlCteDGqVfcyHBtsqxQ/Kcr7Pnxpvn4nmxLJSpCGV+jLBHJaaDhP7lxA8F9B7/wQIrhiTfKopRU3yXAdM3MSWT8rw387rPoDDc9+uh2OVD+xe64RwWpmDydQPnvVznJiYmnGUcC5xQd4CKwSEPIAw0c5rWVmCR/hojZ+MRLdfzs5YMGL2iwiDtBS18xMYH848nZInwC17qkcZmzvQUdvcKYETT9+gpZJzmny5OASULRF3yw89twKKmz/qHyY8QmVxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PU34QT+CFjdlQUQwZb3UgllvlUstPlwQN8sE8xXD5s=; b=BNCvsbfWWZ4dwa5JJ4iWC43tMa6r4D4SeqqBcLH1AnjV1wm9mj1QJ71aHcDm8eqLJLLtObQMCSuo1BsGDWWpJ+i0MS57iXGWMBfKIJHstI5X/Du1Xfa5TcKW7+CHVziQNLPam9GiqsNShcHOi9qygOHIIxisweqHE9j+NKUou9HC0/JCsgqzERGv62Lv+LQOIn/CD+BZKh4CYWzvmL4iWM+6RShRp66X4h/EWWhXZxMLv4OpOxN2k64S22Q2dTURNR2A9aCLNC+BOYFRZaRnpP5y8VGWnVaLJ0rayRpFyUVwJIcOEjizS+Jwu8W78+CnPjLhcokLvam85n+Cc+9orQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9PU34QT+CFjdlQUQwZb3UgllvlUstPlwQN8sE8xXD5s=; b=YiqrDy97/Z28KTubbOAf4i/LTVWH0ijqggdTn9A5893V5oK59L2usHs5QD8ANLXV5hvuARXxgnbpwixJaMYIp5qQcVZUoZq/b1BRkLjFAGXM8g8IQHMvdAou/UJlgVtJDIKDLrWh7QIFJcxQckEvMn925Ib1JiXLqHVY6KFtg151MBTmwzssojMw90iMYqdNlrt3yysxf6Yf8ztjDjpxsozIXFP3ZHHXCax/tfT/R1iutDjikMTN8Xpj2eJqIT3W0TNBhUrHqlolbOpOAKSWBh5JNWXni+uXKQ820B04hMdB7ljB5jFwGYq2Q8WNE7stmppkXwCn3y94Mm8FzHsSiw== Received: from CY5PR15CA0013.namprd15.prod.outlook.com (2603:10b6:930:14::6) by PH7PR12MB8105.namprd12.prod.outlook.com (2603:10b6:510:2b7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15; Wed, 24 May 2023 17:13:52 +0000 Received: from CY4PEPF0000C970.namprd02.prod.outlook.com (2603:10b6:930:14:cafe::a8) by CY5PR15CA0013.outlook.office365.com (2603:10b6:930:14::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Wed, 24 May 2023 17:13:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000C970.mail.protection.outlook.com (10.167.242.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.9 via Frontend Transport; Wed, 24 May 2023 17:13:51 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 24 May 2023 10:13:36 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 24 May 2023 10:13:35 -0700 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Wed, 24 May 2023 10:13:35 -0700 Received: from sw-mtx-002.mtx.labs.mlnx (sw-mtx-002.mtx.labs.mlnx [10.9.151.106]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 34OHDTCc023771; Wed, 24 May 2023 20:13:32 +0300 From: William Tu <witu@nvidia.com> To: <kernel-team@lists.ubuntu.com> Subject: [SRU][F, J:linux-bluefield][PATCH v3 1/1] net: openvswitch: fix race on port output Date: Wed, 24 May 2023 20:13:28 +0300 Message-ID: <20230524171328.397718-2-witu@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230524171328.397718-1-witu@nvidia.com> References: <20230524171328.397718-1-witu@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C970:EE_|PH7PR12MB8105:EE_ X-MS-Office365-Filtering-Correlation-Id: 452ff5a2-a2e6-490a-53ee-08db5c7a3f11 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SDHCBaETBerl5XcU/5ttwkpRgXLAjfF8XBGOo3rj+29oMwQaD3DYuxJ1HrtCuz0/2pb8LTRM6QO5YIfONfPtfUXZihEO+CbSEGw3AVOgtrzGSokHR4vn8lGo9FJtjL0SCL2wsI+242CuABkFQPrV0H1h/PPQ9FgJU8ALD2sIrT7dFa3XdbsvXO2N0fpt2ymTfY6OnZrgHTi8n7aYlcHfSx+sEGjWHECDMCNfU3htSpEHYTxrWL9g4EWAKPf8hId9NaNQR7a8D0Eb3I5JxeDh8a0W/bieCOBaOpLoa2EtyyCJEhJBgRNrksEJ13RdkSj00vVvAgCKq15wuHmVFlmhQ4700lrM1U3x8J3xtEpbG6dMDjyNHBxVHkmQ6bsGpn0fr7r8dg/kD5HxJOBCfzPCm2hwERvByPd4aU4u0kaKUmBYPi23ogD3cu9IL2dH8geVKBJwlkHmWh8+QLRbdBxj/cBI/OwKvPKrkekksWlIm5w673Zz0QtytUYXoBvZp5z/dc78HVb+J3uW0PdFmDx9TG5xmUfzl/55N3EB289K9PEdJQHgqScQ/wULidBjYrjwXre6nwTxyIvRmtuIQ9xtqFQ7s8K2XxWGNzl6hnXPxaQvxYeyreStsZVdKRdh1xQM4itG3eHWaDo1sgOAz5JtilQ2+BzBPFknr2GXoMsHG9Uxl5PzX3zn8n/B+2LXzLMnWWf1htsGKXNA/kkwJ45FSWx1j2BwfKXYPbX3Kd8X6I1nIdnIcru5FaeLjN1FPMnkAIka1Kh9QjGnSqDaXMWNNuis8qltr1WzO15rrzK2b5hyXzHymlmpY/0RAuTKIPiS X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199021)(40470700004)(46966006)(36840700001)(2906002)(54906003)(30864003)(36860700001)(47076005)(82310400005)(5660300002)(8936002)(8676002)(70206006)(6666004)(70586007)(40460700003)(41300700001)(4326008)(478600001)(316002)(6916009)(36756003)(45080400002)(40480700001)(966005)(26005)(1076003)(2616005)(86362001)(107886003)(186003)(83380400001)(7636003)(336012)(82740400003)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 17:13:51.5515 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 452ff5a2-a2e6-490a-53ee-08db5c7a3f11 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C970.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8105 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions <kernel-team.lists.ubuntu.com> List-Unsubscribe: <https://lists.ubuntu.com/mailman/options/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe> List-Archive: <https://lists.ubuntu.com/archives/kernel-team> List-Post: <mailto:kernel-team@lists.ubuntu.com> List-Help: <mailto:kernel-team-request@lists.ubuntu.com?subject=help> List-Subscribe: <https://lists.ubuntu.com/mailman/listinfo/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe> Cc: dann.frazier@canonical.com, paulb@nvidia.com, vlad@nvidia.com, bodong@nvidia.com, cmi@nvidia.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" <kernel-team-bounces@lists.ubuntu.com> |
Series |
net: openvswitch: fix race on port output
|
expand
|
diff --git a/net/core/dev.c b/net/core/dev.c index 88a5b3cc8861..97f7ace43f80 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3176,6 +3176,7 @@ static u16 skb_tx_hash(const struct net_device *dev, } if (skb_rx_queue_recorded(skb)) { + WARN_ON_ONCE(qcount == 0); hash = skb_get_rx_queue(skb); if (hash >= qoffset) hash -= qoffset; diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index aca6e2b599c8..ba0acc171418 100644 --- a/net/openvswitch/actions.c +++ b/net/openvswitch/actions.c @@ -913,7 +913,7 @@ static void do_output(struct datapath *dp, struct sk_buff *skb, int out_port, { struct vport *vport = ovs_vport_rcu(dp, out_port); - if (likely(vport)) { + if (likely(vport && netif_carrier_ok(vport->dev))) { u16 mru = OVS_CB(skb)->mru; u32 cutlen = OVS_CB(skb)->cutlen;