Message ID | 20230403215811.252026-6-witu@nvidia.com |
---|---|
State | New |
Headers | show
Return-Path: <kernel-team-bounces@lists.ubuntu.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=Q7GV1y8z; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Pr4Xm58jMz1yZg for <incoming@patchwork.ozlabs.org>; Tue, 4 Apr 2023 07:58:48 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from <kernel-team-bounces@lists.ubuntu.com>) id 1pjSCH-0004Bs-MT; Mon, 03 Apr 2023 21:58:41 +0000 Received: from mail-mw2nam10on2046.outbound.protection.outlook.com ([40.107.94.46] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <witu@nvidia.com>) id 1pjSCD-00049X-QB for kernel-team@lists.ubuntu.com; Mon, 03 Apr 2023 21:58:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jBIJuUktpQ4oJuKRG2O18j/9zInBMdzqlIout4/SgpUKVN1g/z8gKZVbpX/Yw+pRw6PDHj1Mk0ypXfPSwPblptbhCceYUlQ+rTdrZm1wQgNB2OGbTdeUWNb3ScQCmhx+qzj4sF1dCw2ePiU6R8ThLvkaLaQfFiese3m21EDEGhpxcO9qd+dvoY374pu8dfwB/F+PuftysZChPNgd17OYwd+WZFIX88T/9nrSeBkWljo5+Pr33OKJspAywi6GlMnLHS+/wpYdQoC0Ds9WCy+BFZfEAWCAimbUNFwGCp3Ab7S81TSg0xsL86Kpt+Aj6G+v0UhdPHB4IEsGgsh2TrPsNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7TqC8j1Aq4edZfYHXDKbCDrV320PH9XaXBQUAxN/JK8=; b=XWtTrhvXdf/JshUmYbCR7gKF0CP3rDm40BAm5d5O0fEEocwF12woXaLuDC0zcPZcZCKXxyF2IpyXAKLPS4iuta8vcysMBoUZlVzL3pZmYAXgoWxWT9HArilIpz/t6TiWWf8LJi7H0g+WHuP6JHV5ti+sKmAzpLd0r0F9t82ZcNyqcXjZl98FuDQq03lWYX9IjKZwY6qlXYPhC+C9kA+HXDSpm3UuxqJ8y3beIpy6QHC1nUZzv1az5cZdZsNZODKtwIuiiX5xVX8HOfLbvI5qRWPqJDDA4e/o9Ag8hIyIwopUvP2SWxz+flsdk3Gm+frWkUMRqT8vek/GAEVp0Imf4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7TqC8j1Aq4edZfYHXDKbCDrV320PH9XaXBQUAxN/JK8=; b=Q7GV1y8zmcEz/jG5d/P6d/NNZJ4lFEVe9b/dpVZsaPq332Iwgtec3bAh2T4ql/tnWqXaIf/fLSMlXs0UYJBnGvT65mjRBBwqmHdEhKklUQVtCUeqA4FsGX2XUJg2YFy8lSddXT6g/auFzN2oQWj+JVW7SNBw8OuOXBEyEdDvOXKcW9ZN/R2DXsrecYV1aYwDtgHevVbK1qD0mHsjZf7F7EZ57QEEjZzB8Y2LciesmPARZgfEWgyXfVk2D6VW/LxYVOHATrcylW+fi7cjRW7J2DlYcMbQYmlJ8rNd5JNgcWBBXuecl+msBuqAyBFBW0tMGLXZ7fCTMLpI/3nNl541aA== Received: from DM6PR07CA0132.namprd07.prod.outlook.com (2603:10b6:5:330::25) by IA1PR12MB8288.namprd12.prod.outlook.com (2603:10b6:208:3fe::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Mon, 3 Apr 2023 21:58:34 +0000 Received: from DM6NAM11FT105.eop-nam11.prod.protection.outlook.com (2603:10b6:5:330:cafe::5a) by DM6PR07CA0132.outlook.office365.com (2603:10b6:5:330::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.22 via Frontend Transport; Mon, 3 Apr 2023 21:58:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT105.mail.protection.outlook.com (10.13.173.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.14 via Frontend Transport; Mon, 3 Apr 2023 21:58:34 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 3 Apr 2023 14:58:23 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 3 Apr 2023 14:58:22 -0700 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Mon, 3 Apr 2023 14:58:22 -0700 Received: from sw-mtx-002.mtx.labs.mlnx (sw-mtx-002.mtx.labs.mlnx [10.9.151.106]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 333LwBaU018545; Tue, 4 Apr 2023 00:58:19 +0300 From: William Tu <witu@nvidia.com> To: <kernel-team@lists.ubuntu.com> Subject: [SRU][F:linux-bluefield][PATCH v2 5/5] net/sched: flower: fix fl_change() error recovery path Date: Tue, 4 Apr 2023 00:58:11 +0300 Message-ID: <20230403215811.252026-6-witu@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230403215811.252026-1-witu@nvidia.com> References: <20230403215811.252026-1-witu@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT105:EE_|IA1PR12MB8288:EE_ X-MS-Office365-Filtering-Correlation-Id: c2ebde66-82d1-4450-f379-08db348e920a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L90l1QCy1iLziWjmISY1NROza2B0UpmNoWUKkPYF0tHOJLrydCBy833GSyAb16DpJ90LAdftuMKeqk+M76VOM/jdhTNMCVIISCqOU9eQK5PAO8NKs0MsqXNXEUuPELAA4VrTI6boK+pa4cEz+Gv/dQZsZ9ZCWd7t/qdeRkYl2Rpk0o+icyUPAVJ9Wzgffdi2HlBlIwKWCcH/RbOIWLYxKUOLoV9e4bkGiVhX3gSIPuZjfnqZ5DsRDWXKnQJtblMxPUKhmzTigzgYsBQkNO6IIhLG7Oon0YuaI6HDfI6c+v7FLv6OtLd1vqOC1LfFZt5+BzcS2gQhAy5Of0EOsiWJV45BmOlfuuDFfV0q8xsPEtm36M65SCYKCEZDCUMVSwUR9LK+7Eae7mlDN3lZlvjjvJ1sLS6eTbqEVXIsWjg+ajjS7RZbBf0vvdlf3ol34lfBpDvXn0uGtHGC+7pHLx5bz7n8xucOttRgA6hquO6QhHPIDLGRsiQQHjR20VpUuOxaUZJ8PB/x8tLAvWpcsCj2WV+vkhkrtffcEmRYWylNKDbpu6uwSKcpZ5WK2eYkrasHO+oDsaiSvWeyel/0d0mBzSJ9wvhqzcNUpWYFtuFV48b1z4j3Zi40WY+7prn3NZ+0ObsdPoSp8xZ9nkdnQ3yxfNUq3/wwe2V0ClpChVPkrEWHDqZeZj83oYaqQNA62dxSI8KINeMQBlmY349b6tNQR1KPYC/5C57l9Tp6e2KgNm9pFTLfc4oq/VY9Jhdmg1rzsI41gmHVCARrRYksNc7/h3VXl3eCb4mm5abqseYjvb+RnNXPDQAIdMIV7+P9DuqW X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199021)(36840700001)(40470700004)(46966006)(47076005)(83380400001)(478600001)(2906002)(40480700001)(2616005)(186003)(36756003)(107886003)(1076003)(6666004)(336012)(40460700003)(966005)(26005)(356005)(7636003)(4326008)(8936002)(86362001)(316002)(5660300002)(41300700001)(82310400005)(82740400003)(8676002)(70586007)(70206006)(36860700001)(54906003)(34020700004)(6916009); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 21:58:34.1842 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c2ebde66-82d1-4450-f379-08db348e920a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT105.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8288 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions <kernel-team.lists.ubuntu.com> List-Unsubscribe: <https://lists.ubuntu.com/mailman/options/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe> List-Archive: <https://lists.ubuntu.com/archives/kernel-team> List-Post: <mailto:kernel-team@lists.ubuntu.com> List-Help: <mailto:kernel-team-request@lists.ubuntu.com?subject=help> List-Subscribe: <https://lists.ubuntu.com/mailman/listinfo/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe> Cc: bodong@nvidia.com, vlad@nvidia.com, paulb@nvidia.com, dann.frazier@canonical.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" <kernel-team-bounces@lists.ubuntu.com> |
Series |
Support hardware miss to tc action
|
expand
|
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 99dfc01dee9c..9605f22c1877 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -1652,8 +1652,9 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, fnew->flags = nla_get_u32(tb[TCA_FLOWER_FLAGS]); if (!tc_flags_valid(fnew->flags)) { + kfree(fnew); err = -EINVAL; - goto errout; + goto errout_tb; } } @@ -1678,8 +1679,10 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, } spin_unlock(&tp->lock); - if (err) - goto errout; + if (err) { + kfree(fnew); + goto errout_tb; + } } fnew->handle = handle; @@ -1788,7 +1791,6 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, fl_mask_put(head, fnew->mask); errout_idr: idr_remove(&head->handle_idr, fnew->handle); -errout: __fl_put(fnew); errout_tb: kfree(tb);