From patchwork Mon Feb 20 12:27:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Gherzan X-Patchwork-Id: 1745064 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=rbHgv1UM; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PL1st31hYz240n for ; Mon, 20 Feb 2023 23:28:18 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1pU5HA-0004Zt-O9; Mon, 20 Feb 2023 12:28:12 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1pU5H9-0004Z1-6g for kernel-team@lists.ubuntu.com; Mon, 20 Feb 2023 12:28:11 +0000 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id E36363F326 for ; Mon, 20 Feb 2023 12:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1676896090; bh=4DC4XzrJtuVWBJEm3te7J/slH6CaZm1M0KEMP6DTpsU=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rbHgv1UMRYYbXV5LkhKHGbyRdf/FVjv/iuB0d80J12jLExL8kUBaQh6KIEXYwBuj4 31muCof1Iy/+wSfiAiQm/+omkcyk8aI/ys36tKjU+a4/SrsRaeqLInql2JBLouJ9UI wofmbUkUwd+WmvoknF+T86EjkbisLS62DOmOKATspPmhnEq0p/V2woSsfl0jE1y0Cx IJdlmH2666gd7EfHRkh1BFcYVkiKCHhZYzt9BaE4LRvMlI2nsgj2VNLRtvEdU+mmtU +Tu8l+OSFrAydxuC/XjD58TQptdQnex/hRxvkLVHJES3C8JYWNJRRPtU+UJHHfNL02 2nPh8CtAm2YJQ== Received: by mail-wm1-f71.google.com with SMTP id o35-20020a05600c512300b003dc5cb10dcfso484166wms.9 for ; Mon, 20 Feb 2023 04:28:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4DC4XzrJtuVWBJEm3te7J/slH6CaZm1M0KEMP6DTpsU=; b=yEdFDQooxXhNyZPHsiyZvrBWFQ4bXgR+JipPBtMYu+xE2r3+y4eaMa4WiLyroCiYEC VFYPcY5gh8ZAWLVJwJIN8x2wWFMCRRmS6F1NXCAS9usmEHgzFXVU8PYethYzdDN+Pzb3 t/vr7m7Lv+lcguPkYr3n9ZCZhuPd3+X1hT9u9lxZTAJ4QIVhTekOfBcA0EhjsV/1+2TN MzBrQIpEXyttK7fEU8+SQiUT0ZagLBkLUnFSvbcXcUTF8EJEmX/eL/e1nrIjzqUyqo5L +m+hY3X1Is8qOXi/LKx8gendRs5YrD+4TVgHm8ZYU24ns4m1BrjStYITrycfyuYODzFy Y6zg== X-Gm-Message-State: AO0yUKXJ4KLz1Yg21uQxrnaA9hIJDD+Mfr6wPFJD6mQ4pjOePlfzDY85 AKwBOXGZGxYXfgxmN4WBBRQH+GxrdchXwF5Njs02DqF2JfpwbkQUeudcZSrkGNh1VNOzTJQuRgh u40ld6aS31XHjIEWpevydHO8ipfEQ65QPnypR/faJQ+tTwtI= X-Received: by 2002:a5d:522e:0:b0:2c3:db9e:4b06 with SMTP id i14-20020a5d522e000000b002c3db9e4b06mr1761173wra.45.1676896090349; Mon, 20 Feb 2023 04:28:10 -0800 (PST) X-Google-Smtp-Source: AK7set/eYwlM9s11gcrupKyryvkpJVxeII/s8lIDPFgWU3BElc20UzvZ3WdzMeh+scIujsPAYcDH9Q== X-Received: by 2002:a5d:522e:0:b0:2c3:db9e:4b06 with SMTP id i14-20020a5d522e000000b002c3db9e4b06mr1761161wra.45.1676896089996; Mon, 20 Feb 2023 04:28:09 -0800 (PST) Received: from qwirkle.internal (38-242-176-173.ofnl.uk. [38.242.176.173]) by smtp.gmail.com with ESMTPSA id c11-20020adffb0b000000b002c5503a8d21sm6070765wrr.70.2023.02.20.04.28.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 04:28:09 -0800 (PST) From: Andrei Gherzan To: kernel-team@lists.ubuntu.com Subject: [SRU][B][X][PATCH 1/1] UBUNTU: SAUCE: selftest: rtctest: Force passing unreliable subtest Date: Mon, 20 Feb 2023 12:27:22 +0000 Message-Id: <20230220122720.2851993-2-andrei.gherzan@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230220122720.2851993-1-andrei.gherzan@canonical.com> References: <20230220122720.2851993-1-andrei.gherzan@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1814234 Since 0b63accf87225b5eb7e52814c374cf02d733d4bb, the test includes a verification of time passage that is unstable as it is prone to different results based on the system load. Other investigations led to disabling this test in various other places/projects. For example, Linaro also disabled it[1]. We have chosen to keep this test but to force its result unconditionally successful as opposed to reverting the aforementioned commit because: 1. it keeps running the test with results and data that we can use in the future for any "smarter" way to deal with it - eg. statistical approach 2. it minimizes the maintenance burden of this patch kept in our kernel trees It is worth mentioning that upstream was contacted via the mailing list with no feedback[2]. The request was to increase the current tolerance set at 10%. [1] https://bugs.linaro.org/show_bug.cgi?id=3402#c9 [2] https://lore.kernel.org/lkml/a304b6f1-11db-543b-2cb3-372f34dc7697@linaro.org/ Signed-off-by: Andrei Gherzan --- tools/testing/selftests/timers/rtctest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c index 411eff625e66d..6166ff7b022ba 100644 --- a/tools/testing/selftests/timers/rtctest.c +++ b/tools/testing/selftests/timers/rtctest.c @@ -319,10 +319,11 @@ int main(int argc, char **argv) if (diff.tv_sec > 0 || diff.tv_usec > ((1000000L / tmp) * 1.10)) { fprintf(stderr, "\nPIE delta error: %ld.%06ld should be close to 0.%06ld\n", + fprintf(stderr, "\nUbuntu Testing Force Pass LP #1814234: PIE delta error: %ld.%06ld should be close to 0.%06ld\n", diff.tv_sec, diff.tv_usec, (1000000L / tmp)); fflush(stdout); - exit(-1); + break; // LP: #1814234 } fprintf(stderr, " %d",i);